165096 2016-11-28 10:31:37 -0800 Fix exception scope verification failures in runtime/Weak* files. 2016-11-28 14:40:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 162351 1 mark.lam mark.lam commit-queue fpizlo ggaren jfbastien keith_miller msaboff saam ysuzuki oldest_to_newest 1253874 0 mark.lam 2016-11-28 10:31:37 -0800 Patch coming. 1253884 1 295502 mark.lam 2016-11-28 10:46:53 -0800 Created attachment 295502 proposed patch. 1253919 2 295502 mark.lam 2016-11-28 12:21:42 -0800 Comment on attachment 295502 proposed patch. This patch has passed the JSC tests locally. It's ready for a review. 1253926 3 295502 ggaren 2016-11-28 12:28:08 -0800 Comment on attachment 295502 proposed patch. r=me 1254031 4 mark.lam 2016-11-28 14:40:02 -0800 Thanks for the review. Landed in r209023: <http://trac.webkit.org/r209023>. 295502 2016-11-28 10:46:53 -0800 2016-11-28 12:28:08 -0800 proposed patch. bug-165096.patch text/plain 4467 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5MDAwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE2LTExLTI4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggZXhjZXB0aW9uIHNjb3BlIHZlcmlmaWNhdGlvbiBmYWlsdXJlcyBpbiBydW50aW1lL1dlYWsq IGZpbGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY1MDk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBydW50aW1lL1dlYWtNYXBDb25zdHJ1Y3Rvci5jcHA6CisgICAgICAgIChKU0M6OmNvbnN0cnVj dFdlYWtNYXApOgorICAgICAgICAqIHJ1bnRpbWUvV2Vha01hcFByb3RvdHlwZS5jcHA6CisgICAg ICAgIChKU0M6OnByb3RvRnVuY1dlYWtNYXBTZXQpOgorICAgICAgICAqIHJ1bnRpbWUvV2Vha1Nl dENvbnN0cnVjdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6Y29uc3RydWN0V2Vha1NldCk6CisgICAg ICAgICogcnVudGltZS9XZWFrU2V0UHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6cHJvdG9G dW5jV2Vha1NldEFkZCk6CisKIDIwMTYtMTEtMjYgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRl YUBnbWFpbC5jb20+CiAKICAgICAgICAgW1dURl0gSW1wb3J0IHN0ZDo6b3B0aW9uYWwgcmVmZXJl bmNlIGltcGxlbWVudGF0aW9uIGFzIFdURjo6T3B0aW9uYWwKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1dlYWtNYXBDb25zdHJ1Y3Rvci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vha01hcENvbnN0cnVjdG9yLmNwcAkocmV2aXNp b24gMjA4OTk5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vha01hcENvbnN0 cnVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjUsNyArNjUsNyBAQCBzdGF0aWMgRW5jb2Rl ZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBjb25zCiAgICAgaWYgKGl0ZXJhYmxlLmlzVW5kZWZpbmVk T3JOdWxsKCkpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUod2Vha01hcCk7CiAKLSAg ICBKU1ZhbHVlIGFkZGVyRnVuY3Rpb24gPSB3ZWFrTWFwLT5KU09iamVjdDo6Z2V0KGV4ZWMsIGV4 ZWMtPnByb3BlcnR5TmFtZXMoKS5zZXQpOworICAgIEpTVmFsdWUgYWRkZXJGdW5jdGlvbiA9IHdl YWtNYXAtPkpTT2JqZWN0OjpnZXQoZXhlYywgdm0ucHJvcGVydHlOYW1lcy0+c2V0KTsKICAgICBS RVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBlbmNvZGVkSlNWYWx1ZSgpKTsKIAogICAgIENhbGxE YXRhIGFkZGVyRnVuY3Rpb25DYWxsRGF0YTsKQEAgLTczLDYgKzczLDcgQEAgc3RhdGljIEVuY29k ZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgY29ucwogICAgIGlmIChhZGRlckZ1bmN0aW9uQ2FsbFR5 cGUgPT0gQ2FsbFR5cGU6Ok5vbmUpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUodGhy b3dUeXBlRXJyb3IoZXhlYywgc2NvcGUpKTsKIAorICAgIHNjb3BlLnJlbGVhc2UoKTsKICAgICBm b3JFYWNoSW5JdGVyYWJsZShleGVjLCBpdGVyYWJsZSwgWyZdKFZNJiB2bSwgRXhlY1N0YXRlKiBl eGVjLCBKU1ZhbHVlIG5leHRJdGVtKSB7CiAgICAgICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RI Uk9XX1NDT1BFKHZtKTsKICAgICAgICAgaWYgKCFuZXh0SXRlbS5pc09iamVjdCgpKSB7CkBAIC04 OSw2ICs5MCw3IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGNvbnMKICAg ICAgICAgTWFya2VkQXJndW1lbnRCdWZmZXIgYXJndW1lbnRzOwogICAgICAgICBhcmd1bWVudHMu YXBwZW5kKGtleSk7CiAgICAgICAgIGFyZ3VtZW50cy5hcHBlbmQodmFsdWUpOworICAgICAgICBz Y29wZS5yZWxlYXNlKCk7CiAgICAgICAgIGNhbGwoZXhlYywgYWRkZXJGdW5jdGlvbiwgYWRkZXJG dW5jdGlvbkNhbGxUeXBlLCBhZGRlckZ1bmN0aW9uQ2FsbERhdGEsIHdlYWtNYXAsIGFyZ3VtZW50 cyk7CiAgICAgfSk7CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1dlYWtN YXBQcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1dlYWtNYXBQcm90b3R5cGUuY3BwCShyZXZpc2lvbiAyMDg5OTkpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9XZWFrTWFwUHJvdG90eXBlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTA1LDYgKzEwNSw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgcHJvdG9GdW5j V2UKICAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19TQ09QRSh2bSk7CiAKICAgICBXZWFr TWFwRGF0YSogbWFwID0gZ2V0V2Vha01hcERhdGEoY2FsbEZyYW1lLCBjYWxsRnJhbWUtPnRoaXNW YWx1ZSgpKTsKKyAgICBBU1NFUlQoISFzY29wZS5leGNlcHRpb24oKSA9PSAhbWFwKTsKICAgICBp ZiAoIW1hcCkKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsK ICAgICBKU1ZhbHVlIGtleSA9IGNhbGxGcmFtZS0+YXJndW1lbnQoMCk7CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9XZWFrU2V0Q29uc3RydWN0b3IuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1dlYWtTZXRDb25zdHJ1Y3Rvci5jcHAJ KHJldmlzaW9uIDIwODk5OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1dlYWtT ZXRDb25zdHJ1Y3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1LDcgKzY1LDcgQEAgc3RhdGlj IEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgY29ucwogICAgIGlmIChpdGVyYWJsZS5pc1Vu ZGVmaW5lZE9yTnVsbCgpKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHdlYWtTZXQp OwogCi0gICAgSlNWYWx1ZSBhZGRlckZ1bmN0aW9uID0gd2Vha1NldC0+SlNPYmplY3Q6OmdldChl eGVjLCBleGVjLT5wcm9wZXJ0eU5hbWVzKCkuYWRkKTsKKyAgICBKU1ZhbHVlIGFkZGVyRnVuY3Rp b24gPSB3ZWFrU2V0LT5KU09iamVjdDo6Z2V0KGV4ZWMsIHZtLnByb3BlcnR5TmFtZXMtPmFkZCk7 CiAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7CiAKICAg ICBDYWxsRGF0YSBhZGRlckZ1bmN0aW9uQ2FsbERhdGE7CkBAIC03Myw2ICs3Myw3IEBAIHN0YXRp YyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGNvbnMKICAgICBpZiAoYWRkZXJGdW5jdGlv bkNhbGxUeXBlID09IENhbGxUeXBlOjpOb25lKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5j b2RlKHRocm93VHlwZUVycm9yKGV4ZWMsIHNjb3BlKSk7CiAKKyAgICBzY29wZS5yZWxlYXNlKCk7 CiAgICAgZm9yRWFjaEluSXRlcmFibGUoZXhlYywgaXRlcmFibGUsIFsmXShWTSYsIEV4ZWNTdGF0 ZSogZXhlYywgSlNWYWx1ZSBuZXh0VmFsdWUpIHsKICAgICAgICAgTWFya2VkQXJndW1lbnRCdWZm ZXIgYXJndW1lbnRzOwogICAgICAgICBhcmd1bWVudHMuYXBwZW5kKG5leHRWYWx1ZSk7CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9XZWFrU2V0UHJvdG90eXBlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9XZWFrU2V0UHJvdG90eXBl LmNwcAkocmV2aXNpb24gMjA4OTk5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv V2Vha1NldFByb3RvdHlwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkyLDYgKzkyLDcgQEAgRW5j b2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBwcm90b0Z1bmNXZQogICAgIGF1dG8gc2NvcGUgPSBE RUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKIAogICAgIFdlYWtNYXBEYXRhKiBtYXAgPSBnZXRXZWFr TWFwRGF0YShjYWxsRnJhbWUsIGNhbGxGcmFtZS0+dGhpc1ZhbHVlKCkpOworICAgIEFTU0VSVCgh IXNjb3BlLmV4Y2VwdGlvbigpID09ICFtYXApOwogICAgIGlmICghbWFwKQogICAgICAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOwogICAgIEpTVmFsdWUga2V5ID0gY2Fs bEZyYW1lLT5hcmd1bWVudCgwKTsK