165070 2016-11-25 02:52:13 -0800 Fix build warnings in WebCore/Modules/indexeddb/server/IDBSerialization.cp 2016-11-30 02:59:57 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy alecflett beidson cgarcia commit-queue jsbell oldest_to_newest 1253638 0 ossy 2016-11-25 02:52:13 -0800 ../../Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp:99:22: warning: unused variable 'LegacySerializedKeyVersion' [-Wunused-const-variable] static const uint8_t LegacySerializedKeyVersion = 'b'; ^ ../../Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp:137:22: warning: unused variable 'SIDBKeyVersion' [-Wunused-const-variable] static const uint8_t SIDBKeyVersion = 0x00; ^ ../../Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp:219:13: warning: function 'encodeKey' is not needed and will not be emitted [-Wunneeded-internal-declaration] static void encodeKey(Vector<char>& data, const IDBKeyData& key) ^ ../../Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp:284:13: warning: function 'decodeKey' is not needed and will not be emitted [-Wunneeded-internal-declaration] static bool decodeKey(const uint8_t*& data, const uint8_t* end, IDBKeyData& result) ^ 4 warnings generated. All of these are used only if USE(CF) is true, let's guard them. 1253639 1 295421 ossy 2016-11-25 02:53:13 -0800 Created attachment 295421 Patch 1253647 2 295422 ossy 2016-11-25 07:38:31 -0800 Created attachment 295422 Patch 1253651 3 295424 ossy 2016-11-25 08:01:36 -0800 Created attachment 295424 Patch 1253730 4 295424 beidson 2016-11-26 20:16:17 -0800 Comment on attachment 295424 Patch Any chance I could convince a Linux/GLib type person to dig up the magic first character for a GLib-encoded key? Then we could have Linux actually use the new serialization and only have to have one of these guards! 1253734 5 295424 commit-queue 2016-11-26 20:41:14 -0800 Comment on attachment 295424 Patch Clearing flags on attachment: 295424 Committed r208984: <http://trac.webkit.org/changeset/208984> 1253735 6 commit-queue 2016-11-26 20:41:19 -0800 All reviewed patches have been landed. Closing bug. 1253739 7 ossy 2016-11-26 23:23:52 -0800 (In reply to comment #4) > Comment on attachment 295424 [details] > Patch > > Any chance I could convince a Linux/GLib type person to dig up the magic > first character for a GLib-encoded key? Then we could have Linux actually > use the new serialization and only have to have one of these guards! Maybe Carlos? 1253746 8 cgarcia 2016-11-27 01:38:22 -0800 (In reply to comment #7) > (In reply to comment #4) > > Comment on attachment 295424 [details] > > Patch > > > > Any chance I could convince a Linux/GLib type person to dig up the magic > > first character for a GLib-encoded key? Then we could have Linux actually > > use the new serialization and only have to have one of these guards! > > Maybe Carlos? Sure, I didn't know anything about this, I'll look at it. 1253795 9 beidson 2016-11-27 16:43:01 -0800 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #4) > > > Comment on attachment 295424 [details] > > > Patch > > > > > > Any chance I could convince a Linux/GLib type person to dig up the magic > > > first character for a GLib-encoded key? Then we could have Linux actually > > > use the new serialization and only have to have one of these guards! > > > > Maybe Carlos? > > Sure, I didn't know anything about this, I'll look at it. The CFPropertyList serialization literally always starts with the first character 'b' I'm hoping the Glib serialization literally always starts with some other magic character. (Or, even if it happened to be 'b', that'd be fine) Once we confirm it does, then Glib can adopt the new serialization right now, no more questions asked! 1253818 10 cgarcia 2016-11-28 00:40:26 -0800 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > (In reply to comment #4) > > > > Comment on attachment 295424 [details] > > > > Patch > > > > > > > > Any chance I could convince a Linux/GLib type person to dig up the magic > > > > first character for a GLib-encoded key? Then we could have Linux actually > > > > use the new serialization and only have to have one of these guards! > > > > > > Maybe Carlos? > > > > Sure, I didn't know anything about this, I'll look at it. > > The CFPropertyList serialization literally always starts with the first > character 'b' > I'm hoping the Glib serialization literally always starts with some other > magic character. (Or, even if it happened to be 'b', that'd be fine) > > Once we confirm it does, then Glib can adopt the new serialization right > now, no more questions asked! No, we use GVariant that doesn't add any magic character, but I guess the point is detecting if given data was encoded using the KeyedEncoder right? In that case we could at least check if the data is a GVariant dictionary and assume that it was encoded by KeyedEncoder in such case. The new serialization doesn't need any platform specific code, right? 1254631 11 beidson 2016-11-29 18:41:55 -0800 (In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > (In reply to comment #7) > > > > (In reply to comment #4) > > > > > Comment on attachment 295424 [details] > > > > > Patch > > > > > > > > > > Any chance I could convince a Linux/GLib type person to dig up the magic > > > > > first character for a GLib-encoded key? Then we could have Linux actually > > > > > use the new serialization and only have to have one of these guards! > > > > > > > > Maybe Carlos? > > > > > > Sure, I didn't know anything about this, I'll look at it. > > > > The CFPropertyList serialization literally always starts with the first > > character 'b' > > I'm hoping the Glib serialization literally always starts with some other > > magic character. (Or, even if it happened to be 'b', that'd be fine) > > > > Once we confirm it does, then Glib can adopt the new serialization right > > now, no more questions asked! > > No, we use GVariant that doesn't add any magic character, but I guess the > point is detecting if given data was encoded using the KeyedEncoder right? Right, which in the GLib case is GVariant, and I guess that doesn't have easy detection...? > In that case we could at least check if the data is a GVariant dictionary > and assume that it was encoded by KeyedEncoder in such case. That's the hard part - How to detect if it's a GVariant dictionary *efficiently* > The new serialization doesn't need any platform specific code, right? That's right, it's cross platform. 1254731 12 cgarcia 2016-11-30 02:59:57 -0800 (In reply to comment #11) > (In reply to comment #10) > > (In reply to comment #9) > > > (In reply to comment #8) > > > > (In reply to comment #7) > > > > > (In reply to comment #4) > > > > > > Comment on attachment 295424 [details] > > > > > > Patch > > > > > > > > > > > > Any chance I could convince a Linux/GLib type person to dig up the magic > > > > > > first character for a GLib-encoded key? Then we could have Linux actually > > > > > > use the new serialization and only have to have one of these guards! > > > > > > > > > > Maybe Carlos? > > > > > > > > Sure, I didn't know anything about this, I'll look at it. > > > > > > The CFPropertyList serialization literally always starts with the first > > > character 'b' > > > I'm hoping the Glib serialization literally always starts with some other > > > magic character. (Or, even if it happened to be 'b', that'd be fine) > > > > > > Once we confirm it does, then Glib can adopt the new serialization right > > > now, no more questions asked! > > > > No, we use GVariant that doesn't add any magic character, but I guess the > > point is detecting if given data was encoded using the KeyedEncoder right? > > Right, which in the GLib case is GVariant, and I guess that doesn't have > easy detection...? > > > In that case we could at least check if the data is a GVariant dictionary > > and assume that it was encoded by KeyedEncoder in such case. > > That's the hard part - How to detect if it's a GVariant dictionary > *efficiently* > > > The new serialization doesn't need any platform specific code, right? > > That's right, it's cross platform. Ok, understood, thanks! I've attached a patch to bug #165191, it's not as efficient as checking data[0], but hopefully good enough. 295421 2016-11-25 02:53:13 -0800 2016-11-25 07:38:26 -0800 Patch bug-165070-20161125115255.patch text/plain 2788 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4OTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA3ZTc5MDk5ZWIzMTI0 OWZkY2ZmODcwOGU5YTY5ZmI2OWY4ODVjZC4uYWNjNGViNDA1ZDYyN2E3ZTUyMDg5YjY2OTZlMTIw MTk5MDQ4N2MzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTExLTI1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGJ1aWxkIHdh cm5pbmdzIGluIFdlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL0lEQlNlcmlhbGl6YXRp b24uY3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 NTA3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog TW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL0lEQlNlcmlhbGl6YXRpb24uY3BwOgorCiAyMDE2LTEx LTI0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUg dW51c2VkIGJvb2wgcmV0dXJuIGZyb20gRWxlbWVudDo6d2lsbFJlY2FsY1N0eWxlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvSURCU2VyaWFsaXph dGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvSURCU2Vy aWFsaXphdGlvbi5jcHAKaW5kZXggMWEzMTBiOTNiYjhlODBhNGUyNzczMTAzMWNmNDg3YzBmYmRh YmU5NS4uNWIzNmYyNDYwOGE4NTA1ZjI4ZDEzNTc5YmJlNTMxMTc4NGM0MDlkMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL0lEQlNlcmlhbGl6YXRp b24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9JREJT ZXJpYWxpemF0aW9uLmNwcApAQCAtOTYsNyArOTYsOSBAQCBib29sIGRlc2VyaWFsaXplSURCS2V5 UGF0aChjb25zdCB1aW50OF90KiBkYXRhLCBzaXplX3Qgc2l6ZSwgT3B0aW9uYWw8SURCS2V5UGF0 aAogCiAvLyBUaGlzIGlzIHRoZSBtYWdpYyBjaGFyYWN0ZXIgdGhhdCBiZWdpbnMgc2VyaWFsaXpl ZCBQcm9wZXJ0eUxpc3RzLCBhbmQgdGVsbHMgdXMgd2hldGhlcgogLy8gdGhlIGtleSB3ZSdyZSBs b29raW5nIGF0IGlzIGFuIG9sZC1zdHlsZSBrZXkuCisjaWYgVVNFKENGKQogc3RhdGljIGNvbnN0 IHVpbnQ4X3QgTGVnYWN5U2VyaWFsaXplZEtleVZlcnNpb24gPSAnYic7CisjZW5kaWYKIAogLy8g RklYTUU6IExpbnV4IHBvcnRzIHVzZXMgS2V5ZWRFbmNvZGVyR2xpYiBmb3IgdGhlaXIgSURCS2V5 cy4KIC8vIFdoZW4gYSBHbGliIG1haW50YWluZXIgY29tZXMgYWxvbmcgdG8gZW5hYmxlIHRoZSBu ZXcgc2VyaWFsaXphdGlvbiB0aGV5J2xsIG5lZWQgdG8KQEAgLTEzNCw3ICsxMzYsOSBAQCBNYXg6 CiAKIC8vIEZJWE1FOiBJZiB0aGUgR0xpYiBtYWdpYyBjaGFyYWN0ZXIgZW5kcyB1cCBiZWluZyAw eDAwLCB3ZSBzaG91bGQgY29uc2lkZXIgY2hhbmdpbmcKIC8vIHRoaXMgMHgwMCBzbyB3ZSBjYW4g c3VwcG9ydCBHbGliIGtleWVkIGVuY29kaW5nLCBhbHNvLgorI2lmIFVTRShDRikKIHN0YXRpYyBj b25zdCB1aW50OF90IFNJREJLZXlWZXJzaW9uID0gMHgwMDsKKyNlbmRpZgogZW51bSBjbGFzcyBT SURCS2V5VHlwZSA6IHVpbnQ4X3QgewogICAgIE1pbiA9IDB4MDAsCiAgICAgTnVtYmVyID0gMHgy MCwKQEAgLTIxNiw2ICsyMjAsNyBAQCBzdGF0aWMgYm9vbCByZWFkRG91YmxlKGNvbnN0IHVpbnQ4 X3QqJiBkYXRhLCBjb25zdCB1aW50OF90KiBlbmQsIGRvdWJsZSYgZCkKICAgICByZXR1cm4gcmVh ZExpdHRsZUVuZGlhbihkYXRhLCBlbmQsICpyZWludGVycHJldF9jYXN0PHVpbnQ2NF90Kj4oJmQp KTsKIH0KIAorI2lmIFVTRShDRikKIHN0YXRpYyB2b2lkIGVuY29kZUtleShWZWN0b3I8Y2hhcj4m IGRhdGEsIGNvbnN0IElEQktleURhdGEmIGtleSkKIHsKICAgICBTSURCS2V5VHlwZSB0eXBlID0g c2VyaWFsaXplZFR5cGVGb3JLZXlUeXBlKGtleS50eXBlKCkpOwpAQCAtMjY0LDYgKzI2OSw3IEBA IHN0YXRpYyB2b2lkIGVuY29kZUtleShWZWN0b3I8Y2hhcj4mIGRhdGEsIGNvbnN0IElEQktleURh dGEmIGtleSkKICAgICAgICAgYnJlYWs7CiAgICAgfQogfQorI2VuZGlmCiAKIFJlZlB0cjxTaGFy ZWRCdWZmZXI+IHNlcmlhbGl6ZUlEQktleURhdGEoY29uc3QgSURCS2V5RGF0YSYga2V5KQogewpA QCAtMjgxLDYgKzI4Nyw3IEBAIFJlZlB0cjxTaGFyZWRCdWZmZXI+IHNlcmlhbGl6ZUlEQktleURh dGEoY29uc3QgSURCS2V5RGF0YSYga2V5KQogCiB9CiAKKyNpZiBVU0UoQ0YpCiBzdGF0aWMgYm9v bCBkZWNvZGVLZXkoY29uc3QgdWludDhfdComIGRhdGEsIGNvbnN0IHVpbnQ4X3QqIGVuZCwgSURC S2V5RGF0YSYgcmVzdWx0KQogewogICAgIGlmICghZGF0YSB8fCBkYXRhID49IGVuZCkKQEAgLTM4 MSw2ICszODgsNyBAQCBzdGF0aWMgYm9vbCBkZWNvZGVLZXkoY29uc3QgdWludDhfdComIGRhdGEs IGNvbnN0IHVpbnQ4X3QqIGVuZCwgSURCS2V5RGF0YSYgcmVzdQogICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgfQogfQorI2VuZGlmCiAKIGJvb2wgZGVzZXJpYWxpemVJREJLZXlEYXRhKGNvbnN0 IHVpbnQ4X3QqIGRhdGEsIHNpemVfdCBzaXplLCBJREJLZXlEYXRhJiByZXN1bHQpCiB7Cg== 295422 2016-11-25 07:38:31 -0800 2016-11-25 08:01:31 -0800 Patch bug-165070-20161125163812.patch text/plain 2721 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4OTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmJkZjlkNDk1YjEzODU3 OGRkZTllZWQ5ZjI5NzMyY2M0ZDFlYTNmZS4uNDBjN2RkMzUwYTYwMDZiM2Q5YThmNjg0MmExNzU1 NGNmYTUzN2UxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTExLTI1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGJ1aWxkIHdh cm5pbmdzIGluIFdlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL0lEQlNlcmlhbGl6YXRp b24uY3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 NTA3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog TW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL0lEQlNlcmlhbGl6YXRpb24uY3BwOgorCiAyMDE2LTEx LTIzICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtjc3MtZ3JpZF0gQ29udmVydCBncmlkIHJlcHJlc2VudGF0aW9uIGludG8gYSBjbGFzcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL0lEQlNlcmlh bGl6YXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL0lE QlNlcmlhbGl6YXRpb24uY3BwCmluZGV4IDFhMzEwYjkzYmI4ZTgwYTRlMjc3MzEwMzFjZjQ4N2Mw ZmJkYWJlOTUuLjVkZjIzMzYwZmQ3OGY1N2Y4YjgzOTYwNDliYzA3ZGE5NmQzMThmYWQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9JREJTZXJpYWxp emF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIv SURCU2VyaWFsaXphdGlvbi5jcHAKQEAgLTk2LDcgKzk2LDkgQEAgYm9vbCBkZXNlcmlhbGl6ZUlE QktleVBhdGgoY29uc3QgdWludDhfdCogZGF0YSwgc2l6ZV90IHNpemUsIE9wdGlvbmFsPElEQktl eVBhdGgKIAogLy8gVGhpcyBpcyB0aGUgbWFnaWMgY2hhcmFjdGVyIHRoYXQgYmVnaW5zIHNlcmlh bGl6ZWQgUHJvcGVydHlMaXN0cywgYW5kIHRlbGxzIHVzIHdoZXRoZXIKIC8vIHRoZSBrZXkgd2Un cmUgbG9va2luZyBhdCBpcyBhbiBvbGQtc3R5bGUga2V5LgorI2lmIFVTRShDRikKIHN0YXRpYyBj b25zdCB1aW50OF90IExlZ2FjeVNlcmlhbGl6ZWRLZXlWZXJzaW9uID0gJ2InOworI2VuZGlmCiAK IC8vIEZJWE1FOiBMaW51eCBwb3J0cyB1c2VzIEtleWVkRW5jb2RlckdsaWIgZm9yIHRoZWlyIElE QktleXMuCiAvLyBXaGVuIGEgR2xpYiBtYWludGFpbmVyIGNvbWVzIGFsb25nIHRvIGVuYWJsZSB0 aGUgbmV3IHNlcmlhbGl6YXRpb24gdGhleSdsbCBuZWVkIHRvCkBAIC0xMzQsNyArMTM2LDkgQEAg TWF4OgogCiAvLyBGSVhNRTogSWYgdGhlIEdMaWIgbWFnaWMgY2hhcmFjdGVyIGVuZHMgdXAgYmVp bmcgMHgwMCwgd2Ugc2hvdWxkIGNvbnNpZGVyIGNoYW5naW5nCiAvLyB0aGlzIDB4MDAgc28gd2Ug Y2FuIHN1cHBvcnQgR2xpYiBrZXllZCBlbmNvZGluZywgYWxzby4KKyNpZiBVU0UoQ0YpCiBzdGF0 aWMgY29uc3QgdWludDhfdCBTSURCS2V5VmVyc2lvbiA9IDB4MDA7CisjZW5kaWYKIGVudW0gY2xh c3MgU0lEQktleVR5cGUgOiB1aW50OF90IHsKICAgICBNaW4gPSAweDAwLAogICAgIE51bWJlciA9 IDB4MjAsCkBAIC0yMDYsNiArMjEwLDcgQEAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IHN0YXRpYyBi b29sIHJlYWRMaXR0bGVFbmRpYW4oY29uc3QgdWludDhfdComIHB0ciwgY29uc3QgdWkKIH0KICNl bmRpZgogCisjaWYgVVNFKENGKQogc3RhdGljIHZvaWQgd3JpdGVEb3VibGUoVmVjdG9yPGNoYXI+ JiBkYXRhLCBkb3VibGUgZCkKIHsKICAgICB3cml0ZUxpdHRsZUVuZGlhbihkYXRhLCAqcmVpbnRl cnByZXRfY2FzdDx1aW50NjRfdCo+KCZkKSk7CkBAIC0yNjQsNiArMjY5LDcgQEAgc3RhdGljIHZv aWQgZW5jb2RlS2V5KFZlY3RvcjxjaGFyPiYgZGF0YSwgY29uc3QgSURCS2V5RGF0YSYga2V5KQog ICAgICAgICBicmVhazsKICAgICB9CiB9CisjZW5kaWYKIAogUmVmUHRyPFNoYXJlZEJ1ZmZlcj4g c2VyaWFsaXplSURCS2V5RGF0YShjb25zdCBJREJLZXlEYXRhJiBrZXkpCiB7CkBAIC0yODEsNiAr Mjg3LDcgQEAgUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gc2VyaWFsaXplSURCS2V5RGF0YShjb25zdCBJ REJLZXlEYXRhJiBrZXkpCiAKIH0KIAorI2lmIFVTRShDRikKIHN0YXRpYyBib29sIGRlY29kZUtl eShjb25zdCB1aW50OF90KiYgZGF0YSwgY29uc3QgdWludDhfdCogZW5kLCBJREJLZXlEYXRhJiBy ZXN1bHQpCiB7CiAgICAgaWYgKCFkYXRhIHx8IGRhdGEgPj0gZW5kKQpAQCAtMzgxLDYgKzM4OCw3 IEBAIHN0YXRpYyBib29sIGRlY29kZUtleShjb25zdCB1aW50OF90KiYgZGF0YSwgY29uc3QgdWlu dDhfdCogZW5kLCBJREJLZXlEYXRhJiByZXN1CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9 CiB9CisjZW5kaWYKIAogYm9vbCBkZXNlcmlhbGl6ZUlEQktleURhdGEoY29uc3QgdWludDhfdCog ZGF0YSwgc2l6ZV90IHNpemUsIElEQktleURhdGEmIHJlc3VsdCkKIHsK 295424 2016-11-25 08:01:36 -0800 2016-11-26 20:41:14 -0800 Patch bug-165070-20161125170117.patch text/plain 2988 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4OTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmJkZjlkNDk1YjEzODU3 OGRkZTllZWQ5ZjI5NzMyY2M0ZDFlYTNmZS4uNDBjN2RkMzUwYTYwMDZiM2Q5YThmNjg0MmExNzU1 NGNmYTUzN2UxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTExLTI1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGJ1aWxkIHdh cm5pbmdzIGluIFdlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL0lEQlNlcmlhbGl6YXRp b24uY3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 NTA3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog TW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL0lEQlNlcmlhbGl6YXRpb24uY3BwOgorCiAyMDE2LTEx LTIzICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtjc3MtZ3JpZF0gQ29udmVydCBncmlkIHJlcHJlc2VudGF0aW9uIGludG8gYSBjbGFzcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL0lEQlNlcmlh bGl6YXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL0lE QlNlcmlhbGl6YXRpb24uY3BwCmluZGV4IDFhMzEwYjkzYmI4ZTgwYTRlMjc3MzEwMzFjZjQ4N2Mw ZmJkYWJlOTUuLjdkMGUwNjliZjJlYmEwYzBlOGJiMjQwYWE1ZjA5NTIyMzllNjM3N2QgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9JREJTZXJpYWxp emF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIv SURCU2VyaWFsaXphdGlvbi5jcHAKQEAgLTk2LDcgKzk2LDkgQEAgYm9vbCBkZXNlcmlhbGl6ZUlE QktleVBhdGgoY29uc3QgdWludDhfdCogZGF0YSwgc2l6ZV90IHNpemUsIE9wdGlvbmFsPElEQktl eVBhdGgKIAogLy8gVGhpcyBpcyB0aGUgbWFnaWMgY2hhcmFjdGVyIHRoYXQgYmVnaW5zIHNlcmlh bGl6ZWQgUHJvcGVydHlMaXN0cywgYW5kIHRlbGxzIHVzIHdoZXRoZXIKIC8vIHRoZSBrZXkgd2Un cmUgbG9va2luZyBhdCBpcyBhbiBvbGQtc3R5bGUga2V5LgorI2lmIFVTRShDRikKIHN0YXRpYyBj b25zdCB1aW50OF90IExlZ2FjeVNlcmlhbGl6ZWRLZXlWZXJzaW9uID0gJ2InOworI2VuZGlmCiAK IC8vIEZJWE1FOiBMaW51eCBwb3J0cyB1c2VzIEtleWVkRW5jb2RlckdsaWIgZm9yIHRoZWlyIElE QktleXMuCiAvLyBXaGVuIGEgR2xpYiBtYWludGFpbmVyIGNvbWVzIGFsb25nIHRvIGVuYWJsZSB0 aGUgbmV3IHNlcmlhbGl6YXRpb24gdGhleSdsbCBuZWVkIHRvCkBAIC0xMzQsNiArMTM2LDcgQEAg TWF4OgogCiAvLyBGSVhNRTogSWYgdGhlIEdMaWIgbWFnaWMgY2hhcmFjdGVyIGVuZHMgdXAgYmVp bmcgMHgwMCwgd2Ugc2hvdWxkIGNvbnNpZGVyIGNoYW5naW5nCiAvLyB0aGlzIDB4MDAgc28gd2Ug Y2FuIHN1cHBvcnQgR2xpYiBrZXllZCBlbmNvZGluZywgYWxzby4KKyNpZiBVU0UoQ0YpCiBzdGF0 aWMgY29uc3QgdWludDhfdCBTSURCS2V5VmVyc2lvbiA9IDB4MDA7CiBlbnVtIGNsYXNzIFNJREJL ZXlUeXBlIDogdWludDhfdCB7CiAgICAgTWluID0gMHgwMCwKQEAgLTE2OCw2ICsxNzEsNyBAQCBz dGF0aWMgU0lEQktleVR5cGUgc2VyaWFsaXplZFR5cGVGb3JLZXlUeXBlKEluZGV4ZWREQjo6S2V5 VHlwZSB0eXBlKQogCiAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKIH0KKyNlbmRp ZgogCiAjaWYgQ1BVKEJJR19FTkRJQU4pIHx8IENQVShNSURETEVfRU5ESUFOKSB8fCBDUFUoTkVF RFNfQUxJR05FRF9BQ0NFU1MpCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gc3RhdGljIHZvaWQgd3Jp dGVMaXR0bGVFbmRpYW4oVmVjdG9yPGNoYXI+JiBidWZmZXIsIFQgdmFsdWUpCkBAIC0yMDYsNiAr MjEwLDcgQEAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IHN0YXRpYyBib29sIHJlYWRMaXR0bGVFbmRp YW4oY29uc3QgdWludDhfdComIHB0ciwgY29uc3QgdWkKIH0KICNlbmRpZgogCisjaWYgVVNFKENG KQogc3RhdGljIHZvaWQgd3JpdGVEb3VibGUoVmVjdG9yPGNoYXI+JiBkYXRhLCBkb3VibGUgZCkK IHsKICAgICB3cml0ZUxpdHRsZUVuZGlhbihkYXRhLCAqcmVpbnRlcnByZXRfY2FzdDx1aW50NjRf dCo+KCZkKSk7CkBAIC0yNjQsNiArMjY5LDcgQEAgc3RhdGljIHZvaWQgZW5jb2RlS2V5KFZlY3Rv cjxjaGFyPiYgZGF0YSwgY29uc3QgSURCS2V5RGF0YSYga2V5KQogICAgICAgICBicmVhazsKICAg ICB9CiB9CisjZW5kaWYKIAogUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gc2VyaWFsaXplSURCS2V5RGF0 YShjb25zdCBJREJLZXlEYXRhJiBrZXkpCiB7CkBAIC0yODEsNiArMjg3LDcgQEAgUmVmUHRyPFNo YXJlZEJ1ZmZlcj4gc2VyaWFsaXplSURCS2V5RGF0YShjb25zdCBJREJLZXlEYXRhJiBrZXkpCiAK IH0KIAorI2lmIFVTRShDRikKIHN0YXRpYyBib29sIGRlY29kZUtleShjb25zdCB1aW50OF90KiYg ZGF0YSwgY29uc3QgdWludDhfdCogZW5kLCBJREJLZXlEYXRhJiByZXN1bHQpCiB7CiAgICAgaWYg KCFkYXRhIHx8IGRhdGEgPj0gZW5kKQpAQCAtMzgxLDYgKzM4OCw3IEBAIHN0YXRpYyBib29sIGRl Y29kZUtleShjb25zdCB1aW50OF90KiYgZGF0YSwgY29uc3QgdWludDhfdCogZW5kLCBJREJLZXlE YXRhJiByZXN1CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiB9CisjZW5kaWYKIAogYm9v bCBkZXNlcmlhbGl6ZUlEQktleURhdGEoY29uc3QgdWludDhfdCogZGF0YSwgc2l6ZV90IHNpemUs IElEQktleURhdGEmIHJlc3VsdCkKIHsK