165060 2016-11-24 05:42:32 -0800 Fix various --minimal build issues 2016-11-27 10:17:11 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy commit-queue oldest_to_newest 1253569 0 ossy 2016-11-24 05:42:32 -0800 1.) isCustomIdentValue() is only used inside ENABLE(CSS_GRID_LAYOUT) guard, but defined unconditionally in Source/WebCore/css/parser/CSSPropertyParser.cpp, which caused build error if !ENABLE(CSS_GRID_LAYOUT) - unused but defined function. 2.) SecurityOriginData struct is used in Source/WebCore/loader/EmptyClients.cpp and Source/WebCore/dom/Document.cpp too, but SecurityOriginData.h isn't directly included. The normal full build works, because this header is included indirectly somewhere. 1253571 1 295405 ossy 2016-11-24 05:43:34 -0800 Created attachment 295405 Patch 1253759 2 295405 commit-queue 2016-11-27 10:17:08 -0800 Comment on attachment 295405 Patch Clearing flags on attachment: 295405 Committed r208991: <http://trac.webkit.org/changeset/208991> 1253760 3 commit-queue 2016-11-27 10:17:11 -0800 All reviewed patches have been landed. Closing bug. 295405 2016-11-24 05:43:34 -0800 2016-11-27 10:17:08 -0800 Patch bug-165060-20161124144317.patch text/plain 2793 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4OTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDA3ZTc5MDk5ZWIzMTI0 OWZkY2ZmODcwOGU5YTY5ZmI2OWY4ODVjZC4uNjFiYzAzYmMyMjA4YzVlYmVlM2M5YzZiMjQ0NjNk NTUxMGRkYmIyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTExLTI0ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHZhcmlvdXMg LS1taW5pbWFsIGJ1aWxkIGlzc3VlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY1MDYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBjc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcDoKKyAgICAg ICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAqIGxvYWRlci9FbXB0eUNsaWVudHMuY3Bw OgorCiAyMDE2LTExLTI0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZW1vdmUgdW51c2VkIGJvb2wgcmV0dXJuIGZyb20gRWxlbWVudDo6d2lsbFJlY2FsY1N0 eWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFy c2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXIuY3Bw CmluZGV4IDhkODU2ODJiMjVjMWI2NDBhMWE2NGI1N2ZjZjhkYjQyMWRmMzczNWQuLmMwMzAxNDUx MjZmNDFlYjI5ZDMzNGVjMmM5YjQ1MDZmZTQxYWVjNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXIuY3BwCkBAIC00NzEwLDYgKzQ3MTAsNyBAQCBi b29sIENTU1Byb3BlcnR5UGFyc2VyOjpjb25zdW1lQmFja2dyb3VuZFNob3J0aGFuZChjb25zdCBT dHlsZVByb3BlcnR5U2hvcnRoYW5kJgogICAgIHJldHVybiB0cnVlOwogfQogCisjaWYgRU5BQkxF KENTU19HUklEX0xBWU9VVCkKIC8vIEZJWE1FLU5FV1BBUlNFUjogSGFjayB0byB3b3JrIGFyb3Vu ZCB0aGUgZmFjdCB0aGF0IHdlIGFyZW4ndCB1c2luZyBDU1NDdXN0b21JZGVudFZhbHVlCiAvLyBm b3Igc3R1ZmYgeWV0LiBUaGlzIGNhbiBiZSByZXBsYWNlZCBieSBDU1NWYWx1ZTo6aXNDdXN0b21J ZGVudFZhbHVlKCkgb25jZSB3ZSBzd2l0Y2gKIC8vIHRvIHVzaW5nIENTU0N1c3RvbUlkZW50VmFs dWUgZXZlcnl3aGVyZS4KQEAgLTQ3MTgsNyArNDcxOSw2IEBAIHN0YXRpYyBib29sIGlzQ3VzdG9t SWRlbnRWYWx1ZShjb25zdCBDU1NWYWx1ZSYgdmFsdWUpCiAgICAgcmV0dXJuIGlzPENTU1ByaW1p dGl2ZVZhbHVlPih2YWx1ZSkgJiYgZG93bmNhc3Q8Q1NTUHJpbWl0aXZlVmFsdWU+KHZhbHVlKS5p c1N0cmluZygpOwogfQogCi0jaWYgRU5BQkxFKENTU19HUklEX0xBWU9VVCkKIGJvb2wgQ1NTUHJv cGVydHlQYXJzZXI6OmNvbnN1bWVHcmlkSXRlbVBvc2l0aW9uU2hvcnRoYW5kKENTU1Byb3BlcnR5 SUQgc2hvcnRoYW5kSWQsIGJvb2wgaW1wb3J0YW50KQogewogICAgIGNvbnN0IFN0eWxlUHJvcGVy dHlTaG9ydGhhbmQmIHNob3J0aGFuZCA9IHNob3J0aGFuZEZvclByb3BlcnR5KHNob3J0aGFuZElk KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IGM2MThhOWRkNmZjYWNiOTdmZTMwYmJjZjIx OThmOGFmOWUyNzQ0ODQuLjNkYWFlM2RmNjFmOGU2MDc4ZjI4MTg4Yzg4NTA5M2EzYzQ4NjRlMDkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtMTU1LDYgKzE1NSw3IEBACiAjaW5jbHVkZSAi U2NyaXB0U291cmNlQ29kZS5oIgogI2luY2x1ZGUgIlNjcm9sbGluZ0Nvb3JkaW5hdG9yLmgiCiAj aW5jbHVkZSAiU2VjdXJpdHlPcmlnaW4uaCIKKyNpbmNsdWRlICJTZWN1cml0eU9yaWdpbkRhdGEu aCIKICNpbmNsdWRlICJTZWN1cml0eU9yaWdpblBvbGljeS5oIgogI2luY2x1ZGUgIlNlY3VyaXR5 UG9saWN5LmgiCiAjaW5jbHVkZSAiU2VnbWVudGVkU3RyaW5nLmgiCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9FbXB0eUNsaWVudHMuY3BwCmluZGV4IDM1NmE4MDU5NmIwYjAwY2IzNTY1MTlhYjA4Mjk4YTFj NDM1M2QxY2UuLjhkMDhjZmI1ZTg4MmRkNDMyZWI4NmIyYjc0MmI0YzMxYjA1OWY2ZjIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9FbXB0eUNsaWVudHMuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9FbXB0eUNsaWVudHMuY3BwCkBAIC00NCw2ICs0NCw3IEBACiAjaW5j bHVkZSAiUGFnZUNvbmZpZ3VyYXRpb24uaCIKICNpbmNsdWRlICJQYXltZW50Q29vcmRpbmF0b3JD bGllbnQuaCIKICNpbmNsdWRlICJQbHVnaW5JbmZvUHJvdmlkZXIuaCIKKyNpbmNsdWRlICJTZWN1 cml0eU9yaWdpbkRhdGEuaCIKICNpbmNsdWRlICJTdG9yYWdlQXJlYS5oIgogI2luY2x1ZGUgIlN0 b3JhZ2VOYW1lc3BhY2UuaCIKICNpbmNsdWRlICJTdG9yYWdlTmFtZXNwYWNlUHJvdmlkZXIuaCIK