16503 2007-12-18 10:54:28 -0800 match limit takes at least 13% of the time on the SunSpider regexp-dna test 2010-06-11 17:36:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P3 Enhancement --- 1 darin webkit-unassigned ap darin eric ggaren mjs zwarich oldest_to_newest 64650 0 darin 2007-12-18 10:54:28 -0800 The match limit inside the regular expression execution engine slows down the regexp-dna test by about 13%. If we can find some more efficient way of preventing complex regular expressions from causing a hang, then we could get a substantial speed-up. See bug 16458 for some history. 81832 1 21408 ap 2008-05-29 08:02:00 -0700 Created attachment 21408 2.3% improvement Removing the check altogether is a 9.5% win on my machine. I guess this micro-optimization is unnecessary if someone has a real fix in mind, but I thought it was worth posting anyway. 81850 2 21408 darin 2008-05-29 09:33:37 -0700 Comment on attachment 21408 2.3% improvement r=me I'm not sure anyone has a handle on a "real fix". 82715 3 zwarich 2008-06-08 22:36:51 -0700 Alexey, are you going to land this? 82734 4 ap 2008-06-09 04:28:33 -0700 I'm trying to land this periodically, but random code generation changes elsewhere cause it to be a regression overall now. One of these days, I'll get lucky and have it landed. 82826 5 21408 ap 2008-06-10 07:56:39 -0700 Comment on attachment 21408 2.3% improvement Landed in r34480, clearing review flag. Today, the win on regexp-dna was only 0.6%, but the total win was huge (0.5%), apparently due to random code generation changes. 237182 6 ap 2010-06-11 17:36:13 -0700 Something was landed here, so marking fixed. The rest of the bug is likely long obsolete. 21408 2008-05-29 08:02:00 -0700 2010-06-10 15:41:07 -0700 2.3% improvement MatchLimit.txt text/plain 1528 ap SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM0MTk0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMDUtMjkgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjUwMworICAgICAgICBtYXRjaCBsaW1pdCB0YWtlcyBhdCBsZWFzdCAxMyUgb2YgdGhl IHRpbWUgb24gdGhlIFN1blNwaWRlciByZWdleHAtZG5hIHRlc3QKKworICAgICAgICBNYWtlIHRo ZSB0ZXN0IHNsaWdodGx5IG1vcmUgZWZmaWNpZW50LCBmb3IgMi4zJSB3aW4gb24gcmVnZXhwLWRu YS4KKworICAgICAgICAqIHBjcmUvcGNyZV9leGVjLmNwcDogKG1hdGNoKTogQXZvaWQgbG9hZGlu ZyBhIGNvbnN0YW50IG9uIGVhY2ggaXRlcmF0aW9uLgorCiAyMDA4LTA1LTI4ICBPbGl2ZXIgSHVu dCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzLgpJbmRl eDogSmF2YVNjcmlwdENvcmUvcGNyZS9wY3JlX2V4ZWMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFT Y3JpcHRDb3JlL3BjcmUvcGNyZV9leGVjLmNwcAkocmV2aXNpb24gMzQxOTQpCisrKyBKYXZhU2Ny aXB0Q29yZS9wY3JlL3BjcmVfZXhlYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxMCw3ICs0MTAs NyBAQCBzdGF0aWMgaW50IG1hdGNoKGNvbnN0IFVDaGFyKiBzdWJqZWN0UHRyCiAgICAgYm9vbCBp c01hdGNoID0gZmFsc2U7CiAgICAgaW50IG1pbjsKICAgICBib29sIG1pbmltaXplID0gZmFsc2U7 IC8qIEluaXRpYWxpemF0aW9uIG5vdCByZWFsbHkgbmVlZGVkLCBidXQgc29tZSBjb21waWxlcnMg dGhpbmsgc28uICovCi0gICAgdW5zaWduZWQgbWF0Y2hDb3VudCA9IDA7CisgICAgdW5zaWduZWQg cmVtYWluaW5nTWF0Y2hDb3VudCA9IG1hdGNoTGltaXQ7CiAgICAgCiAgICAgTWF0Y2hTdGFjayBz dGFjazsKIApAQCAtNDQzLDcgKzQ0Myw3IEBAIHN0YXRpYyBpbnQgbWF0Y2goY29uc3QgVUNoYXIq IHN1YmplY3RQdHIKICAgICAvKiBUaGlzIGlzIHdoZXJlIGNvbnRyb2wganVtcHMgYmFjayB0byB0 byBlZmZlY3QgInJlY3Vyc2lvbiIgKi8KICAgICAKIFJFQ1VSU0U6Ci0gICAgaWYgKCsrbWF0Y2hD b3VudCA+IG1hdGNoTGltaXQpCisgICAgaWYgKCEtLXJlbWFpbmluZ01hdGNoQ291bnQpCiAgICAg ICAgIHJldHVybiBtYXRjaEVycm9yKEpTUmVnRXhwRXJyb3JIaXRMaW1pdCwgc3RhY2spOwogCiAg ICAgLyogTm93IHN0YXJ0IHByb2Nlc3NpbmcgdGhlIG9wZXJhdGlvbnMuICovCg==