165008 2016-11-21 07:30:24 -0800 [CMake] build fails after update to cmake 3.7 2023-02-19 16:22:47 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand clopez achristensen bugs-noreply clopez commit-queue dbates fujii gyuyoung.kim joepeck mcatanzaro mitz tpopela oldest_to_newest 1253232 0 pnormand 2016-11-21 07:30:24 -0800 CMake Error at Source/cmake/WebKitMacros.cmake:297 (add_library): The install of the JavaScriptCore target requires changing an RPATH from the build tree, but this is not supported with the Ninja generator unless on an ELF-based platform. The CMAKE_BUILD_WITH_INSTALL_RPATH variable may be set to avoid this relinking step. Call Stack (most recent call first): Source/JavaScriptCore/CMakeLists.txt:1474 (WEBKIT_FRAMEWORK) 1253233 1 pnormand 2016-11-21 07:40:49 -0800 This is on an amd64 machine btw. 1253235 2 clopez 2016-11-21 08:23:27 -0800 I guess it still work if you use Make instead of Ninja (by passing -G "Unix Makefiles" to CMake) This seems to be the CMake commit causing this: https://gitlab.kitware.com/cmake/cmake/commit/72dfca30b94ba1e85533c61a7b5a330dfbc04da5 1253253 3 clopez 2016-11-21 09:31:09 -0800 Asked CMake developers about this at https://gitlab.kitware.com/cmake/cmake/issues/13934 1253281 4 295309 clopez 2016-11-21 11:58:54 -0800 Created attachment 295309 Patch 1253284 5 pnormand 2016-11-21 12:23:46 -0800 Thanks Carlos! 1253285 6 295309 commit-queue 2016-11-21 12:32:52 -0800 Comment on attachment 295309 Patch Clearing flags on attachment: 295309 Committed r208951: <http://trac.webkit.org/changeset/208951> 1253286 7 commit-queue 2016-11-21 12:32:57 -0800 All reviewed patches have been landed. Closing bug. 1935003 8 fujii 2023-02-19 16:22:47 -0800 This change introduced bug#252548. And, CMake 3.8 fixed the problem. https://gitlab.kitware.com/cmake/cmake/-/issues/13934#note_200624 https://gitlab.kitware.com/cmake/cmake/-/commit/25b6e7b710d7739cca44ed19bf45a190e72a6b82 I'm going to revert this change in bug#252548. 295309 2016-11-21 11:58:54 -0800 2016-11-21 12:32:52 -0800 Patch bug-165008-20161121205842.patch text/plain 1742 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4OTUwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmNkY2Q4MDI2ODRjNGYzNTllNzc5ZTFmODc3M2ExOGQ1 MmM3NDdmZS4uNGY4ZjU5YzYxNTYwOTViMzg2NDllZTY4YmU2MDMzMWZmMjhhMjQ2YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE2LTExLTIxICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtDTWFrZV0gYnVpbGQgZmFpbHMgYWZ0ZXIgdXBkYXRlIHRvIGNt YWtlIDMuNworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY1MDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2hlbiB3ZSByZW1vdmUgdGhlIENNYWtlIGNhY2hlLCB3ZSBzaG91bGQgcmVtb3ZlIGJvdGggdGhl CisgICAgICAgIENNYWtlQ2FjaGUudHh0IGZpbGUgYW5kIHRoZSBDTWFrZUZpbGVzIGRpcmVjdG9y eS4KKyAgICAgICAgU2VlOiBodHRwczovL2dpdGxhYi5raXR3YXJlLmNvbS9jbWFrZS9jbWFrZS9p c3N1ZXMvMTQ4MjAKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAg KGNtYWtlRmlsZXNQYXRoKToKKyAgICAgICAgKHJlbW92ZUNNYWtlQ2FjaGUpOgorCiAyMDE2LTEx LTE2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBb R1RLXVtXZWJSVENdIFN3aXRjaCB0byBkb3duc3RyZWFtIE9wZW5XZWJSVEMgYW5kIG1vcmUgcmVj ZW50IEdTdHJlYW1lcgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDIzNGNmYjY4OGFjMTRhZGFkMjNkMGZl N2RiNmNjN2MyNjdiMjdiMTcuLjRkYzk5MWEzYjAzNjQzY2ZhZDY5NTY3MjdiMThhNTMxMDJiZDg0 YjEgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE4MzEsNiArMTgzMSwxMSBAQCBzdWIgY21ha2VDYWNo ZVBhdGgoKQogICAgIHJldHVybiBGaWxlOjpTcGVjLT5jYXRkaXIoYmFzZVByb2R1Y3REaXIoKSwg Y29uZmlndXJhdGlvbigpLCAiQ01ha2VDYWNoZS50eHQiKTsKIH0KIAorc3ViIGNtYWtlRmlsZXNQ YXRoKCkKK3sKKyAgICByZXR1cm4gRmlsZTo6U3BlYy0+Y2F0ZGlyKGJhc2VQcm9kdWN0RGlyKCks IGNvbmZpZ3VyYXRpb24oKSwgIkNNYWtlRmlsZXMiKTsKK30KKwogc3ViIHNob3VsZFJlbW92ZUNN YWtlQ2FjaGUoQCkKIHsKICAgICBteSAoJGNhY2hlRmlsZVBhdGgsIEBidWlsZEFyZ3MpID0gQF87 CkBAIC0xODg0LDcgKzE4ODksOSBAQCBzdWIgcmVtb3ZlQ01ha2VDYWNoZShAKQogICAgIG15IChA YnVpbGRBcmdzKSA9IEBfOwogICAgIGlmIChzaG91bGRSZW1vdmVDTWFrZUNhY2hlKEBidWlsZEFy Z3MpKSB7CiAgICAgICAgIG15ICRjbWFrZUNhY2hlID0gY21ha2VDYWNoZVBhdGgoKTsKKyAgICAg ICAgbXkgJGNtYWtlRmlsZXMgPSBjbWFrZUZpbGVzUGF0aCgpOwogICAgICAgICB1bmxpbmsoJGNt YWtlQ2FjaGUpIGlmIC1lICRjbWFrZUNhY2hlOworICAgICAgICBybXRyZWUoJGNtYWtlRmlsZXMp IGlmIC1kICRjbWFrZUZpbGVzOwogICAgIH0KIH0KIAo=