<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>165006</bug_id>
          
          <creation_ts>2016-11-21 03:08:50 -0800</creation_ts>
          <short_desc>[css-grid] Isolate size of internal representation from actual grid size</short_desc>
          <delta_ts>2016-11-22 06:35:17 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>165007</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Sergio Villar Senin">svillar</reporter>
          <assigned_to name="Sergio Villar Senin">svillar</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>glenn</cc>
    
    <cc>jfernandez</cc>
    
    <cc>kling</cc>
    
    <cc>koivisto</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>rego</cc>
    
    <cc>svillar</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1253211</commentid>
    <comment_count>0</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2016-11-21 03:08:50 -0800</bug_when>
    <thetext>[css-grid] Isolate size of internal representation from actual grid size</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253214</commentid>
    <comment_count>1</comment_count>
      <attachid>295289</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2016-11-21 03:13:58 -0800</bug_when>
    <thetext>Created attachment 295289
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253221</commentid>
    <comment_count>2</comment_count>
      <attachid>295289</attachid>
    <who name="Javier Fernandez">jfernandez</who>
    <bug_when>2016-11-21 03:31:30 -0800</bug_when>
    <thetext>Comment on attachment 295289
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295289&amp;action=review

In the ChangeLog it&apos;s explained very well the problem, but not so clear, IMO, why this patch solves the issue. I&apos;d add some lines to show that we have now 2 different functions to get the size of the grid, one using the pysical representation and the other one, using the logical one.

Other than that, the change looks good.

&gt; Source/WebCore/ChangeLog:13
&gt; +        memory allocations are done to create a grid representation it as it is not needed.

typo: &quot;representation *it as it*&quot; -&gt; &quot;representation *as it*</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253363</commentid>
    <comment_count>3</comment_count>
      <attachid>295333</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2016-11-22 02:29:02 -0800</bug_when>
    <thetext>Created attachment 295333
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253365</commentid>
    <comment_count>4</comment_count>
      <attachid>295333</attachid>
    <who name="Javier Fernandez">jfernandez</who>
    <bug_when>2016-11-22 02:47:47 -0800</bug_when>
    <thetext>Comment on attachment 295333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295333&amp;action=review

&gt; Source/WebCore/rendering/RenderGrid.cpp:2713
&gt; +unsigned RenderGrid::numTracks(GridTrackSizingDirection direction) const

As we talked privately, what do you think about figuring out a more descriptive name for this function and the one we already have, gridColumnCount ? The difference between them is not obvious at all.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253367</commentid>
    <comment_count>5</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2016-11-22 03:13:43 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; Comment on attachment 295333 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=295333&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/rendering/RenderGrid.cpp:2713
&gt; &gt; +unsigned RenderGrid::numTracks(GridTrackSizingDirection direction) const
&gt; 
&gt; As we talked privately, what do you think about figuring out a more
&gt; descriptive name for this function and the one we already have,
&gt; gridColumnCount ? The difference between them is not obvious at all.

Right, I agree the names are not very good, but I&apos;d prefer to change them later after finishing the refactoring if you don&apos;t feel strongly about it (I have a lot of dependent patches in my queue, so this kind of changes will force me to do a lot of conflict resolution).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253373</commentid>
    <comment_count>6</comment_count>
    <who name="Javier Fernandez">jfernandez</who>
    <bug_when>2016-11-22 04:16:09 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; Comment on attachment 295333 [details]
&gt; &gt; Patch
&gt; &gt; 
&gt; &gt; View in context:
&gt; &gt; https://bugs.webkit.org/attachment.cgi?id=295333&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/WebCore/rendering/RenderGrid.cpp:2713
&gt; &gt; &gt; +unsigned RenderGrid::numTracks(GridTrackSizingDirection direction) const
&gt; &gt; 
&gt; &gt; As we talked privately, what do you think about figuring out a more
&gt; &gt; descriptive name for this function and the one we already have,
&gt; &gt; gridColumnCount ? The difference between them is not obvious at all.
&gt; 
&gt; Right, I agree the names are not very good, but I&apos;d prefer to change them
&gt; later after finishing the refactoring if you don&apos;t feel strongly about it (I
&gt; have a lot of dependent patches in my queue, so this kind of changes will
&gt; force me to do a lot of conflict resolution).

Sure, no problem with waiting until the refactoring is completed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253374</commentid>
    <comment_count>7</comment_count>
      <attachid>295333</attachid>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2016-11-22 04:20:45 -0800</bug_when>
    <thetext>Comment on attachment 295333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295333&amp;action=review

LGTM.

&gt; Source/WebCore/rendering/RenderGrid.h:195
&gt;      unsigned gridColumnCount() const;
&gt;      unsigned gridRowCount() const;
&gt; +    unsigned numTracks(GridTrackSizingDirection) const;

I&apos;d add a FIXME on these 3 methods to look for better names once the refactoring is done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253380</commentid>
    <comment_count>8</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2016-11-22 06:35:17 -0800</bug_when>
    <thetext>Committed r208962: &lt;http://trac.webkit.org/changeset/208962&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>295289</attachid>
            <date>2016-11-21 03:13:58 -0800</date>
            <delta_ts>2016-11-22 02:28:54 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-165006-20161121121159.patch</filename>
            <type>text/plain</type>
            <size>7412</size>
            <attacher name="Sergio Villar Senin">svillar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTI0NDg5MWY2YWM3NmQ1
ZTgxZTY2OWI4ZGM4ZDRjMGU3MTgyNDM4My4uZjUzYzViNWQ1MGI2MGQzMTQzMDg5OTQwYzdhMjBl
NTQzYzIzNjU5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDE2LTExLTIxICBTZXJn
aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp
ZF0gSXNvbGF0ZSBzaXplIG9mIGludGVybmFsIHJlcHJlc2VudGF0aW9uIGZyb20gYWN0dWFsIGdy
aWQgc2l6ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTY1MDA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
UmVuZGVyR3JpZCBoYXMgYW4gaW50ZXJuYWwgcmVwcmVzZW50YXRpb24gb2YgYSBncmlkIHVzZWQg
dG8gcGxhY2UgZ3JpZCBpdGVtcywgY29tcHV0ZSBncmlkCisgICAgICAgIHBvc2l0aW9ucywgcnVu
IHRoZSB0cmFjayBzaXppbmcgYWxnb3JpdGhtIGV0Yy4gVGhhdCBkYXRhIHN0cnVjdHVyZSBub3Jt
YWxseSBoYXMgZXhhY3RseSB0aGUKKyAgICAgICAgc2FtZSBzaXplIGFzIHRoZSBhY3R1YWwgZ3Jp
ZCBzcGVjaWZpZWQgdXNpbmcgdGhlIGdyaWQtdGVtcGxhdGUteHh4IHByb3BlcnRpZXMgKG9yIGFu
eSBvdGhlcgorICAgICAgICBzaG9ydGhhbmQpLiBCdXQgaW4gc29tZSBjYXNlcywgbGlrZSBmb3Ig
ZXhhbXBsZSB3aGVuIHRoZSBncmlkIGlzIGVtcHR5LCB0aGUgaW50ZXJuYWwgZGF0YQorICAgICAg
ICBzdHJ1Y3R1cmUgZG9lcyBub3QgcmVhbGx5IG1hdGNoIHRoZSBhY3R1YWwgZ3JpZC4gSW4gdGhl
IHBhcnRpY3VsYXIgY2FzZSBvZiBlbXB0eSBncmlkcyBubworICAgICAgICBtZW1vcnkgYWxsb2Nh
dGlvbnMgYXJlIGRvbmUgdG8gY3JlYXRlIGEgZ3JpZCByZXByZXNlbnRhdGlvbiBpdCBhcyBpdCBp
cyBub3QgbmVlZGVkLgorCisgICAgICAgIFRoaXMgaXMgdGhlIGZpcnN0IHJlcXVpcmVkIHN0ZXAg
b2YgdGhlIHByb2Nlc3Mgb2YgaXNvbGF0aW5nIHRoZSBkYXRhIHVzZWQgYnkgdGhlIGdyaWQgdHJh
Y2sKKyAgICAgICAgc2l6aW5nIGFsZ29yaXRobSBmcm9tIHRoZSBhY3R1YWwgaW50ZXJuYWwgc3Rh
dGUgb2YgdGhlIExheW91dEdyaWQgb2JqZWN0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0
aGlzIGlzIGp1c3QgYSBjb2RlIHJlZmFjdG9yaW5nLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl
bmRlckdyaWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyR3JpZDo6Z3JpZENvbHVtbkNv
dW50KTogQWx3YXlzIHJldHVybiB0aGUgbnVtYmVyIG9mIGNvbHVtbnMgb2YgdGhlIGludGVybmFs
CisgICAgICAgIGRhdGEgc3RydWN0dXJlIHRvIHJlcHJlc2VudCB0aGUgZ3JpZC4KKyAgICAgICAg
KFdlYkNvcmU6OlJlbmRlckdyaWQ6OmxheW91dEJsb2NrKToKKyAgICAgICAgKFdlYkNvcmU6OlJl
bmRlckdyaWQ6OmNvbXB1dGVJbnRyaW5zaWNMb2dpY2FsV2lkdGhzKTogVXNlIHRoZSBhY3R1YWwg
c2l6ZSBvZiB0aGUgZ3JpZCB0bworICAgICAgICBjcmVhdGUgdGhlIEdyaWRTaXppbmdEYXRhIHN0
cnVjdHVyZS4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckdyaWQ6OnBsYWNlSXRlbXNPbkdyaWQp
OiBVc2UgdGhlIGFjdHVhbCBzaXplIG9mIHRoZSBncmlkIHRvIGNyZWF0ZSB0aGUKKyAgICAgICAg
R3JpZFNpemluZ0RhdGEgc3RydWN0dXJlLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyR3JpZDo6
b2Zmc2V0QW5kQnJlYWR0aEZvclBvc2l0aW9uZWRDaGlsZCk6CisgICAgICAgIChXZWJDb3JlOjpS
ZW5kZXJHcmlkOjpudW1UcmFja3MpOiBOZXcgbWV0aG9kIHdoaWNoIHJldHVybnMgdGhlIGFjdHVh
bCBzaXplIG9mIHRoZSBncmlkLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJHcmlkLmg6CisK
IDIwMTYtMTEtMDggIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAK
ICAgICAgICAgW2Nzcy1ncmlkXSBGaXggZnIgdHJhY2tzIHNpemluZyB1bmRlciBtaW58bWF4LXNp
emUgY29uc3RyYWludHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k
ZXJHcmlkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAppbmRl
eCBiZDBmZGM4YjY5MGI5YmY1YmJiYTEzOTZhZDRkZjUzNDEwZjVjYjlmLi5hN2MxZGQ5YWYzOTk4
MzY1YWZhMjE5YzdkMTQ1MjczNTFiZGY2NGEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y
ZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl
bmRlckdyaWQuY3BwCkBAIC0zODcsMTIgKzM4Nyw3IEBAIHZvaWQgUmVuZGVyR3JpZDo6c3R5bGVE
aWRDaGFuZ2UoU3R5bGVEaWZmZXJlbmNlIGRpZmYsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHls
CiB1bnNpZ25lZCBSZW5kZXJHcmlkOjpncmlkQ29sdW1uQ291bnQoKSBjb25zdAogewogICAgIEFT
U0VSVCghbV9ncmlkSXNEaXJ0eSk7Ci0gICAgLy8gRHVlIHRvIGxpbWl0YXRpb25zIGluIG91ciBp
bnRlcm5hbCByZXByZXNlbnRhdGlvbiwgd2UgY2Fubm90IGtub3cgdGhlIG51bWJlciBvZiBjb2x1
bW5zIGZyb20KLSAgICAvLyBtX2dyaWQgKmlmKiB0aGVyZSBpcyBubyByb3cgKGJlY2F1c2UgbV9n
cmlkIHdvdWxkIGJlIGVtcHR5KS4gVGhhdCdzIHdoeSBpbiB0aGF0IGNhc2Ugd2UgbmVlZAotICAg
IC8vIHRvIGdldCBpdCBmcm9tIHRoZSBzdHlsZS4gTm90ZSB0aGF0IHdlIGtub3cgZm9yIHN1cmUg
dGhhdCB0aGVyZSBhcmUndCBhbnkgaW1wbGljaXQgdHJhY2tzLAotICAgIC8vIGJlY2F1c2Ugbm90
IGhhdmluZyByb3dzIGltcGxpZXMgdGhhdCB0aGVyZSBhcmUgbm8gIm5vcm1hbCIgY2hpbGRyZW4g
KG91dC1vZi1mbG93IGNoaWxkcmVuIGFyZQotICAgIC8vIG5vdCBzdG9yZWQgaW4gbV9ncmlkKS4K
LSAgICByZXR1cm4gbV9ncmlkLnNpemUoKSA/IG1fZ3JpZFswXS5zaXplKCkgOiBHcmlkUG9zaXRp
b25zUmVzb2x2ZXI6OmV4cGxpY2l0R3JpZENvbHVtbkNvdW50KHN0eWxlKCksIG1fYXV0b1JlcGVh
dENvbHVtbnMpOworICAgIHJldHVybiBtX2dyaWQuc2l6ZSgpID8gbV9ncmlkWzBdLnNpemUoKSA6
IDA7CiB9CiAKIHVuc2lnbmVkIFJlbmRlckdyaWQ6OmdyaWRSb3dDb3VudCgpIGNvbnN0CkBAIC00
NzgsNyArNDczLDcgQEAgdm9pZCBSZW5kZXJHcmlkOjpsYXlvdXRCbG9jayhib29sIHJlbGF5b3V0
Q2hpbGRyZW4sIExheW91dFVuaXQpCiAKICAgICBwbGFjZUl0ZW1zT25HcmlkKFRyYWNrU2l6aW5n
KTsKIAotICAgIEdyaWRTaXppbmdEYXRhIHNpemluZ0RhdGEoZ3JpZENvbHVtbkNvdW50KCksIGdy
aWRSb3dDb3VudCgpKTsKKyAgICBHcmlkU2l6aW5nRGF0YSBzaXppbmdEYXRhKG51bVRyYWNrcyhG
b3JDb2x1bW5zKSwgbnVtVHJhY2tzKEZvclJvd3MpKTsKIAogICAgIC8vIEF0IHRoaXMgcG9pbnQg
dGhlIGxvZ2ljYWwgd2lkdGggaXMgYWx3YXlzIGRlZmluaXRlIGFzIHRoZSBhYm92ZSBjYWxsIHRv
IHVwZGF0ZUxvZ2ljYWxXaWR0aCgpCiAgICAgLy8gcHJvcGVybHkgcmVzb2x2ZXMgaW50cmluc2lj
IHNpemVzLiBXZSBjYW5ub3QgZG8gdGhlIHNhbWUgZm9yIGhlaWdodHMgdGhvdWdoIGJlY2F1c2Ug
bWFueSBjb2RlCkBAIC02MjgsNyArNjIzLDcgQEAgdm9pZCBSZW5kZXJHcmlkOjpjb21wdXRlSW50
cmluc2ljTG9naWNhbFdpZHRocyhMYXlvdXRVbml0JiBtaW5Mb2dpY2FsV2lkdGgsIExheW8KICAg
ICBpZiAoIXdhc1BvcHVsYXRlZCkKICAgICAgICAgY29uc3RfY2FzdDxSZW5kZXJHcmlkKj4odGhp
cyktPnBsYWNlSXRlbXNPbkdyaWQoSW50cmluc2ljU2l6ZUNvbXB1dGF0aW9uKTsKIAotICAgIEdy
aWRTaXppbmdEYXRhIHNpemluZ0RhdGEoZ3JpZENvbHVtbkNvdW50KCksIGdyaWRSb3dDb3VudCgp
KTsKKyAgICBHcmlkU2l6aW5nRGF0YSBzaXppbmdEYXRhKG51bVRyYWNrcyhGb3JDb2x1bW5zKSwg
bnVtVHJhY2tzKEZvclJvd3MpKTsKICAgICBzaXppbmdEYXRhLnNldEF2YWlsYWJsZVNwYWNlKE51
bGxvcHQpOwogICAgIHNpemluZ0RhdGEuc2V0RnJlZVNwYWNlKEZvckNvbHVtbnMsIE51bGxvcHQp
OwogICAgIHNpemluZ0RhdGEuc2l6aW5nT3BlcmF0aW9uID0gSW50cmluc2ljU2l6ZUNvbXB1dGF0
aW9uOwpAQCAtMTY3Nyw4ICsxNjcyLDEyIEBAIHZvaWQgUmVuZGVyR3JpZDo6cGxhY2VJdGVtc09u
R3JpZChTaXppbmdPcGVyYXRpb24gc2l6aW5nT3BlcmF0aW9uKQogICAgICAgICBpbnNlcnRJdGVt
SW50b0dyaWQoKmNoaWxkLCBHcmlkQXJlYShhcmVhLnJvd3MsIGFyZWEuY29sdW1ucykpOwogICAg
IH0KIAotICAgIEFTU0VSVChncmlkUm93Q291bnQoKSA+PSBHcmlkUG9zaXRpb25zUmVzb2x2ZXI6
OmV4cGxpY2l0R3JpZFJvd0NvdW50KHN0eWxlKCksIG1fYXV0b1JlcGVhdFJvd3MpKTsKLSAgICBB
U1NFUlQoZ3JpZENvbHVtbkNvdW50KCkgPj0gR3JpZFBvc2l0aW9uc1Jlc29sdmVyOjpleHBsaWNp
dEdyaWRDb2x1bW5Db3VudChzdHlsZSgpLCBtX2F1dG9SZXBlYXRDb2x1bW5zKSk7CisjaWYgRU5B
QkxFKEFTU0VSVCkKKyAgICBpZiAoIW1fZ3JpZEl0ZW1BcmVhLmlzRW1wdHkoKSkgeworICAgICAg
ICBBU1NFUlQoZ3JpZFJvd0NvdW50KCkgPj0gR3JpZFBvc2l0aW9uc1Jlc29sdmVyOjpleHBsaWNp
dEdyaWRSb3dDb3VudChzdHlsZSgpLCBtX2F1dG9SZXBlYXRSb3dzKSk7CisgICAgICAgIEFTU0VS
VChncmlkQ29sdW1uQ291bnQoKSA+PSBHcmlkUG9zaXRpb25zUmVzb2x2ZXI6OmV4cGxpY2l0R3Jp
ZENvbHVtbkNvdW50KHN0eWxlKCksIG1fYXV0b1JlcGVhdENvbHVtbnMpKTsKKyAgICB9CisjZW5k
aWYKIAogICAgIHBsYWNlU3BlY2lmaWVkTWFqb3JBeGlzSXRlbXNPbkdyaWQoc3BlY2lmaWVkTWFq
b3JBeGlzQXV0b0dyaWRJdGVtcyk7CiAgICAgcGxhY2VBdXRvTWFqb3JBeGlzSXRlbXNPbkdyaWQo
YXV0b01ham9yQXhpc0F1dG9HcmlkSXRlbXMpOwpAQCAtMjA0Nyw3ICsyMDQ2LDcgQEAgdm9pZCBS
ZW5kZXJHcmlkOjpvZmZzZXRBbmRCcmVhZHRoRm9yUG9zaXRpb25lZENoaWxkKGNvbnN0IFJlbmRl
ckJveCYgY2hpbGQsIEdyaWQKIAogICAgIEdyaWRQb3NpdGlvbiBzdGFydFBvc2l0aW9uID0gaXNS
b3dBeGlzID8gY2hpbGQuc3R5bGUoKS5ncmlkSXRlbUNvbHVtblN0YXJ0KCkgOiBjaGlsZC5zdHls
ZSgpLmdyaWRJdGVtUm93U3RhcnQoKTsKICAgICBHcmlkUG9zaXRpb24gZW5kUG9zaXRpb24gPSBp
c1Jvd0F4aXMgPyBjaGlsZC5zdHlsZSgpLmdyaWRJdGVtQ29sdW1uRW5kKCkgOiBjaGlsZC5zdHls
ZSgpLmdyaWRJdGVtUm93RW5kKCk7Ci0gICAgaW50IGxhc3RMaW5lID0gaXNSb3dBeGlzID8gZ3Jp
ZENvbHVtbkNvdW50KCkgOiBncmlkUm93Q291bnQoKTsKKyAgICBpbnQgbGFzdExpbmUgPSBudW1U
cmFja3MoZGlyZWN0aW9uKTsKIAogICAgIGJvb2wgc3RhcnRJc0F1dG8gPSBzdGFydFBvc2l0aW9u
LmlzQXV0bygpCiAgICAgICAgIHx8IChzdGFydFBvc2l0aW9uLmlzTmFtZWRHcmlkQXJlYSgpICYm
ICFOYW1lZExpbmVDb2xsZWN0aW9uOjppc1ZhbGlkTmFtZWRMaW5lT3JBcmVhKHN0YXJ0UG9zaXRp
b24ubmFtZWRHcmlkTGluZSgpLCBzdHlsZSgpLCAoZGlyZWN0aW9uID09IEZvckNvbHVtbnMpID8g
Q29sdW1uU3RhcnRTaWRlIDogUm93U3RhcnRTaWRlKSkKQEAgLTI3MDEsNiArMjcwMCwxOSBAQCBM
YXlvdXRQb2ludCBSZW5kZXJHcmlkOjpmaW5kQ2hpbGRMb2dpY2FsUG9zaXRpb24oY29uc3QgUmVu
ZGVyQm94JiBjaGlsZCkgY29uc3QKICAgICByZXR1cm4gaXNPcnRob2dvbmFsQ2hpbGQoY2hpbGQp
ID8gY2hpbGRMb2NhdGlvbi50cmFuc3Bvc2VkUG9pbnQoKSA6IGNoaWxkTG9jYXRpb247CiB9CiAK
K3Vuc2lnbmVkIFJlbmRlckdyaWQ6Om51bVRyYWNrcyhHcmlkVHJhY2tTaXppbmdEaXJlY3Rpb24g
ZGlyZWN0aW9uKSBjb25zdAoreworICAgIC8vIER1ZSB0byBsaW1pdGF0aW9ucyBpbiBvdXIgaW50
ZXJuYWwgcmVwcmVzZW50YXRpb24sIHdlIGNhbm5vdCBrbm93IHRoZSBudW1iZXIgb2YgY29sdW1u
cyBmcm9tCisgICAgLy8gbV9ncmlkICppZiogdGhlcmUgaXMgbm8gcm93IChiZWNhdXNlIG1fZ3Jp
ZCB3b3VsZCBiZSBlbXB0eSkuIFRoYXQncyB3aHkgaW4gdGhhdCBjYXNlIHdlIG5lZWQKKyAgICAv
LyB0byBnZXQgaXQgZnJvbSB0aGUgc3R5bGUuIE5vdGUgdGhhdCB3ZSBrbm93IGZvciBzdXJlIHRo
YXQgdGhlcmUgYXJlJ3QgYW55IGltcGxpY2l0IHRyYWNrcywKKyAgICAvLyBiZWNhdXNlIG5vdCBo
YXZpbmcgcm93cyBpbXBsaWVzIHRoYXQgdGhlcmUgYXJlIG5vICJub3JtYWwiIGNoaWxkcmVuIChv
dXQtb2YtZmxvdyBjaGlsZHJlbiBhcmUKKyAgICAvLyBub3Qgc3RvcmVkIGluIG1fZ3JpZCkuCisg
ICAgaWYgKGRpcmVjdGlvbiA9PSBGb3JSb3dzKQorICAgICAgICByZXR1cm4gbV9ncmlkLnNpemUo
KTsKKworICAgIHJldHVybiBtX2dyaWQuc2l6ZSgpID8gbV9ncmlkWzBdLnNpemUoKSA6IEdyaWRQ
b3NpdGlvbnNSZXNvbHZlcjo6ZXhwbGljaXRHcmlkQ29sdW1uQ291bnQoc3R5bGUoKSwgbV9hdXRv
UmVwZWF0Q29sdW1ucyk7Cit9CisKIHZvaWQgUmVuZGVyR3JpZDo6cGFpbnRDaGlsZHJlbihQYWlu
dEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5b3V0UG9pbnQmIHBhaW50T2Zmc2V0LCBQYWludElu
Zm8mIGZvckNoaWxkLCBib29sIHVzZVByaW50UmVjdCkKIHsKICAgICBmb3IgKFJlbmRlckJveCog
Y2hpbGQgPSBtX29yZGVySXRlcmF0b3IuZmlyc3QoKTsgY2hpbGQ7IGNoaWxkID0gbV9vcmRlckl0
ZXJhdG9yLm5leHQoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k
ZXJHcmlkLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5oCmluZGV4IGRk
MjUyZWM4NzRjMmViYjhkN2ZlMmU3ZjMxMjhhMzZmNTk2MGE2NDUuLjkwMzNlMTFhMTkyZTJlMTE2
MjhlOTc5ZWU2ZjRmN2U2YmUxNjI0YTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl
cmluZy9SZW5kZXJHcmlkLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdy
aWQuaApAQCAtMTkyLDYgKzE5Miw3IEBAIHByaXZhdGU6CiAKICAgICB1bnNpZ25lZCBncmlkQ29s
dW1uQ291bnQoKSBjb25zdDsKICAgICB1bnNpZ25lZCBncmlkUm93Q291bnQoKSBjb25zdDsKKyAg
ICB1bnNpZ25lZCBudW1UcmFja3MoR3JpZFRyYWNrU2l6aW5nRGlyZWN0aW9uKSBjb25zdDsKIAog
ICAgIExheW91dFVuaXQgdHJhbnNsYXRlUlRMQ29vcmRpbmF0ZShMYXlvdXRVbml0KSBjb25zdDsK
IAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>295333</attachid>
            <date>2016-11-22 02:29:02 -0800</date>
            <delta_ts>2016-11-22 04:20:45 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-165006-20161122112701.patch</filename>
            <type>text/plain</type>
            <size>7632</size>
            <attacher name="Sergio Villar Senin">svillar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4OTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzA0ZDRlODk1YzcyZmVj
MTVjMGY3NWQ1ZjY5ZTliYTRkNjBhYTBlNS4uZDY5ZmY5Yzg5ZGRhNjg5YzFhNmYyMTE2MTAxNzRj
Mjg0YmJkNjU4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM4IEBACisyMDE2LTExLTIxICBTZXJn
aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp
ZF0gSXNvbGF0ZSBzaXplIG9mIGludGVybmFsIHJlcHJlc2VudGF0aW9uIGZyb20gYWN0dWFsIGdy
aWQgc2l6ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTY1MDA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
UmVuZGVyR3JpZCBoYXMgYW4gaW50ZXJuYWwgcmVwcmVzZW50YXRpb24gb2YgYSBncmlkIHVzZWQg
dG8gcGxhY2UgZ3JpZCBpdGVtcywgY29tcHV0ZSBncmlkCisgICAgICAgIHBvc2l0aW9ucywgcnVu
IHRoZSB0cmFjayBzaXppbmcgYWxnb3JpdGhtIGV0Yy4gVGhhdCBkYXRhIHN0cnVjdHVyZSBub3Jt
YWxseSBoYXMgZXhhY3RseSB0aGUKKyAgICAgICAgc2FtZSBzaXplIGFzIHRoZSBhY3R1YWwgZ3Jp
ZCBzcGVjaWZpZWQgdXNpbmcgdGhlIGdyaWQtdGVtcGxhdGUteHh4IHByb3BlcnRpZXMgKG9yIGFu
eSBvdGhlcgorICAgICAgICBzaG9ydGhhbmQpLiBCdXQgaW4gc29tZSBjYXNlcywgbGlrZSBmb3Ig
ZXhhbXBsZSB3aGVuIHRoZSBncmlkIGlzIGVtcHR5LCB0aGUgaW50ZXJuYWwgZGF0YQorICAgICAg
ICBzdHJ1Y3R1cmUgZG9lcyBub3QgcmVhbGx5IG1hdGNoIHRoZSBhY3R1YWwgZ3JpZC4gSW4gdGhl
IHBhcnRpY3VsYXIgY2FzZSBvZiBlbXB0eSBncmlkcyBubworICAgICAgICBtZW1vcnkgYWxsb2Nh
dGlvbnMgYXJlIGRvbmUgdG8gY3JlYXRlIGEgZ3JpZCByZXByZXNlbnRhdGlvbiBhcyBpdCBpcyBu
b3QgbmVlZGVkLgorCisgICAgICAgIEZyb20gbm93IG9uIGJvdGggZ3JpZENvbHVtbkNvdW50KCkg
YW5kIGdyaWRSb3dDb3VudCgpIHdpbGwgYWx3YXlzIHJldHVybiB0aGUgc2l6ZSBvZiB0aGUKKyAg
ICAgICAgZGF0YSBzdHJ1Y3R1cmUgcmVwcmVzZW50aW5nIHRoZSBncmlkIHdoZXJlYXMgdGhlIG5l
d2x5IGFkZGVkIG51bVRyYWNrcygpIHdpbGwgYWx3YXlzIHJldHVybgorICAgICAgICB0aGUgYWN0
dWFsIHNpemUgb2YgdGhlIGdyaWQuCisKKyAgICAgICAgVGhpcyBpcyB0aGUgZmlyc3QgcmVxdWly
ZWQgc3RlcCBvZiB0aGUgcHJvY2VzcyBvZiBpc29sYXRpbmcgdGhlIGRhdGEgdXNlZCBieSB0aGUg
Z3JpZCB0cmFjaworICAgICAgICBzaXppbmcgYWxnb3JpdGhtIGZyb20gdGhlIGFjdHVhbCBpbnRl
cm5hbCBzdGF0ZSBvZiB0aGUgTGF5b3V0R3JpZCBvYmplY3QuCisKKyAgICAgICAgTm8gbmV3IHRl
c3RzIGFzIHRoaXMgaXMganVzdCBhIGNvZGUgcmVmYWN0b3JpbmcuCisKKyAgICAgICAgKiByZW5k
ZXJpbmcvUmVuZGVyR3JpZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJHcmlkOjpncmlk
Q29sdW1uQ291bnQpOiBBbHdheXMgcmV0dXJuIHRoZSBudW1iZXIgb2YgY29sdW1ucyBvZiB0aGUg
aW50ZXJuYWwKKyAgICAgICAgZGF0YSBzdHJ1Y3R1cmUgdG8gcmVwcmVzZW50IHRoZSBncmlkLgor
ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyR3JpZDo6bGF5b3V0QmxvY2spOgorICAgICAgICAoV2Vi
Q29yZTo6UmVuZGVyR3JpZDo6Y29tcHV0ZUludHJpbnNpY0xvZ2ljYWxXaWR0aHMpOiBVc2UgdGhl
IGFjdHVhbCBzaXplIG9mIHRoZSBncmlkIHRvCisgICAgICAgIGNyZWF0ZSB0aGUgR3JpZFNpemlu
Z0RhdGEgc3RydWN0dXJlLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyR3JpZDo6cGxhY2VJdGVt
c09uR3JpZCk6IFVzZSB0aGUgYWN0dWFsIHNpemUgb2YgdGhlIGdyaWQgdG8gY3JlYXRlIHRoZQor
ICAgICAgICBHcmlkU2l6aW5nRGF0YSBzdHJ1Y3R1cmUuCisgICAgICAgIChXZWJDb3JlOjpSZW5k
ZXJHcmlkOjpvZmZzZXRBbmRCcmVhZHRoRm9yUG9zaXRpb25lZENoaWxkKToKKyAgICAgICAgKFdl
YkNvcmU6OlJlbmRlckdyaWQ6Om51bVRyYWNrcyk6IE5ldyBtZXRob2Qgd2hpY2ggcmV0dXJucyB0
aGUgYWN0dWFsIHNpemUgb2YgdGhlIGdyaWQuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckdy
aWQuaDoKKwogMjAxNi0xMS0yMSAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgu
cnU+CiAKICAgICAgICAgRGlzYWJsZSAjbGluZSBtYXJrZXJzIGluIGJpc29uIG91dHB1dCBvbiBX
aW5kb3dzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5j
cHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKaW5kZXggODBkNjkx
NDlkYTI4OTFiMTI2OTMxMjBjYTM3MjEyOGY4OWNhYzczMS4uZDA1NGI0YjMwODQxOTQ1OTZkY2E4
ZTlkNzZmZjNkMWQyMzBkNGFjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n
L1JlbmRlckdyaWQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlk
LmNwcApAQCAtMzg3LDEyICszODcsNyBAQCB2b2lkIFJlbmRlckdyaWQ6OnN0eWxlRGlkQ2hhbmdl
KFN0eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSogb2xkU3R5bAogdW5zaWdu
ZWQgUmVuZGVyR3JpZDo6Z3JpZENvbHVtbkNvdW50KCkgY29uc3QKIHsKICAgICBBU1NFUlQoIW1f
Z3JpZElzRGlydHkpOwotICAgIC8vIER1ZSB0byBsaW1pdGF0aW9ucyBpbiBvdXIgaW50ZXJuYWwg
cmVwcmVzZW50YXRpb24sIHdlIGNhbm5vdCBrbm93IHRoZSBudW1iZXIgb2YgY29sdW1ucyBmcm9t
Ci0gICAgLy8gbV9ncmlkICppZiogdGhlcmUgaXMgbm8gcm93IChiZWNhdXNlIG1fZ3JpZCB3b3Vs
ZCBiZSBlbXB0eSkuIFRoYXQncyB3aHkgaW4gdGhhdCBjYXNlIHdlIG5lZWQKLSAgICAvLyB0byBn
ZXQgaXQgZnJvbSB0aGUgc3R5bGUuIE5vdGUgdGhhdCB3ZSBrbm93IGZvciBzdXJlIHRoYXQgdGhl
cmUgYXJlJ3QgYW55IGltcGxpY2l0IHRyYWNrcywKLSAgICAvLyBiZWNhdXNlIG5vdCBoYXZpbmcg
cm93cyBpbXBsaWVzIHRoYXQgdGhlcmUgYXJlIG5vICJub3JtYWwiIGNoaWxkcmVuIChvdXQtb2Yt
ZmxvdyBjaGlsZHJlbiBhcmUKLSAgICAvLyBub3Qgc3RvcmVkIGluIG1fZ3JpZCkuCi0gICAgcmV0
dXJuIG1fZ3JpZC5zaXplKCkgPyBtX2dyaWRbMF0uc2l6ZSgpIDogR3JpZFBvc2l0aW9uc1Jlc29s
dmVyOjpleHBsaWNpdEdyaWRDb2x1bW5Db3VudChzdHlsZSgpLCBtX2F1dG9SZXBlYXRDb2x1bW5z
KTsKKyAgICByZXR1cm4gbV9ncmlkLnNpemUoKSA/IG1fZ3JpZFswXS5zaXplKCkgOiAwOwogfQog
CiB1bnNpZ25lZCBSZW5kZXJHcmlkOjpncmlkUm93Q291bnQoKSBjb25zdApAQCAtNDg4LDcgKzQ4
Myw3IEBAIHZvaWQgUmVuZGVyR3JpZDo6bGF5b3V0QmxvY2soYm9vbCByZWxheW91dENoaWxkcmVu
LCBMYXlvdXRVbml0KQogCiAgICAgcGxhY2VJdGVtc09uR3JpZChUcmFja1NpemluZyk7CiAKLSAg
ICBHcmlkU2l6aW5nRGF0YSBzaXppbmdEYXRhKGdyaWRDb2x1bW5Db3VudCgpLCBncmlkUm93Q291
bnQoKSk7CisgICAgR3JpZFNpemluZ0RhdGEgc2l6aW5nRGF0YShudW1UcmFja3MoRm9yQ29sdW1u
cyksIG51bVRyYWNrcyhGb3JSb3dzKSk7CiAKICAgICAvLyBBdCB0aGlzIHBvaW50IHRoZSBsb2dp
Y2FsIHdpZHRoIGlzIGFsd2F5cyBkZWZpbml0ZSBhcyB0aGUgYWJvdmUgY2FsbCB0byB1cGRhdGVM
b2dpY2FsV2lkdGgoKQogICAgIC8vIHByb3Blcmx5IHJlc29sdmVzIGludHJpbnNpYyBzaXplcy4g
V2UgY2Fubm90IGRvIHRoZSBzYW1lIGZvciBoZWlnaHRzIHRob3VnaCBiZWNhdXNlIG1hbnkgY29k
ZQpAQCAtNjM4LDcgKzYzMyw3IEBAIHZvaWQgUmVuZGVyR3JpZDo6Y29tcHV0ZUludHJpbnNpY0xv
Z2ljYWxXaWR0aHMoTGF5b3V0VW5pdCYgbWluTG9naWNhbFdpZHRoLCBMYXlvCiAgICAgaWYgKCF3
YXNQb3B1bGF0ZWQpCiAgICAgICAgIGNvbnN0X2Nhc3Q8UmVuZGVyR3JpZCo+KHRoaXMpLT5wbGFj
ZUl0ZW1zT25HcmlkKEludHJpbnNpY1NpemVDb21wdXRhdGlvbik7CiAKLSAgICBHcmlkU2l6aW5n
RGF0YSBzaXppbmdEYXRhKGdyaWRDb2x1bW5Db3VudCgpLCBncmlkUm93Q291bnQoKSk7CisgICAg
R3JpZFNpemluZ0RhdGEgc2l6aW5nRGF0YShudW1UcmFja3MoRm9yQ29sdW1ucyksIG51bVRyYWNr
cyhGb3JSb3dzKSk7CiAgICAgc2l6aW5nRGF0YS5zZXRBdmFpbGFibGVTcGFjZShOdWxsb3B0KTsK
ICAgICBzaXppbmdEYXRhLnNldEZyZWVTcGFjZShGb3JDb2x1bW5zLCBOdWxsb3B0KTsKICAgICBz
aXppbmdEYXRhLnNpemluZ09wZXJhdGlvbiA9IEludHJpbnNpY1NpemVDb21wdXRhdGlvbjsKQEAg
LTE2ODcsOCArMTY4MiwxMiBAQCB2b2lkIFJlbmRlckdyaWQ6OnBsYWNlSXRlbXNPbkdyaWQoU2l6
aW5nT3BlcmF0aW9uIHNpemluZ09wZXJhdGlvbikKICAgICAgICAgaW5zZXJ0SXRlbUludG9Hcmlk
KCpjaGlsZCwgR3JpZEFyZWEoYXJlYS5yb3dzLCBhcmVhLmNvbHVtbnMpKTsKICAgICB9CiAKLSAg
ICBBU1NFUlQoZ3JpZFJvd0NvdW50KCkgPj0gR3JpZFBvc2l0aW9uc1Jlc29sdmVyOjpleHBsaWNp
dEdyaWRSb3dDb3VudChzdHlsZSgpLCBtX2F1dG9SZXBlYXRSb3dzKSk7Ci0gICAgQVNTRVJUKGdy
aWRDb2x1bW5Db3VudCgpID49IEdyaWRQb3NpdGlvbnNSZXNvbHZlcjo6ZXhwbGljaXRHcmlkQ29s
dW1uQ291bnQoc3R5bGUoKSwgbV9hdXRvUmVwZWF0Q29sdW1ucykpOworI2lmIEVOQUJMRShBU1NF
UlQpCisgICAgaWYgKCFtX2dyaWRJdGVtQXJlYS5pc0VtcHR5KCkpIHsKKyAgICAgICAgQVNTRVJU
KGdyaWRSb3dDb3VudCgpID49IEdyaWRQb3NpdGlvbnNSZXNvbHZlcjo6ZXhwbGljaXRHcmlkUm93
Q291bnQoc3R5bGUoKSwgbV9hdXRvUmVwZWF0Um93cykpOworICAgICAgICBBU1NFUlQoZ3JpZENv
bHVtbkNvdW50KCkgPj0gR3JpZFBvc2l0aW9uc1Jlc29sdmVyOjpleHBsaWNpdEdyaWRDb2x1bW5D
b3VudChzdHlsZSgpLCBtX2F1dG9SZXBlYXRDb2x1bW5zKSk7CisgICAgfQorI2VuZGlmCiAKICAg
ICBwbGFjZVNwZWNpZmllZE1ham9yQXhpc0l0ZW1zT25HcmlkKHNwZWNpZmllZE1ham9yQXhpc0F1
dG9HcmlkSXRlbXMpOwogICAgIHBsYWNlQXV0b01ham9yQXhpc0l0ZW1zT25HcmlkKGF1dG9NYWpv
ckF4aXNBdXRvR3JpZEl0ZW1zKTsKQEAgLTIwNTcsNyArMjA1Niw3IEBAIHZvaWQgUmVuZGVyR3Jp
ZDo6b2Zmc2V0QW5kQnJlYWR0aEZvclBvc2l0aW9uZWRDaGlsZChjb25zdCBSZW5kZXJCb3gmIGNo
aWxkLCBHcmlkCiAKICAgICBHcmlkUG9zaXRpb24gc3RhcnRQb3NpdGlvbiA9IGlzUm93QXhpcyA/
IGNoaWxkLnN0eWxlKCkuZ3JpZEl0ZW1Db2x1bW5TdGFydCgpIDogY2hpbGQuc3R5bGUoKS5ncmlk
SXRlbVJvd1N0YXJ0KCk7CiAgICAgR3JpZFBvc2l0aW9uIGVuZFBvc2l0aW9uID0gaXNSb3dBeGlz
ID8gY2hpbGQuc3R5bGUoKS5ncmlkSXRlbUNvbHVtbkVuZCgpIDogY2hpbGQuc3R5bGUoKS5ncmlk
SXRlbVJvd0VuZCgpOwotICAgIGludCBsYXN0TGluZSA9IGlzUm93QXhpcyA/IGdyaWRDb2x1bW5D
b3VudCgpIDogZ3JpZFJvd0NvdW50KCk7CisgICAgaW50IGxhc3RMaW5lID0gbnVtVHJhY2tzKGRp
cmVjdGlvbik7CiAKICAgICBib29sIHN0YXJ0SXNBdXRvID0gc3RhcnRQb3NpdGlvbi5pc0F1dG8o
KQogICAgICAgICB8fCAoc3RhcnRQb3NpdGlvbi5pc05hbWVkR3JpZEFyZWEoKSAmJiAhTmFtZWRM
aW5lQ29sbGVjdGlvbjo6aXNWYWxpZE5hbWVkTGluZU9yQXJlYShzdGFydFBvc2l0aW9uLm5hbWVk
R3JpZExpbmUoKSwgc3R5bGUoKSwgKGRpcmVjdGlvbiA9PSBGb3JDb2x1bW5zKSA/IENvbHVtblN0
YXJ0U2lkZSA6IFJvd1N0YXJ0U2lkZSkpCkBAIC0yNzExLDYgKzI3MTAsMTkgQEAgTGF5b3V0UG9p
bnQgUmVuZGVyR3JpZDo6ZmluZENoaWxkTG9naWNhbFBvc2l0aW9uKGNvbnN0IFJlbmRlckJveCYg
Y2hpbGQpIGNvbnN0CiAgICAgcmV0dXJuIGlzT3J0aG9nb25hbENoaWxkKGNoaWxkKSA/IGNoaWxk
TG9jYXRpb24udHJhbnNwb3NlZFBvaW50KCkgOiBjaGlsZExvY2F0aW9uOwogfQogCit1bnNpZ25l
ZCBSZW5kZXJHcmlkOjpudW1UcmFja3MoR3JpZFRyYWNrU2l6aW5nRGlyZWN0aW9uIGRpcmVjdGlv
bikgY29uc3QKK3sKKyAgICAvLyBEdWUgdG8gbGltaXRhdGlvbnMgaW4gb3VyIGludGVybmFsIHJl
cHJlc2VudGF0aW9uLCB3ZSBjYW5ub3Qga25vdyB0aGUgbnVtYmVyIG9mIGNvbHVtbnMgZnJvbQor
ICAgIC8vIG1fZ3JpZCAqaWYqIHRoZXJlIGlzIG5vIHJvdyAoYmVjYXVzZSBtX2dyaWQgd291bGQg
YmUgZW1wdHkpLiBUaGF0J3Mgd2h5IGluIHRoYXQgY2FzZSB3ZSBuZWVkCisgICAgLy8gdG8gZ2V0
IGl0IGZyb20gdGhlIHN0eWxlLiBOb3RlIHRoYXQgd2Uga25vdyBmb3Igc3VyZSB0aGF0IHRoZXJl
IGFyZSd0IGFueSBpbXBsaWNpdCB0cmFja3MsCisgICAgLy8gYmVjYXVzZSBub3QgaGF2aW5nIHJv
d3MgaW1wbGllcyB0aGF0IHRoZXJlIGFyZSBubyAibm9ybWFsIiBjaGlsZHJlbiAob3V0LW9mLWZs
b3cgY2hpbGRyZW4gYXJlCisgICAgLy8gbm90IHN0b3JlZCBpbiBtX2dyaWQpLgorICAgIGlmIChk
aXJlY3Rpb24gPT0gRm9yUm93cykKKyAgICAgICAgcmV0dXJuIG1fZ3JpZC5zaXplKCk7CisKKyAg
ICByZXR1cm4gbV9ncmlkLnNpemUoKSA/IG1fZ3JpZFswXS5zaXplKCkgOiBHcmlkUG9zaXRpb25z
UmVzb2x2ZXI6OmV4cGxpY2l0R3JpZENvbHVtbkNvdW50KHN0eWxlKCksIG1fYXV0b1JlcGVhdENv
bHVtbnMpOworfQorCiB2b2lkIFJlbmRlckdyaWQ6OnBhaW50Q2hpbGRyZW4oUGFpbnRJbmZvJiBw
YWludEluZm8sIGNvbnN0IExheW91dFBvaW50JiBwYWludE9mZnNldCwgUGFpbnRJbmZvJiBmb3JD
aGlsZCwgYm9vbCB1c2VQcmludFJlY3QpCiB7CiAgICAgZm9yIChSZW5kZXJCb3gqIGNoaWxkID0g
bV9vcmRlckl0ZXJhdG9yLmZpcnN0KCk7IGNoaWxkOyBjaGlsZCA9IG1fb3JkZXJJdGVyYXRvci5u
ZXh0KCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5o
IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuaAppbmRleCA3NjFhMjQwNzJi
OGVlMDdkY2U3NzUzMTA1ZGM5YjFlNzM2ZDdiMzQwLi5lNzUwMWViZjFhZTM2ZDM4NjljMTgzYmZl
OWJhNGUzOWEwODNkZjUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu
ZGVyR3JpZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmgKQEAg
LTE5Miw2ICsxOTIsNyBAQCBwcml2YXRlOgogCiAgICAgdW5zaWduZWQgZ3JpZENvbHVtbkNvdW50
KCkgY29uc3Q7CiAgICAgdW5zaWduZWQgZ3JpZFJvd0NvdW50KCkgY29uc3Q7CisgICAgdW5zaWdu
ZWQgbnVtVHJhY2tzKEdyaWRUcmFja1NpemluZ0RpcmVjdGlvbikgY29uc3Q7CiAKICAgICBMYXlv
dXRVbml0IHRyYW5zbGF0ZVJUTENvb3JkaW5hdGUoTGF5b3V0VW5pdCkgY29uc3Q7CiAK
</data>
<flag name="review"
          id="317949"
          type_id="1"
          status="+"
          setter="rego"
    />
          </attachment>
      

    </bug>

</bugzilla>