<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>164997</bug_id>
          
          <creation_ts>2016-11-20 01:37:31 -0800</creation_ts>
          <short_desc>set PYTHONPATH in separate COMMAND doesn&apos;t work with all CMake generators</short_desc>
          <delta_ts>2016-12-21 12:19:52 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Konstantin Tokarev">annulen</reporter>
          <assigned_to name="Konstantin Tokarev">annulen</assigned_to>
          <cc>achristensen</cc>
    
    <cc>fujii</cc>
    
    <cc>lforschler</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1253146</commentid>
    <comment_count>0</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2016-11-20 01:37:31 -0800</bug_when>
    <thetext>Fix for r201413.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253147</commentid>
    <comment_count>1</comment_count>
      <attachid>295278</attachid>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2016-11-20 01:39:23 -0800</bug_when>
    <thetext>Created attachment 295278
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253181</commentid>
    <comment_count>2</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2016-11-20 20:29:04 -0800</bug_when>
    <thetext>You can use &apos;${CMAKE_EXECUTABLE} -E env&apos; if all Windows port use CMake &gt;=3.1. Right?
Bug 156833</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253189</commentid>
    <comment_count>3</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2016-11-20 23:50:56 -0800</bug_when>
    <thetext>Makes sense!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1262063</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-12-21 12:05:12 -0800</bug_when>
    <thetext>So what does this fix...?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1262067</commentid>
    <comment_count>5</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2016-12-21 12:11:00 -0800</bug_when>
    <thetext>This fixes build with &quot;NMake Makefiles&quot; CMake generator</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1262068</commentid>
    <comment_count>6</comment_count>
      <attachid>295278</attachid>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2016-12-21 12:19:44 -0800</bug_when>
    <thetext>Comment on attachment 295278
Patch

Clearing flags on attachment: 295278

Committed r210071: &lt;http://trac.webkit.org/changeset/210071&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1262069</commentid>
    <comment_count>7</comment_count>
    <who name="Konstantin Tokarev">annulen</who>
    <bug_when>2016-12-21 12:19:52 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>295278</attachid>
            <date>2016-11-20 01:39:23 -0800</date>
            <delta_ts>2016-12-21 12:19:44 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-164997-20161120123913.patch</filename>
            <type>text/plain</type>
            <size>1265</size>
            <attacher name="Konstantin Tokarev">annulen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi
S2l0TWFjcm9zLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQppbmRleCAy
YTcyNTFlMWY4YzhlY2NlMmFkOGM1MTczNWRhOTEwYjYyYzc0NTI4Li4yZTY0ZjM5MmVmYzViZmI4
ODcwZjFlMGU5ZGIxMjA4Nzg3ODRjY2JhIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0
TWFjcm9zLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKQEAgLTQw
MSw3ICs0MDEsNyBAQCBlbmRtYWNybygpCiAKIG1hY3JvKE1BS0VfSlNfRklMRV9BUlJBWVMgX291
dHB1dF9jcHAgX291dHB1dF9oIF9zY3JpcHRzIF9zY3JpcHRzX2RlcGVuZGVuY2llcykKICAgICBp
ZiAoV0lOMzIpCi0gICAgICAgIHNldChfcHl0aG9uX3BhdGggc2V0ICJQWVRIT05QQVRIPSR7SmF2
YVNjcmlwdENvcmVfU0NSSVBUU19ESVJ9IiBDT01NQU5EKQorICAgICAgICBzZXQoX3B5dGhvbl9w
YXRoIHNldCAiUFlUSE9OUEFUSD0ke0phdmFTY3JpcHRDb3JlX1NDUklQVFNfRElSfSIgJiYpCiAg
ICAgZWxzZSAoKQogICAgICAgICBzZXQoX3B5dGhvbl9wYXRoICJQWVRIT05QQVRIPSR7SmF2YVNj
cmlwdENvcmVfU0NSSVBUU19ESVJ9IikKICAgICBlbmRpZiAoKQpkaWZmIC0tZ2l0IGEvQ2hhbmdl
TG9nIGIvQ2hhbmdlTG9nCmluZGV4IGUxYjk1YzU2MTJhMTc2YzM2NTg1MzNiYzY4YTY2YjljMWYw
MmZkMjMuLjJkOGMxNjFlN2NlZmZlODIzNzY4MTcwN2I3ZDE5MmQzMTQxYjI5MmIgMTAwNjQ0Ci0t
LSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNi0xMS0y
MCAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CisKKyAgICAgICAgc2V0
IFBZVEhPTlBBVEggaW4gc2VwYXJhdGUgQ09NTUFORCBkb2Vzbid0IHdvcmsgd2l0aCBhbGwgQ01h
a2UgZ2VuZXJhdG9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTY0OTk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgRml4IGZvciByMjAxNDEzLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdE1h
Y3Jvcy5jbWFrZToKKwogMjAxNi0xMS0xNyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNv
bT4KIAogICAgICAgICBSZW1vdmUgYXN5bmMvYXdhaXQgY29tcGlsZSB0aW1lIGZsYWcgYW5kIGVu
YWJsZSB0ZXN0cwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>