164973 2016-11-18 17:20:25 -0800 Disable #line markers in bison output on Windows 2016-11-21 17:57:42 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen achristensen bfulgham darin pvollan oldest_to_newest 1252972 0 annulen 2016-11-18 17:20:25 -0800 New bison versions since 3.0 have bug that causes unescaped paths to be printed in #line directives. On Windows CMake passes absolute paths to bison that have backslashes in them, leading to compiler errors or warnings because of unrecognized escape sequences. 1252973 1 295229 annulen 2016-11-18 17:22:15 -0800 Created attachment 295229 Patch 1253251 2 295229 darin 2016-11-21 09:14:12 -0800 Comment on attachment 295229 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295229&action=review > Source/WebCore/css/makegrammar.pl:83 > -system("\"$bison\" -d -p $symbolsPrefix $grammarFilePath -o $fileBase.cpp"); > + > +my $extraArg = ""; > +if ($^O eq "MSWin32") { > + $extraArg = "--no-lines"; > +} > +system("\"$bison\" $extraArg -d -p $symbolsPrefix $grammarFilePath -o $fileBase.cpp"); Here's how I would write it: my @noLines = (); push @noLines, "--no-lines" if $^O eq "MSWin32"; # Work around bug in bison >= 3.0 on Windows where it puts backslashes into #line directives. system($bison, @noLines, "-d", "-p", $symbolsPrefix, $grammarFilePath, "-o", "$fileBase.cpp") == 0 or die; 1253256 3 annulen 2016-11-21 09:39:59 -0800 What about my @bisonCmd = ($bison, "-d", "-p", $symbolsPrefix, $grammarFilePath, "-o", $fileBase.cpp); push @bisonCmd, "--no-lines" if $^O eq "MSWin32"; # Work around bug in bison >= 3.0 on Windows where it puts backslashes into #line directives. system(@bisonCmd) == 0 or die; ? 1253257 4 darin 2016-11-21 09:42:16 -0800 That seems fine. I would name it @bisonCommand, without abbreviating the word, though. 1253258 5 darin 2016-11-21 09:43:00 -0800 (In reply to comment #3) > my @bisonCmd = ($bison, "-d", "-p", $symbolsPrefix, $grammarFilePath, > "-o", $fileBase.cpp); Need quotes around "$fileBase.cpp". 1253309 6 annulen 2016-11-21 17:57:42 -0800 Committed r208954: <http://trac.webkit.org/changeset/208954> 295229 2016-11-18 17:22:15 -0800 2016-11-21 09:14:12 -0800 Patch bug-164973-20161119042207.patch text/plain 1617 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4OTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmRmYjcwNDMxNmNkNjdl Mjg0ODY0MzE1M2JmNTBhZTk0YmQ0NGU3OS4uNTYyZDkzYjEzZjBhYmFjNDVkODI4YmYyYjI0NjIz YzBmNTY4NmJmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTExLTE4ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBEaXNhYmxlICNs aW5lIG1hcmtlcnMgaW4gYmlzb24gb3V0cHV0IG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDk3MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyBiaXNvbiB2ZXJzaW9ucyBzaW5jZSAz LjAgaGF2ZSBidWcgdGhhdCBjYXVzZXMgdW5lc2NhcGVkIHBhdGhzCisgICAgICAgIHRvIGJlIHBy aW50ZWQgaW4gI2xpbmUgZGlyZWN0aXZlcy4gT24gV2luZG93cyBDTWFrZSBwYXNzZXMgYWJzb2x1 dGUKKyAgICAgICAgcGF0aHMgdG8gYmlzb24gdGhhdCBoYXZlIGJhY2tzbGFzaGVzIGluIHRoZW0s IGxlYWRpbmcgdG8gY29tcGlsZXIKKyAgICAgICAgZXJyb3JzIG9yIHdhcm5pbmdzIGJlY2F1c2Ug b2YgdW5yZWNvZ25pemVkIGVzY2FwZSBzZXF1ZW5jZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz IG5lZWRlZC4KKworICAgICAgICAqIGNzcy9tYWtlZ3JhbW1hci5wbDoKKwogMjAxNi0xMS0xOCAg TXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJH TDJdIEltcGxlbWVudCB0ZXhTdG9yYWdlMkQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y3NzL21ha2VncmFtbWFyLnBsIGIvU291cmNlL1dlYkNvcmUvY3NzL21ha2VncmFtbWFyLnBsCmlu ZGV4IDRkNGY1MTgxNGNhNmYzOGQ3MDAxNmQwYzg3MTAzOTE3ZTY3OWFkNjcuLjhjZWJmNWQzYmVm NmU1ZmFiNDQzY2VjNjMzNWM0MzlhZGIzNjhmYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9tYWtlZ3JhbW1hci5wbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZWdyYW1tYXIu cGwKQEAgLTc1LDcgKzc1LDEyIEBAIGlmICgkc3VmZml4IGVxICIueS5pbiIpIHsKIH0KIAogbXkg JGZpbGVCYXNlID0gRmlsZTo6U3BlYy0+am9pbigkb3V0cHV0RGlyLCAkZmlsZW5hbWUpOwotc3lz dGVtKCJcIiRiaXNvblwiIC1kIC1wICRzeW1ib2xzUHJlZml4ICRncmFtbWFyRmlsZVBhdGggLW8g JGZpbGVCYXNlLmNwcCIpOworCitteSAkZXh0cmFBcmcgPSAiIjsKK2lmICgkXk8gZXEgIk1TV2lu MzIiKSB7CisgICAgJGV4dHJhQXJnID0gIi0tbm8tbGluZXMiOworfQorc3lzdGVtKCJcIiRiaXNv blwiICRleHRyYUFyZyAtZCAtcCAkc3ltYm9sc1ByZWZpeCAkZ3JhbW1hckZpbGVQYXRoIC1vICRm aWxlQmFzZS5jcHAiKTsKIAogb3BlbiBIRUFERVIsICI+JGZpbGVCYXNlLmgiIG9yIGRpZTsKIHBy aW50IEhFQURFUiA8PCAiRU9GIjsK