<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>164934</bug_id>
          
          <creation_ts>2016-11-18 10:10:59 -0800</creation_ts>
          <short_desc>[Win] Apple build is using incorrect ICU library (if present)</short_desc>
          <delta_ts>2016-11-30 10:46:22 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>fujii</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>pvollan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1252715</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-11-18 10:10:59 -0800</bug_when>
    <thetext>The Apple Windows port needs to link against &quot;libicuuc.lib&quot; and &quot;libicuin.lib&quot;, which have the correct symbols and versioning. For historical reasons, the Apple build environment also contains an older &quot;icuuc.lib&quot; and &quot;icuin.lib&quot;, that are not compatible.

The FindICU.cmake rules will preferentially find and use the &quot;icuuc.lib&quot; and &quot;icuin.lib&quot; if they are present.

While I modified the WebKit build system to delete instances of &quot;icuuc.lib&quot; and &quot;icuin.lib&quot;, I cannot do this for the production build system (to avoid breaking other Apple software).

Consequently, the FindICU.cmake rules need to be modified to account for this quirk.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252717</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-11-18 10:11:28 -0800</bug_when>
    <thetext>&lt;rdar://problem/29329654&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252721</commentid>
    <comment_count>2</comment_count>
      <attachid>295163</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-11-18 10:18:17 -0800</bug_when>
    <thetext>Created attachment 295163
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252739</commentid>
    <comment_count>3</comment_count>
      <attachid>295163</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2016-11-18 11:20:25 -0800</bug_when>
    <thetext>Comment on attachment 295163
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295163&amp;action=review

&gt; Source/cmake/FindICU.cmake:26
&gt; +if (WIN32)

:(

&gt; Source/cmake/FindICU.cmake:37
&gt; +        NAMES icuuc libicuuc cygicuuc cygicuuc32

I think we should make this platform independent and just not look for icuuc anywhere, even on linux.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252784</commentid>
    <comment_count>4</comment_count>
      <attachid>295163</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-11-18 12:36:58 -0800</bug_when>
    <thetext>Comment on attachment 295163
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295163&amp;action=review

&gt;&gt; Source/cmake/FindICU.cmake:37
&gt;&gt; +        NAMES icuuc libicuuc cygicuuc cygicuuc32
&gt; 
&gt; I think we should make this platform independent and just not look for icuuc anywhere, even on linux.

FWIW the only one of these that exists on Linux is libicuuc. I guess icuuc is probably Windows-specific, so we should go with Alex&apos;s suggestion if it doesn&apos;t seem to break anything.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252815</commentid>
    <comment_count>5</comment_count>
      <attachid>295185</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-11-18 13:31:43 -0800</bug_when>
    <thetext>Created attachment 295185
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252817</commentid>
    <comment_count>6</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-11-18 13:32:12 -0800</bug_when>
    <thetext>Revised patch removing &apos;icuin.lib&apos; and &apos;icuuc.lib&apos;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252820</commentid>
    <comment_count>7</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2016-11-18 13:34:54 -0800</bug_when>
    <thetext>Does it work if you put lib* in front of the other ones?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252821</commentid>
    <comment_count>8</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2016-11-18 13:36:20 -0800</bug_when>
    <thetext>Don, do you use icuin.lib or icuuc.lib, or libicuin.lib and libicuuc.lib?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252824</commentid>
    <comment_count>9</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2016-11-18 13:39:00 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; Don, do you use icuin.lib or icuuc.lib, or libicuin.lib and libicuuc.lib?

Ours are all lib* for icu</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252825</commentid>
    <comment_count>10</comment_count>
      <attachid>295185</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2016-11-18 13:40:54 -0800</bug_when>
    <thetext>Comment on attachment 295185
Patch

It looks like EFL and only EFL needs icuuc and icuin.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252829</commentid>
    <comment_count>11</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2016-11-18 13:45:08 -0800</bug_when>
    <thetext>(In reply to comment #10)
&gt; Comment on attachment 295185 [details]
&gt; Patch
&gt; 
&gt; It looks like EFL and only EFL needs icuuc and icuin.

But does the ordering matter in CMake? If the ordering was switched to have libicuuc at the front does CMake choose that or still icuuc?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252846</commentid>
    <comment_count>12</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-11-18 14:07:13 -0800</bug_when>
    <thetext>(In reply to comment #10)
&gt; Comment on attachment 295185 [details]
&gt; Patch
&gt; 
&gt; It looks like EFL and only EFL needs icuuc and icuin.

I cannot imagine why the library name would be different... Gyuyoung, any ideas?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252863</commentid>
    <comment_count>13</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2016-11-18 14:25:26 -0800</bug_when>
    <thetext>CMake has some variables for prefixes for libraries CMAKE_SHARED_LIBRARY_PREFIX and CMAKE_STATIC_LIBRARY_PREFIX. I believe it uses this with the find scripts.

For *NIX it appears that CMAKE_SHARED_LIBRARY_PREFIX and CMAKE_STATIC_LIBRARY_PREFIX are set to &quot;lib&quot;. On Windows its set to &quot;&quot;. That&apos;s why lib* had to be added to work with Windows.

Platform files are in share/cmake-${version}/Platform/ for reference.

For the WinCairoRequirements its a mix of stuff prefixed with lib and stuff without it. If all of them were prefixed then we could just set those values.

My only other thought is that maybe if its

NAMES libicui18n libicuin cygicuin cygicuin32 icui18n icuin

then the libicu ones will be used on windows as its the first match.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1254807</commentid>
    <comment_count>14</comment_count>
      <attachid>295726</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-11-30 09:39:56 -0800</bug_when>
    <thetext>Created attachment 295726
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1254808</commentid>
    <comment_count>15</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-11-30 09:41:24 -0800</bug_when>
    <thetext>I updated the patch to move the undesirable ICU names to the end of the set of choices. Let&apos;s see if that works!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1254812</commentid>
    <comment_count>16</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2016-11-30 09:50:31 -0800</bug_when>
    <thetext>This seems to work on my development machine. By reordering the libraries being searched for, it preferentially locates the &quot;libicuin.lib&quot; and &quot;libicuuc.lib&quot; files, even when the &quot;icuin.lib&quot; and &quot;icuuc.lib&quot; files are present in the libraries folder.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1254843</commentid>
    <comment_count>17</comment_count>
      <attachid>295726</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-11-30 10:46:17 -0800</bug_when>
    <thetext>Comment on attachment 295726
Patch

Clearing flags on attachment: 295726

Committed r209138: &lt;http://trac.webkit.org/changeset/209138&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1254844</commentid>
    <comment_count>18</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-11-30 10:46:22 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>295163</attachid>
            <date>2016-11-18 10:18:17 -0800</date>
            <delta_ts>2016-11-18 13:31:40 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-164934-20161118101811.patch</filename>
            <type>text/plain</type>
            <size>3162</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwODg4
NCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTEx
LTE4ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5d
IEFwcGxlIGJ1aWxkIGlzIHVzaW5nIGluY29ycmVjdCBJQ1UgbGlicmFyeSAoaWYgcHJlc2VudCkK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDkzNAor
ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjkzMjk2NTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBidWlsZGluZyBmb3IgV2luZG93cywgZG8g
bm90IGluY2x1ZGUgJ2ljdXVjLmxpYicgb3IgJ2ljdWluLmxpYicgaW4gdGhlIGxpc3Qgb2YKKyAg
ICAgICAgc3VpdGFibGUgSUNVIGxpYnJhcmllcyB0byB1c2UgaW4gdGhlIGJ1aWxkLgorCisgICAg
ICAgICogU291cmNlL2NtYWtlL0ZpbmRJQ1UuY21ha2U6CisKIDIwMTYtMTEtMTcgIFNhYW0gQmFy
YXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGFzeW5jL2F3YWl0IGNv
bXBpbGUgdGltZSBmbGFnIGFuZCBlbmFibGUgdGVzdHMKSW5kZXg6IFNvdXJjZS9jbWFrZS9GaW5k
SUNVLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9jbWFrZS9GaW5kSUNVLmNtYWtlCShyZXZp
c2lvbiAyMDg4NjApCisrKyBTb3VyY2UvY21ha2UvRmluZElDVS5jbWFrZQkod29ya2luZyBjb3B5
KQpAQCAtMjMsMTMgKzIzLDIzIEBAIGZpbmRfcGF0aCgKIG1hcmtfYXNfYWR2YW5jZWQoSUNVX0lO
Q0xVREVfRElSKQogCiAjIExvb2sgZm9yIHRoZSBsaWJyYXJ5LgotZmluZF9saWJyYXJ5KAotICAg
IElDVV9MSUJSQVJZCi0gICAgTkFNRVMgaWN1dWMgbGliaWN1dWMgY3lnaWN1dWMgY3lnaWN1dWMz
MgotICAgIEhJTlRTICR7UENfSUNVX0xJQlJBUllfRElSU30KLSAgICAgICAgICAke1BDX0lDVV9M
SUJESVJ9Ci0gICAgICAgICAgJHtXRUJLSVRfTElCUkFSSUVTX0xJTktfRElSfQotICAgIERPQyAi
TGlicmFyaWVzIHRvIGxpbmsgYWdhaW5zdCBmb3IgdGhlIGNvbW1vbiBwYXJ0cyBvZiBJQ1UiKQor
aWYgKFdJTjMyKQorICAgIGZpbmRfbGlicmFyeSgKKyAgICAgICAgSUNVX0xJQlJBUlkKKyAgICAg
ICAgTkFNRVMgbGliaWN1dWMgY3lnaWN1dWMgY3lnaWN1dWMzMgorICAgICAgICBISU5UUyAke1BD
X0lDVV9MSUJSQVJZX0RJUlN9CisgICAgICAgICAgICAgICR7UENfSUNVX0xJQkRJUn0KKyAgICAg
ICAgICAgICAgJHtXRUJLSVRfTElCUkFSSUVTX0xJTktfRElSfQorICAgICAgICBET0MgIkxpYnJh
cmllcyB0byBsaW5rIGFnYWluc3QgZm9yIHRoZSBjb21tb24gcGFydHMgb2YgSUNVIikKK2Vsc2Ug
KCkKKyAgICBmaW5kX2xpYnJhcnkoCisgICAgICAgIElDVV9MSUJSQVJZCisgICAgICAgIE5BTUVT
IGljdXVjIGxpYmljdXVjIGN5Z2ljdXVjIGN5Z2ljdXVjMzIKKyAgICAgICAgSElOVFMgJHtQQ19J
Q1VfTElCUkFSWV9ESVJTfQorICAgICAgICAgICAgICAke1BDX0lDVV9MSUJESVJ9CisgICAgICAg
ICAgICAgICR7V0VCS0lUX0xJQlJBUklFU19MSU5LX0RJUn0KKyAgICAgICAgRE9DICJMaWJyYXJp
ZXMgdG8gbGluayBhZ2FpbnN0IGZvciB0aGUgY29tbW9uIHBhcnRzIG9mIElDVSIpCitlbmRpZiAo
KQogbWFya19hc19hZHZhbmNlZChJQ1VfTElCUkFSWSkKIAogIyBDb3B5IHRoZSByZXN1bHRzIHRv
IHRoZSBvdXRwdXQgdmFyaWFibGVzLgpAQCAtNDksMTMgKzU5LDIzIEBAIGlmIChJQ1VfSU5DTFVE
RV9ESVIgQU5EIElDVV9MSUJSQVJZKQogCiAgICAgIyBMb29rIGZvciB0aGUgSUNVIGludGVybmF0
aW9uYWxpemF0aW9uIGxpYnJhcmllcwogICAgIHBrZ19jaGVja19tb2R1bGVzKFBDX0lDVV9JMThO
IGljdS1pMThuKQotICAgIGZpbmRfbGlicmFyeSgKLSAgICAgICAgSUNVX0kxOE5fTElCUkFSWQot
ICAgICAgICBOQU1FUyBpY3VpMThuIGljdWluIGxpYmljdWkxOG4gbGliaWN1aW4gY3lnaWN1aW4g
Y3lnaWN1aW4zMgotICAgICAgICBISU5UUyAke1BDX0lDVV9JMThOX0xJQlJBUllfRElSU30KLSAg
ICAgICAgICAgICAgJHtQQ19JQ1VfSTE4Tl9MSUJESVJ9Ci0gICAgICAgICAgICAgICR7V0VCS0lU
X0xJQlJBUklFU19MSU5LX0RJUn0KLSAgICAgICAgRE9DICJMaWJyYXJpZXMgdG8gbGluayBhZ2Fp
bnN0IGZvciBJQ1UgaW50ZXJuYXRpb25hbGl6YXRpb24iKQorICAgIGlmIChXSU4zMikKKyAgICAg
ICAgZmluZF9saWJyYXJ5KAorICAgICAgICAgICAgSUNVX0kxOE5fTElCUkFSWQorICAgICAgICAg
ICAgTkFNRVMgbGliaWN1aW4gY3lnaWN1aW4gY3lnaWN1aW4zMgorICAgICAgICAgICAgSElOVFMg
JHtQQ19JQ1VfSTE4Tl9MSUJSQVJZX0RJUlN9CisgICAgICAgICAgICAgICAgICAke1BDX0lDVV9J
MThOX0xJQkRJUn0KKyAgICAgICAgICAgICAgICAgICR7V0VCS0lUX0xJQlJBUklFU19MSU5LX0RJ
Un0KKyAgICAgICAgICAgIERPQyAiTGlicmFyaWVzIHRvIGxpbmsgYWdhaW5zdCBmb3IgSUNVIGlu
dGVybmF0aW9uYWxpemF0aW9uIikKKyAgICBlbHNlICgpCisgICAgICAgIGZpbmRfbGlicmFyeSgK
KyAgICAgICAgICAgIElDVV9JMThOX0xJQlJBUlkKKyAgICAgICAgICAgIE5BTUVTIGljdWkxOG4g
aWN1aW4gbGliaWN1aTE4biBsaWJpY3VpbiBjeWdpY3VpbiBjeWdpY3VpbjMyCisgICAgICAgICAg
ICBISU5UUyAke1BDX0lDVV9JMThOX0xJQlJBUllfRElSU30KKyAgICAgICAgICAgICAgICAgICR7
UENfSUNVX0kxOE5fTElCRElSfQorICAgICAgICAgICAgICAgICAgJHtXRUJLSVRfTElCUkFSSUVT
X0xJTktfRElSfQorICAgICAgICAgICAgRE9DICJMaWJyYXJpZXMgdG8gbGluayBhZ2FpbnN0IGZv
ciBJQ1UgaW50ZXJuYXRpb25hbGl6YXRpb24iKQorICAgIGVuZGlmICgpCiAgICAgbWFya19hc19h
ZHZhbmNlZChJQ1VfSTE4Tl9MSUJSQVJZKQogICAgIGlmIChJQ1VfSTE4Tl9MSUJSQVJZKQogICAg
ICAgICBzZXQoSUNVX0kxOE5fRk9VTkQgMSkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>295185</attachid>
            <date>2016-11-18 13:31:43 -0800</date>
            <delta_ts>2016-11-30 09:39:53 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-164934-20161118133136.patch</filename>
            <type>text/plain</type>
            <size>1615</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwODg4
NCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTEx
LTE4ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5d
IEFwcGxlIGJ1aWxkIGlzIHVzaW5nIGluY29ycmVjdCBJQ1UgbGlicmFyeSAoaWYgcHJlc2VudCkK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDkzNAor
ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjkzMjk2NTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2V0IHJpZCBvZiB0aGUgJ2ljdXVjLmxpYicgYW5k
ICdpY3Vpbi5saWInIGxpYnJhcnkgbmFtZXMgd2hlbiBzZWFyY2hpbmcgZm9yIElDVS4KKyAgICAg
ICAgVGhleSBhcmUgbm90IHVzZWQgb24gYW55IHN1cHBvcnRlZCBidWlsZCB0YXJnZXRzLgorCisg
ICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRJQ1UuY21ha2U6CisKIDIwMTYtMTEtMTcgIFNhYW0g
QmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGFzeW5jL2F3YWl0
IGNvbXBpbGUgdGltZSBmbGFnIGFuZCBlbmFibGUgdGVzdHMKSW5kZXg6IFNvdXJjZS9jbWFrZS9G
aW5kSUNVLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9jbWFrZS9GaW5kSUNVLmNtYWtlCShy
ZXZpc2lvbiAyMDg4NjApCisrKyBTb3VyY2UvY21ha2UvRmluZElDVS5jbWFrZQkod29ya2luZyBj
b3B5KQpAQCAtMjUsNyArMjUsNyBAQCBtYXJrX2FzX2FkdmFuY2VkKElDVV9JTkNMVURFX0RJUikK
ICMgTG9vayBmb3IgdGhlIGxpYnJhcnkuCiBmaW5kX2xpYnJhcnkoCiAgICAgSUNVX0xJQlJBUlkK
LSAgICBOQU1FUyBpY3V1YyBsaWJpY3V1YyBjeWdpY3V1YyBjeWdpY3V1YzMyCisgICAgTkFNRVMg
bGliaWN1dWMgY3lnaWN1dWMgY3lnaWN1dWMzMgogICAgIEhJTlRTICR7UENfSUNVX0xJQlJBUllf
RElSU30KICAgICAgICAgICAke1BDX0lDVV9MSUJESVJ9CiAgICAgICAgICAgJHtXRUJLSVRfTElC
UkFSSUVTX0xJTktfRElSfQpAQCAtNTEsNyArNTEsNyBAQCBpZiAoSUNVX0lOQ0xVREVfRElSIEFO
RCBJQ1VfTElCUkFSWSkKICAgICBwa2dfY2hlY2tfbW9kdWxlcyhQQ19JQ1VfSTE4TiBpY3UtaTE4
bikKICAgICBmaW5kX2xpYnJhcnkoCiAgICAgICAgIElDVV9JMThOX0xJQlJBUlkKLSAgICAgICAg
TkFNRVMgaWN1aTE4biBpY3VpbiBsaWJpY3VpMThuIGxpYmljdWluIGN5Z2ljdWluIGN5Z2ljdWlu
MzIKKyAgICAgICAgTkFNRVMgaWN1aTE4biBsaWJpY3VpMThuIGxpYmljdWluIGN5Z2ljdWluIGN5
Z2ljdWluMzIKICAgICAgICAgSElOVFMgJHtQQ19JQ1VfSTE4Tl9MSUJSQVJZX0RJUlN9CiAgICAg
ICAgICAgICAgICR7UENfSUNVX0kxOE5fTElCRElSfQogICAgICAgICAgICAgICAke1dFQktJVF9M
SUJSQVJJRVNfTElOS19ESVJ9Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>295726</attachid>
            <date>2016-11-30 09:39:56 -0800</date>
            <delta_ts>2016-11-30 10:46:17 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-164934-20161130093929.patch</filename>
            <type>text/plain</type>
            <size>1689</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTEz
MSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTEx
LTMwICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5d
IEFwcGxlIGJ1aWxkIGlzIHVzaW5nIGluY29ycmVjdCBJQ1UgbGlicmFyeSAoaWYgcHJlc2VudCkK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDkzNAor
ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjkzMjk2NTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSB0aGUgJ2ljdXVjLmxpYicgYW5kICdpY3Vp
bi5saWInIGxpYnJhcnkgbmFtZXMgdG8gdGhlIGVuZCBvZiB0aGUgc2V0IG9mIGNob2ljZXMgd2hl
biBzZWFyY2hpbmcgZm9yIElDVS4KKyAgICAgICAgc28gdGhhdCB3ZSBwcmVmZXJlbnRpYWxseSBz
ZWxlY3QgdGhlICduZXcnIHZlcnNpb24gb2YgdGhlc2UgbGlicmFyaWVzIGlmIHRoZXkgYXJlIGF2
YWlsYWJsZS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kSUNVLmNtYWtlOgorCiAyMDE2
LTExLTIzICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBS
ZW1vdmUgRU5BQkxFX0FTU0VNQkxFUl9XWF9FWENMVVNJVkUgY29kZQpJbmRleDogU291cmNlL2Nt
YWtlL0ZpbmRJQ1UuY21ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2NtYWtlL0ZpbmRJQ1UuY21h
a2UJKHJldmlzaW9uIDIwOTEzMSkKKysrIFNvdXJjZS9jbWFrZS9GaW5kSUNVLmNtYWtlCSh3b3Jr
aW5nIGNvcHkpCkBAIC0yNSw3ICsyNSw3IEBAIG1hcmtfYXNfYWR2YW5jZWQoSUNVX0lOQ0xVREVf
RElSKQogIyBMb29rIGZvciB0aGUgbGlicmFyeS4KIGZpbmRfbGlicmFyeSgKICAgICBJQ1VfTElC
UkFSWQotICAgIE5BTUVTIGljdXVjIGxpYmljdXVjIGN5Z2ljdXVjIGN5Z2ljdXVjMzIKKyAgICBO
QU1FUyBsaWJpY3V1YyBjeWdpY3V1YyBjeWdpY3V1YzMyIGljdXVjCiAgICAgSElOVFMgJHtQQ19J
Q1VfTElCUkFSWV9ESVJTfQogICAgICAgICAgICR7UENfSUNVX0xJQkRJUn0KICAgICAgICAgICAk
e1dFQktJVF9MSUJSQVJJRVNfTElOS19ESVJ9CkBAIC01MSw3ICs1MSw3IEBAIGlmIChJQ1VfSU5D
TFVERV9ESVIgQU5EIElDVV9MSUJSQVJZKQogICAgIHBrZ19jaGVja19tb2R1bGVzKFBDX0lDVV9J
MThOIGljdS1pMThuKQogICAgIGZpbmRfbGlicmFyeSgKICAgICAgICAgSUNVX0kxOE5fTElCUkFS
WQotICAgICAgICBOQU1FUyBpY3VpMThuIGljdWluIGxpYmljdWkxOG4gbGliaWN1aW4gY3lnaWN1
aW4gY3lnaWN1aW4zMgorICAgICAgICBOQU1FUyBpY3VpMThuIGxpYmljdWkxOG4gbGliaWN1aW4g
Y3lnaWN1aW4gY3lnaWN1aW4zMiBpY3VpbgogICAgICAgICBISU5UUyAke1BDX0lDVV9JMThOX0xJ
QlJBUllfRElSU30KICAgICAgICAgICAgICAgJHtQQ19JQ1VfSTE4Tl9MSUJESVJ9CiAgICAgICAg
ICAgICAgICR7V0VCS0lUX0xJQlJBUklFU19MSU5LX0RJUn0K
</data>

          </attachment>
      

    </bug>

</bugzilla>