164933 2016-11-18 10:10:43 -0800 REGRESSION (r208865?): [mac-wk1] LayoutTest http/tests/misc/link-rel-icon-beforeload.html is failing 2026-01-06 13:32:42 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 ryanhaddad webkit-unassigned beidson ben_schwartz oldest_to_newest 1252714 0 ryanhaddad 2016-11-18 10:10:43 -0800 LayoutTest http/tests/misc/link-rel-icon-beforeload.html is failing https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK1%20(Tests)/r208884%20(19808)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fmisc%2Flink-rel-icon-beforeload.html --- /Volumes/Data/slave/yosemite-release-tests-wk1/build/layout-test-results/http/tests/misc/link-rel-icon-beforeload-expected.txt +++ /Volumes/Data/slave/yosemite-release-tests-wk1/build/layout-test-results/http/tests/misc/link-rel-icon-beforeload-actual.txt @@ -1,5 +1,5 @@ http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html - didFinishLoading http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html, main document URL http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html, http method GET> redirectResponse (null) http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html - didReceiveResponse <NSURLResponse http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html, http status code 200> -http://127.0.0.1:8000/favicon.ico - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/favicon.ico, main document URL http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html, http method GET> redirectResponse (null) +http://127.0.0.1:8000/misc/resources/favicon.ico - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/misc/resources/favicon.ico, main document URL http://127.0.0.1:8000/misc/link-rel-icon-beforeload.html, http method GET> redirectResponse (null) This test should not show a request for the favicon dont-load-this.ico, since the beforeload handler on the favicon link returns false. Therefore, if the resource request list below shows a request for dont-load-this.ico, then this test has failed. 1252716 1 ryanhaddad 2016-11-18 10:11:25 -0800 This appears to have regressed in this range: https://trac.webkit.org/log/?verbose=on&rev=208867&stop_rev=208863 1252738 2 ryanhaddad 2016-11-18 11:19:48 -0800 Of those changes, this seems like a contender: https://trac.webkit.org/changeset/208865 1252834 3 beidson 2016-11-18 13:53:11 -0800 Huh, EWS didn't catch this :( This is not an important regression and we should just skip for now. It will be an easy fix, but I can't do it right now. 1252843 4 ryanhaddad 2016-11-18 14:05:05 -0800 Marked test as failing on mac-wk1 in http://trac.webkit.org/projects/webkit/changeset/208896 1977436 5 ben_schwartz 2023-09-13 21:39:28 -0700 This appears to be fixed in a recent commit. Ryan please verify. 2169782 6 jbedard 2026-01-06 13:32:42 -0800 Test is now passing on WebKitLegacy