164907 2016-11-18 00:31:45 -0800 Add URL::hostAndPort() 2024-07-01 17:16:58 -0700 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned achristensen cdumez commit-queue darin esprehn+autocc gyuyoung.kim jurkuipers oldest_to_newest 1252628 0 cgarcia 2016-11-18 00:31:45 -0800 As a convenient way of getting the host and port (if any) as a string. This is already needed in a few places. 1252629 1 295141 cgarcia 2016-11-18 00:34:28 -0800 Created attachment 295141 Patch 1252679 2 295141 achristensen 2016-11-18 08:32:01 -0800 Comment on attachment 295141 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295141&action=review > Source/WebCore/html/URLUtils.h:132 > if (!url.port() || isDefaultPortForProtocol(url.port().value(), url.protocol())) > return url.host(); We can also remove this. The new URLParser will always remove the port if it's the default port for the protocol. Same with the check for hostEnd and pathStart. 1253209 3 cgarcia 2016-11-21 02:04:19 -0800 Committed r208945: <http://trac.webkit.org/changeset/208945> 2044101 4 frances_c 2024-07-01 17:16:58 -0700 *** Bug 17627 has been marked as a duplicate of this bug. *** 295141 2016-11-18 00:34:28 -0800 2016-11-18 08:32:01 -0800 Patch wcore-url-host-and-port.diff text/plain 4591 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5OTBlYTdlLi41MDAzNjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTYtMTEtMTggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIEFkZCBVUkw6Omhvc3RBbmRQb3J0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDkwNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIGEgY29udmVuaWVudCB3YXkgb2YgZ2V0dGlu ZyB0aGUgaG9zdCBhbmQgcG9ydCAoaWYgYW55KSBhcyBhIHN0cmluZy4KKworICAgICAgICAqIGh0 bWwvVVJMVXRpbHMuaDoKKyAgICAgICAgKFdlYkNvcmU6OlVSTFV0aWxzPFQ+Ojpob3N0KTogVXNl IFVSTDo6aG9zdEFuZFBvcnQoKS4KKyAgICAgICAgKiBwYWdlL0xvY2F0aW9uLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkxvY2F0aW9uOjpob3N0KTogRGl0dG8uCisgICAgICAgICogcGxhdGZvcm0v VVJMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlVSTDo6aG9zdEFuZFBvcnQpOiBSZXR1cm4gaG9z dDpwb3J0IG9yIGp1c3QgaG9zdCBpZiB0aGVyZSBpc24ndCBhIHBvcnQuCisgICAgICAgICogcGxh dGZvcm0vVVJMLmg6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9DcmVkZW50aWFsU3RvcmFn ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpvcmlnaW5TdHJpbmdGcm9tVVJMKTogVXNlIFVSTDo6 aG9zdEFuZFBvcnQoKS4KKyAgICAgICAgKiB3b3JrZXJzL1dvcmtlckxvY2F0aW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OldvcmtlckxvY2F0aW9uOjpob3N0KTogRGl0dG8uCisKIDIwMTYtMTEt MTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFJFR1JFU1NJT04ocjIwODUxMSk6IEltYWdlRGVjb2RlcnM6IENyYXNoIGRlY29kaW5nIEdJRiBp bWFnZXMgc2luY2UgcjIwODUxMQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9VUkxV dGlscy5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9VUkxVdGlscy5oCmluZGV4IDViYzYzNDEuLjVk OTY2ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvVVJMVXRpbHMuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL1VSTFV0aWxzLmgKQEAgLTEzMCw3ICsxMzAsNyBAQCBTdHJpbmcg VVJMVXRpbHM8VD46Omhvc3QoKSBjb25zdAogICAgICAgICByZXR1cm4gdXJsLmhvc3QoKTsKICAg ICBpZiAoIXVybC5wb3J0KCkgfHwgaXNEZWZhdWx0UG9ydEZvclByb3RvY29sKHVybC5wb3J0KCku dmFsdWUoKSwgdXJsLnByb3RvY29sKCkpKQogICAgICAgICByZXR1cm4gdXJsLmhvc3QoKTsKLSAg ICByZXR1cm4gdXJsLmhvc3QoKSArICc6JyArIFN0cmluZzo6bnVtYmVyKHVybC5wb3J0KCkudmFs dWUoKSk7CisgICAgcmV0dXJuIHVybC5ob3N0QW5kUG9ydCgpOwogfQogCiAvLyBUaGlzIGZ1bmN0 aW9uIGRvZXMgbm90IGFsbG93IGxlYWRpbmcgc3BhY2VzIGJlZm9yZSB0aGUgcG9ydCBudW1iZXIu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0xvY2F0aW9uLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvTG9jYXRpb24uY3BwCmluZGV4IGIwNmZhOGQuLjA3NmI3YzAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTG9jYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvTG9jYXRpb24uY3BwCkBAIC04Niw4ICs4Niw3IEBAIFN0cmluZyBMb2NhdGlvbjo6aG9z dCgpIGNvbnN0CiAKICAgICAvLyBOb3RlOiB0aGlzIGlzIHRoZSBJRSBzcGVjLiBUaGUgTlMgc3Bl YyBzd2FwcyB0aGUgdHdvLCBpdCBzYXlzCiAgICAgLy8gIlRoZSBob3N0bmFtZSBwcm9wZXJ0eSBp cyB0aGUgY29uY2F0ZW5hdGlvbiBvZiB0aGUgaG9zdCBhbmQgcG9ydCBwcm9wZXJ0aWVzLCBzZXBh cmF0ZWQgYnkgYSBjb2xvbi4iCi0gICAgY29uc3QgVVJMJiB1cmwgPSB0aGlzLT51cmwoKTsKLSAg ICByZXR1cm4gdXJsLnBvcnQoKSA/IHVybC5ob3N0KCkgKyAiOiIgKyBTdHJpbmc6Om51bWJlcih1 cmwucG9ydCgpLnZhbHVlKCkpIDogdXJsLmhvc3QoKTsKKyAgICByZXR1cm4gdXJsKCkuaG9zdEFu ZFBvcnQoKTsKIH0KIAogU3RyaW5nIExvY2F0aW9uOjpob3N0bmFtZSgpIGNvbnN0CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vVVJMLmNwcAppbmRleCBiOGQzZDg2Li5mMjYxYjg0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9VUkwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VS TC5jcHAKQEAgLTczMCw2ICs3MzAsMTMgQEAgT3B0aW9uYWw8dWludDE2X3Q+IFVSTDo6cG9ydCgp IGNvbnN0CiAgICAgcmV0dXJuIG51bWJlcjsKIH0KIAorU3RyaW5nIFVSTDo6aG9zdEFuZFBvcnQo KSBjb25zdAoreworICAgIGlmIChhdXRvIHBvcnQgPSB0aGlzLT5wb3J0KCkpCisgICAgICAgIHJl dHVybiBob3N0KCkgKyAnOicgKyBTdHJpbmc6Om51bWJlcihwb3J0LnZhbHVlKCkpOworICAgIHJl dHVybiBob3N0KCk7Cit9CisKIFN0cmluZyBVUkw6OnVzZXIoKSBjb25zdAogewogICAgIHJldHVy biBkZWNvZGVVUkxFc2NhcGVTZXF1ZW5jZXMobV9zdHJpbmcuc3Vic3RyaW5nKG1fdXNlclN0YXJ0 LCBtX3VzZXJFbmQgLSBtX3VzZXJTdGFydCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vVVJMLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkwuaAppbmRleCBkNjJh MjA3Li4wYzFiNzRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkwuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkwuaApAQCAtMTAzLDYgKzEwMyw3IEBAIHB1 YmxpYzoKICAgICBXRUJDT1JFX0VYUE9SVCBTdHJpbmdWaWV3IHByb3RvY29sKCkgY29uc3Q7CiAg ICAgV0VCQ09SRV9FWFBPUlQgU3RyaW5nIGhvc3QoKSBjb25zdDsKICAgICBXRUJDT1JFX0VYUE9S VCBPcHRpb25hbDx1aW50MTZfdD4gcG9ydCgpIGNvbnN0OworICAgIFdFQkNPUkVfRVhQT1JUIFN0 cmluZyBob3N0QW5kUG9ydCgpIGNvbnN0OwogICAgIFdFQkNPUkVfRVhQT1JUIFN0cmluZyB1c2Vy KCkgY29uc3Q7CiAgICAgV0VCQ09SRV9FWFBPUlQgU3RyaW5nIHBhc3MoKSBjb25zdDsKICAgICBX RUJDT1JFX0VYUE9SVCBTdHJpbmcgcGF0aCgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9DcmVkZW50aWFsU3RvcmFnZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL0NyZWRlbnRpYWxTdG9yYWdlLmNwcAppbmRleCBkNDkyMzZk Li44M2JiZjMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0Ny ZWRlbnRpYWxTdG9yYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L0NyZWRlbnRpYWxTdG9yYWdlLmNwcApAQCAtNDIsMTAgKzQyLDcgQEAgQ3JlZGVudGlhbFN0b3Jh Z2UmIENyZWRlbnRpYWxTdG9yYWdlOjpkZWZhdWx0Q3JlZGVudGlhbFN0b3JhZ2UoKQogCiBzdGF0 aWMgU3RyaW5nIG9yaWdpblN0cmluZ0Zyb21VUkwoY29uc3QgVVJMJiB1cmwpCiB7Ci0gICAgaWYg KHVybC5wb3J0KCkpCi0gICAgICAgIHJldHVybiBtYWtlU3RyaW5nKHVybC5wcm90b2NvbCgpLCAi Oi8vIiwgdXJsLmhvc3QoKSwgJzonLCBTdHJpbmc6Om51bWJlcih1cmwucG9ydCgpLnZhbHVlKCkp LCAnLycpOwotCi0gICAgcmV0dXJuIG1ha2VTdHJpbmcodXJsLnByb3RvY29sKCksICI6Ly8iLCB1 cmwuaG9zdCgpLCAnLycpOworICAgIHJldHVybiBtYWtlU3RyaW5nKHVybC5wcm90b2NvbCgpLCAi Oi8vIiwgdXJsLmhvc3RBbmRQb3J0KCksICcvJyk7CiB9CiAKIHN0YXRpYyBTdHJpbmcgcHJvdGVj dGlvblNwYWNlTWFwS2V5RnJvbVVSTChjb25zdCBVUkwmIHVybCkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyTG9jYXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvd29y a2Vycy9Xb3JrZXJMb2NhdGlvbi5jcHAKaW5kZXggMjE0YWM3NS4uZGVmNDFmZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJMb2NhdGlvbi5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJMb2NhdGlvbi5jcHAKQEAgLTQzLDcgKzQzLDcgQEAgU3Ry aW5nIFdvcmtlckxvY2F0aW9uOjpwcm90b2NvbCgpIGNvbnN0CiAKIFN0cmluZyBXb3JrZXJMb2Nh dGlvbjo6aG9zdCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIG1fdXJsLnBvcnQoKSA/IG1fdXJsLmhv c3QoKSArICI6IiArIFN0cmluZzo6bnVtYmVyKG1fdXJsLnBvcnQoKS52YWx1ZSgpKSA6IG1fdXJs Lmhvc3QoKTsKKyAgICByZXR1cm4gbV91cmwuaG9zdEFuZFBvcnQoKTsKIH0KIAogU3RyaW5nIFdv cmtlckxvY2F0aW9uOjpob3N0bmFtZSgpIGNvbnN0Cg==