164903 2016-11-17 19:31:11 -0800 TextDecoder constructor should not accept replacement encodings 2016-11-18 16:59:13 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen cdumez commit-queue dbates esprehn+autocc kangil.han oldest_to_newest 1252567 0 achristensen 2016-11-17 19:31:11 -0800 TextDecoder constructor should not accept replacement encodings 1252571 1 295126 achristensen 2016-11-17 19:34:15 -0800 Created attachment 295126 Patch 1252572 2 commit-queue 2016-11-17 19:37:07 -0800 Attachment 295126 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1252601 3 295134 achristensen 2016-11-17 21:27:08 -0800 Created attachment 295134 Patch 1252909 4 295134 cdumez 2016-11-18 15:42:56 -0800 Comment on attachment 295134 Patch r=me 1252959 5 achristensen 2016-11-18 16:59:13 -0800 http://trac.webkit.org/changeset/208909 295126 2016-11-17 19:34:15 -0800 2016-11-17 21:27:04 -0800 Patch bug-164903-20161117193414.patch text/plain 3555 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODg3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTExLTE3ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVGV4dERlY29k ZXIgY29uc3RydWN0b3Igc2hvdWxkIG5vdCBhY2NlcHQgcmVwbGFjZW1lbnQgZW5jb2RpbmdzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ5MDMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMgKE9PUFMhKS4KKworICAgICAgICAqIGRvbS9UZXh0RGVjb2Rlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpUZXh0RGVjb2Rlcjo6Y3JlYXRlKToKKwogMjAxNi0xMS0xNyAgQWxleCBDaHJpc3Rl bnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBXaW5DYWlybyBi dWlsZCBhZnRlciByMjA4NzQwCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vVGV4dERlY29kZXIu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9UZXh0RGVjb2Rlci5jcHAJKHJl dmlzaW9uIDIwODg3MikKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9UZXh0RGVjb2Rlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTM3LDcgKzM3LDcgQEAgRXhjZXB0aW9uT3I8UmVmPFRleHREZWNvZGVy Pj4gVGV4dERlY29kZQogICAgIGlmIChzdHJpcHBlZExhYmVsLmNvbnRhaW5zKG51bGxDaGFyYWN0 ZXIpKQogICAgICAgICByZXR1cm4gRXhjZXB0aW9uIHsgUmFuZ2VFcnJvciB9OwogICAgIGF1dG8g ZGVjb2RlciA9IGFkb3B0UmVmKCpuZXcgVGV4dERlY29kZXIoc3RyaXBwZWRMYWJlbC51dGY4KCku ZGF0YSgpLCBvcHRpb25zKSk7Ci0gICAgaWYgKCFkZWNvZGVyLT5tX3RleHRFbmNvZGluZy5pc1Zh bGlkKCkpCisgICAgaWYgKCFkZWNvZGVyLT5tX3RleHRFbmNvZGluZy5pc1ZhbGlkKCkgfHwgIXN0 cmNtcChkZWNvZGVyLT5tX3RleHRFbmNvZGluZy5uYW1lKCksICJyZXBsYWNlbWVudCIpKQogICAg ICAgICByZXR1cm4gRXhjZXB0aW9uIHsgUmFuZ2VFcnJvciB9OwogICAgIHJldHVybiBXVEZNb3Zl KGRlY29kZXIpOwogfQpJbmRleDogTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCShyZXZpc2lv biAyMDg4NzMpCisrKyBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTYtMTEtMTcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBUZXh0RGVjb2RlciBjb25zdHJ1Y3Rv ciBzaG91bGQgbm90IGFjY2VwdCByZXBsYWNlbWVudCBlbmNvZGluZ3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDkwMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2Vu Y29kaW5nL2FwaS1yZXBsYWNlbWVudC1lbmNvZGluZ3MtZXhwZWN0ZWQudHh0OgorCiAyMDE2LTEx LTE3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgSW1wbGVtZW50IFRleHREZWNvZGVyIGFuZCBUZXh0RW5jb2RlcgpJbmRleDogTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9lbmNvZGluZy9hcGktcmVwbGFjZW1l bnQtZW5jb2RpbmdzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9pbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2VuY29kaW5nL2FwaS1yZXBsYWNlbWVudC1lbmNv ZGluZ3MtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAyMDg4NzIpCisrKyBMYXlvdXRUZXN0cy9pbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2VuY29kaW5nL2FwaS1yZXBsYWNlbWVudC1lbmNv ZGluZ3MtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDggKzEsOCBAQAogCiBQQVNT IFRoZSAicmVwbGFjZW1lbnQiIGxhYmVsIHNob3VsZCBub3QgYmUgYSBrbm93biBlbmNvZGluZy4g Ci1GQUlMIExhYmVsIGZvciAicmVwbGFjZW1lbnQiIHNob3VsZCBiZSByZWplY3RlZCBieSBBUEk6 IGNzaXNvMjAyMmtyIGFzc2VydF90aHJvd3M6IGZ1bmN0aW9uICJmdW5jdGlvbiAoKSB7IG5ldyBU ZXh0RGVjb2RlcihsYWJlbCk7IH0iIGRpZCBub3QgdGhyb3cKLUZBSUwgTGFiZWwgZm9yICJyZXBs YWNlbWVudCIgc2hvdWxkIGJlIHJlamVjdGVkIGJ5IEFQSTogaHotZ2ItMjMxMiBhc3NlcnRfdGhy b3dzOiBmdW5jdGlvbiAiZnVuY3Rpb24gKCkgeyBuZXcgVGV4dERlY29kZXIobGFiZWwpOyB9IiBk aWQgbm90IHRocm93Ci1GQUlMIExhYmVsIGZvciAicmVwbGFjZW1lbnQiIHNob3VsZCBiZSByZWpl Y3RlZCBieSBBUEk6IGlzby0yMDIyLWNuIGFzc2VydF90aHJvd3M6IGZ1bmN0aW9uICJmdW5jdGlv biAoKSB7IG5ldyBUZXh0RGVjb2RlcihsYWJlbCk7IH0iIGRpZCBub3QgdGhyb3cKLUZBSUwgTGFi ZWwgZm9yICJyZXBsYWNlbWVudCIgc2hvdWxkIGJlIHJlamVjdGVkIGJ5IEFQSTogaXNvLTIwMjIt Y24tZXh0IGFzc2VydF90aHJvd3M6IGZ1bmN0aW9uICJmdW5jdGlvbiAoKSB7IG5ldyBUZXh0RGVj b2RlcihsYWJlbCk7IH0iIGRpZCBub3QgdGhyb3cKLUZBSUwgTGFiZWwgZm9yICJyZXBsYWNlbWVu dCIgc2hvdWxkIGJlIHJlamVjdGVkIGJ5IEFQSTogaXNvLTIwMjIta3IgYXNzZXJ0X3Rocm93czog ZnVuY3Rpb24gImZ1bmN0aW9uICgpIHsgbmV3IFRleHREZWNvZGVyKGxhYmVsKTsgfSIgZGlkIG5v dCB0aHJvdworUEFTUyBMYWJlbCBmb3IgInJlcGxhY2VtZW50IiBzaG91bGQgYmUgcmVqZWN0ZWQg YnkgQVBJOiBjc2lzbzIwMjJrciAKK1BBU1MgTGFiZWwgZm9yICJyZXBsYWNlbWVudCIgc2hvdWxk IGJlIHJlamVjdGVkIGJ5IEFQSTogaHotZ2ItMjMxMiAKK1BBU1MgTGFiZWwgZm9yICJyZXBsYWNl bWVudCIgc2hvdWxkIGJlIHJlamVjdGVkIGJ5IEFQSTogaXNvLTIwMjItY24gCitQQVNTIExhYmVs IGZvciAicmVwbGFjZW1lbnQiIHNob3VsZCBiZSByZWplY3RlZCBieSBBUEk6IGlzby0yMDIyLWNu LWV4dCAKK1BBU1MgTGFiZWwgZm9yICJyZXBsYWNlbWVudCIgc2hvdWxkIGJlIHJlamVjdGVkIGJ5 IEFQSTogaXNvLTIwMjIta3IgCiAK 295134 2016-11-17 21:27:08 -0800 2016-11-18 15:42:56 -0800 Patch bug-164903-20161117212702.patch text/plain 3889 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODg3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTExLTE3ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVGV4dERlY29k ZXIgY29uc3RydWN0b3Igc2hvdWxkIG5vdCBhY2NlcHQgcmVwbGFjZW1lbnQgZW5jb2RpbmdzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ5MDMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5 IG5ld2x5IHBhc3Npbmcgd2ViIHBsYXRmb3JtIHRlc3RzLgorCisgICAgICAgICogZG9tL1RleHRE ZWNvZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHREZWNvZGVyOjpjcmVhdGUpOgorICAg ICAgICBodHRwczovL2VuY29kaW5nLnNwZWMud2hhdHdnLm9yZy8jdGV4dGRlY29kZXIgc2F5cyBh Ym91dCB0aGUgY29uc3RydWN0b3I6CisgICAgICAgICJJZiBsYWJlbCBpcyBlaXRoZXIgbm90IGEg bGFiZWwgb3IgaXMgYSBsYWJlbCBmb3IgcmVwbGFjZW1lbnQsIHRocm93cyBhIFJhbmdlRXJyb3Iu IgorICAgICAgICBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 OTE4MCBmb3IgdGhlIG1hcHBpbmcgb2YgdGhlIHJlcGxhY2VtZW50CisgICAgICAgIGNvZGVjIG5h bWVzIHRvICJyZXBsYWNlbWVudCIuCisKIDIwMTYtMTEtMTcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggV2luQ2Fpcm8gYnVpbGQgYWZ0 ZXIgcjIwODc0MApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL1RleHREZWNvZGVyLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vVGV4dERlY29kZXIuY3BwCShyZXZpc2lvbiAy MDg4NzIpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vVGV4dERlY29kZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNyw3ICszNyw3IEBAIEV4Y2VwdGlvbk9yPFJlZjxUZXh0RGVjb2Rlcj4+IFRleHRE ZWNvZGUKICAgICBpZiAoc3RyaXBwZWRMYWJlbC5jb250YWlucyhudWxsQ2hhcmFjdGVyKSkKICAg ICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IFJhbmdlRXJyb3IgfTsKICAgICBhdXRvIGRlY29kZXIg PSBhZG9wdFJlZigqbmV3IFRleHREZWNvZGVyKHN0cmlwcGVkTGFiZWwudXRmOCgpLmRhdGEoKSwg b3B0aW9ucykpOwotICAgIGlmICghZGVjb2Rlci0+bV90ZXh0RW5jb2RpbmcuaXNWYWxpZCgpKQor ICAgIGlmICghZGVjb2Rlci0+bV90ZXh0RW5jb2RpbmcuaXNWYWxpZCgpIHx8ICFzdHJjbXAoZGVj b2Rlci0+bV90ZXh0RW5jb2RpbmcubmFtZSgpLCAicmVwbGFjZW1lbnQiKSkKICAgICAgICAgcmV0 dXJuIEV4Y2VwdGlvbiB7IFJhbmdlRXJyb3IgfTsKICAgICByZXR1cm4gV1RGTW92ZShkZWNvZGVy KTsKIH0KSW5kZXg6IExheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwkocmV2aXNpb24gMjA4ODcz KQorKysgTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDE2LTExLTE3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVGV4dERlY29kZXIgY29uc3RydWN0b3Igc2hvdWxk IG5vdCBhY2NlcHQgcmVwbGFjZW1lbnQgZW5jb2RpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ5MDMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9lbmNvZGluZy9h cGktcmVwbGFjZW1lbnQtZW5jb2RpbmdzLWV4cGVjdGVkLnR4dDoKKwogMjAxNi0xMS0xNyAgQWxl eCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEltcGxl bWVudCBUZXh0RGVjb2RlciBhbmQgVGV4dEVuY29kZXIKSW5kZXg6IExheW91dFRlc3RzL2ltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZW5jb2RpbmcvYXBpLXJlcGxhY2VtZW50LWVuY29k aW5ncy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9lbmNvZGluZy9hcGktcmVwbGFjZW1lbnQtZW5jb2RpbmdzLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMjA4ODcyKQorKysgTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9lbmNvZGluZy9hcGktcmVwbGFjZW1lbnQtZW5jb2RpbmdzLWV4 cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw4ICsxLDggQEAKIAogUEFTUyBUaGUgInJl cGxhY2VtZW50IiBsYWJlbCBzaG91bGQgbm90IGJlIGEga25vd24gZW5jb2RpbmcuIAotRkFJTCBM YWJlbCBmb3IgInJlcGxhY2VtZW50IiBzaG91bGQgYmUgcmVqZWN0ZWQgYnkgQVBJOiBjc2lzbzIw MjJrciBhc3NlcnRfdGhyb3dzOiBmdW5jdGlvbiAiZnVuY3Rpb24gKCkgeyBuZXcgVGV4dERlY29k ZXIobGFiZWwpOyB9IiBkaWQgbm90IHRocm93Ci1GQUlMIExhYmVsIGZvciAicmVwbGFjZW1lbnQi IHNob3VsZCBiZSByZWplY3RlZCBieSBBUEk6IGh6LWdiLTIzMTIgYXNzZXJ0X3Rocm93czogZnVu Y3Rpb24gImZ1bmN0aW9uICgpIHsgbmV3IFRleHREZWNvZGVyKGxhYmVsKTsgfSIgZGlkIG5vdCB0 aHJvdwotRkFJTCBMYWJlbCBmb3IgInJlcGxhY2VtZW50IiBzaG91bGQgYmUgcmVqZWN0ZWQgYnkg QVBJOiBpc28tMjAyMi1jbiBhc3NlcnRfdGhyb3dzOiBmdW5jdGlvbiAiZnVuY3Rpb24gKCkgeyBu ZXcgVGV4dERlY29kZXIobGFiZWwpOyB9IiBkaWQgbm90IHRocm93Ci1GQUlMIExhYmVsIGZvciAi cmVwbGFjZW1lbnQiIHNob3VsZCBiZSByZWplY3RlZCBieSBBUEk6IGlzby0yMDIyLWNuLWV4dCBh c3NlcnRfdGhyb3dzOiBmdW5jdGlvbiAiZnVuY3Rpb24gKCkgeyBuZXcgVGV4dERlY29kZXIobGFi ZWwpOyB9IiBkaWQgbm90IHRocm93Ci1GQUlMIExhYmVsIGZvciAicmVwbGFjZW1lbnQiIHNob3Vs ZCBiZSByZWplY3RlZCBieSBBUEk6IGlzby0yMDIyLWtyIGFzc2VydF90aHJvd3M6IGZ1bmN0aW9u ICJmdW5jdGlvbiAoKSB7IG5ldyBUZXh0RGVjb2RlcihsYWJlbCk7IH0iIGRpZCBub3QgdGhyb3cK K1BBU1MgTGFiZWwgZm9yICJyZXBsYWNlbWVudCIgc2hvdWxkIGJlIHJlamVjdGVkIGJ5IEFQSTog Y3Npc28yMDIya3IgCitQQVNTIExhYmVsIGZvciAicmVwbGFjZW1lbnQiIHNob3VsZCBiZSByZWpl Y3RlZCBieSBBUEk6IGh6LWdiLTIzMTIgCitQQVNTIExhYmVsIGZvciAicmVwbGFjZW1lbnQiIHNo b3VsZCBiZSByZWplY3RlZCBieSBBUEk6IGlzby0yMDIyLWNuIAorUEFTUyBMYWJlbCBmb3IgInJl cGxhY2VtZW50IiBzaG91bGQgYmUgcmVqZWN0ZWQgYnkgQVBJOiBpc28tMjAyMi1jbi1leHQgCitQ QVNTIExhYmVsIGZvciAicmVwbGFjZW1lbnQiIHNob3VsZCBiZSByZWplY3RlZCBieSBBUEk6IGlz by0yMDIyLWtyIAogCg==