164868 2016-11-17 08:09:49 -0800 CryptoKeyPair objects should be dictionaries - and not a distinct object type - making them structured cloneable 2016-12-07 11:41:27 -0800 1 1 1 Unclassified WebKit WebCore Misc. Safari Technology Preview Unspecified Unspecified RESOLVED DUPLICATE 165367 InRadar P2 Normal --- 160880 1 jason.mei webkit-unassigned ap beidson jason.mei jiewen_tan webkit-bug-importer oldest_to_newest 1252294 0 295050 jason.mei 2016-11-17 08:09:49 -0800 Created attachment 295050 stand alone html that shows the problem There is a problem adding the CryptoKeyPair object into indexedDB. I have attached a html test case that shows this problem. This code works in Chrome and Firefox. Neither browser returns a CryptoKeyPair, and instead returns a plain object. 1252313 1 webkit-bug-importer 2016-11-17 09:38:55 -0800 <rdar://problem/29312605> 1252350 2 beidson 2016-11-17 11:21:00 -0800 > This code works in Chrome and Firefox. but then > Neither browser returns a CryptoKeyPair, and instead returns a plain object. This makes no sense to me. If it truly works, it would have to also *return* a CryptoKeyPair. Are you sure CryptoKeyPair is actually serializable WRT the structured clone algorithm? (I haven't looked into it yet) 1252353 3 beidson 2016-11-17 11:22:30 -0800 (In reply to comment #2) > > This code works in Chrome and Firefox. > > but then > > > Neither browser returns a CryptoKeyPair, and instead returns a plain object. > > This makes no sense to me. > If it truly works, it would have to also *return* a CryptoKeyPair. > > Are you sure CryptoKeyPair is actually serializable WRT the structured clone > algorithm? > > (I haven't looked into it yet) The error we throw: DataCloneError "An object could not be cloned" This strongly suggests that CryptoKeyPairs are not structured cloneable, and therefore are not allowed to be stored in IDB 1252354 4 beidson 2016-11-17 11:28:37 -0800 Also, you state this is a regression, but it is not: Safari 9 also shows the DataCloneError 1252367 5 beidson 2016-11-17 11:38:17 -0800 The current spec for WebCrypto: https://w3c.github.io/webcrypto/Overview.html#cryptokey-interface-clone Specifies the Structured Clone Algorithm for "CryptoKey" objects. It does *not* specify the Structured Clone Algorithm for "CryptoKeyPair" objects. Additionally, the WebCrypto spec explicitly calls out the fact that CryptoKeys should be storable in IndexedDB, but not CryptoKeyPairs. 1252371 6 beidson 2016-11-17 11:39:13 -0800 Basically, until somebody finds a standard that specifies the Structured Clone Algorithm for CryptoKeyPair objects, they absolutely should not be storable in IndexedDB. 1252377 7 beidson 2016-11-17 11:44:06 -0800 I believe the reason Chrome and Firefox allow the put is that they do not recognize the CryptoKeyPair as a "CryptoKeyPair" - They think it's an "Object" And "Objects" are structured cloneable as long as each of their properties are. 1252378 8 beidson 2016-11-17 11:46:42 -0800 (In reply to comment #7) > I believe the reason Chrome and Firefox allow the put is that they do not > recognize the CryptoKeyPair as a "CryptoKeyPair" - They think it's an > "Object" > > And "Objects" are structured cloneable as long as each of their properties > are. Got it. At one point in the history of the spec, CryptoKeyPair objects were their own interface, therefore their own explicit object type. Now they're just an object dictionary (https://w3c.github.io/webcrypto/Overview.html#keypair), which means they are an "Object", which means they are structured cloneable 1252379 9 beidson 2016-11-17 11:47:06 -0800 (In reply to comment #8) > (In reply to comment #7) > > I believe the reason Chrome and Firefox allow the put is that they do not > > recognize the CryptoKeyPair as a "CryptoKeyPair" - They think it's an > > "Object" > > > > And "Objects" are structured cloneable as long as each of their properties > > are. > > Got it. > > At one point in the history of the spec, CryptoKeyPair objects were their > own interface, therefore their own explicit object type. > > Now they're just an object dictionary > (https://w3c.github.io/webcrypto/Overview.html#keypair), which means they > are an "Object", which means they are structured cloneable Fixing this is just a matter of fixing our IDL situation for CryptoKeyPair. 1255869 10 beidson 2016-12-02 13:57:35 -0800 This will be resolved as part of https://bugs.webkit.org/show_bug.cgi?id=163711 *** This bug has been marked as a duplicate of bug 163711 *** 1255933 11 jiewen_tan 2016-12-02 15:33:50 -0800 We need a specific hack for this as Bug 163711 will not be resolved in a short term. 1257291 12 jiewen_tan 2016-12-07 11:41:27 -0800 *** This bug has been marked as a duplicate of bug 165367 *** 295050 2016-11-17 08:09:49 -0800 2016-11-17 08:09:49 -0800 stand alone html that shows the problem crypto-safari-test.html text/html 3725 jason.mei PCFET0NUWVBFIGh0bWw+DQo8aHRtbCBsYW5nPSJlbiI+DQo8aGVhZD4NCiAgICA8bWV0YSBjaGFy c2V0PSJVVEYtOCI+DQogICAgPHRpdGxlPlN0b3JlIFJTQSBrZXlwYWlyIGluIEluZGV4ZWREQjwv dGl0bGU+DQogICAgPHNjcmlwdD4NCiAgICAgICAgdmFyIF9pZGIgPSB3aW5kb3cuaW5kZXhlZERC Ow0KICAgICAgICB2YXIgX2RiID0gbnVsbDsNCiAgICAgICAgdmFyIF90ZXN0REIgPSAiUlNBX1Rl c3REQiI7DQogICAgICAgIHZhciBfdGVzdFN0b3JlID0gInJzYWtleXMiOw0KDQogICAgICAgIHZh ciBDID0gZnVuY3Rpb24oKSB7DQogICAgICAgICAgICBpZiAoIWNyeXB0bykgew0KICAgICAgICAg ICAgICAgIGFsZXJ0KCJDcnlwdG8gbm90IHN1cHBvcnRlZCIpOw0KICAgICAgICAgICAgfQ0KICAg ICAgICAgICAgaWYgKGNyeXB0by53ZWJraXRTdWJ0bGUpIHsNCiAgICAgICAgICAgICAgICByZXR1 cm4gY3J5cHRvLndlYmtpdFN1YnRsZTsNCiAgICAgICAgICAgIH0NCiAgICAgICAgICAgIGVsc2Ug ew0KICAgICAgICAgICAgICAgIHJldHVybiBjcnlwdG8uc3VidGxlOw0KICAgICAgICAgICAgfQ0K ICAgICAgICB9Ow0KDQogICAgICAgIGZ1bmN0aW9uIGdlbmVyYXRlS2V5UGFpcigpIHsNCiAgICAg ICAgICAgIHZhciBhbGdvID0gew0KICAgICAgICAgICAgICAgIG5hbWU6ICJSU0EtT0FFUCIsDQog ICAgICAgICAgICAgICAgbW9kdWx1c0xlbmd0aDogMjA0OCwNCiAgICAgICAgICAgICAgICBwdWJs aWNFeHBvbmVudDogbmV3IFVpbnQ4QXJyYXkoWzB4MDEsIDB4MDAsIDB4MDFdKSwNCiAgICAgICAg ICAgICAgICBoYXNoOiB7bmFtZTogIlNIQS0xIn0NCiAgICAgICAgICAgIH07DQoNCiAgICAgICAg ICAgIHZhciBnZW5lcmF0ZSA9IGZ1bmN0aW9uIChyZXNvbHZlLCByZWplY3QpIHsNCiAgICAgICAg ICAgICAgICBDKCkuZ2VuZXJhdGVLZXkoYWxnbywgZmFsc2UsIFsiZW5jcnlwdCIsICJkZWNyeXB0 Il0pLnRoZW4oZnVuY3Rpb24gKGtleVBhaXIpIHsNCiAgICAgICAgICAgICAgICAgICAgcmVzb2x2 ZShrZXlQYWlyKTsNCiAgICAgICAgICAgICAgICB9KS5jYXRjaChmdW5jdGlvbiAoZXJyb3IpIHsN CiAgICAgICAgICAgICAgICAgICAgcmVqZWN0KGVycm9yKTsNCiAgICAgICAgICAgICAgICB9KTsN CiAgICAgICAgICAgIH07DQogICAgICAgICAgICByZXR1cm4gbmV3IFByb21pc2UoZ2VuZXJhdGUp Ow0KICAgICAgICB9DQoNCiAgICAgICAgZnVuY3Rpb24gb3BlbkRCKHJlc29sdmUsIHJlamVjdCkg ew0KICAgICAgICAgICAgaWYgKF9kYikgew0KICAgICAgICAgICAgICAgIHJlc29sdmUodHJ1ZSk7 DQogICAgICAgICAgICB9DQoNCiAgICAgICAgICAgIHZhciByZXEgPSBfaWRiLm9wZW4oX3Rlc3RE QiwgMSk7DQogICAgICAgICAgICByZXEub25zdWNjZXNzID0gZnVuY3Rpb24gKGV2ZW50KSB7DQog ICAgICAgICAgICAgICAgX2RiID0gZXZlbnQudGFyZ2V0LnJlc3VsdDsNCiAgICAgICAgICAgICAg ICByZXNvbHZlKHRydWUpOw0KICAgICAgICAgICAgfTsNCiAgICAgICAgICAgIHJlcS5vbmVycm9y ID0gZnVuY3Rpb24gKCkgew0KICAgICAgICAgICAgICAgIHJlamVjdChyZXEuZXJyb3IpOw0KICAg ICAgICAgICAgfTsNCg0KICAgICAgICAgICAgcmVxLm9uYmxvY2tlZCA9IGZ1bmN0aW9uICgpIHsN CiAgICAgICAgICAgICAgICByZWplY3QobmV3IEVycm9yKCJEQiBpcyBibG9ja2VkLCB1bmFibGUg dG8gb3BlbiAiKSk7DQogICAgICAgICAgICB9Ow0KDQogICAgICAgICAgICByZXEub251cGdyYWRl bmVlZGVkID0gZnVuY3Rpb24oZXZlbnQpIHsNCiAgICAgICAgICAgICAgICBfZGIgPSBldmVudC50 YXJnZXQucmVzdWx0Ow0KICAgICAgICAgICAgICAgIHZhciBvcHRzID0gew0KICAgICAgICAgICAg ICAgICAgICBrZXlQYXRoOiAia2V5IiwNCiAgICAgICAgICAgICAgICAgICAgYXV0b0luY3JlbWVu dDogZmFsc2UNCiAgICAgICAgICAgICAgICB9Ow0KDQogICAgICAgICAgICAgICAgdmFyIHN0b3Jl ID0gX2RiLmNyZWF0ZU9iamVjdFN0b3JlKF90ZXN0U3RvcmUsIG9wdHMpOw0KICAgICAgICAgICAg ICAgIGlmICghc3RvcmUpIHsNCiAgICAgICAgICAgICAgICAgICAgLy9ub2luc3BlY3Rpb24gRXhj ZXB0aW9uQ2F1Z2h0TG9jYWxseUpTDQogICAgICAgICAgICAgICAgICAgIHRocm93IG5ldyBFcnJv cigiU3RvcmUgY3JlYXRpb24gcmV0dXJuZWQgbnVsbCIpOw0KICAgICAgICAgICAgICAgIH0NCiAg ICAgICAgICAgICAgICByZXNvbHZlKHRydWUpOw0KICAgICAgICAgICAgfQ0KICAgICAgICB9DQoN CiAgICAgICAgZnVuY3Rpb24gcHV0KGtleVBhaXIpIHsNCiAgICAgICAgICAgIHZhciBzdG9yZUtl eVBhaXIgPSBmdW5jdGlvbihyZXNvbHZlLCByZWplY3QpIHsNCiAgICAgICAgICAgICAgICB2YXIg dHggPSBfZGIudHJhbnNhY3Rpb24oW190ZXN0U3RvcmVdLCAicmVhZHdyaXRlIik7DQogICAgICAg ICAgICAgICAgdHgub25jb21wbGV0ZSA9IGZ1bmN0aW9uICgpIHsNCiAgICAgICAgICAgICAgICAg ICAgcmVzb2x2ZSh0cnVlKTsNCiAgICAgICAgICAgICAgICB9Ow0KICAgICAgICAgICAgICAgIHR4 Lm9uYWJvcnQgPSBmdW5jdGlvbiAoKSB7DQogICAgICAgICAgICAgICAgICAgIHJlamVjdCh0eC5l cnJvcik7DQogICAgICAgICAgICAgICAgfTsNCiAgICAgICAgICAgICAgICB0eC5vbmVycm9yID0g ZnVuY3Rpb24gKCkgew0KICAgICAgICAgICAgICAgICAgICByZWplY3QodHguZXJyb3IpOw0KICAg ICAgICAgICAgICAgIH07DQoNCiAgICAgICAgICAgICAgICB2YXIgc3RvcmUgPSB0eC5vYmplY3RT dG9yZShfdGVzdFN0b3JlKTsNCiAgICAgICAgICAgICAgICBrZXlQYWlyLmtleT0xOw0KICAgICAg ICAgICAgICAgIC8qcmV0dXJuIHN0b3JlLnB1dCh7DQogICAgICAgICAgICAgICAgICAgIGtleSA6 IDEsDQogICAgICAgICAgICAgICAgICAgIHB1YmtleSA6IGtleVBhaXIucHVibGljS2V5LA0KICAg ICAgICAgICAgICAgICAgICBwcml2a2V5IDoga2V5UGFpci5wcml2YXRlS2V5DQogICAgICAgICAg ICAgICAgfSk7Ki8NCg0KICAgICAgICAgICAgICAgIHJldHVybiBzdG9yZS5wdXQoa2V5UGFpcik7 DQogICAgICAgICAgICB9Ow0KDQogICAgICAgICAgICByZXR1cm4gbmV3IFByb21pc2Uoc3RvcmVL ZXlQYWlyKTsNCiAgICAgICAgfQ0KDQogICAgICAgIGZ1bmN0aW9uIHRlc3QoKSB7DQogICAgICAg ICAgICByZXR1cm4gbmV3IFByb21pc2Uob3BlbkRCKS50aGVuKGZ1bmN0aW9uKCkgew0KICAgICAg ICAgICAgICAgIHJldHVybiBnZW5lcmF0ZUtleVBhaXIoKTsNCiAgICAgICAgICAgIH0pLnRoZW4o ZnVuY3Rpb24oa2V5cGFpcikgew0KICAgICAgICAgICAgICAgIHJldHVybiBwdXQoa2V5cGFpcik7 DQogICAgICAgICAgICB9KS50aGVuKGZ1bmN0aW9uKCkgew0KICAgICAgICAgICAgICAgIGFsZXJ0 KCJ3b3JrcyEiKTsNCiAgICAgICAgICAgIH0pLmNhdGNoKGZ1bmN0aW9uKGVycm9yKSB7DQogICAg ICAgICAgICAgICAgYWxlcnQoImZhaWxzIHdpdGggZXJyb3IgIiArIChlcnJvciA/IGVycm9yLm1l c3NhZ2UgfHwgZXJyb3IubmFtZSB8fCBlcnJvciA6ICIodW5rbm93bikiKSk7DQogICAgICAgICAg ICB9KTsNCiAgICAgICAgfQ0KICAgIDwvc2NyaXB0Pg0KPC9oZWFkPg0KPGJvZHk+DQo8YnV0dG9u IGlkPSJ0ZXN0IiBvbmNsaWNrPSJ0ZXN0KCkiPlRlc3QgUlNBIGFuZCBJbmRleGVkREI8L2J1dHRv bj4NCjwvYm9keT4NCjwvaHRtbD4=