164862 2016-11-17 02:32:48 -0800 [Win32] Start releasing memory earlier when memory is running low. 2016-11-18 02:03:28 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue webkit-bug-importer oldest_to_newest 1252261 0 pvollan 2016-11-17 02:32:48 -0800 On Windows, 32-bit processes have 2GB of memory available, where some is used by the system. Debugging has shown that allocations might fail and cause crashes when memory usage is > ~1GB. We should start releasing memory before we reach 1GB. 1252262 1 295043 pvollan 2016-11-17 02:36:29 -0800 Created attachment 295043 Patch 1252274 2 pvollan 2016-11-17 04:24:27 -0800 <rdar://problem/27988989> 1252317 3 295043 bfulgham 2016-11-17 09:59:09 -0800 Comment on attachment 295043 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295043&action=review r=me > Source/WebCore/platform/win/MemoryPressureHandlerWin.cpp:77 > + const int maxMemoryUsageBytes = 0.9 * 1024 * 1024 * 1024; So we trigger clean-up about 10% earlier than before? Seems reasonable. Would it make sense to convert this from a floating point calculation to just hard-coding the actual integer value that results from this math? 1252632 4 pvollan 2016-11-18 01:43:52 -0800 (In reply to comment #3) > Comment on attachment 295043 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295043&action=review > > r=me > > > Source/WebCore/platform/win/MemoryPressureHandlerWin.cpp:77 > > + const int maxMemoryUsageBytes = 0.9 * 1024 * 1024 * 1024; > > So we trigger clean-up about 10% earlier than before? Seems reasonable. > > Would it make sense to convert this from a floating point calculation to > just hard-coding the actual integer value that results from this math? I checked the generated code, and the compiler will optimize this. Just let me know if you still want me to change it :) Thanks for reviewing! 1252633 5 295043 commit-queue 2016-11-18 02:03:24 -0800 Comment on attachment 295043 Patch Clearing flags on attachment: 295043 Committed r208883: <http://trac.webkit.org/changeset/208883> 1252634 6 commit-queue 2016-11-18 02:03:28 -0800 All reviewed patches have been landed. Closing bug. 295043 2016-11-17 02:36:29 -0800 2016-11-18 02:03:24 -0800 Patch bug-164862-20161117023623.patch text/plain 1724 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODg0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTExLTE3ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luMzJdIFN0YXJ0IHJl bGVhc2luZyBtZW1vcnkgZWFybGllciB3aGVuIG1lbW9yeSBpcyBydW5uaW5nIGxvdy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDg2MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIFdpbmRvd3MsIDMy LWJpdCBwcm9jZXNzZXMgaGF2ZSAyR0Igb2YgbWVtb3J5IGF2YWlsYWJsZSwgd2hlcmUgc29tZSBp cyB1c2VkIGJ5IHRoZSBzeXN0ZW0uCisgICAgICAgIERlYnVnZ2luZyBoYXMgc2hvd24gdGhhdCBh bGxvY2F0aW9ucyBtaWdodCBmYWlsIGFuZCBjYXVzZSBjcmFzaGVzIHdoZW4gbWVtb3J5IHVzYWdl IGlzID4gfjFHQi4KKyAgICAgICAgV2Ugc2hvdWxkIHN0YXJ0IHJlbGVhc2luZyBtZW1vcnkgYmVm b3JlIHdlIHJlYWNoIDFHQi4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9NZW1vcnlQcmVzc3Vy ZUhhbmRsZXJXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2hlY2tNZW1vcnlUaW1lcjo6Zmly ZWQpOgorCiAyMDE2LTExLTE3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZSBhc3luYy9hd2FpdCBjb21waWxlIHRpbWUgZmxhZyBhbmQgZW5hYmxlIHRl c3RzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vTWVtb3J5UHJlc3N1cmVIYW5k bGVyV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vTWVt b3J5UHJlc3N1cmVIYW5kbGVyV2luLmNwcAkocmV2aXNpb24gMjA4ODQzKQorKysgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vd2luL01lbW9yeVByZXNzdXJlSGFuZGxlcldpbi5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTczLDcgKzczLDggQEAgdm9pZCBDaGVja01lbW9yeVRpbWVyOjpmaXJlZCgpCiAK ICAgICAvLyBPbiBXaW5kb3dzLCAzMi1iaXQgcHJvY2Vzc2VzIGhhdmUgMkdCIG9mIG1lbW9yeSBh dmFpbGFibGUsIHdoZXJlIHNvbWUgaXMgdXNlZCBieSB0aGUgc3lzdGVtLgogICAgIC8vIERlYnVn Z2luZyBoYXMgc2hvd24gdGhhdCBhbGxvY2F0aW9ucyBtaWdodCBmYWlsIGFuZCBjYXVzZSBjcmFz aGVzIHdoZW4gbWVtb3J5IHVzYWdlIGlzID4gfjFHQi4KLSAgICBjb25zdCBpbnQgbWF4TWVtb3J5 VXNhZ2VCeXRlcyA9IDEwMjQgKiAxMDI0ICogMTAyNDsKKyAgICAvLyBXZSBzaG91bGQgc3RhcnQg cmVsZWFzaW5nIG1lbW9yeSBiZWZvcmUgd2UgcmVhY2ggMUdCLgorICAgIGNvbnN0IGludCBtYXhN ZW1vcnlVc2FnZUJ5dGVzID0gMC45ICogMTAyNCAqIDEwMjQgKiAxMDI0OwogCiAgICAgaWYgKGNv dW50ZXJzLlByaXZhdGVVc2FnZSA+IG1heE1lbW9yeVVzYWdlQnl0ZXMpCiAgICAgICAgIGhhbmRs ZU1lbW9yeUxvdygpOwo=