164858 2016-11-17 01:03:51 -0800 [JSC] Specifying same module entry point multiple times cause TypeError 2016-11-30 19:56:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 147340 1 ysuzuki ysuzuki commit-queue keith_miller mark.lam msaboff rniwa saam oldest_to_newest 1252251 0 ysuzuki 2016-11-17 01:03:51 -0800 If you request the same module entry point to evaluate multiple times, JSC raises Type error. Now, the current loader API spec becomes abandoned. We can just modify our loader to fit to the whatwg's HTML's ES6 modules. 1254721 1 295707 ysuzuki 2016-11-30 00:51:33 -0800 Created attachment 295707 Patch 1255127 2 295707 saam 2016-11-30 19:33:16 -0800 Comment on attachment 295707 Patch r=me 1255131 3 ysuzuki 2016-11-30 19:56:36 -0800 Committed r209172: <http://trac.webkit.org/changeset/209172> 295707 2016-11-30 00:51:33 -0800 2016-11-30 19:33:16 -0800 Patch bug-164858-20161130175106.patch text/plain 6162 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw OTY3ZjgwODc3NWJlYjcxMGE3ZGFhYjE4ZjgyYmYxNWI0ZDU2Zjc1Li5hZTNlMzYxOGUwZTIzN2Q0 NTQ5ZjFjMDVhZjlhMTNlNjZlYzMzZGNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0xMS0zMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBTcGVjaWZ5aW5nIHNhbWUgbW9kdWxlIGVudHJ5IHBvaW50 IG11bHRpcGxlIHRpbWVzIGNhdXNlIFR5cGVFcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0ODU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgaW1wb3J0aW5nIHRoZSBzYW1lIG1vZHVsZSBt dWx0aXBsZSB0aW1lcy4gUHJldmlvdXNseSwgd2hlbiBzcGVjaWZ5aW5nIHRoZSBzYW1lCisgICAg ICAgIG1vZHVsZSBpbiB0aGUgPHNjcmlwdCB0eXBlPSJtb2R1bGUiIHNyYz0iaGVyZSI+LCBpdCB0 aHJvd3MgVHlwZUVycm9yLgorCisgICAgICAgICogYnVpbHRpbnMvTW9kdWxlTG9hZGVyUHJvdG90 eXBlLmpzOgorICAgICAgICAocmVxdWVzdEZldGNoKToKKyAgICAgICAgKHJlcXVlc3RUcmFuc2xh dGUpOgorICAgICAgICAocmVxdWVzdEluc3RhbnRpYXRlKToKKyAgICAgICAgKHJlcXVlc3RTYXRp c2Z5KToKKwogMjAxNi0xMS0yOSAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViQXNzZW1ibHkgSlMgQVBJOiBpbXByb3ZlIEluc3RhbmNlCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvTW9kdWxlTG9hZGVyUHJvdG90eXBlLmpz IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL01vZHVsZUxvYWRlclByb3RvdHlwZS5q cwppbmRleCAwYTk4MjU4NjBiMzIxMzc0NTQxZTNhNWQ5NTYyOTc0ZDRjYjA5ZmEyLi4wNjNiMmM5 MGRjNDQ0ZDNmYzY0MWNmZjZjNDdkNWNlY2U1Y2NkNTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnVpbHRpbnMvTW9kdWxlTG9hZGVyUHJvdG90eXBlLmpzCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9Nb2R1bGVMb2FkZXJQcm90b3R5cGUuanMKQEAgLTIz MCwxMiArMjMwLDYgQEAgZnVuY3Rpb24gcmVxdWVzdEZldGNoKGtleSwgaW5pdGlhdG9yKQogICAg ICJ1c2Ugc3RyaWN0IjsKIAogICAgIHZhciBlbnRyeSA9IHRoaXMuZW5zdXJlUmVnaXN0ZXJlZChr ZXkpOwotICAgIGlmIChlbnRyeS5zdGF0ZSA+IEBNb2R1bGVMaW5rKSB7Ci0gICAgICAgIHZhciBk ZWZlcnJlZCA9IEBuZXdQcm9taXNlQ2FwYWJpbGl0eShASW50ZXJuYWxQcm9taXNlKTsKLSAgICAg ICAgZGVmZXJyZWQuQHJlamVjdC5AY2FsbChAdW5kZWZpbmVkLCBuZXcgQFR5cGVFcnJvcigiUmVx dWVzdGVkIG1vZHVsZSBpcyBhbHJlYWR5IHJlYWR5IHRvIGJlIGV4ZWN1dGVkLiIpKTsKLSAgICAg ICAgcmV0dXJuIGRlZmVycmVkLkBwcm9taXNlOwotICAgIH0KLQogICAgIGlmIChlbnRyeS5mZXRj aCkKICAgICAgICAgcmV0dXJuIGVudHJ5LmZldGNoOwogCkBAIC0yNjAsMTIgKzI1NCw2IEBAIGZ1 bmN0aW9uIHJlcXVlc3RUcmFuc2xhdGUoa2V5LCBpbml0aWF0b3IpCiAgICAgInVzZSBzdHJpY3Qi OwogCiAgICAgdmFyIGVudHJ5ID0gdGhpcy5lbnN1cmVSZWdpc3RlcmVkKGtleSk7Ci0gICAgaWYg KGVudHJ5LnN0YXRlID4gQE1vZHVsZUxpbmspIHsKLSAgICAgICAgdmFyIGRlZmVycmVkID0gQG5l d1Byb21pc2VDYXBhYmlsaXR5KEBJbnRlcm5hbFByb21pc2UpOwotICAgICAgICBkZWZlcnJlZC5A cmVqZWN0LkBjYWxsKEB1bmRlZmluZWQsIG5ldyBAVHlwZUVycm9yKCJSZXF1ZXN0ZWQgbW9kdWxl IGlzIGFscmVhZHkgcmVhZHkgdG8gYmUgZXhlY3V0ZWQuIikpOwotICAgICAgICByZXR1cm4gZGVm ZXJyZWQuQHByb21pc2U7Ci0gICAgfQotCiAgICAgaWYgKGVudHJ5LnRyYW5zbGF0ZSkKICAgICAg ICAgcmV0dXJuIGVudHJ5LnRyYW5zbGF0ZTsKIApAQCAtMjkxLDEyICsyNzksNiBAQCBmdW5jdGlv biByZXF1ZXN0SW5zdGFudGlhdGUoa2V5LCBpbml0aWF0b3IpCiAgICAgInVzZSBzdHJpY3QiOwog CiAgICAgdmFyIGVudHJ5ID0gdGhpcy5lbnN1cmVSZWdpc3RlcmVkKGtleSk7Ci0gICAgaWYgKGVu dHJ5LnN0YXRlID4gQE1vZHVsZUxpbmspIHsKLSAgICAgICAgdmFyIGRlZmVycmVkID0gQG5ld1By b21pc2VDYXBhYmlsaXR5KEBJbnRlcm5hbFByb21pc2UpOwotICAgICAgICBkZWZlcnJlZC5AcmVq ZWN0LkBjYWxsKEB1bmRlZmluZWQsIG5ldyBAVHlwZUVycm9yKCJSZXF1ZXN0ZWQgbW9kdWxlIGlz IGFscmVhZHkgcmVhZHkgdG8gYmUgZXhlY3V0ZWQuIikpOwotICAgICAgICByZXR1cm4gZGVmZXJy ZWQuQHByb21pc2U7Ci0gICAgfQotCiAgICAgaWYgKGVudHJ5Lmluc3RhbnRpYXRlKQogICAgICAg ICByZXR1cm4gZW50cnkuaW5zdGFudGlhdGU7CiAKQEAgLTMyNCwxMiArMzA2LDYgQEAgZnVuY3Rp b24gcmVxdWVzdFNhdGlzZnkoa2V5LCBpbml0aWF0b3IpCiAgICAgInVzZSBzdHJpY3QiOwogCiAg ICAgdmFyIGVudHJ5ID0gdGhpcy5lbnN1cmVSZWdpc3RlcmVkKGtleSk7Ci0gICAgaWYgKGVudHJ5 LnN0YXRlID4gQE1vZHVsZUxpbmspIHsKLSAgICAgICAgdmFyIGRlZmVycmVkID0gQG5ld1Byb21p c2VDYXBhYmlsaXR5KEBJbnRlcm5hbFByb21pc2UpOwotICAgICAgICBkZWZlcnJlZC5AcmVqZWN0 LkBjYWxsKEB1bmRlZmluZWQsIG5ldyBAVHlwZUVycm9yKCJSZXF1ZXN0ZWQgbW9kdWxlIGlzIGFs cmVhZHkgcmVhZHkgdG8gYmUgZXhlY3V0ZWQuIikpOwotICAgICAgICByZXR1cm4gZGVmZXJyZWQu QHByb21pc2U7Ci0gICAgfQotCiAgICAgaWYgKGVudHJ5LnNhdGlzZnkpCiAgICAgICAgIHJldHVy biBlbnRyeS5zYXRpc2Z5OwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjFkMjEwOTZmNTA4ZWY5MzhjODcxOGI1OTlhMWQx Mzk2OTMyODQzYi4uMjlhZDU1M2QyZGE2Y2FkMzc4ZGRkYmVhMjdmNTcxNjYxNGE2YzIxMCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTExLTMwICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50 ZWFAZ21haWwuY29tPgorCisgICAgICAgIFtKU0NdIFNwZWNpZnlpbmcgc2FtZSBtb2R1bGUgZW50 cnkgcG9pbnQgbXVsdGlwbGUgdGltZXMgY2F1c2UgVHlwZUVycm9yCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ4NTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpzL2RvbS9tb2R1bGVzL21vZHVsZS1s b2FkLXNhbWUtbW9kdWxlLWZyb20tZGlmZmVyZW50LWVudHJ5LXBvaW50LWluLXNyYy1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGpzL2RvbS9tb2R1bGVzL21vZHVsZS1sb2FkLXNhbWUt bW9kdWxlLWZyb20tZGlmZmVyZW50LWVudHJ5LXBvaW50LWluLXNyYy5odG1sOiBBZGRlZC4KKwog MjAxNi0xMS0yOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtp T1NdIEFkZCB0ZXN0IGZvciBIVE1MIGZvcm0gdmFsaWRhdGlvbiBwb3BvdmVyIGRpc21pc3NhbCBv biB0YXAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL2RvbS9tb2R1bGVzL21vZHVsZS1sb2Fk LXNhbWUtbW9kdWxlLWZyb20tZGlmZmVyZW50LWVudHJ5LXBvaW50LWluLXNyYy1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9qcy9kb20vbW9kdWxlcy9tb2R1bGUtbG9hZC1zYW1lLW1vZHVsZS1m cm9tLWRpZmZlcmVudC1lbnRyeS1wb2ludC1pbi1zcmMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjNjY2I4NGEyY2FlMzY3ZWU2Njg0ODg4MWY1NmFjMDUxNGM5MDFmNGYKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9qcy9kb20vbW9kdWxlcy9tb2R1bGUtbG9hZC1zYW1lLW1vZHVsZS1m cm9tLWRpZmZlcmVudC1lbnRyeS1wb2ludC1pbi1zcmMtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEs MTUgQEAKKzIgZGlmZmVyZW50IG1vZHVsZSB0YWcgd2lsbCBhdHRlbXB0IHRvIGxvYWQgdGhlIHNh bWUgbW9kdWxlIHdpdGggInNyYyIgYXR0cmlidXRlLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBz ZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVU RSIuCisKKworTW9kdWxlIGlzIG5vdCBleGVjdXRlZCB5ZXQuCitQQVNTIHdpbmRvdy5tb2R1bGVF eGVjdXRlZENvdW50IGlzIDAKK0V4ZWN1dGluZyBtb2R1bGUtbG9hZC1zYW1lLW1vZHVsZS1mcm9t LWRpZmZlcmVudC1lbnRyeS1wb2ludC5qcy4KK1BBU1Mgd2luZG93Lm1vZHVsZUV4ZWN1dGVkQ291 bnQgaXMgMQorUEFTUyB3aW5kb3cubW9kdWxlRXhlY3V0ZWRDb3VudCBpcyAxCitQQVNTIGNvdW50 ZXIgaXMgMgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRF CisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL2RvbS9tb2R1bGVzL21vZHVsZS1sb2FkLXNh bWUtbW9kdWxlLWZyb20tZGlmZmVyZW50LWVudHJ5LXBvaW50LWluLXNyYy5odG1sIGIvTGF5b3V0 VGVzdHMvanMvZG9tL21vZHVsZXMvbW9kdWxlLWxvYWQtc2FtZS1tb2R1bGUtZnJvbS1kaWZmZXJl bnQtZW50cnktcG9pbnQtaW4tc3JjLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYmVlOWMxMDBmOWE2YTIxYmQz ZmEzZGRiNzQxN2FmYjUxM2UwYmM1ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2pz L2RvbS9tb2R1bGVzL21vZHVsZS1sb2FkLXNhbWUtbW9kdWxlLWZyb20tZGlmZmVyZW50LWVudHJ5 LXBvaW50LWluLXNyYy5odG1sCkBAIC0wLDAgKzEsMzEgQEAKKzwhRE9DVFlQRSBIVE1MPgorPGh0 bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUu anMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oJzIg ZGlmZmVyZW50IG1vZHVsZSB0YWcgd2lsbCBhdHRlbXB0IHRvIGxvYWQgdGhlIHNhbWUgbW9kdWxl IHdpdGggInNyYyIgYXR0cmlidXRlLicpOword2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOwor d2luZG93Lm1vZHVsZUV4ZWN1dGVkQ291bnQgPSAwOworZGVidWcoJ01vZHVsZSBpcyBub3QgZXhl Y3V0ZWQgeWV0LicpOworc2hvdWxkQmUoYHdpbmRvdy5tb2R1bGVFeGVjdXRlZENvdW50YCwgYDBg KTsKK3ZhciBjb3VudGVyID0gMDsKK2Z1bmN0aW9uIG9uTG9hZCgpIHsKKyAgICBzaG91bGRCZShg d2luZG93Lm1vZHVsZUV4ZWN1dGVkQ291bnRgLCBgMWApOworICAgICsrY291bnRlcjsKK30KK2Z1 bmN0aW9uIGZpbmlzaCgpIHsKKyAgICBzaG91bGRCZShgY291bnRlcmAsIGAyYCk7CisgICAgZmlu aXNoSlNUZXN0KCk7Cit9CisKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291 cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdCB0eXBlPSJtb2R1bGUiIHNy Yz0iLi9zY3JpcHQtdGVzdHMvbW9kdWxlLWxvYWQtc2FtZS1tb2R1bGUtZnJvbS1kaWZmZXJlbnQt ZW50cnktcG9pbnQuanMiIG9ubG9hZD0ib25Mb2FkKCkiPjwvc2NyaXB0PgorPHNjcmlwdCB0eXBl PSJtb2R1bGUiIHNyYz0iLi9zY3JpcHQtdGVzdHMvbW9kdWxlLWxvYWQtc2FtZS1tb2R1bGUtZnJv bS1kaWZmZXJlbnQtZW50cnktcG9pbnQuanMiIG9ubG9hZD0ib25Mb2FkKCkiPjwvc2NyaXB0Pgor PHNjcmlwdCB0eXBlPSJtb2R1bGUiPgorZmluaXNoKCk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwv aHRtbD4K