164838 2016-11-16 15:28:03 -0800 UnlinkedCodeBlock should not have a starting line number 2016-11-16 17:02:11 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren commit-queue keith_miller mark.lam msaboff oliver saam oldest_to_newest 1252054 0 ggaren 2016-11-16 15:28:03 -0800 UnlinkedCodeBlock should not have a starting line number 1252064 1 294985 ggaren 2016-11-16 15:36:08 -0800 Created attachment 294985 Patch 1252068 2 294985 mark.lam 2016-11-16 15:39:50 -0800 Comment on attachment 294985 Patch r=me 1252069 3 saam 2016-11-16 15:42:46 -0800 LGTM 1252116 4 ggaren 2016-11-16 17:02:11 -0800 Committed r208830: <http://trac.webkit.org/changeset/208830> 294985 2016-11-16 15:36:08 -0800 2016-11-16 15:39:50 -0800 Patch bug-164838-20161116153604.patch text/plain 6433 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA4ODE5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQwIEBA CisyMDE2LTExLTE2ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgVW5saW5rZWRDb2RlQmxvY2sgc2hvdWxkIG5vdCBoYXZlIGEgc3RhcnRpbmcgbGluZSBudW1i ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDgz OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhlcmUn cyBob3cgdGhlIHN0YXJ0aW5nIGxpbmUgbnVtYmVyIGluIFVubGlua2VkQ29kZUJsb2NrIHVzZWQg dG8gd29yazoKKworICAgICAgICAoMSkgQXNzaWduIHRoZSBzb3VyY2UgY29kZSBzdGFydGluZyBs aW5lIG51bWJlciB0byB0aGUgcGFyc2VyIHN0YXJ0aW5nCisgICAgICAgIGxpbmUgbnVtYmVyLgor CisgICAgICAgICgyKSBBc3NpZ24gdGhlIHBhcnNlciBzdGFydGluZyBsaW5lIG51bWJlciB0byB0 aGUgQVNULgorCisgICAgICAgICgzKSBTdWJ0cmFjdCAoMSkgZnJvbSAoMikgYW5kIGFzc2lnbiB0 byBVbmxpbmtlZENvZGVCbG9jay4KKworICAgICAgICBUaGVuLCB3aGVuIGxpbmtpbmc6CisKKyAg ICAgICAgKDQpIEFkZCAoMykgdG8gKDEpLgorCisgICAgICAgIFRoaXMgd2FzIGFuIGF3ZXNvbWUg bm8tb3AuCisKKyAgICAgICAgR2VuZXJhbGx5LCB1bmxpbmtlZCBjb2RlIGlzIGNvZGUgdGhhdCBp cyBub3QgdGllZCB0byBhbnkgcGFydGljdWxhcgorICAgICAgICB3ZWIgcGFnZSBvciByZXNvdXJj ZS4gU28sIGl0J3MgaW5hcHByb3ByaWF0ZSB0byB0aGluayBvZiBpdCBoYXZpbmcgYQorICAgICAg ICBzdGFydGluZyBsaW5lIG51bWJlci4KKworICAgICAgICAqIGJ5dGVjb2RlL1VubGlua2VkQ29k ZUJsb2NrLmNwcDoKKyAgICAgICAgKEpTQzo6VW5saW5rZWRDb2RlQmxvY2s6OlVubGlua2VkQ29k ZUJsb2NrKToKKyAgICAgICAgKiBieXRlY29kZS9VbmxpbmtlZENvZGVCbG9jay5oOgorICAgICAg ICAoSlNDOjpVbmxpbmtlZENvZGVCbG9jazo6cmVjb3JkUGFyc2UpOgorICAgICAgICAoSlNDOjpV bmxpbmtlZENvZGVCbG9jazo6aGFzQ2FwdHVyZWRWYXJpYWJsZXMpOgorICAgICAgICAoSlNDOjpV bmxpbmtlZENvZGVCbG9jazo6Zmlyc3RMaW5lKTogRGVsZXRlZC4KKyAgICAgICAgKiBydW50aW1l L0NvZGVDYWNoZS5jcHA6CisgICAgICAgIChKU0M6OkNvZGVDYWNoZTo6Z2V0VW5saW5rZWRHbG9i YWxDb2RlQmxvY2spOgorICAgICAgICAqIHJ1bnRpbWUvQ29kZUNhY2hlLmg6CisgICAgICAgIChK U0M6OmdlbmVyYXRlVW5saW5rZWRDb2RlQmxvY2spOgorCiAyMDE2LTExLTE2ICBNYXJrIExhbSAg PG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBFeGNlcHRpb25GdXp6IGZ1bmN0aW9ucyBz aG91bGQgdXNlIGl0cyBjbGllbnQncyBUaHJvd1Njb3BlLgpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL1VubGlua2VkQ29kZUJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suY3BwCShyZXZpc2lv biAyMDg4MTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRDb2Rl QmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MCw3ICs3MCw2IEBAIFVubGlua2VkQ29kZUJs b2NrOjpVbmxpbmtlZENvZGVCbG9jayhWTSoKICAgICAsIG1fY29uc3RydWN0b3JLaW5kKHN0YXRp Y19jYXN0PHVuc2lnbmVkPihpbmZvLmNvbnN0cnVjdG9yS2luZCgpKSkKICAgICAsIG1fZGVyaXZl ZENvbnRleHRUeXBlKHN0YXRpY19jYXN0PHVuc2lnbmVkPihpbmZvLmRlcml2ZWRDb250ZXh0VHlw ZSgpKSkKICAgICAsIG1fZXZhbENvbnRleHRUeXBlKHN0YXRpY19jYXN0PHVuc2lnbmVkPihpbmZv LmV2YWxDb250ZXh0VHlwZSgpKSkKLSAgICAsIG1fZmlyc3RMaW5lKDApCiAgICAgLCBtX2xpbmVD b3VudCgwKQogICAgICwgbV9lbmRDb2x1bW4oVUlOVF9NQVgpCiAgICAgLCBtX2RpZE9wdGltaXpl KE1peGVkVHJpU3RhdGUpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5s aW5rZWRDb2RlQmxvY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvVW5saW5rZWRDb2RlQmxvY2suaAkocmV2aXNpb24gMjA4ODE5KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkQ29kZUJsb2NrLmgJKHdvcmtpbmcgY29weSkK QEAgLTM0NywxMSArMzQ3LDEwIEBAIHB1YmxpYzoKIAogICAgIGJvb2wgdHlwZVByb2ZpbGVyRXhw cmVzc2lvbkluZm9Gb3JCeXRlY29kZU9mZnNldCh1bnNpZ25lZCBieXRlY29kZU9mZnNldCwgdW5z aWduZWQmIHN0YXJ0RGl2b3QsIHVuc2lnbmVkJiBlbmREaXZvdCk7CiAKLSAgICB2b2lkIHJlY29y ZFBhcnNlKENvZGVGZWF0dXJlcyBmZWF0dXJlcywgYm9vbCBoYXNDYXB0dXJlZFZhcmlhYmxlcywg dW5zaWduZWQgZmlyc3RMaW5lLCB1bnNpZ25lZCBsaW5lQ291bnQsIHVuc2lnbmVkIGVuZENvbHVt bikKKyAgICB2b2lkIHJlY29yZFBhcnNlKENvZGVGZWF0dXJlcyBmZWF0dXJlcywgYm9vbCBoYXND YXB0dXJlZFZhcmlhYmxlcywgdW5zaWduZWQgbGluZUNvdW50LCB1bnNpZ25lZCBlbmRDb2x1bW4p CiAgICAgewogICAgICAgICBtX2ZlYXR1cmVzID0gZmVhdHVyZXM7CiAgICAgICAgIG1faGFzQ2Fw dHVyZWRWYXJpYWJsZXMgPSBoYXNDYXB0dXJlZFZhcmlhYmxlczsKLSAgICAgICAgbV9maXJzdExp bmUgPSBmaXJzdExpbmU7CiAgICAgICAgIG1fbGluZUNvdW50ID0gbGluZUNvdW50OwogICAgICAg ICAvLyBGb3IgdGhlIFVubGlua2VkQ29kZUJsb2NrLCBzdGFydENvbHVtbiBpcyBhbHdheXMgMC4K ICAgICAgICAgbV9lbmRDb2x1bW4gPSBlbmRDb2x1bW47CkBAIC0zNjQsNyArMzYzLDYgQEAgcHVi bGljOgogCiAgICAgQ29kZUZlYXR1cmVzIGNvZGVGZWF0dXJlcygpIGNvbnN0IHsgcmV0dXJuIG1f ZmVhdHVyZXM7IH0KICAgICBib29sIGhhc0NhcHR1cmVkVmFyaWFibGVzKCkgY29uc3QgeyByZXR1 cm4gbV9oYXNDYXB0dXJlZFZhcmlhYmxlczsgfQotICAgIHVuc2lnbmVkIGZpcnN0TGluZSgpIGNv bnN0IHsgcmV0dXJuIG1fZmlyc3RMaW5lOyB9CiAgICAgdW5zaWduZWQgbGluZUNvdW50KCkgY29u c3QgeyByZXR1cm4gbV9saW5lQ291bnQ7IH0KICAgICBBTFdBWVNfSU5MSU5FIHVuc2lnbmVkIHN0 YXJ0Q29sdW1uKCkgY29uc3QgeyByZXR1cm4gMDsgfQogICAgIHVuc2lnbmVkIGVuZENvbHVtbigp IGNvbnN0IHsgcmV0dXJuIG1fZW5kQ29sdW1uOyB9CkBAIC00MzYsNyArNDM0LDYgQEAgcHJpdmF0 ZToKICAgICB1bnNpZ25lZCBtX2NvbnN0cnVjdG9yS2luZCA6IDI7CiAgICAgdW5zaWduZWQgbV9k ZXJpdmVkQ29udGV4dFR5cGUgOiAyOwogICAgIHVuc2lnbmVkIG1fZXZhbENvbnRleHRUeXBlIDog MjsKLSAgICB1bnNpZ25lZCBtX2ZpcnN0TGluZTsKICAgICB1bnNpZ25lZCBtX2xpbmVDb3VudDsK ICAgICB1bnNpZ25lZCBtX2VuZENvbHVtbjsKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvQ29kZUNhY2hlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9Db2RlQ2FjaGUuY3BwCShyZXZpc2lvbiAyMDg4MTkpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MSwx MiArNjEsMTEgQEAgVW5saW5rZWRDb2RlQmxvY2tUeXBlKiBDb2RlQ2FjaGU6OmdldFVubAogICAg IFNvdXJjZUNvZGVWYWx1ZSogY2FjaGUgPSBtX3NvdXJjZUNvZGUuZmluZENhY2hlQW5kVXBkYXRl QWdlKGtleSk7CiAgICAgaWYgKGNhY2hlICYmIE9wdGlvbnM6OnVzZUNvZGVDYWNoZSgpKSB7CiAg ICAgICAgIFVubGlua2VkQ29kZUJsb2NrVHlwZSogdW5saW5rZWRDb2RlQmxvY2sgPSBqc0Nhc3Q8 VW5saW5rZWRDb2RlQmxvY2tUeXBlKj4oY2FjaGUtPmNlbGwuZ2V0KCkpOwotICAgICAgICB1bnNp Z25lZCBmaXJzdExpbmUgPSBzb3VyY2UuZmlyc3RMaW5lKCkgKyB1bmxpbmtlZENvZGVCbG9jay0+ Zmlyc3RMaW5lKCk7CiAgICAgICAgIHVuc2lnbmVkIGxpbmVDb3VudCA9IHVubGlua2VkQ29kZUJs b2NrLT5saW5lQ291bnQoKTsKICAgICAgICAgdW5zaWduZWQgc3RhcnRDb2x1bW4gPSB1bmxpbmtl ZENvZGVCbG9jay0+c3RhcnRDb2x1bW4oKSArIHNvdXJjZS5zdGFydENvbHVtbigpOwogICAgICAg ICBib29sIGVuZENvbHVtbklzT25TdGFydExpbmUgPSAhbGluZUNvdW50OwogICAgICAgICB1bnNp Z25lZCBlbmRDb2x1bW4gPSB1bmxpbmtlZENvZGVCbG9jay0+ZW5kQ29sdW1uKCkgKyAoZW5kQ29s dW1uSXNPblN0YXJ0TGluZSA/IHN0YXJ0Q29sdW1uIDogMSk7Ci0gICAgICAgIGV4ZWN1dGFibGUt PnJlY29yZFBhcnNlKHVubGlua2VkQ29kZUJsb2NrLT5jb2RlRmVhdHVyZXMoKSwgdW5saW5rZWRD b2RlQmxvY2stPmhhc0NhcHR1cmVkVmFyaWFibGVzKCksIGZpcnN0TGluZSwgZmlyc3RMaW5lICsg bGluZUNvdW50LCBzdGFydENvbHVtbiwgZW5kQ29sdW1uKTsKKyAgICAgICAgZXhlY3V0YWJsZS0+ cmVjb3JkUGFyc2UodW5saW5rZWRDb2RlQmxvY2stPmNvZGVGZWF0dXJlcygpLCB1bmxpbmtlZENv ZGVCbG9jay0+aGFzQ2FwdHVyZWRWYXJpYWJsZXMoKSwgc291cmNlLmZpcnN0TGluZSgpLCBzb3Vy Y2UuZmlyc3RMaW5lKCkgKyBsaW5lQ291bnQsIHN0YXJ0Q29sdW1uLCBlbmRDb2x1bW4pOwogICAg ICAgICBzb3VyY2UucHJvdmlkZXIoKS0+c2V0U291cmNlVVJMRGlyZWN0aXZlKHVubGlua2VkQ29k ZUJsb2NrLT5zb3VyY2VVUkxEaXJlY3RpdmUoKSk7CiAgICAgICAgIHNvdXJjZS5wcm92aWRlcigp LT5zZXRTb3VyY2VNYXBwaW5nVVJMRGlyZWN0aXZlKHVubGlua2VkQ29kZUJsb2NrLT5zb3VyY2VN YXBwaW5nVVJMRGlyZWN0aXZlKCkpOwogICAgICAgICByZXR1cm4gdW5saW5rZWRDb2RlQmxvY2s7 CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db2RlQ2FjaGUuaAkocmV2aXNp b24gMjA4ODE5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmgJ KHdvcmtpbmcgY29weSkKQEAgLTI0Niw3ICsyNDYsNyBAQCBVbmxpbmtlZENvZGVCbG9ja1R5cGUq IGdlbmVyYXRlVW5saW5rZWRDCiAgICAgZXhlY3V0YWJsZS0+cmVjb3JkUGFyc2Uocm9vdE5vZGUt PmZlYXR1cmVzKCkgfCBhcnJvd0NvbnRleHRGZWF0dXJlLCByb290Tm9kZS0+aGFzQ2FwdHVyZWRW YXJpYWJsZXMoKSwgcm9vdE5vZGUtPmZpcnN0TGluZSgpLCByb290Tm9kZS0+bGFzdExpbmUoKSwg c3RhcnRDb2x1bW4sIGVuZENvbHVtbik7CiAKICAgICBVbmxpbmtlZENvZGVCbG9ja1R5cGUqIHVu bGlua2VkQ29kZUJsb2NrID0gVW5saW5rZWRDb2RlQmxvY2tUeXBlOjpjcmVhdGUoJnZtLCBleGVj dXRhYmxlLT5leGVjdXRhYmxlSW5mbygpLCBkZWJ1Z2dlck1vZGUpOwotICAgIHVubGlua2VkQ29k ZUJsb2NrLT5yZWNvcmRQYXJzZShyb290Tm9kZS0+ZmVhdHVyZXMoKSwgcm9vdE5vZGUtPmhhc0Nh cHR1cmVkVmFyaWFibGVzKCksIHJvb3ROb2RlLT5maXJzdExpbmUoKSAtIHNvdXJjZS5maXJzdExp bmUoKSwgbGluZUNvdW50LCB1bmxpbmtlZEVuZENvbHVtbik7CisgICAgdW5saW5rZWRDb2RlQmxv Y2stPnJlY29yZFBhcnNlKHJvb3ROb2RlLT5mZWF0dXJlcygpLCByb290Tm9kZS0+aGFzQ2FwdHVy ZWRWYXJpYWJsZXMoKSwgbGluZUNvdW50LCB1bmxpbmtlZEVuZENvbHVtbik7CiAgICAgdW5saW5r ZWRDb2RlQmxvY2stPnNldFNvdXJjZVVSTERpcmVjdGl2ZShzb3VyY2UucHJvdmlkZXIoKS0+c291 cmNlVVJMKCkpOwogICAgIHVubGlua2VkQ29kZUJsb2NrLT5zZXRTb3VyY2VNYXBwaW5nVVJMRGly ZWN0aXZlKHNvdXJjZS5wcm92aWRlcigpLT5zb3VyY2VNYXBwaW5nVVJMKCkpOwogCg==