164833 2016-11-16 13:48:07 -0800 LayoutTest inspector/worker/debugger-pause.html is a flaky failure 2020-01-19 23:26:52 -0800 1 1 1 Unclassified WebKit Web Inspector Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188580 https://bugs.webkit.org/show_bug.cgi?id=206285 InRadar P2 Normal --- 1 ryanhaddad joepeck bburg commit-queue inspector-bugzilla-changes joepeck tsavell webkit-bug-importer oldest_to_newest 1252000 0 ryanhaddad 2016-11-16 13:48:07 -0800 LayoutTest inspector/worker/debugger-pause.html is a flaky failure --- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/inspector/worker/debugger-pause-expected.txt +++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/inspector/worker/debugger-pause-actual.txt @@ -1,65 +1,14 @@ -CONSOLE MESSAGE: line 14: TypeError: undefined is not an object (evaluating '[].x.x') Ensure we can pause in Workers. +ERROR: Exception during test execution: TypeError: null is not an object (evaluating 'sourceCode.requestContent') loadLinesFromSourceCode +test +runTestMethodInFrontend +eval code +eval@[native code] +file:///Volumes/Data/slave/elcapitan-release-tests-wk2/build/WebKitBuild/Release/WebInspectorUI.framework/Resources/TestCombined.js:5689:24 +_flushPendingScripts@file:///Volumes/Data/slave/elcapitan-release-tests-wk2/build/WebKitBuild/Release/WebInspectorUI.framework/Resources/TestCombined.js:5157:24 +_dispatchResponse@file:///Volumes/Data/slave/elcapitan-release-tests-wk2/build/WebKitBuild/Release/WebInspectorUI.framework/Resources/TestCombined.js:5018:38 +dispatch@file:///Volumes/Data/slave/elcapitan-release-tests-wk2/build/WebKitBuild/Release/WebInspectorUI.framework/Resources/TestCombined.js:4955:35 +dispatch@file:///Volumes/Data/slave/elcapitan-release-tests-wk2/build/WebKitBuild/Release/WebInspectorUI.framework/Resources/TestCombined.js:4610:49 +dispatchNextQueuedMessageFromBackend@file:///Volumes/Data/slave/elcapitan-release-tests-wk2/build/WebKitBuild/Release/WebInspectorUI.framework/Resources/TestCombined.js:5445:34 -== Running test suite: Worker.Debugger.Pause --- Running test case: Worker.Debugger.Pause.DebuggerStatement -PASS: Paused -PASS: Should be paused in a Worker CallFrame. -PASS: Pause reason should be a debugger statement. -PAUSE AT triggerDebuggerStatement:3:5 - 0 function triggerDebuggerStatement() { - 1 let before = 1; - -> 2 |debugger; - 3 let after = 2; - 4 } - 5 - - - --- Running test case: Worker.Debugger.Pause.Breakpoint -PASS: Paused -PASS: Should be paused in a Worker CallFrame. -PASS: Pause reason should be a breakpoint. -PAUSE AT triggerBreakpoint:9:5 - 5 - 6 function triggerBreakpoint() { - 7 let alpha = 1; - -> 8 |let beta = 2; // BREAKPOINT - 9 let gamma = 3; - 10 } - 11 - - - --- Running test case: Worker.Debugger.Pause.Exception -PASS: Paused -PASS: Should be paused in a Worker CallFrame. -PASS: Pause reason should be an exception. -PAUSE AT triggerException:14:9 - 10 } - 11 - 12 function triggerException() { - -> 13 [].x|.x; - 14 } - 15 - 16 function triggerAssertion() { - - -Uncaught exception in test page: TypeError: undefined is not an object (evaluating '[].x.x') [worker-debugger-pause.js:14] - --- Running test case: Worker.Debugger.Pause.Assert -PASS: Paused -PASS: Should be paused in a Worker CallFrame. -PASS: Pause reason should be an exception. -PAUSE AT triggerAssertion:18:19 - 14 } - 15 - 16 function triggerAssertion() { - -> 17 console.assert|(false, "Assertion"); - 18 } - 19 - 20 onmessage = function(event) { - - - 1252001 1 ryanhaddad 2016-11-16 13:48:49 -0800 Here is an instance with a different diff: +FAIL: Main Thread's work fired before it could pause. Failing early. https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r208798%20(16260)/results.html 1252002 2 webkit-bug-importer 2016-11-16 13:50:39 -0800 <rdar://problem/29295404> 1252003 3 webkit-bug-importer 2016-11-16 13:51:28 -0800 <rdar://problem/29295420> 1252059 4 ryanhaddad 2016-11-16 15:32:54 -0800 Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/208820 1449415 5 346941 joepeck 2018-08-10 16:55:28 -0700 Created attachment 346941 [PATCH] Proposed Fix 1449421 6 346941 bburg 2018-08-10 17:17:34 -0700 Comment on attachment 346941 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=346941&action=review r=me > LayoutTests/inspector/worker/debugger-pause.html:115 > + Promise.resolve().then(() => { It would be interesting to abstract away the Promise mechanism to turn the event loop. Say, turnEventLoop().then(... would make the comment disappear. Is this something we should be doing in more worker tests? Would it be less fragile for the worker to post back a "I'm initialized!" message then continue the test? I think we use this pattern in Inspector layout test runner between the inspector and inspected page. 1449429 7 joepeck 2018-08-10 17:33:27 -0700 (In reply to Brian Burg from comment #6) > Comment on attachment 346941 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=346941&action=review > > r=me > > > LayoutTests/inspector/worker/debugger-pause.html:115 > > + Promise.resolve().then(() => { > > It would be interesting to abstract away the Promise mechanism to turn the > event loop. Say, turnEventLoop().then(... would make the comment disappear. > > Is this something we should be doing in more worker tests? Would it be less > fragile for the worker to post back a "I'm initialized!" message then > continue the test? I think we use this pattern in Inspector layout test > runner between the inspector and inspected page. This one isn't the worker, its the frontend setting up the worker. Which is a shame. I like the idea of turnEventLoop(), but it still would probably need a comment explains why. 1449450 8 346941 commit-queue 2018-08-10 19:21:17 -0700 Comment on attachment 346941 [PATCH] Proposed Fix Clearing flags on attachment: 346941 Committed r234779: <https://trac.webkit.org/changeset/234779> 1449451 9 commit-queue 2018-08-10 19:21:19 -0700 All reviewed patches have been landed. Closing bug. 1449841 10 tsavell 2018-08-13 16:51:49 -0700 It looks like this patch <https://trac.webkit.org/changeset/234779> Did alleviate the failures in the test. Now the test is timing out and has had two crashes though those may be a persisting issue. Test History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fworker%2Fdebugger-pause.html 1450000 11 joepeck 2018-08-14 10:41:35 -0700 (In reply to Truitt Savell from comment #10) > It looks like this patch <https://trac.webkit.org/changeset/234779> > Did alleviate the failures in the test. Now the test is timing out and has > had two crashes though those may be a persisting issue. > > > Test History: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=inspector%2Fworker%2Fdebugger-pause.html Thanks for the heads up, looking. 1450091 12 joepeck 2018-08-14 14:09:26 -0700 I was able to reproduce this 1 out of 100 times in a debug build on my desktop. By doing: $ run-webkit-tests inspector/worker --force --verbose --iterations=100 --exit-after-n-failures=1 In that case, the worker main resource wasn't available. So while it seems the vast majority of the time 1 run loop turn is a long enough wait, sometimes it may not be. I'm going to try this instead: 1. Wait 1 turn 2. If not available, wait for some amount of time (100ms? 1s?) before giving up. 3. If not available, fail immediately instead of timeout With this lets see what happens on the bots. 1450093 13 joepeck 2018-08-14 14:10:57 -0700 Actually even better, I can produce an event when a target has its main resource set. Let me try that. 1450116 14 joepeck 2018-08-14 15:11:10 -0700 (In reply to Joseph Pecoraro from comment #13) > Actually even better, I can produce an event when a target has its main > resource set. Let me try that. https://bugs.webkit.org/show_bug.cgi?id=188580 346941 2018-08-10 16:55:28 -0700 2018-08-10 19:21:17 -0700 [PATCH] Proposed Fix worker-test-1.patch text/plain 3242 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MjNiMTdmN2M2Yy4uYzBhMzU5ZGFlODYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAor MjAxOC0wOC0xMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAg ICAgIExheW91dFRlc3QgaW5zcGVjdG9yL3dvcmtlci9kZWJ1Z2dlci1wYXVzZS5odG1sIGlzIGEg Zmxha3kgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTY0ODMzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTI5NTQwND4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci93b3Jr ZXIvZGVidWdnZXItcGF1c2UuaHRtbDoKKyAgICAgICAgQWRkIGEgbWljcm90YXNrIHR1cm4gdG8g ZW5zdXJlIHRoZSB3b3JrZXJUYXJnZXQncyBtYWluUmVzb3VyY2UgaXMgc2V0dXAuCisgICAgICAg IFRoZXJlIHdlcmUgdGltZXMgaXQgbWlnaHQgbm90IGdldCBzZXR1cCwgYnV0IGEgc2luZ2xlIHR1 cm4gYXBwZWFycworICAgICAgICByZWxpYWJsZSBlbm91Z2guCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ndGsvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9uczoKKyAgICAgICAgVGhpcyB0ZXN0IGFsd2F5cyBwYXNzZXMgZm9yIG1lIGluIFJlbGVh c2UgYW5kIERlYnVnLiBSZXNldCBleHBlY3RhdGlvbnMuCisKIDIwMTgtMDgtMTAgIEpvc2VwaCBQ ZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBj b25zb2xlLmxvZyBmaXJlcyBnZXR0ZXJzIGZvciBkZWVwIHByb3BlcnRpZXMKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2luc3BlY3Rvci93b3JrZXIvZGVidWdnZXItcGF1c2UuaHRtbCBiL0xheW91 dFRlc3RzL2luc3BlY3Rvci93b3JrZXIvZGVidWdnZXItcGF1c2UuaHRtbAppbmRleCBjNzQ1Yzgw NmMxMC4uMGRlNTEzNGEzNGQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci93b3Jr ZXIvZGVidWdnZXItcGF1c2UuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivd29ya2Vy L2RlYnVnZ2VyLXBhdXNlLmh0bWwKQEAgLTExMSw4ICsxMTEsMTEgQEAgZnVuY3Rpb24gdGVzdCgp CiAgICAgICAgIH0KICAgICB9KTsKIAotICAgIHdpbmRvdy5sb2FkTGluZXNGcm9tU291cmNlQ29k ZSh3b3JrZXJUYXJnZXQubWFpblJlc291cmNlKS50aGVuKCgpID0+IHsKLSAgICAgICAgc3VpdGUu cnVuVGVzdENhc2VzQW5kRmluaXNoKCk7CisgICAgLy8gVHVybiBvbmNlIHRvIGVuc3VyZSB3b3Jr ZXJUYXJnZXQubWFpblJlc291cmNlIGlzIGxvYWRlZC4KKyAgICBQcm9taXNlLnJlc29sdmUoKS50 aGVuKCgpID0+IHsKKyAgICAgICAgd2luZG93LmxvYWRMaW5lc0Zyb21Tb3VyY2VDb2RlKHdvcmtl clRhcmdldC5tYWluUmVzb3VyY2UpLnRoZW4oKCkgPT4geworICAgICAgICAgICAgc3VpdGUucnVu VGVzdENhc2VzQW5kRmluaXNoKCk7CisgICAgICAgIH0pOwogICAgIH0pOwogfQogPC9zY3JpcHQ+ CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDc3NDI1MzYw NzdhLi4zNTIyZWY1YThmMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rl c3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3Rh dGlvbnMKQEAgLTE4NDAsOCArMTg0MCw2IEBAIHdlYmtpdC5vcmcvYi8xNzIyODMgaW5zcGVjdG9y L3dvcmtlci9kZWJ1Z2dlci1tdWx0aXBsZS10YXJnZXRzLXBhdXNlLmh0bWwgWyBUaW1lCiAKIHdl YmtpdC5vcmcvYi8xNzI4MTUgaW1wb3J0ZWQvdzNjL2kxOG4vYmlkaS9iaWRpLXBsYWludGV4dC0w MTEuaHRtbCBbIFBhc3MgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8xNjQ4MzMg aW5zcGVjdG9yL3dvcmtlci9kZWJ1Z2dlci1wYXVzZS5odG1sIFsgUGFzcyBGYWlsdXJlIFRpbWVv dXQgXQotCiB3ZWJraXQub3JnL2IvMTczNDEyIGZhc3Qvc2Nyb2xsaW5nL292ZXJmbG93LXNjcm9s bGFibGUtYWZ0ZXItYmFjay5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzE2 ODM3MyBtZWRpYS92aWRlby1zZWVrLXBhc3QtZW5kLXBhdXNlZC5odG1sIFsgRmFpbHVyZSBQYXNz IF0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25z IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZTYwNTRl YTZiYmQuLjljYjZhNWRkM2MyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv VGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9ucwpAQCAtMTEwMiw3ICsxMTAyLDYgQEAgd2Via2l0Lm9yZy9iLzE4MTgzMiBpbnNwZWN0 b3IvdW5pdC10ZXN0cy90aHJvdHRsZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcv Yi8xNjEzNjEgaW5zcGVjdG9yL3VuaXQtdGVzdHMveWllbGRhYmxlLXRhc2suaHRtbCBbIFBhc3Mg RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTY5MjI4IGluc3BlY3Rvci93b3JrZXIvY29uc29sZS1i YXNpYy5odG1sIFsgUGFzcyBUaW1lb3V0IF0KIHdlYmtpdC5vcmcvYi8xNjQ4NzIgaW5zcGVjdG9y L3dvcmtlci9kZWJ1Z2dlci1tdWx0aXBsZS10YXJnZXRzLXBhdXNlLmh0bWwgWyBQYXNzIEZhaWx1 cmUgVGltZW91dCBdCi13ZWJraXQub3JnL2IvMTY0ODMzIGluc3BlY3Rvci93b3JrZXIvZGVidWdn ZXItcGF1c2UuaHRtbCBbIFBhc3MgRmFpbHVyZSBUaW1lb3V0IF0KIHdlYmtpdC5vcmcvYi8xNjU1 ODIgaW5zcGVjdG9yL3dvcmtlci9kZWJ1Z2dlci1zY3JpcHRzLmh0bWwgWyBQYXNzIEZhaWx1cmUg XQogd2Via2l0Lm9yZy9iLzE2NzIwMyBpbnNwZWN0b3Ivd29ya2VyL2RlYnVnZ2VyLXNoYXJlZC1i cmVha3BvaW50Lmh0bWwgWyBQYXNzIEZhaWx1cmUgVGltZW91dCBdCiB3ZWJraXQub3JnL2IvMTU1 NjA3IGluc3BlY3Rvci9oZWFwL3NuYXBzaG90Lmh0bWwgWyBQYXNzIFRpbWVvdXQgXQo=