164832 2016-11-16 13:33:04 -0800 Micro-optimize ContainerNode::removeBetween() 2016-11-16 14:30:51 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cdumez commit-queue darin dbates esprehn+autocc kangil.han rniwa oldest_to_newest 1251995 0 cdumez 2016-11-16 13:33:04 -0800 Micro-optimize ContainerNode::removeBetween() by updating pointers only when strictly needed and reducing branching. 1251996 1 294970 cdumez 2016-11-16 13:34:24 -0800 Created attachment 294970 Patch 1252022 2 294970 commit-queue 2016-11-16 14:30:48 -0800 Comment on attachment 294970 Patch Clearing flags on attachment: 294970 Committed r208813: <http://trac.webkit.org/changeset/208813> 1252023 3 commit-queue 2016-11-16 14:30:51 -0800 All reviewed patches have been landed. Closing bug. 294970 2016-11-16 13:34:24 -0800 2016-11-16 14:30:48 -0800 Patch bug-164832-20161116133420.patch text/plain 2184 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4Nzk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzg2MmRiZGE3NTI5NDU5 OTU2MGVkOTJmZjEzNzI2YjZmOGNhMDhlOS4uY2MxMGYzOGFkNjBjYjE1MWJiNDc5ZjQ3YWQ2OTMx MzRlM2UxYzVhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTExLTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTWljcm8tb3B0aW1pemUgQ29u dGFpbmVyTm9kZTo6cmVtb3ZlQmV0d2VlbigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ4MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBNaWNyby1vcHRpbWl6ZSBDb250YWluZXJOb2RlOjpyZW1vdmVC ZXR3ZWVuKCkgYnkgdXBkYXRpbmcgcG9pbnRlcnMgb25seQorICAgICAgICB3aGVuIHN0cmljdGx5 IG5lZWRlZCBhbmQgcmVkdWNpbmcgYnJhbmNoaW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg bm8gV2ViLWV4cG9zZWQgYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogZG9tL0NvbnRhaW5l ck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGFpbmVyTm9kZTo6cmVtb3ZlQmV0d2Vl bik6CisKIDIwMTYtMTEtMTYgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZSBnZXRNdXRhYmxlQ2FjaGVkUHNldWRvU3R5bGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9D b250YWluZXJOb2RlLmNwcAppbmRleCA2NzIxNTk0OTQ1MjgwMWE5NzU3NmRiMTU4MzZmN2M3OWMy ZDQ4M2NiLi5mZGY0YjM5ZDE0ZGQ3OWQzZWNmYmRhMTVhM2UyMzFmMmQyZDlmMDlkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCkBAIC01NTgsMTcgKzU1OCwyNSBAQCB2b2lkIENv bnRhaW5lck5vZGU6OnJlbW92ZUJldHdlZW4oTm9kZSogcHJldmlvdXNDaGlsZCwgTm9kZSogbmV4 dENoaWxkLCBOb2RlJiBvbAogCiAgICAgZGVzdHJveVJlbmRlclRyZWVJZk5lZWRlZChvbGRDaGls ZCk7CiAKLSAgICBpZiAobmV4dENoaWxkKQorICAgIGlmIChuZXh0Q2hpbGQpIHsKICAgICAgICAg bmV4dENoaWxkLT5zZXRQcmV2aW91c1NpYmxpbmcocHJldmlvdXNDaGlsZCk7Ci0gICAgaWYgKHBy ZXZpb3VzQ2hpbGQpCisgICAgICAgIG9sZENoaWxkLnNldE5leHRTaWJsaW5nKG51bGxwdHIpOwor ICAgIH0gZWxzZSB7CisgICAgICAgIEFTU0VSVChtX2xhc3RDaGlsZCA9PSAmb2xkQ2hpbGQpOwor ICAgICAgICBtX2xhc3RDaGlsZCA9IHByZXZpb3VzQ2hpbGQ7CisgICAgfQorICAgIGlmIChwcmV2 aW91c0NoaWxkKSB7CiAgICAgICAgIHByZXZpb3VzQ2hpbGQtPnNldE5leHRTaWJsaW5nKG5leHRD aGlsZCk7Ci0gICAgaWYgKG1fZmlyc3RDaGlsZCA9PSAmb2xkQ2hpbGQpCisgICAgICAgIG9sZENo aWxkLnNldFByZXZpb3VzU2libGluZyhudWxscHRyKTsKKyAgICB9IGVsc2UgeworICAgICAgICBB U1NFUlQobV9maXJzdENoaWxkID09ICZvbGRDaGlsZCk7CiAgICAgICAgIG1fZmlyc3RDaGlsZCA9 IG5leHRDaGlsZDsKLSAgICBpZiAobV9sYXN0Q2hpbGQgPT0gJm9sZENoaWxkKQotICAgICAgICBt X2xhc3RDaGlsZCA9IHByZXZpb3VzQ2hpbGQ7CisgICAgfQogCi0gICAgb2xkQ2hpbGQuc2V0UHJl dmlvdXNTaWJsaW5nKG51bGxwdHIpOwotICAgIG9sZENoaWxkLnNldE5leHRTaWJsaW5nKG51bGxw dHIpOworICAgIEFTU0VSVChtX2ZpcnN0Q2hpbGQgIT0gJm9sZENoaWxkKTsKKyAgICBBU1NFUlQo bV9sYXN0Q2hpbGQgIT0gJm9sZENoaWxkKTsKKyAgICBBU1NFUlQoIW9sZENoaWxkLnByZXZpb3Vz U2libGluZygpKTsKKyAgICBBU1NFUlQoIW9sZENoaWxkLm5leHRTaWJsaW5nKCkpOwogICAgIG9s ZENoaWxkLnNldFBhcmVudE5vZGUobnVsbHB0cik7CiAKICAgICBkb2N1bWVudCgpLmFkb3B0SWZO ZWVkZWQoJm9sZENoaWxkKTsK