164814 2016-11-15 19:37:25 -0800 Add more assertions to ElementQueue diagnose a bug 2016-12-06 21:32:49 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 162029 1 rniwa rniwa ap cdumez commit-queue dbates esprehn+autocc kangil.han koivisto oldest_to_newest 1251780 0 rniwa 2016-11-15 19:37:25 -0800 We seem to be sporadically hitting an assertion in CustomElementReactionStack::ElementQueue on our bots. I don’t quite understand how this is possible. We swap the vector at the beginning of the function before start invoking on elements. So the only way m_elements can be not empty is if an item was added to m_elements while we’re calling invokeAll: inline void CustomElementReactionStack::ElementQueue::invokeAll() { #if !ASSERT_DISABLED TemporaryChange<bool> invoking(m_invoking); #endif Vector<Ref<Element>> elements; elements.swap(m_elements); for (auto& element : elements) { auto* queue = element->reactionQueue(); ASSERT(queue); queue->invokeAll(element.get()); } ASSERT(m_elements.isEmpty()); } But I’ve added an assertion for m_invoking so that m_invoking is false when we’re calling add: inline void CustomElementReactionStack::ElementQueue::add(Element& element) { ASSERT(!m_invoking); // FIXME: Avoid inserting the same element multiple times. m_elements.append(element); } which isn't firing... 1251781 1 294918 rniwa 2016-11-15 19:40:21 -0800 Created attachment 294918 Tightens assertions 1251782 2 294918 ysuzuki 2016-11-15 19:42:51 -0800 Comment on attachment 294918 Tightens assertions r=me 1251800 3 294923 rniwa 2016-11-15 21:16:13 -0800 Created attachment 294923 Patch for landing 1251809 4 294923 commit-queue 2016-11-15 22:18:21 -0800 Comment on attachment 294923 Patch for landing Clearing flags on attachment: 294923 Committed r208785: <http://trac.webkit.org/changeset/208785> 1251810 5 commit-queue 2016-11-15 22:18:26 -0800 All reviewed patches have been landed. Closing bug. 1256729 6 rniwa 2016-12-05 21:36:34 -0800 Reopening to attach new patch. 1256730 7 296267 rniwa 2016-12-05 21:36:37 -0800 Created attachment 296267 Set m_invoking in release builds 1256996 8 296267 commit-queue 2016-12-06 15:02:23 -0800 Comment on attachment 296267 Set m_invoking in release builds Clearing flags on attachment: 296267 Committed r209426: <http://trac.webkit.org/changeset/209426> 1256997 9 commit-queue 2016-12-06 15:02:28 -0800 All reviewed patches have been landed. Closing bug. 294918 2016-11-15 19:40:21 -0800 2016-11-15 21:16:06 -0800 Tightens assertions bug-164814-20161115194020.patch text/plain 2354 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE0NGYxZGZlMmNhODkx NTA1ZjM5NzczODZlYTEyYjU5MmJkNzY1NC4uZDdlMjlmMWQxZDIxNWRkNGFmMTUxOTMzMWM1ZjBk YmU4YzdmMzFhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTExLTE2ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBtb3JlIGFzc2VydGlv bnMgdG8gRWxlbWVudFF1ZXVlIGRpYWdub3NlIGEgYnVnCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ4MTQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbW9yZSBhc3NlcnRpb25zIHRvIGNoZWNrIHRo ZSBzYW5pdHkgb2YgdGhlIGVsZW1lbnQgcXVldWUuCisgICAgICAgIEFsc28gbWFkZSB0aGVtIGFs bCByZWxlYXNlIGFzc2VydGlvbnMgc28gdGhhdCB3ZSBjYW4gY2F0Y2ggdGhlbSBiZXR0ZXIuCisK KyAgICAgICAgKiBkb20vQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q3VzdG9tRWxlbWVudFJlYWN0aW9uU3RhY2s6OkVsZW1lbnRRdWV1ZTo6YWRkKToK KyAgICAgICAgKFdlYkNvcmU6OkN1c3RvbUVsZW1lbnRSZWFjdGlvblN0YWNrOjpFbGVtZW50UXVl dWU6Omludm9rZUFsbCk6CisKIDIwMTYtMTEtMTUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtp dC5vcmc+CiAKICAgICAgICAgc2xvdGNoYW5nZSBldmVudCBzaG91bGQgYnViYmxlIGFuZCBkaXNw YXRjaGVkIG9uY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50 UmVhY3Rpb25RdWV1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9tRWxlbWVudFJlYWN0 aW9uUXVldWUuY3BwCmluZGV4IGZlN2Q0OTg1NmI3YzAyODdhZjYzZjA4MjViY2UzMmViYjg4MjI2 NTcuLjA3YzVhYmUxZTg2ZGY5NWM4ZTY0N2E4NGQyOTNkOGNmYTU4N2RmMjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRSZWFjdGlvblF1ZXVlLmNwcApAQCAtMjA1 LDcgKzIwNSw3IEBAIHZvaWQgQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWU6Omludm9rZUFsbChF bGVtZW50JiBlbGVtZW50KQogCiBpbmxpbmUgdm9pZCBDdXN0b21FbGVtZW50UmVhY3Rpb25TdGFj azo6RWxlbWVudFF1ZXVlOjphZGQoRWxlbWVudCYgZWxlbWVudCkKIHsKLSAgICBBU1NFUlQoIW1f aW52b2tpbmcpOworICAgIFJFTEVBU0VfQVNTRVJUKCFtX2ludm9raW5nKTsKICAgICAvLyBGSVhN RTogQXZvaWQgaW5zZXJ0aW5nIHRoZSBzYW1lIGVsZW1lbnQgbXVsdGlwbGUgdGltZXMuCiAgICAg bV9lbGVtZW50cy5hcHBlbmQoZWxlbWVudCk7CiB9CkBAIC0yMTMsMTYgKzIxMywxOCBAQCBpbmxp bmUgdm9pZCBDdXN0b21FbGVtZW50UmVhY3Rpb25TdGFjazo6RWxlbWVudFF1ZXVlOjphZGQoRWxl bWVudCYgZWxlbWVudCkKIGlubGluZSB2b2lkIEN1c3RvbUVsZW1lbnRSZWFjdGlvblN0YWNrOjpF bGVtZW50UXVldWU6Omludm9rZUFsbCgpCiB7CiAjaWYgIUFTU0VSVF9ESVNBQkxFRAotICAgIFRl bXBvcmFyeUNoYW5nZTxib29sPiBpbnZva2luZyhtX2ludm9raW5nKTsKKyAgICBSRUxFQVNFX0FT U0VSVCghbV9pbnZva2luZyk7CisgICAgVGVtcG9yYXJ5Q2hhbmdlPGJvb2w+IGludm9raW5nKG1f aW52b2tpbmcsIHRydWUpOwogI2VuZGlmCiAgICAgVmVjdG9yPFJlZjxFbGVtZW50Pj4gZWxlbWVu dHM7CiAgICAgZWxlbWVudHMuc3dhcChtX2VsZW1lbnRzKTsKKyAgICBSRUxFQVNFX0FTU0VSVCht X2VsZW1lbnRzLmlzRW1wdHkoKSk7CiAgICAgZm9yIChhdXRvJiBlbGVtZW50IDogZWxlbWVudHMp IHsKICAgICAgICAgYXV0byogcXVldWUgPSBlbGVtZW50LT5yZWFjdGlvblF1ZXVlKCk7CiAgICAg ICAgIEFTU0VSVChxdWV1ZSk7CiAgICAgICAgIHF1ZXVlLT5pbnZva2VBbGwoZWxlbWVudC5nZXQo KSk7CiAgICAgfQotICAgIEFTU0VSVChtX2VsZW1lbnRzLmlzRW1wdHkoKSk7CisgICAgUkVMRUFT RV9BU1NFUlQobV9lbGVtZW50cy5pc0VtcHR5KCkpOwogfQogCiBDdXN0b21FbGVtZW50UmVhY3Rp b25RdWV1ZSYgQ3VzdG9tRWxlbWVudFJlYWN0aW9uU3RhY2s6OmVuc3VyZUN1cnJlbnRRdWV1ZShF bGVtZW50JiBlbGVtZW50KQo= 294923 2016-11-15 21:16:13 -0800 2016-12-05 21:36:45 -0800 Patch for landing bug-164814-20161115211612.patch text/plain 2870 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE0NGYxZGZlMmNhODkx NTA1ZjM5NzczODZlYTEyYjU5MmJkNzY1NC4uNWM0ZjlmMTJlMGUzMDU1MWMyN2NjZGY3MzU0Y2Zj NDBiNDY4OTQzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTExLTE2ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBtb3JlIGFzc2VydGlv bnMgdG8gRWxlbWVudFF1ZXVlIGRpYWdub3NlIGEgYnVnCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ4MTQKKworICAgICAgICBSZXZpZXdlZCBieSBZ dXN1a2UgU3V6dWtpLgorCisgICAgICAgIEFkZCBtb3JlIGFzc2VydGlvbnMgdG8gY2hlY2sgdGhl IHNhbml0eSBvZiB0aGUgZWxlbWVudCBxdWV1ZS4KKyAgICAgICAgQWxzbyBtYWRlIHRoZW0gYWxs IHJlbGVhc2UgYXNzZXJ0aW9ucyBzbyB0aGF0IHdlIGNhbiBjYXRjaCB0aGVtIGJldHRlci4KKwor ICAgICAgICAqIGRvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDdXN0b21FbGVtZW50UmVhY3Rpb25TdGFjazo6RWxlbWVudFF1ZXVlOjphZGQpOgor ICAgICAgICAoV2ViQ29yZTo6Q3VzdG9tRWxlbWVudFJlYWN0aW9uU3RhY2s6OkVsZW1lbnRRdWV1 ZTo6aW52b2tlQWxsKToKKwogMjAxNi0xMS0xNSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBzbG90Y2hhbmdlIGV2ZW50IHNob3VsZCBidWJibGUgYW5kIGRpc3Bh dGNoZWQgb25jZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRS ZWFjdGlvblF1ZXVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rp b25RdWV1ZS5jcHAKaW5kZXggZmU3ZDQ5ODU2YjdjMDI4N2FmNjNmMDgyNWJjZTMyZWJiODgyMjY1 Ny4uMDdjNWFiZTFlODZkZjk1YzhlNjQ3YTg0ZDI5M2Q4Y2ZhNTg3ZGYyOSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRSZWFjdGlvblF1ZXVlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWUuY3BwCkBAIC0yMDUs NyArMjA1LDcgQEAgdm9pZCBDdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZTo6aW52b2tlQWxsKEVs ZW1lbnQmIGVsZW1lbnQpCiAKIGlubGluZSB2b2lkIEN1c3RvbUVsZW1lbnRSZWFjdGlvblN0YWNr OjpFbGVtZW50UXVldWU6OmFkZChFbGVtZW50JiBlbGVtZW50KQogewotICAgIEFTU0VSVCghbV9p bnZva2luZyk7CisgICAgUkVMRUFTRV9BU1NFUlQoIW1faW52b2tpbmcpOwogICAgIC8vIEZJWE1F OiBBdm9pZCBpbnNlcnRpbmcgdGhlIHNhbWUgZWxlbWVudCBtdWx0aXBsZSB0aW1lcy4KICAgICBt X2VsZW1lbnRzLmFwcGVuZChlbGVtZW50KTsKIH0KQEAgLTIxMywxNiArMjEzLDE4IEBAIGlubGlu ZSB2b2lkIEN1c3RvbUVsZW1lbnRSZWFjdGlvblN0YWNrOjpFbGVtZW50UXVldWU6OmFkZChFbGVt ZW50JiBlbGVtZW50KQogaW5saW5lIHZvaWQgQ3VzdG9tRWxlbWVudFJlYWN0aW9uU3RhY2s6OkVs ZW1lbnRRdWV1ZTo6aW52b2tlQWxsKCkKIHsKICNpZiAhQVNTRVJUX0RJU0FCTEVECi0gICAgVGVt cG9yYXJ5Q2hhbmdlPGJvb2w+IGludm9raW5nKG1faW52b2tpbmcpOworICAgIFJFTEVBU0VfQVNT RVJUKCFtX2ludm9raW5nKTsKKyAgICBUZW1wb3JhcnlDaGFuZ2U8Ym9vbD4gaW52b2tpbmcobV9p bnZva2luZywgdHJ1ZSk7CiAjZW5kaWYKICAgICBWZWN0b3I8UmVmPEVsZW1lbnQ+PiBlbGVtZW50 czsKICAgICBlbGVtZW50cy5zd2FwKG1fZWxlbWVudHMpOworICAgIFJFTEVBU0VfQVNTRVJUKG1f ZWxlbWVudHMuaXNFbXB0eSgpKTsKICAgICBmb3IgKGF1dG8mIGVsZW1lbnQgOiBlbGVtZW50cykg ewogICAgICAgICBhdXRvKiBxdWV1ZSA9IGVsZW1lbnQtPnJlYWN0aW9uUXVldWUoKTsKICAgICAg ICAgQVNTRVJUKHF1ZXVlKTsKICAgICAgICAgcXVldWUtPmludm9rZUFsbChlbGVtZW50LmdldCgp KTsKICAgICB9Ci0gICAgQVNTRVJUKG1fZWxlbWVudHMuaXNFbXB0eSgpKTsKKyAgICBSRUxFQVNF X0FTU0VSVChtX2VsZW1lbnRzLmlzRW1wdHkoKSk7CiB9CiAKIEN1c3RvbUVsZW1lbnRSZWFjdGlv blF1ZXVlJiBDdXN0b21FbGVtZW50UmVhY3Rpb25TdGFjazo6ZW5zdXJlQ3VycmVudFF1ZXVlKEVs ZW1lbnQmIGVsZW1lbnQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9tRWxl bWVudFJlYWN0aW9uUXVldWUuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVh Y3Rpb25RdWV1ZS5oCmluZGV4IGZhZTZkZTg5Yzg3ODE2NDY0MGMwMWRhMTVkMjBmZGJiNzdjODZl NjMuLjBjOTEyM2RjMmUyMTZkY2EzYzgzNWI2MTU0NGQ5NDRlZTk4MTc4MWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5oCkBAIC04OSw5ICs4 OSw3IEBAIHByaXZhdGU6CiAKICAgICBwcml2YXRlOgogICAgICAgICBWZWN0b3I8UmVmPEVsZW1l bnQ+PiBtX2VsZW1lbnRzOwotI2lmICFBU1NFUlRfRElTQUJMRUQKICAgICAgICAgYm9vbCBtX2lu dm9raW5nIHsgZmFsc2UgfTsKLSNlbmRpZgogICAgIH07CiAKICAgICBXRUJDT1JFX0VYUE9SVCB2 b2lkIHByb2Nlc3NRdWV1ZSgpOwo= 296267 2016-12-05 21:36:37 -0800 2016-12-06 15:02:23 -0800 Set m_invoking in release builds bug-164814-20161205213600.patch text/plain 1346 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTM4NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTEyLTA1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBtb3JlIGFzc2VydGlvbnMg dG8gRWxlbWVudFF1ZXVlIGRpYWdub3NlIGEgYnVnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ4MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTZXQgbV9pbnZva2luZyBpbiByZWxlYXNlIGJ1aWxkcyBu b3cgdGhhdCBhc3NlcnRpb25zIGFyZSBhbHNvIHJ1biBpbiByZWxlYXNlIGJ1aWxkcy4KKworICAg ICAgICAqIGRvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpDdXN0b21FbGVtZW50UmVhY3Rpb25TdGFjazo6RWxlbWVudFF1ZXVlOjppbnZva2VBbGwp OgorCiAyMDE2LTEyLTA1ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAg ICAgICBCdWlsZCBmaXggZm9sbG93dXAgdG8gcjIwOTM3OToKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRSZWFjdGlvblF1ZXVlLmNwcAkocmV2aXNpb24gMjA5 Mzg0KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRSZWFjdGlvblF1ZXVlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjEzLDEwICsyMTMsOCBAQCBpbmxpbmUgdm9pZCBDdXN0b21F bGVtZW50UmVhY3Rpb25TdGFjazo6CiAKIGlubGluZSB2b2lkIEN1c3RvbUVsZW1lbnRSZWFjdGlv blN0YWNrOjpFbGVtZW50UXVldWU6Omludm9rZUFsbCgpCiB7Ci0jaWYgIUFTU0VSVF9ESVNBQkxF RAogICAgIFJFTEVBU0VfQVNTRVJUKCFtX2ludm9raW5nKTsKICAgICBTZXRGb3JTY29wZTxib29s PiBpbnZva2luZyhtX2ludm9raW5nLCB0cnVlKTsKLSNlbmRpZgogICAgIFZlY3RvcjxSZWY8RWxl bWVudD4+IGVsZW1lbnRzOwogICAgIGVsZW1lbnRzLnN3YXAobV9lbGVtZW50cyk7CiAgICAgUkVM RUFTRV9BU1NFUlQobV9lbGVtZW50cy5pc0VtcHR5KCkpOwo=