16480 2007-12-17 14:23:17 -0800 Document::completeURL should return a KURL 2011-09-12 09:53:59 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 16485 16487 1 brettw webkit-unassigned kaustubh.ra sam oldest_to_newest 64567 0 brettw 2007-12-17 14:23:17 -0800 Document::completeURL returns either a String or a DepricatedString. Since the output is really a URL, it should return a KURL instead. This weirdness causes extra conversions that are not necessary and slow things down. For example, in DocLoader::requestResource: KURL fullURL = m_doc->completeURL(url.deprecatedString()); This does a conversion to a KURL in completeURL, then does a conversion back to a DeprecatedString, then converts back to a KURL. This is a whole extra parse of the URL that's unnecessary. The String version is even sillier, since it has to convert to and from a String before calling the DepricatedString version of completeURL. Some functions HTML* especially, need the string, but they should just get it out of the KURL if they want it. 64581 1 brettw 2007-12-17 14:49:26 -0800 When fixed, this will expose bug 16487 and bug 16485 which will cause a crash in DocLoader::checkForReload. 465564 2 kaustubh.ra 2011-09-12 04:29:25 -0700 I guess this issue is already been fixed. Can be closed. 465643 3 brettw 2011-09-12 09:53:59 -0700 Yup, this was fixed at some point.