164797 2016-11-15 14:48:31 -0800 js/dom/domjit-function-get-element-by-id-licm.html and js/dom/domjit-function-get-element-by-id-changed.html are flaky timeouts 2016-12-08 13:33:53 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED P2 Normal --- 163305 164175 1 ryanhaddad ysuzuki ap commit-queue ggaren sam ysuzuki oldest_to_newest 1251647 0 ryanhaddad 2016-11-15 14:48:31 -0800 js/dom/domjit-function-get-element-by-id-licm.html and js/dom/domjit-function-get-element-by-id-changed.html are flaky timeouts https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20(Tests)/r208747%20(16237)/results.html http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2Fdomjit-function-get-element-by-id-changed.html http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2Fdomjit-function-get-element-by-id-licm.html 1251648 1 ryanhaddad 2016-11-15 14:50:05 -0800 Flakiness dashboard isn't updating at the moment, so I'll try to gather some data on this manually. 1251649 2 ryanhaddad 2016-11-15 14:50:32 -0800 js/dom/domjit-function-get-element-by-id-changed.html timeout on El Capitan Debug WK2: https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r208746%20(9448)/results.html 1251650 3 ryanhaddad 2016-11-15 14:50:32 -0800 js/dom/domjit-function-get-element-by-id-changed.html timeout on El Capitan Debug WK2: https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r208746%20(9448)/results.html 1251652 4 ryanhaddad 2016-11-15 14:50:54 -0800 Tests were added with https://trac.webkit.org/changeset/208412 1251656 5 ysuzuki 2016-11-15 15:00:00 -0800 I guess this becomes flaky after r208588 is landed, correct? If so, I think this is due to the following reason. The performance of the both tests rely on PureGetById. But PureGetById is reverted recently in r208588. Then, this revert makes the both tests flaky. Once PureGetById patch is relanded OR this change[1] is landed, I believe the both tests becomes unflaky. Until PureGetById patch is relanded or impure object patch[1] is landed, I think making the both tests TIMEOUT or SKIP is better. What do you think of? [1]: https://bugs.webkit.org/show_bug.cgi?id=164175 1251657 6 ryanhaddad 2016-11-15 15:05:27 -0800 I'm alright with marking them as flaky for the time being while we wait for the patch referenced above is landed. 1251674 7 294886 ysuzuki 2016-11-15 15:19:05 -0800 Created attachment 294886 mark tests as flaky 1251969 8 294886 commit-queue 2016-11-16 12:39:47 -0800 Comment on attachment 294886 mark tests as flaky Rejecting attachment 294886 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 294886, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: y', '--force', '--reviewer', u'Saam Barati']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/TestExpectations Hunk #1 FAILED at 985. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Saam Barati']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2527044 1251987 9 ysuzuki 2016-11-16 13:02:22 -0800 Committed r208807: <http://trac.webkit.org/changeset/208807> 1252867 10 ryanhaddad 2016-11-18 14:27:26 -0800 Reopening because the flaky expectation for these tests was removed, but they are still flaky. 1252868 11 ryanhaddad 2016-11-18 14:28:02 -0800 (In reply to comment #10) > Reopening because the flaky expectation for these tests was removed, but > they are still flaky. https://trac.webkit.org/changeset/208824/trunk/LayoutTests/TestExpectations 1252870 12 ysuzuki 2016-11-18 14:28:34 -0800 (In reply to comment #11) > (In reply to comment #10) > > Reopening because the flaky expectation for these tests was removed, but > > they are still flaky. > > https://trac.webkit.org/changeset/208824/trunk/LayoutTests/TestExpectations Oops, I accidentally removed it. I'll land it soon. 1252873 13 ryanhaddad 2016-11-18 14:32:10 -0800 Marked as flaky again in http://trac.webkit.org/projects/webkit/changeset/208900 1252876 14 ysuzuki 2016-11-18 14:32:59 -0800 (In reply to comment #13) > Marked as flaky again in > http://trac.webkit.org/projects/webkit/changeset/208900 Thanks so much. 1257853 15 ap 2016-12-08 13:33:53 -0800 This still happens on the bots very frequently. It seems like the tests are just ultra slow in debug - they take around 30 seconds consistently. 294886 2016-11-15 15:19:05 -0800 2016-11-16 14:54:30 -0800 mark tests as flaky bug-164797-20161116081902.patch text/plain 1886 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NzU5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDI5MjU4ZjY5MGZiNzI3N2M3NjM4 ZGZjYzBhNjkwYWNlMDJiNjY0Ny4uNzBlNGZjZWFkMDMzZGY0MTEzYWI3YjYzNDc2MGQzMjdjOTEx ODMzZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTExLTE1ICBZdXN1a2UgU3V6dWtpICA8 dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIGpzL2RvbS9kb21qaXQtZnVuY3Rpb24t Z2V0LWVsZW1lbnQtYnktaWQtbGljbS5odG1sIGFuZCBqcy9kb20vZG9taml0LWZ1bmN0aW9uLWdl dC1lbGVtZW50LWJ5LWlkLWNoYW5nZWQuaHRtbCBhcmUgZmxha3kgdGltZW91dHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDc5NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwZXJmb3JtYW5jZSBv ZiB0aGUgYm90aCB0ZXN0cyByZWx5IG9uIFB1cmVHZXRCeUlkLgorICAgICAgICBIb3dldmVyLCBQ dXJlR2V0QnlJZCBpcyByb2xsZWQgb3V0IHRlbXBvcmFyeVsxXSwgdGhlc2UgdGVzdHMgYmVjb21l IHRpbWVkIG91dC4KKyAgICAgICAgVGhpcyBwYXRjaCBtYWtlcyB0aGUgYm90aCB0ZXN0cyBbIFBB U1MgVElNRU9VVCBdIHVudGlsIFB1cmVHZXRCeUlkIHBhdGNoWzFdIGlzCisgICAgICAgIHJlbGFu ZGVkIG9yIGltcHVyZSBvYmplY3Qgb3B0aW1pemF0aW9uIHBhdGNoWzJdIGlzIGxhbmRlZC4KKwor ICAgICAgICBbMV06IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjMz MDUKKyAgICAgICAgWzJdOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY0MTc1CisKKyAgICAgICAgKiBUZXN0RXhwZWN0YXRpb25zOgorCiAyMDE2LTExLTE1ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CiAKICAgICAgICAganMtdGVzdC1wcmUuanM6 OnNob3VsZFJlamVjdCBkb2Vzbid0IG5lZWQgX3JlamVjdENhbGxiYWNrIGFuZCBfcmVzb2x2ZUNh bGxiYWNrCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0 VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA5N2VlZmQ5ZjRlOGViYWU5MzM1MmQzMzhmM2Zm ZTBiMWFjYzQyMjlmLi44ZWQ0ODk2MDk2YzBjYTU4ODI0NDYxNDg5YjhhMjkzMmVmNTQ4MmU4IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3Rz L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTk4NSwzICs5ODUsNiBAQCB3ZWJraXQub3JnL2IvMTY0MjI5 IG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy92b2x1bWUtc3VwcG9ydC92b2x1bWUtc3VwcG9y dC1jbAogCiB3ZWJraXQub3JnL2IvMTY0MDgwIGh0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5 YmkvY2xvc2VkLXdoZW4tZW50ZXJpbmctcGFnZS1jYWNoZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0K IHdlYmtpdC5vcmcvYi8xNjQwODAgaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9zdG9w LW9uLXJlc3VtZS1pbi1lcnJvci1oYW5kbGVyLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQorCit3ZWJr aXQub3JnL2IvMTY0Nzk3IGpzL2RvbS9kb21qaXQtZnVuY3Rpb24tZ2V0LWVsZW1lbnQtYnktaWQt bGljbS5odG1sIFsgUGFzcyBUaW1lb3V0IF0KK3dlYmtpdC5vcmcvYi8xNjQ3OTcganMvZG9tL2Rv bWppdC1mdW5jdGlvbi1nZXQtZWxlbWVudC1ieS1pZC1jaGFuZ2VkLmh0bWwgWyBQYXNzIFRpbWVv dXQgXQo=