164796 2016-11-15 14:40:02 -0800 UIScriptController: setting a callback to undefined should unregister it 2016-11-15 16:25:38 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser simon.fraser oldest_to_newest 1251642 0 simon.fraser 2016-11-15 14:40:02 -0800 UIScriptController: setting a callback to undefined should unregister it 1251643 1 294882 simon.fraser 2016-11-15 14:42:40 -0800 Created attachment 294882 Patch 1251713 2 simon.fraser 2016-11-15 16:25:38 -0800 https://trac.webkit.org/changeset/208769 294882 2016-11-15 14:42:40 -0800 2016-11-15 14:46:20 -0800 Patch bug-164796-20161115144238.patch text/plain 7444 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NzM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDBmMTMyNzI4ODU2ZGZjZTNjNjQyYjYyZTEyZDNmYWY5 OTE0OWZhOC4uMTI1ZjU0M2JkMDdlNzJlNmMwNzgwMTg0OTljMjhlY2Y5OTY4NzNlZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDE2LTExLTE1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIFVJU2NyaXB0Q29udHJvbGxlcjogc2V0dGluZyBhIGNhbGxiYWNrIHRvIHVuZGVm aW5lZCBzaG91bGQgdW5yZWdpc3RlciBpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY0Nzk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisgICAgICAgIAorICAgICAgICAiSW1tZWRpYXRlIiBVSSBzY3JpcHRzICh0aG9zZSB0 aGF0IGRvbid0IHNjaGVkdWxlIGFueSBhc3luYyB0YXNrcykgc2hvdWxkIHJldHVybgorICAgICAg ICBpbW1lZGlhdGVseSwgd2l0aG91dCB0aGUgbmVlZCB0byBjYWxsIHVpU2NyaXB0Q29tcGxldGUo KS4gSG93ZXZlciwgdGhpcyBpcyBicm9rZW4gaWYKKyAgICAgICAgYW4gZWFybGllciBVSSBzY3Jp cHQgcmVnaXN0ZXJlZCBhIGNhbGxiYWNrIChzaW5jZSBuby1vbmUgY2xlYXJzIHRoYXQgY2FsbGJh Y2sgYWZ0ZXIgdGhlCisgICAgICAgIGZpcnN0IHNjcmlwdCBjb21wbGV0ZXMpLgorCisgICAgICAg IE1ha2UgcG9zc2libGUgdGhlIHdvcmthcm91bmQgb2Ygc2V0dGluZyB0aGUgY2FsbGJhY2sgdG8g dW5kZWZpbmVkLCB3aGljaCBwcmV2aW91c2x5IGRpZAorICAgICAgICBub3QgY2xlYXIgdGhlIGNh bGxiYWNrIHJlZ2lzdHJhdGlvbi4KKworICAgICAgICAqIFRlc3RSdW5uZXJTaGFyZWQvVUlTY3Jp cHRDb250ZXh0L1VJU2NyaXB0Q29udGV4dC5jcHA6CisgICAgICAgIChVSVNjcmlwdENvbnRleHQ6 OnJlZ2lzdGVyQ2FsbGJhY2spOgorICAgICAgICAqIFRlc3RSdW5uZXJTaGFyZWQvVUlTY3JpcHRD b250ZXh0L1VJU2NyaXB0Q29udGV4dC5oOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvaW9z L1VJU2NyaXB0Q29udHJvbGxlcklPUy5tbToKKyAgICAgICAgKFdUUjo6VUlTY3JpcHRDb250cm9s bGVyOjpwbGF0Zm9ybUNsZWFyQWxsQ2FsbGJhY2tzKToKKwogMjAxNi0xMS0xNCAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRW5oYW5jZSBydW4tanNjLXN0cmVzcy10 ZXN0IHNjcmlwdCB0byBhbGxvdyBvcHRpb25hbCB0ZXN0IHNwZWNpZmljIG9wdGlvbnMgdG8gYmUg YWRkZWQgZm9yIGFsbCB0ZXN0IHJ1biBjb25maWd1cmF0aW9ucy4KZGlmZiAtLWdpdCBhL1Rvb2xz L1Rlc3RSdW5uZXJTaGFyZWQvVUlTY3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udGV4dC5jcHAgYi9U b29scy9UZXN0UnVubmVyU2hhcmVkL1VJU2NyaXB0Q29udGV4dC9VSVNjcmlwdENvbnRleHQuY3Bw CmluZGV4IGUyZTdiMGQxMzc1YzRkZWY3ZTA1OTJmYWYwMmM0ZDY1ZmQ5ZWQ4ODcuLmJiNWM5ZThi ZWNhZWE2OThmNzg1YTNlNWJkZTIwODQyZTY1NDlhZjcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RS dW5uZXJTaGFyZWQvVUlTY3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udGV4dC5jcHAKKysrIGIvVG9v bHMvVGVzdFJ1bm5lclNoYXJlZC9VSVNjcmlwdENvbnRleHQvVUlTY3JpcHRDb250ZXh0LmNwcApA QCAtMTE3LDYgKzExNyw5IEBAIHVuc2lnbmVkIFVJU2NyaXB0Q29udGV4dDo6cmVnaXN0ZXJDYWxs YmFjayhKU1ZhbHVlUmVmIHRhc2tDYWxsYmFjaywgQ2FsbGJhY2tUeXBlCiAgICAgaWYgKG1fY2Fs bGJhY2tzLmNvbnRhaW5zKHR5cGUpKQogICAgICAgICB1bnJlZ2lzdGVyQ2FsbGJhY2sodHlwZSk7 CiAKKyAgICBpZiAoSlNWYWx1ZUlzVW5kZWZpbmVkKG1fY29udGV4dC5nZXQoKSwgdGFza0NhbGxi YWNrKSkKKyAgICAgICAgcmV0dXJuIDA7CisKICAgICByZXR1cm4gcHJlcGFyZUZvckFzeW5jVGFz ayh0YXNrQ2FsbGJhY2ssIHR5cGUpOwogfQogCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0UnVubmVy U2hhcmVkL1VJU2NyaXB0Q29udGV4dC9VSVNjcmlwdENvbnRleHQuaCBiL1Rvb2xzL1Rlc3RSdW5u ZXJTaGFyZWQvVUlTY3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udGV4dC5oCmluZGV4IDAxZWYyMzgw YjBmYzc4MzIxMzBmZjJlYTNjZmVjMWUwNDg4NmEyY2EuLjRlYzE4MjkzYTAzMzExNTVmZjljYjIz NTRhYzU1NWJhMTQwOGRiYmMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSdW5uZXJTaGFyZWQvVUlT Y3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udGV4dC5oCisrKyBiL1Rvb2xzL1Rlc3RSdW5uZXJTaGFy ZWQvVUlTY3JpcHRDb250ZXh0L1VJU2NyaXB0Q29udGV4dC5oCkBAIC00OSw3ICs0OSw4IEBAIHB1 YmxpYzoKIGNvbnN0IHVuc2lnbmVkIGZpcnN0Tm9uUGVyc2lzdGVudENhbGxiYWNrSUQgPSAxMDAw OwogCiB0eXBlZGVmIGVudW0gIHsKLSAgICBDYWxsYmFja1R5cGVXaWxsQmVnaW5ab29taW5nID0g MCwKKyAgICBDYWxsYmFja1R5cGVJbnZhbGlkID0gMCwKKyAgICBDYWxsYmFja1R5cGVXaWxsQmVn aW5ab29taW5nLAogICAgIENhbGxiYWNrVHlwZURpZEVuZFpvb21pbmcsCiAgICAgQ2FsbGJhY2tU eXBlRGlkU2hvd0tleWJvYXJkLAogICAgIENhbGxiYWNrVHlwZURpZEhpZGVLZXlib2FyZCwKZGlm ZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL1VJU2NyaXB0Q29udHJvbGxlcklP Uy5tbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL1VJU2NyaXB0Q29udHJvbGxlcklPUy5t bQppbmRleCBmMTc1MDQ1NDFlNzk1ZWRhODYwN2Y1MGQwNjgyYTVjMjhiODg3MWQ4Li44MTg0YjZk ODBhMTBkZWI3NjRkMDM0NTBiNWIxODgyZGUzMzkzNjA4IDEwMDY0NAotLS0gYS9Ub29scy9XZWJL aXRUZXN0UnVubmVyL2lvcy9VSVNjcmlwdENvbnRyb2xsZXJJT1MubW0KKysrIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9pb3MvVUlTY3JpcHRDb250cm9sbGVySU9TLm1tCkBAIC00OTgsNiArNDk4 LDExIEBAIHZvaWQgVUlTY3JpcHRDb250cm9sbGVyOjpwbGF0Zm9ybVNldERpZEVuZFNjcm9sbGlu Z0NhbGxiYWNrKCkKIHZvaWQgVUlTY3JpcHRDb250cm9sbGVyOjpwbGF0Zm9ybUNsZWFyQWxsQ2Fs bGJhY2tzKCkKIHsKICAgICBUZXN0UnVubmVyV0tXZWJWaWV3ICp3ZWJWaWV3ID0gVGVzdENvbnRy b2xsZXI6OnNpbmdsZXRvbigpLm1haW5XZWJWaWV3KCktPnBsYXRmb3JtVmlldygpOworICAgIAor ICAgIHdlYlZpZXcuZGlkU3RhcnRGb3JtQ29udHJvbEludGVyYWN0aW9uQ2FsbGJhY2sgPSBuaWw7 CisgICAgd2ViVmlldy5kaWRFbmRGb3JtQ29udHJvbEludGVyYWN0aW9uQ2FsbGJhY2sgPSBuaWw7 CisgICAgd2ViVmlldy5kaWRTaG93Rm9yY2VQcmVzc1ByZXZpZXdDYWxsYmFjayA9IG5pbDsKKyAg ICB3ZWJWaWV3LmRpZERpc21pc3NGb3JjZVByZXNzUHJldmlld0NhbGxiYWNrID0gbmlsOwogICAg IHdlYlZpZXcuZGlkRW5kWm9vbWluZ0NhbGxiYWNrID0gbmlsOwogICAgIHdlYlZpZXcud2lsbEJl Z2luWm9vbWluZ0NhbGxiYWNrID0gbmlsOwogICAgIHdlYlZpZXcuZGlkSGlkZUtleWJvYXJkQ2Fs bGJhY2sgPSBuaWw7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTdmYWFmOWNkNTBhMmIxOTdlYWQzNmViNTg3ZmMyMmEwMDc4 MmZkMi4uYTBkNzAzZDA1OTE2NWVkZWJiZWE4ZWM1MjE1NDM0MWZiNzZkYjEyYiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEzIEBACisyMDE2LTExLTE1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgorCisgICAgICAgIFVJU2NyaXB0Q29udHJvbGxlcjogc2V0dGluZyBhIGNhbGxiYWNr IHRvIHVuZGVmaW5lZCBzaG91bGQgdW5yZWdpc3RlciBpdAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0Nzk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2hhcm5lc3MvdWktc2lkZS1zY3JpcHQt dW5yZWdpc3Rlci1jYWxsYmFjay1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv aGFybmVzcy91aS1zaWRlLXNjcmlwdC11bnJlZ2lzdGVyLWNhbGxiYWNrLmh0bWw6IEFkZGVkLgor CiAyMDE2LTExLTE1ICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KIAogICAg ICAgICBBWDogTmVlZCB0byB1cGRhdGUgaW1wbGljaXQvZGVmYXVsdCB2YWx1ZXMgZm9yIGFyaWEt dmFsdWVtaW4sIGFyaWEtdmFsdWVub3csIGFuZCBhcmlhLXZhbHVlbWF4CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvdWktc2lkZS1zY3JpcHQtdW5yZWdpc3Rlci1jYWxsYmFj ay1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3MvdWktc2lkZS1zY3JpcHQt dW5yZWdpc3Rlci1jYWxsYmFjay1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYzljNjVkZTFkMzJh MzAyZmM4ZGQzZjNkZDVlZjliNDkxZmU2ZmI1ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvaGFybmVzcy91aS1zaWRlLXNjcmlwdC11bnJlZ2lzdGVyLWNhbGxiYWNrLWV4cGVj dGVkLnR4dApAQCAtMCwwICsxLDExIEBACitUZXN0IHRoYXQgYSBzZWNvbmQgaW1tZWRpYXRlIFVJ IHNjcmlwdCByZXR1cm5zIGlmIGFuIGVhcmxpZXIgc2NyaXB0IHJlZ2lzdGVyZWQgdGhlbiB1bnJl Z2lzdGVyZWQgYSBjYWxsYmFjaworCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMg b2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFT UyBzY3JpcHRSZXN1bHQgaXMgImFzeW5jIHRhc2sgY29tcGxldGUiCitQQVNTIHNjcmlwdFJlc3Vs dCBpcyAiaW1tZWRpYXRlIHNjcmlwdCBjb21wbGV0ZSIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2hhcm5lc3MvdWktc2lkZS1zY3JpcHQtdW5yZWdpc3Rlci1jYWxsYmFjay5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC9oYXJuZXNzL3VpLXNpZGUtc2NyaXB0LXVucmVnaXN0ZXItY2FsbGJhY2suaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi42NzEyYWM0OTc4NDZlZjZjYWQ4ZmVhZDkwOTIwYjNlYjhmMjI0YWU1Ci0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9oYXJuZXNzL3VpLXNpZGUtc2NyaXB0 LXVucmVnaXN0ZXItY2FsbGJhY2suaHRtbApAQCAtMCwwICsxLDYzIEBACis8IURPQ1RZUEUgaHRt bD4KKworPGh0bWw+Cis8aGVhZD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pz LXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0PgorICAgICAgICAKKyAgICAgICAg dmFyIGpzVGVzdElzQXN5bmMgPSB0cnVlOworICAgICAgICAKKyAgICAgICAgZnVuY3Rpb24gZ2V0 QXN5bmNUYXNrU2NyaXB0KCkKKyAgICAgICAgeworICAgICAgICAgICAgcmV0dXJuIGAoZnVuY3Rp b24oKSB7CisgICAgICAgICAgICAgICAgdWlDb250cm9sbGVyLmRpZEVuZFNjcm9sbGluZ0NhbGxi YWNrID0gZnVuY3Rpb24oKSB7IH07CisgICAgICAgICAgICAgICAgdWlDb250cm9sbGVyLmRpZEVu ZFNjcm9sbGluZ0NhbGxiYWNrID0gdW5kZWZpbmVkOworCisgICAgICAgICAgICAgICAgdWlDb250 cm9sbGVyLmRvQXN5bmNUYXNrKGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgICAgICB1aUNv bnRyb2xsZXIudWlTY3JpcHRDb21wbGV0ZSgnYXN5bmMgdGFzayBjb21wbGV0ZScpOworICAgICAg ICAgICAgICAgIH0pOworICAgICAgICAgICAgfSkoKTtgOworICAgICAgICB9CisKKyAgICAgICAg ZnVuY3Rpb24gZ2V0SW1tZWRpYXRlU2NyaXB0KCkKKyAgICAgICAgeworICAgICAgICAgICAgcmV0 dXJuIGAoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgICAgcmV0dXJuICdpbW1lZGlhdGUgc2Ny aXB0IGNvbXBsZXRlJzsKKyAgICAgICAgICAgIH0pKCk7YDsKKyAgICAgICAgfQorICAgIAorICAg ICAgICB2YXIgc2NyaXB0UmVzdWx0OworICAgICAgICBmdW5jdGlvbiBydW5UZXN0KCkKKyAgICAg ICAgeworICAgICAgICAgICAgZGVzY3JpcHRpb24oJ1Rlc3QgdGhhdCBhIHNlY29uZCBpbW1lZGlh dGUgVUkgc2NyaXB0IHJldHVybnMgaWYgYW4gZWFybGllciBzY3JpcHQgcmVnaXN0ZXJlZCB0aGVu IHVucmVnaXN0ZXJlZCBhIGNhbGxiYWNrJyk7CisKKyAgICAgICAgICAgIGlmICghd2luZG93LnRl c3RSdW5uZXIpIHsKKyAgICAgICAgICAgICAgICBkZWJ1ZygnVGhpcyB0ZXN0IHJlcXVpcmVzIHRl c3RSdW5uZXInKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9CisKKyAg ICAgICAgICAgIGlmICghdGVzdFJ1bm5lci5ydW5VSVNjcmlwdCkgeworICAgICAgICAgICAgICAg IGRlYnVnKCdUaGlzIHRlc3QgcmVxdWlyZXMgcnVuVUlTY3JpcHQnKTsKKyAgICAgICAgICAgICAg ICByZXR1cm47CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIHRlc3RSdW5uZXIucnVuVUlT Y3JpcHQoZ2V0QXN5bmNUYXNrU2NyaXB0KCksIGZ1bmN0aW9uKHJlc3VsdCkgeworICAgICAgICAg ICAgICAgIHNjcmlwdFJlc3VsdCA9IHJlc3VsdDsKKyAgICAgICAgICAgICAgICBzaG91bGRCZUVx dWFsVG9TdHJpbmcoJ3NjcmlwdFJlc3VsdCcsICdhc3luYyB0YXNrIGNvbXBsZXRlJyk7CisKKyAg ICAgICAgICAgICAgICB0ZXN0UnVubmVyLnJ1blVJU2NyaXB0KGdldEltbWVkaWF0ZVNjcmlwdCgp LCBmdW5jdGlvbihyZXN1bHQpIHsKKyAgICAgICAgICAgICAgICAgICAgc2NyaXB0UmVzdWx0ID0g cmVzdWx0OworICAgICAgICAgICAgICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoJ3Njcmlw dFJlc3VsdCcsICdpbW1lZGlhdGUgc2NyaXB0IGNvbXBsZXRlJyk7CisgICAgICAgICAgICAgICAg ICAgIGZpbmlzaEpTVGVzdCgpOworICAgICAgICAgICAgICAgIH0pOworICAgICAgICAgICAgfSk7 CisgICAgICAgIH0KKyAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBydW5U ZXN0LCBmYWxzZSk7CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKworPHByZSBpZD0i cmVzdWx0cyI+PC9wcmU+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9z dC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==