164788 2016-11-15 13:47:00 -0800 It should be possible to disable concurrent GC timeslicing 2016-11-15 14:02:22 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 149432 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1251605 0 fpizlo 2016-11-15 13:47:00 -0800 This will be an excellent testing configuration since it maximizes the chances of race conditions causing things to go terribly wrong. 1251610 1 294875 fpizlo 2016-11-15 13:52:42 -0800 Created attachment 294875 the patch 1251613 2 294875 saam 2016-11-15 13:55:24 -0800 Comment on attachment 294875 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=294875&action=review r=me > Source/JavaScriptCore/ChangeLog:18 > + The idea is that we will usually use this in conjunction with collectContinuously=true Is it worth just setting useCollectorTimeslicing=false when collectContinuously=true inside the compute dependent options function? > Source/JavaScriptCore/heap/Heap.cpp:686 > + // Disabling collector timeslicing is meant to be used together with > + // --collectContinuously=true to maximize the opportunity for harmful races. Might be worth mentioning this in the options file. > Source/JavaScriptCore/runtime/Options.h:197 > + v(bool, useCollectorTimeslicing, true, Normal, nullptr) \ It's probably worth adding a description here. 1251616 3 fpizlo 2016-11-15 13:58:13 -0800 (In reply to comment #2) > Comment on attachment 294875 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=294875&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:18 > > + The idea is that we will usually use this in conjunction with collectContinuously=true > > Is it worth just setting useCollectorTimeslicing=false when > collectContinuously=true inside the compute dependent options function? No, because I want to be able to test continuous collection with collector timeslicing. That will shake out races in the stop-resume code. > > > Source/JavaScriptCore/heap/Heap.cpp:686 > > + // Disabling collector timeslicing is meant to be used together with > > + // --collectContinuously=true to maximize the opportunity for harmful races. > > Might be worth mentioning this in the options file. > > > Source/JavaScriptCore/runtime/Options.h:197 > > + v(bool, useCollectorTimeslicing, true, Normal, nullptr) \ > > It's probably worth adding a description here. Can you think of anything more clever than "use collector timeslicing"? 1251619 4 fpizlo 2016-11-15 14:02:22 -0800 Landed in https://trac.webkit.org/changeset/208754 294875 2016-11-15 13:52:42 -0800 2016-11-15 13:55:24 -0800 the patch blah.patch text/plain 6158 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA4NzUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBA CisyMDE2LTExLTE1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGRpc2FibGUgY29uY3VycmVudCBHQyB0aW1lc2xpY2lu ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0Nzg4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAg ICBDb2xsZWN0b3IgdGltZXNsaWNpbmcgbWVhbnMgdGhhdCB0aGUgY29sbGVjdG9yIHdpbGwgdHJ5 IHRvIHBhdXNlIG9uY2UgZXZlcnkgMm1zLiBUaGlzIGlzCisgICAgICAgIGdyZWF0IGJlY2F1c2Ug aXQgdGhyb3R0bGVzIHRoZSBtdXRhdG9yIGFuZCBwcmV2ZW50cyBpdCBmcm9tIG91dHBhY2luZyB0 aGUgY29sbGVjdG9yLiBCdXQKKyAgICAgICAgaXQgcmVkdWNlcyBzb21lIG9mIHRoZSBlZmZpY2Fj eSBvZiB0aGUgY29sbGVjdENvbnRpbnVvdXNseT10cnVlIGNvbmZpZ3VyYXRpb246IHdoaWxlCisg ICAgICAgIGl0J3MgZ3JlYXQgdGhhdCBjb2xsZWN0aW5nIGNvbnRpbnVvdXNseSBtZWFucyB0aGF0 IHRoZSBjb2xsZWN0b3Igd2lsbCBhbHNvIHBhdXNlIG1vcmUKKyAgICAgICAgZnJlcXVlbnRseSBh bmQgc28gaXQgd2lsbCB0ZXN0IHRoZSBwYXVzaW5nIGNvZGUsIGl0IGFsc28gbWVhbnMgdGhhdCB0 aGUgY29sbGVjdG9yIHdpbGwKKyAgICAgICAgc3BlbmQgbGVzcyB0aW1lIHJ1bm5pbmcgY29uY3Vy cmVudGx5LiBUaGUgcHJpbWFyeSBwdXJwb3NlIG9mIGNvbGxlY3RDb250aW51b3VzbHkgaXMgdG8K KyAgICAgICAgbWF4aW1pemUgdGhlIGFtb3VudCBvZiB0aW1lIHRoYXQgdGhlIGNvbGxlY3RvciBp cyBydW5uaW5nIGNvbmN1cnJlbnRseSB0byB0aGUgbXV0YXRvciB0bworICAgICAgICBtYXhpbWl6 ZSB0aGUgbGlrZWxpaG9vZCB0aGF0IGEgcmFjZSB3aWxsIGNhdXNlIGEgZGV0ZWN0YWJsZSBlcnJv ci4KKyAgICAgICAgCisgICAgICAgIFRoaXMgYWRkcyBhbiBvcHRpb24gdG8gZGlzYWJsZSBjb2xs ZWN0b3IgdGltZXNsaWNpbmcgKHVzZUNvbGxlY3RvclRpbWVzbGljaW5nPWZhbHNlKS4KKyAgICAg ICAgVGhlIGlkZWEgaXMgdGhhdCB3ZSB3aWxsIHVzdWFsbHkgdXNlIHRoaXMgaW4gY29uanVuY3Rp b24gd2l0aCBjb2xsZWN0Q29udGludW91c2x5PXRydWUKKyAgICAgICAgdG8gZmluZCByYWNlIGNv bmRpdGlvbnMgZHVyaW5nIG1hcmtpbmcsIGJ1dCB3ZSBjYW4gYWxzbyB1c2UgdGhlIHR3byBvcHRp b25zCisgICAgICAgIGluZGVwZW5kZW50bHkgdG8gZm9jdXMgb3VyIHRlc3Rpbmcgb24gb3RoZXIg dGhpbmdzLgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6 bWFya1RvRml4cG9pbnQpOgorICAgICAgICAqIGhlYXAvU2xvdFZpc2l0b3IuY3BwOgorICAgICAg ICAoSlNDOjpTbG90VmlzaXRvcjo6ZHJhaW5JblBhcmFsbGVsKTogV2Ugc2hvdWxkIGhhdmUgYWRk ZWQgdGhpcyBoZWxwZXIgYWdlcyBhZ28uCisgICAgICAgICogaGVhcC9TbG90VmlzaXRvci5oOgor ICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5oOgorCiAyMDE2LTExLTE1ICBGaWxpcCBQaXpsbyAg PGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgVGhlIGNvbmN1cnJlbnQgR0Mgc2hvdWxkIGhh dmUgYSB0aW1lc2xpY2luZyBjb250cm9sbGVyCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9IZWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9I ZWFwLmNwcAkocmV2aXNpb24gMjA4NzUwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv SGVhcC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY2OSwyMSArNjY5LDIzIEBAIHZvaWQgSGVhcDo6 bWFya1RvRml4cG9pbnQoZG91YmxlIGdjU3RhcnQKICAgICAgICAgewogICAgICAgICAgICAgVGlt aW5nU2NvcGUgdHJhY2VUaW1pbmdTY29wZSgqdGhpcywgIkhlYXA6Om1hcmtUb0ZpeHBvaW50IHRy YWNpbmciKTsKICAgICAgICAgICAgIFBhcmFsbGVsTW9kZUVuYWJsZXIgZW5hYmxlcigqbV9jb2xs ZWN0b3JTbG90VmlzaXRvcik7Ci0gICAgICAgICAgICBmb3IgKDs7KSB7Ci0gICAgICAgICAgICAg ICAgTW9ub3RvbmljVGltZSBub3cgPSBNb25vdG9uaWNUaW1lOjpub3coKTsKLSAgICAgICAgICAg ICAgICBTbG90VmlzaXRvcjo6U2hhcmVkRHJhaW5SZXN1bHQgZHJhaW5SZXN1bHQ7Ci0gICAgICAg ICAgICAgICAgaWYgKHNob3VsZEJlUmVzdW1lZChub3cpKSB7Ci0gICAgICAgICAgICAgICAgICAg IFJlc3VtZVRoZVdvcmxkU2NvcGUgcmVzdW1lVGhlV29ybGRTY29wZSgqdGhpcyk7Ci0gICAgICAg ICAgICAgICAgICAgIG1fY29sbGVjdG9yU2xvdFZpc2l0b3ItPmRvbmF0ZUFuZERyYWluKHRpbWVU b1N0b3Aobm93KSk7Ci0gICAgICAgICAgICAgICAgICAgIGRyYWluUmVzdWx0ID0gbV9jb2xsZWN0 b3JTbG90VmlzaXRvci0+ZHJhaW5Gcm9tU2hhcmVkKAotICAgICAgICAgICAgICAgICAgICAgICAg U2xvdFZpc2l0b3I6Ok1hc3RlckRyYWluLCB0aW1lVG9TdG9wKG5vdykpOwotICAgICAgICAgICAg ICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgICAgIG1fY29sbGVjdG9yU2xvdFZpc2l0b3It PmRvbmF0ZUFuZERyYWluKHRpbWVUb1Jlc3VtZShub3cpKTsKLSAgICAgICAgICAgICAgICAgICAg ZHJhaW5SZXN1bHQgPSBtX2NvbGxlY3RvclNsb3RWaXNpdG9yLT5kcmFpbkZyb21TaGFyZWQoCi0g ICAgICAgICAgICAgICAgICAgICAgICBTbG90VmlzaXRvcjo6TWFzdGVyRHJhaW4sIHRpbWVUb1Jl c3VtZShub3cpKTsKKyAgICAgICAgICAgIGlmIChPcHRpb25zOjp1c2VDb2xsZWN0b3JUaW1lc2xp Y2luZygpKSB7CisgICAgICAgICAgICAgICAgZm9yICg7OykgeworICAgICAgICAgICAgICAgICAg ICBNb25vdG9uaWNUaW1lIG5vdyA9IE1vbm90b25pY1RpbWU6Om5vdygpOworICAgICAgICAgICAg ICAgICAgICBTbG90VmlzaXRvcjo6U2hhcmVkRHJhaW5SZXN1bHQgZHJhaW5SZXN1bHQ7CisgICAg ICAgICAgICAgICAgICAgIGlmIChzaG91bGRCZVJlc3VtZWQobm93KSkgeworICAgICAgICAgICAg ICAgICAgICAgICAgUmVzdW1lVGhlV29ybGRTY29wZSByZXN1bWVUaGVXb3JsZFNjb3BlKCp0aGlz KTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGRyYWluUmVzdWx0ID0gbV9jb2xsZWN0b3JTbG90 VmlzaXRvci0+ZHJhaW5JblBhcmFsbGVsKHRpbWVUb1N0b3Aobm93KSk7CisgICAgICAgICAgICAg ICAgICAgIH0gZWxzZQorICAgICAgICAgICAgICAgICAgICAgICAgZHJhaW5SZXN1bHQgPSBtX2Nv bGxlY3RvclNsb3RWaXNpdG9yLT5kcmFpbkluUGFyYWxsZWwodGltZVRvUmVzdW1lKG5vdykpOwor ICAgICAgICAgICAgICAgICAgICBpZiAoZHJhaW5SZXN1bHQgPT0gU2xvdFZpc2l0b3I6OlNoYXJl ZERyYWluUmVzdWx0OjpEb25lKQorICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAg ICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgIGlmIChkcmFpblJlc3VsdCA9PSBTbG90Vmlz aXRvcjo6U2hhcmVkRHJhaW5SZXN1bHQ6OkRvbmUpCi0gICAgICAgICAgICAgICAgICAgIGJyZWFr OworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICAvLyBEaXNhYmxpbmcgY29s bGVjdG9yIHRpbWVzbGljaW5nIGlzIG1lYW50IHRvIGJlIHVzZWQgdG9nZXRoZXIgd2l0aAorICAg ICAgICAgICAgICAgIC8vIC0tY29sbGVjdENvbnRpbnVvdXNseT10cnVlIHRvIG1heGltaXplIHRo ZSBvcHBvcnR1bml0eSBmb3IgaGFybWZ1bCByYWNlcy4KKyAgICAgICAgICAgICAgICBSZXN1bWVU aGVXb3JsZFNjb3BlIHJlc3VtZVRoZVdvcmxkU2NvcGUoKnRoaXMpOworICAgICAgICAgICAgICAg IG1fY29sbGVjdG9yU2xvdFZpc2l0b3ItPmRyYWluSW5QYXJhbGxlbCgpOwogICAgICAgICAgICAg fQogICAgICAgICB9CiAgICAgfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvU2xv dFZpc2l0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1Ns b3RWaXNpdG9yLmNwcAkocmV2aXNpb24gMjA4NzUwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvU2xvdFZpc2l0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzMsNiArNDczLDEyIEBA IFNsb3RWaXNpdG9yOjpTaGFyZWREcmFpblJlc3VsdCBTbG90VmlzaXQKICAgICB9CiB9CiAKK1Ns b3RWaXNpdG9yOjpTaGFyZWREcmFpblJlc3VsdCBTbG90VmlzaXRvcjo6ZHJhaW5JblBhcmFsbGVs KE1vbm90b25pY1RpbWUgdGltZW91dCkKK3sKKyAgICBkb25hdGVBbmREcmFpbih0aW1lb3V0KTsK KyAgICByZXR1cm4gZHJhaW5Gcm9tU2hhcmVkKE1hc3RlckRyYWluLCB0aW1lb3V0KTsKK30KKwog dm9pZCBTbG90VmlzaXRvcjo6YWRkT3BhcXVlUm9vdCh2b2lkKiByb290KQogewogICAgIGlmIChP cHRpb25zOjpudW1iZXJPZkdDTWFya2VycygpID09IDEpIHsKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9oZWFwL1Nsb3RWaXNpdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvU2xvdFZpc2l0b3IuaAkocmV2aXNpb24gMjA4NzUwKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvU2xvdFZpc2l0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMTA1LDYg KzEwNSw4IEBAIHB1YmxpYzoKICAgICBlbnVtIGNsYXNzIFNoYXJlZERyYWluUmVzdWx0IHsgRG9u ZSwgVGltZWRPdXQgfTsKICAgICBTaGFyZWREcmFpblJlc3VsdCBkcmFpbkZyb21TaGFyZWQoU2hh cmVkRHJhaW5Nb2RlLCBNb25vdG9uaWNUaW1lIHRpbWVvdXQgPSBNb25vdG9uaWNUaW1lOjppbmZp bml0eSgpKTsKIAorICAgIFNoYXJlZERyYWluUmVzdWx0IGRyYWluSW5QYXJhbGxlbChNb25vdG9u aWNUaW1lIHRpbWVvdXQgPSBNb25vdG9uaWNUaW1lOjppbmZpbml0eSgpKTsKKwogICAgIHZvaWQg aGFydmVzdFdlYWtSZWZlcmVuY2VzKCk7CiAgICAgdm9pZCBmaW5hbGl6ZVVuY29uZGl0aW9uYWxG aW5hbGl6ZXJzKCk7CiAgICAgCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9P cHRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0 aW9ucy5oCShyZXZpc2lvbiAyMDg3NTApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcHRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTE5NCw2ICsxOTQsNyBAQCB0eXBlZGVmIGNv bnN0IGNoYXIqIG9wdGlvblN0cmluZzsKICAgICB2KGRvdWJsZSwgbWVkaXVtSGVhcFJBTUZyYWN0 aW9uLCAwLjUsIE5vcm1hbCwgbnVsbHB0cikgXAogICAgIHYoZG91YmxlLCBtZWRpdW1IZWFwR3Jv d3RoRmFjdG9yLCAxLjUsIE5vcm1hbCwgbnVsbHB0cikgXAogICAgIHYoZG91YmxlLCBsYXJnZUhl YXBHcm93dGhGYWN0b3IsIDEuMjQsIE5vcm1hbCwgbnVsbHB0cikgXAorICAgIHYoYm9vbCwgdXNl Q29sbGVjdG9yVGltZXNsaWNpbmcsIHRydWUsIE5vcm1hbCwgbnVsbHB0cikgXAogICAgIHYoZG91 YmxlLCBjb25jdXJyZW50R0NIZWFkcm9vbVJhdGlvLCAxLjUsIE5vcm1hbCwgbnVsbHB0cikgXAog ICAgIHYoZG91YmxlLCBjb25jdXJyZW50R0NQZXJpb2RNUywgMiwgTm9ybWFsLCBudWxscHRyKSBc CiAgICAgdihib29sLCBzY3JpYmJsZUZyZWVDZWxscywgZmFsc2UsIE5vcm1hbCwgbnVsbHB0cikg XAo=