164781 2016-11-15 11:17:47 -0800 The jsc shell's setImpureGetterDelegate() should ensure that the set value is an ImpureGetter. 2016-11-15 11:45:30 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1251496 0 mark.lam 2016-11-15 11:17:47 -0800 Patch coming. 1251497 1 mark.lam 2016-11-15 11:18:23 -0800 <rdar://problem/28418590> 1251507 2 294857 mark.lam 2016-11-15 11:30:18 -0800 Created attachment 294857 proposed patch. 1251511 3 294857 ggaren 2016-11-15 11:33:20 -0800 Comment on attachment 294857 proposed patch. r=me 1251515 4 294857 msaboff 2016-11-15 11:35:31 -0800 Comment on attachment 294857 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=294857&action=review > JSTests/stress/jsc-setImpureGetterDelegate-on-bad-type.js:2 > +// This test passes if it does not crash or triggers any assertion failures. How about "trigger" singular? 1251516 5 mark.lam 2016-11-15 11:36:49 -0800 (In reply to comment #4) > Comment on attachment 294857 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=294857&action=review > > > JSTests/stress/jsc-setImpureGetterDelegate-on-bad-type.js:2 > > +// This test passes if it does not crash or triggers any assertion failures. > > How about "trigger" singular? Thanks. Fixed. 1251524 6 mark.lam 2016-11-15 11:45:30 -0800 Thanks for the reviews. Landed in r208741: <http://trac.webkit.org/r208741>. 294857 2016-11-15 11:30:18 -0800 2016-11-15 11:33:20 -0800 proposed patch. bug-164781.patch text/plain 3486 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDg3MzgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE2LTExLTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBUaGUganNjIHNoZWxsJ3Mgc2V0SW1wdXJlR2V0dGVyRGVsZWdhdGUoKSBz aG91bGQgZW5zdXJlIHRoYXQgdGhlIHNldCB2YWx1ZSBpcyBhbiBJbXB1cmVHZXR0ZXIuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ3ODEKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzI4NDE4NTkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2pzYy1zZXRJbXB1cmVHZXR0ZXJEZWxlZ2F0 ZS1vbi1iYWQtdHlwZS5qczogQWRkZWQuCisKIDIwMTYtMTEtMTUgIFl1c3VrZSBTdXp1a2kgIDx1 dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0RPTUpJVF0gQWxsb3cgdXNpbmcgbWFj cm8gYXNzZW1ibGVyIHNjcmF0Y2hlcyBpbiBGVEwgQ2hlY2tET00KSW5kZXg6IEpTVGVzdHMvc3Ry ZXNzL2pzYy1zZXRJbXB1cmVHZXR0ZXJEZWxlZ2F0ZS1vbi1iYWQtdHlwZS5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKU1Rlc3RzL3N0cmVzcy9qc2Mtc2V0SW1wdXJlR2V0dGVyRGVsZWdhdGUtb24tYmFkLXR5 cGUuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvanNjLXNldEltcHVyZUdldHRl ckRlbGVnYXRlLW9uLWJhZC10eXBlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjEgQEAK Ky8vQCBydW5GVExOb0NKSVQKKy8vIFRoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3QgY3Jh c2ggb3IgdHJpZ2dlcnMgYW55IGFzc2VydGlvbiBmYWlsdXJlcy4KKworZnVuY3Rpb24gc2hvdWxk RXF1YWwoYWN0dWFsLCBleHBlY3RlZCkgeworICAgIGlmIChhY3R1YWwgIT0gZXhwZWN0ZWQpIHsK KyAgICAgICAgdGhyb3cgIkVSUk9SOiBleHBlY3QgIiArIGV4cGVjdGVkICsgIiwgYWN0dWFsICIg KyBhY3R1YWw7CisgICAgfQorfQorCit2YXIgYXJyYXlCdWZmZXIgPSBuZXcgQXJyYXlCdWZmZXIo MHgyMCk7Cit2YXIgZGF0YVZpZXdfQSA9IG5ldyBEYXRhVmlldyhhcnJheUJ1ZmZlcik7Cit2YXIg ZGF0YVZpZXdfQiA9IG5ldyBEYXRhVmlldyhhcnJheUJ1ZmZlcik7CisKK3ZhciBleGNlcHRpb247 Cit0cnkgeworICAgIHNldEltcHVyZUdldHRlckRlbGVnYXRlKGRhdGFWaWV3X0EsIGRhdGFWaWV3 X0IpOworfSBjYXRjaCAoZSkgeworICAgIGV4Y2VwdGlvbiA9IGU7Cit9CisKK3Nob3VsZEVxdWFs KGV4Y2VwdGlvbiwgIlR5cGVFcnJvcjogYXJndW1lbnQgaXMgbm90IGFuIEltcHVyZUdldHRlciIp OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDg3MzgpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTYtMTEtMTUgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAg IFRoZSBqc2Mgc2hlbGwncyBzZXRJbXB1cmVHZXR0ZXJEZWxlZ2F0ZSgpIHNob3VsZCBlbnN1cmUg dGhhdCB0aGUgc2V0IHZhbHVlIGlzIGFuIEltcHVyZUdldHRlci4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDc4MQorICAgICAgICA8cmRhcjovL3By b2JsZW0vMjg0MTg1OTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBqc2MuY3BwOgorICAgICAgICAoZnVuY3Rpb25TZXRJbXB1cmVHZXR0ZXJEZWxl Z2F0ZSk6CisKIDIwMTYtMTEtMTUgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5j b20+CiAKICAgICAgICAgW0RPTUpJVF0gQWxsb3cgdXNpbmcgbWFjcm8gYXNzZW1ibGVyIHNjcmF0 Y2hlcyBpbiBGVEwgQ2hlY2tET00KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCShyZXZpc2lvbiAy MDg3MzgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTc1MCwxNSArMTc1MCwyMiBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0 aW9uQ3JlCiAKIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25TZXRJbXB1cmVH ZXR0ZXJEZWxlZ2F0ZShFeGVjU3RhdGUqIGV4ZWMpCiB7Ci0gICAgSlNMb2NrSG9sZGVyIGxvY2so ZXhlYyk7CisgICAgVk0mIHZtID0gZXhlYy0+dm0oKTsKKyAgICBKU0xvY2tIb2xkZXIgbG9jayh2 bSk7CisgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOworCiAgICAgSlNW YWx1ZSBiYXNlID0gZXhlYy0+YXJndW1lbnQoMCk7CiAgICAgaWYgKCFiYXNlLmlzT2JqZWN0KCkp CiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CiAgICAgSlNW YWx1ZSBkZWxlZ2F0ZSA9IGV4ZWMtPmFyZ3VtZW50KDEpOwogICAgIGlmICghZGVsZWdhdGUuaXNP YmplY3QoKSkKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsK LSAgICBJbXB1cmVHZXR0ZXIqIGltcHVyZUdldHRlciA9IGpzQ2FzdDxJbXB1cmVHZXR0ZXIqPihh c09iamVjdChiYXNlLmFzQ2VsbCgpKSk7Ci0gICAgaW1wdXJlR2V0dGVyLT5zZXREZWxlZ2F0ZShl eGVjLT52bSgpLCBhc09iamVjdChkZWxlZ2F0ZS5hc0NlbGwoKSkpOworICAgIEltcHVyZUdldHRl ciogaW1wdXJlR2V0dGVyID0ganNEeW5hbWljQ2FzdDxJbXB1cmVHZXR0ZXIqPihhc09iamVjdChi YXNlLmFzQ2VsbCgpKSk7CisgICAgaWYgKFVOTElLRUxZKCFpbXB1cmVHZXR0ZXIpKSB7CisgICAg ICAgIHRocm93VHlwZUVycm9yKGV4ZWMsIHNjb3BlLCBBU0NJSUxpdGVyYWwoImFyZ3VtZW50IGlz IG5vdCBhbiBJbXB1cmVHZXR0ZXIiKSk7CisgICAgICAgIHJldHVybiBlbmNvZGVkSlNWYWx1ZSgp OworICAgIH0KKyAgICBpbXB1cmVHZXR0ZXItPnNldERlbGVnYXRlKHZtLCBhc09iamVjdChkZWxl Z2F0ZS5hc0NlbGwoKSkpOwogICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQo KSk7CiB9CiAK