164776 2016-11-15 09:21:21 -0800 [GStreamer][GL] build broken when using gst-plugins-bad from git 2016-11-16 04:00:29 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 164817 1 pnormand webkit-unassigned calvaris magomez pnormand oldest_to_newest 1251455 0 pnormand 2016-11-15 09:21:21 -0800 ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: In static member function ‘static GstContext* WebCore::MediaPlayerPrivateGStreamerBase::requestGLContext(const gchar*, WebCore::MediaPlayerPrivateGStreamerBase*)’: ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:310:49: warning: ‘GType GST_GL_TYPE_CONTEXT()’ is deprecated: Use 'GST_TYPE_GL_CONTEXT' instead [-Wdeprecated-declarations] gst_structure_set(structure, "context", GST_GL_TYPE_CONTEXT, player->gstGLContext(), nullptr); ^~~~~~~~~~~~~~~~~~~ In file included from ../DependenciesGTK/Root/include/gstreamer-1.0/gst/gl/gl.h:33:0, from ../../Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:50: Will send a patch. 1251456 1 294843 pnormand 2016-11-15 09:26:27 -0800 Created attachment 294843 patch 1251841 2 294843 calvaris 2016-11-16 03:39:44 -0800 Comment on attachment 294843 patch View in context: https://bugs.webkit.org/attachment.cgi?id=294843&action=review > Source/WebCore/ChangeLog:10 > + GStreamer GL context GType was renamed, add an ifder taking this ifder. 1251844 3 pnormand 2016-11-16 04:00:29 -0800 Committed r208789: <http://trac.webkit.org/changeset/208789> 294843 2016-11-15 09:26:27 -0800 2016-11-16 03:39:44 -0800 patch patch.patch text/plain 2148 pnormand RnJvbSBjNDJlZTkzNzU2ZDA3MzIwZjc3YWY1MzAzZWZmOTIzYmE4MGY0MjYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDE1IE5vdiAyMDE2IDE4OjI1OjU5ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgMTIgKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwICAgfCAgNCArKysrCiAyIGZpbGVz IGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmU1YjE1My4uZGFhMTVk NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTExLTE1ICBQaGlsaXBwZSBOb3Jt YW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXVtHTF0gYnVp bGQgYnJva2VuIHdoZW4gdXNpbmcgZ3N0LXBsdWdpbnMtYmFkIGZyb20gZ2l0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ3NzYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OnJlcXVlc3RHTENvbnRl eHQpOiBUaGUKKyAgICAgICAgR1N0cmVhbWVyIEdMIGNvbnRleHQgR1R5cGUgd2FzIHJlbmFtZWQs IGFkZCBhbiBpZmRlciB0YWtpbmcgdGhpcworICAgICAgICBpbnRvIGFjY291bnQuCisKIDIwMTYt MTEtMTUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTXVsdGlD b2xdIFJlbmRlciB0cmVlIHNob3VsZCBiZSBhbGwgY2xlYW4gYnkgdGhlIGVuZCBvZiBGcmFtZVZp ZXc6OmxheW91dCgpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lckJhc2UuY3BwCmluZGV4IDk5MjBmOTQuLjk2OTM2OWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXJCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKQEAgLTMwNyw3ICsz MDcsMTEgQEAgR3N0Q29udGV4dCogTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6cmVx dWVzdEdMQ29udGV4dChjb25zdCBnY2hhciogY29udGUKICAgICBpZiAoIWdfc3RyY21wMChjb250 ZXh0VHlwZSwgImdzdC5nbC5hcHBfY29udGV4dCIpKSB7CiAgICAgICAgIEdzdENvbnRleHQqIGFw cENvbnRleHQgPSBnc3RfY29udGV4dF9uZXcoImdzdC5nbC5hcHBfY29udGV4dCIsIFRSVUUpOwog ICAgICAgICBHc3RTdHJ1Y3R1cmUqIHN0cnVjdHVyZSA9IGdzdF9jb250ZXh0X3dyaXRhYmxlX3N0 cnVjdHVyZShhcHBDb250ZXh0KTsKKyNpZiBHU1RfQ0hFQ0tfVkVSU0lPTigxLCAxMSwgMCkKKyAg ICAgICAgZ3N0X3N0cnVjdHVyZV9zZXQoc3RydWN0dXJlLCAiY29udGV4dCIsIEdTVF9UWVBFX0dM X0NPTlRFWFQsIHBsYXllci0+Z3N0R0xDb250ZXh0KCksIG51bGxwdHIpOworI2Vsc2UKICAgICAg ICAgZ3N0X3N0cnVjdHVyZV9zZXQoc3RydWN0dXJlLCAiY29udGV4dCIsIEdTVF9HTF9UWVBFX0NP TlRFWFQsIHBsYXllci0+Z3N0R0xDb250ZXh0KCksIG51bGxwdHIpOworI2VuZGlmCiAgICAgICAg IHJldHVybiBhcHBDb250ZXh0OwogICAgIH0KIAotLSAKMi4xMC4y