164772 2016-11-15 05:29:02 -0800 [Win] WebCore test is failing. 2016-11-16 01:08:31 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue lforschler oldest_to_newest 1251428 0 pvollan 2016-11-15 05:29:02 -0800 A CG rectangle test is failing on Windows. 1251429 1 294833 pvollan 2016-11-15 05:53:14 -0800 Created attachment 294833 Patch 1251463 2 294833 bfulgham 2016-11-15 09:51:04 -0800 Comment on attachment 294833 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294833&action=review r=me. > Tools/TestWebKitAPI/Tests/WebCore/FloatRect.cpp:719 > + EXPECT_FLOAT_EQ(std::numeric_limits<float>::max(), cgInfiniteRect.size.height); *sigh*. I wonder if this was a change in CG behavior post Leopard, or if these have always been mismatched. 1251822 3 294833 pvollan 2016-11-16 00:45:02 -0800 Comment on attachment 294833 Patch Thanks for reviewing :) 1251827 4 294833 commit-queue 2016-11-16 01:08:28 -0800 Comment on attachment 294833 Patch Clearing flags on attachment: 294833 Committed r208787: <http://trac.webkit.org/changeset/208787> 1251828 5 commit-queue 2016-11-16 01:08:31 -0800 All reviewed patches have been landed. Closing bug. 294833 2016-11-15 05:53:14 -0800 2016-11-16 01:08:28 -0800 Patch bug-164772-20161115055307.patch text/plain 1905 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwODczMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTExLTE1ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBXZWJDb3JlIHRlc3QgaXMgZmFpbGluZy4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDc3MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB2YWx1ZSBvZiBDR1JlY3RJ bmZpbml0ZSBpcyBub3QgdGhlIHNhbWUgb24gV2luZG93cyBhcyBvbiBNYWMuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvRmxvYXRSZWN0LmNwcDoKKyAgICAgICAgKFRl c3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDE2LTExLTE0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBFbmhhbmNlIHJ1bi1qc2Mtc3RyZXNzLXRlc3Qgc2NyaXB0IHRv IGFsbG93IG9wdGlvbmFsIHRlc3Qgc3BlY2lmaWMgb3B0aW9ucyB0byBiZSBhZGRlZCBmb3IgYWxs IHRlc3QgcnVuIGNvbmZpZ3VyYXRpb25zLgpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJDb3JlL0Zsb2F0UmVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJDb3JlL0Zsb2F0UmVjdC5jcHAJKHJldmlzaW9uIDIwODcyOCkKKysrIFRvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9GbG9hdFJlY3QuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC03MTIsMTAgKzcxMiwxNyBAQCBURVNUKEZsb2F0UmVjdCwgSW5maW5pdGVSZWN0KQogI2lm IFVTRShDRykKICAgICBDR1JlY3QgY2dJbmZpbml0ZVJlY3QgPSBDR1JlY3RJbmZpbml0ZTsKIAor I2lmIFBMQVRGT1JNKFdJTikKKyAgICBFWFBFQ1RfRkxPQVRfRVEoLXN0ZDo6bnVtZXJpY19saW1p dHM8ZmxvYXQ+OjptYXgoKSAvIDIsIGNnSW5maW5pdGVSZWN0Lm9yaWdpbi54KTsKKyAgICBFWFBF Q1RfRkxPQVRfRVEoLXN0ZDo6bnVtZXJpY19saW1pdHM8ZmxvYXQ+OjptYXgoKSAvIDIsIGNnSW5m aW5pdGVSZWN0Lm9yaWdpbi55KTsKKyAgICBFWFBFQ1RfRkxPQVRfRVEoc3RkOjpudW1lcmljX2xp bWl0czxmbG9hdD46Om1heCgpLCBjZ0luZmluaXRlUmVjdC5zaXplLndpZHRoKTsKKyAgICBFWFBF Q1RfRkxPQVRfRVEoc3RkOjpudW1lcmljX2xpbWl0czxmbG9hdD46Om1heCgpLCBjZ0luZmluaXRl UmVjdC5zaXplLmhlaWdodCk7CisjZWxzZQogICAgIEVYUEVDVF9GTE9BVF9FUSgtc3RkOjpudW1l cmljX2xpbWl0czxmbG9hdD46Om1heCgpLCBjZ0luZmluaXRlUmVjdC5vcmlnaW4ueCk7CiAgICAg RVhQRUNUX0ZMT0FUX0VRKC1zdGQ6Om51bWVyaWNfbGltaXRzPGZsb2F0Pjo6bWF4KCksIGNnSW5m aW5pdGVSZWN0Lm9yaWdpbi55KTsKICAgICBFWFBFQ1RfRkxPQVRfRVEoc3RkOjpudW1lcmljX2xp bWl0czxmbG9hdD46Om1heCgpLCBjZ0luZmluaXRlUmVjdC5vcmlnaW4ueCArIGNnSW5maW5pdGVS ZWN0LnNpemUud2lkdGgpOwogICAgIEVYUEVDVF9GTE9BVF9FUShzdGQ6Om51bWVyaWNfbGltaXRz PGZsb2F0Pjo6bWF4KCksIGNnSW5maW5pdGVSZWN0Lm9yaWdpbi55ICsgY2dJbmZpbml0ZVJlY3Qu c2l6ZS5oZWlnaHQpOworI2VuZGlmCiAgICAgLy8gQVNTRVJUX1RSVUUoaW5maW5pdGUgPT0gY2dJ bmZpbml0ZVJlY3QpOwogI2VuZGlmCiAK