164764 2016-11-14 20:44:09 -0800 Hard to write reliable UIScriptController scrollingTreeAsText tests 2016-11-16 15:17:34 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 164766 1 simon.fraser simon.fraser lforschler simon.fraser oldest_to_newest 1251349 0 simon.fraser 2016-11-14 20:44:09 -0800 It's very hard to know when the UI process has received a scrolling tree update, so scrollingTreeAsText tests are flakey. 1251357 1 simon.fraser 2016-11-14 21:15:39 -0800 Maybe need this: diff --git a/Tools/WebKitTestRunner/ios/TestControllerIOS.mm b/Tools/WebKitTestRunner/ios/TestControllerIOS.mm index 03454a5b5d4847e015a142a19b31920141373bb4..452c410c8379b70c6512dad2c0fd0146311afbda 100644 --- a/Tools/WebKitTestRunner/ios/TestControllerIOS.mm +++ b/Tools/WebKitTestRunner/ios/TestControllerIOS.mm @@ -28,6 +28,7 @@ #import "PlatformWebView.h" #import "TestInvocation.h" +#import "TestRunnerWKWebView.h" #import <Foundation/Foundation.h> #import <UIKit/UIKit.h> #import <WebKit/WKPreferencesRefPrivate.h> @@ -83,6 +84,12 @@ void TestController::platformResetPreferencesToConsistentValues() void TestController::platformResetStateToConsistentValues() { cocoaResetStateToConsistentValues(); + + if (PlatformWebView* webView = mainWebView()) { + UIScrollView *scrollView = webView->platformView().scrollView; + [scrollView setZoomScale:1 animated:NO]; + [scrollView setContentOffset:CGPointZero]; + } } void TestController::platformConfigureViewForTest(const TestInvocation& test) 1252041 2 294981 simon.fraser 2016-11-16 15:05:24 -0800 Created attachment 294981 Patch 1252047 3 294981 wenson_hsieh 2016-11-16 15:14:36 -0800 Comment on attachment 294981 Patch r=mews 1252050 4 simon.fraser 2016-11-16 15:17:34 -0800 Committed r208818: <http://trac.webkit.org/changeset/208818> 294981 2016-11-16 15:05:24 -0800 2016-11-16 15:14:36 -0800 Patch bug-164764-20161116150520.patch text/plain 1842 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4Nzk5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTQ5OTc3NTE5MmMxZGUyNTlmZWRiMTY5OGZlMzJhNzc2 MDUyZDBmYS4uZTRkOTA5NjYyNTE3NGYzYTJiNzE4NzlkZDAwMjg3NmZiMzcwYjQ4OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE2LTExLTE2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIEhhcmQgdG8gd3JpdGUgcmVsaWFibGUgVUlTY3JpcHRDb250cm9sbGVyIHNjcm9s bGluZ1RyZWVBc1RleHQgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2NDc2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZpeCBvbmUgY2F1c2Ugb2YgZmxha2luZXNzIGJ5IHJlc2V0dGluZyB0aGUg V0tXZWJWaWV3J3MgVUlTY3JvbGxWaWV3IHNjYWxlCisgICAgICAgIGFuZCBwb3NpdGlvbiBiZXR3 ZWVuIHRlc3RzLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9pb3MvVGVzdENvbnRyb2xs ZXJJT1MubW06CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybVJlc2V0U3Rh dGVUb0NvbnNpc3RlbnRWYWx1ZXMpOgorCiAyMDE2LTExLTE2ICBSeWFuIEhhZGRhZCAgPHJ5YW5o YWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMDg3 NzAuCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9UZXN0Q29udHJvbGxl cklPUy5tbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL1Rlc3RDb250cm9sbGVySU9TLm1t CmluZGV4IDAzNDU0YTViNWQ0ODQ3ZTAxNWExNDJhMTliMzE5MjAxNDEzNzNiYjQuLjQ1MmM0MTBj ODM3OWI3MGM2NTEyZGFkMmMwZmQwMTQ2MzExYWZiZGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvaW9zL1Rlc3RDb250cm9sbGVySU9TLm1tCisrKyBiL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvaW9zL1Rlc3RDb250cm9sbGVySU9TLm1tCkBAIC0yOCw2ICsyOCw3IEBACiAKICNp bXBvcnQgIlBsYXRmb3JtV2ViVmlldy5oIgogI2ltcG9ydCAiVGVzdEludm9jYXRpb24uaCIKKyNp bXBvcnQgIlRlc3RSdW5uZXJXS1dlYlZpZXcuaCIKICNpbXBvcnQgPEZvdW5kYXRpb24vRm91bmRh dGlvbi5oPgogI2ltcG9ydCA8VUlLaXQvVUlLaXQuaD4KICNpbXBvcnQgPFdlYktpdC9XS1ByZWZl cmVuY2VzUmVmUHJpdmF0ZS5oPgpAQCAtODMsNiArODQsMTIgQEAgdm9pZCBUZXN0Q29udHJvbGxl cjo6cGxhdGZvcm1SZXNldFByZWZlcmVuY2VzVG9Db25zaXN0ZW50VmFsdWVzKCkKIHZvaWQgVGVz dENvbnRyb2xsZXI6OnBsYXRmb3JtUmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcygpCiB7CiAg ICAgY29jb2FSZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzKCk7CisKKyAgICBpZiAoUGxhdGZv cm1XZWJWaWV3KiB3ZWJWaWV3ID0gbWFpbldlYlZpZXcoKSkgeworICAgICAgICBVSVNjcm9sbFZp ZXcgKnNjcm9sbFZpZXcgPSB3ZWJWaWV3LT5wbGF0Zm9ybVZpZXcoKS5zY3JvbGxWaWV3OworICAg ICAgICBbc2Nyb2xsVmlldyBzZXRab29tU2NhbGU6MSBhbmltYXRlZDpOT107CisgICAgICAgIFtz Y3JvbGxWaWV3IHNldENvbnRlbnRPZmZzZXQ6Q0dQb2ludFplcm9dOworICAgIH0KIH0KIAogdm9p ZCBUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1Db25maWd1cmVWaWV3Rm9yVGVzdChjb25zdCBUZXN0 SW52b2NhdGlvbiYgdGVzdCkK