164756 2016-11-14 17:33:06 -0800 Scrolling when zoomed doesn't always use the correct layout viewport 2016-11-14 18:19:34 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser cmarcelo commit-queue jamesr luiz tonikitoo oldest_to_newest 1251287 0 simon.fraser 2016-11-14 17:33:06 -0800 Scrolling when zoomed doesn't always use the correct layout viewport 1251294 1 294787 simon.fraser 2016-11-14 17:47:17 -0800 Created attachment 294787 Patch 1251296 2 294787 dino 2016-11-14 17:48:53 -0800 Comment on attachment 294787 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294787&action=review > Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:407 > - setScrollLayerPosition(scrollPosition, layoutViewport); > + setScrollLayerPosition(scrollPosition, layoutViewport()); What? 1251311 3 294787 commit-queue 2016-11-14 18:19:30 -0800 Comment on attachment 294787 Patch Clearing flags on attachment: 294787 Committed r208722: <http://trac.webkit.org/changeset/208722> 1251312 4 commit-queue 2016-11-14 18:19:34 -0800 All reviewed patches have been landed. Closing bug. 294787 2016-11-14 17:47:17 -0800 2016-11-14 18:19:30 -0800 Patch bug-164756-20161114174716.patch text/plain 4068 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTg5M2E4YzlmOTc4NGYx OGQzNTlmM2Q3NDBmZTM0N2YzZmIxZjg4My4uMTU3OGUwNzg2OGNiZTQ4ZmQ4NDM5NTAwZjY0YWE1 NWNkZjZiYTM1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTExLTE0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFNjcm9sbGluZyB3 aGVuIHpvb21lZCBkb2Vzbid0IGFsd2F5cyB1c2UgdGhlIGNvcnJlY3QgbGF5b3V0IHZpZXdwb3J0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ3NTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc2Ny b2xsaW5nIHRocmVhZCB3YXMgYWx3YXlzIHVzaW5nIHRoZSBsYXlvdXQgdmlld3BvcnQgcmVjdCBw dXNoZWQgb250byBpdCBhbmQKKyAgICAgICAgbmV2ZXIgY29tcHV0aW5nIGEgbmV3IG9uZSwgc28g d2hlbiBzY3JvbGxpbmcgYXJvdW5kIGFmdGVyIHpvb21pbmcgcG9zaXRpb246Zml4ZWQKKyAgICAg ICAgZWxlbWVudHMgd291bGQgbm90IGdldCB0aGUgZXhwZWN0ZWQgdmlzdWFsIHZpZXdwb3J0IGJl aGF2aW9yLgorCisgICAgICAgIEZpeCBieSBoYXZpbmcgU2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xs aW5nTm9kZSB1cGRhdGluZyBpdHMgbm90aW9uIG9mIHRoZSBsYXlvdXQgdmlld3BvcnQKKyAgICAg ICAgb24gc2Nyb2xscy4KKworICAgICAgICBOb3QgdGVzdGFibGUgYmVjYXVzZSB3ZSBjYW4ndCBk dW1wIHRoZSBzY3JvbGxpbmcgdHJlZSBvbiBNYWMgKHlldCkuCisKKyAgICAgICAgKiBwYWdlL3Nj cm9sbGluZy9TY3JvbGxpbmdUcmVlRnJhbWVTY3JvbGxpbmdOb2RlLmg6CisgICAgICAgIChXZWJD b3JlOjpTY3JvbGxpbmdUcmVlRnJhbWVTY3JvbGxpbmdOb2RlOjpzZXRMYXlvdXRWaWV3cG9ydCk6 CisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ1RyZWVGcmFtZVNjcm9sbGlu Z05vZGVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdUcmVlRnJhbWVTY3JvbGxp bmdOb2RlTWFjOjpzZXRTY3JvbGxQb3NpdGlvbldpdGhvdXRDb250ZW50RWRnZUNvbnN0cmFpbnRz KToKKwogMjAxNi0xMS0xNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAg ICAgICAgTWVkaWFTdHJlYW1Qcml2YXRlOjpjcmVhdGUgc2hvdWxkIHRha2UgdmVjdG9ycyBvZiBS ZWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1Ry ZWVGcmFtZVNjcm9sbGluZ05vZGUuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Nj cm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05vZGUuaAppbmRleCA1OTE0N2VhZTlmY2Q3NmFmYTkz OTYzZTEzYjBkZjEzMGU5MGFmYWNkLi40MzQ4OGM0ZmFmMTE3ODgxYzliOTgzN2VmNTg1NzExNDZj OTEwOGE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxp bmdUcmVlRnJhbWVTY3JvbGxpbmdOb2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3Jv bGxpbmcvU2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZS5oCkBAIC03MCwxMSArNzAsMTMg QEAgcHJvdGVjdGVkOgogICAgIGZsb2F0IHRvcENvbnRlbnRJbnNldCgpIGNvbnN0IHsgcmV0dXJu IG1fdG9wQ29udGVudEluc2V0OyB9CiAKICAgICBGbG9hdFJlY3QgbGF5b3V0Vmlld3BvcnQoKSBj b25zdCB7IHJldHVybiBtX2xheW91dFZpZXdwb3J0OyB9OworICAgIHZvaWQgc2V0TGF5b3V0Vmll d3BvcnQoY29uc3QgRmxvYXRSZWN0JiByKSB7IG1fbGF5b3V0Vmlld3BvcnQgPSByOyB9OworCiAg ICAgRmxvYXRQb2ludCBtaW5MYXlvdXRWaWV3cG9ydE9yaWdpbigpIGNvbnN0IHsgcmV0dXJuIG1f bWluTGF5b3V0Vmlld3BvcnRPcmlnaW47IH0KICAgICBGbG9hdFBvaW50IG1heExheW91dFZpZXdw b3J0T3JpZ2luKCkgY29uc3QgeyByZXR1cm4gbV9tYXhMYXlvdXRWaWV3cG9ydE9yaWdpbjsgfQog CiAgICAgU2Nyb2xsQmVoYXZpb3JGb3JGaXhlZEVsZW1lbnRzIHNjcm9sbEJlaGF2aW9yRm9yRml4 ZWRFbGVtZW50cygpIGNvbnN0IHsgcmV0dXJuIG1fYmVoYXZpb3JGb3JGaXhlZDsgfQotICAgIAor CiBwcml2YXRlOgogICAgIHZvaWQgZHVtcFByb3BlcnRpZXMoVGV4dFN0cmVhbSYsIFNjcm9sbGlu Z1N0YXRlVHJlZUFzVGV4dEJlaGF2aW9yKSBjb25zdCBvdmVycmlkZTsKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ1RyZWVGcmFtZVNjcm9s bGluZ05vZGVNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xs aW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZU1hYy5tbQppbmRleCAyMmM2MTIyNTRlNWFkNDMwNGU2 MTc0YzU4YWIwNTJmY2YxYzZjZGE5Li5jZTE2NzU5NGQxYzgwZGI3ZTcyZmZlOWIzNDI3NmQzMWJm OGNmYjEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9tYWMvU2Ny b2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nVHJlZUZyYW1lU2Nyb2xsaW5nTm9kZU1hYy5tbQpA QCAtMzg4LDE0ICszODgsMTQgQEAgdm9pZCBTY3JvbGxpbmdUcmVlRnJhbWVTY3JvbGxpbmdOb2Rl TWFjOjpzZXRTY3JvbGxQb3NpdGlvbldpdGhvdXRDb250ZW50RWRnZUNvbnMKIHsKICAgICB1cGRh dGVNYWluRnJhbWVQaW5TdGF0ZShzY3JvbGxQb3NpdGlvbik7CiAKLSAgICBGbG9hdFJlY3QgbGF5 b3V0Vmlld3BvcnQ7CiAgICAgT3B0aW9uYWw8RmxvYXRQb2ludD4gbGF5b3V0Vmlld3BvcnRPcmln aW47CiAgICAgaWYgKHNjcm9sbGluZ1RyZWUoKS52aXN1YWxWaWV3cG9ydEVuYWJsZWQoKSkgewog ICAgICAgICBGbG9hdFBvaW50IHZpc2libGVDb250ZW50T3JpZ2luID0gc2Nyb2xsUG9zaXRpb247 CiAgICAgICAgIGZsb2F0IGNvdW50ZXJTY2FsZSA9IDEgLyBmcmFtZVNjYWxlRmFjdG9yKCk7CiAg ICAgICAgIHZpc2libGVDb250ZW50T3JpZ2luLnNjYWxlKGNvdW50ZXJTY2FsZSwgY291bnRlclNj YWxlKTsKLSAgICAgICAgbGF5b3V0Vmlld3BvcnQgPSBsYXlvdXRWaWV3cG9ydEZvclNjcm9sbFBv c2l0aW9uKHZpc2libGVDb250ZW50T3JpZ2luLCBmcmFtZVNjYWxlRmFjdG9yKCkpOwotICAgICAg ICBsYXlvdXRWaWV3cG9ydE9yaWdpbiA9IGxheW91dFZpZXdwb3J0LmxvY2F0aW9uKCk7CisgICAg ICAgIEZsb2F0UmVjdCBuZXdMYXlvdXRWaWV3cG9ydCA9IGxheW91dFZpZXdwb3J0Rm9yU2Nyb2xs UG9zaXRpb24odmlzaWJsZUNvbnRlbnRPcmlnaW4sIGZyYW1lU2NhbGVGYWN0b3IoKSk7CisgICAg ICAgIHNldExheW91dFZpZXdwb3J0KG5ld0xheW91dFZpZXdwb3J0KTsKKyAgICAgICAgbGF5b3V0 Vmlld3BvcnRPcmlnaW4gPSBuZXdMYXlvdXRWaWV3cG9ydC5sb2NhdGlvbigpOwogICAgIH0KIAog ICAgIGlmIChzaG91bGRVcGRhdGVTY3JvbGxMYXllclBvc2l0aW9uU3luY2hyb25vdXNseSgpKSB7 CkBAIC00MDQsNyArNDA0LDcgQEAgdm9pZCBTY3JvbGxpbmdUcmVlRnJhbWVTY3JvbGxpbmdOb2Rl TWFjOjpzZXRTY3JvbGxQb3NpdGlvbldpdGhvdXRDb250ZW50RWRnZUNvbnMKICAgICAgICAgcmV0 dXJuOwogICAgIH0KIAotICAgIHNldFNjcm9sbExheWVyUG9zaXRpb24oc2Nyb2xsUG9zaXRpb24s IGxheW91dFZpZXdwb3J0KTsKKyAgICBzZXRTY3JvbGxMYXllclBvc2l0aW9uKHNjcm9sbFBvc2l0 aW9uLCBsYXlvdXRWaWV3cG9ydCgpKTsKICAgICBzY3JvbGxpbmdUcmVlKCkuc2Nyb2xsaW5nVHJl ZU5vZGVEaWRTY3JvbGwoc2Nyb2xsaW5nTm9kZUlEKCksIHNjcm9sbFBvc2l0aW9uLCBsYXlvdXRW aWV3cG9ydE9yaWdpbik7CiB9CiAK