164735 2016-11-14 15:28:30 -0800 Expected: add missing `inline` 2016-11-14 16:13:37 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jfbastien jfbastien benjamin cdumez cmarcelo commit-queue dbates jfbastien ysuzuki oldest_to_newest 1251179 0 jfbastien 2016-11-14 15:28:30 -0800 Free functions and full template specializations need to be `static inline`, or in a .cpp file, otherwise each .o creates a duplicate symbol which makes the linker very sad. 1251185 1 294759 jfbastien 2016-11-14 15:32:13 -0800 Created attachment 294759 patch 1251191 2 294762 jfbastien 2016-11-14 15:37:14 -0800 Created attachment 294762 patch Drop `static`, only `inline` is needed. 1251194 3 294762 ysuzuki 2016-11-14 15:37:38 -0800 Comment on attachment 294762 patch r=me 1251224 4 294762 commit-queue 2016-11-14 16:13:32 -0800 Comment on attachment 294762 patch Clearing flags on attachment: 294762 Committed r208713: <http://trac.webkit.org/changeset/208713> 1251225 5 commit-queue 2016-11-14 16:13:37 -0800 All reviewed patches have been landed. Closing bug. 294759 2016-11-14 15:32:13 -0800 2016-11-14 15:37:14 -0800 patch 0001-Expected-add-missing.patch text/plain 2472 jfbastien RnJvbSA2ODY1MmQ0NzgxOTg3MGMzM2NlOWE0MDFkZTZjOTU3MzljNzcxNjcyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBNb24sIDE0IE5vdiAyMDE2IDE1OjI3OjExIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gRXhwZWN0 ZWQ6IGFkZCBtaXNzaW5nCgpGcmVlIGZ1bmN0aW9ucyBhbmQgZnVsbCB0ZW1wbGF0ZSBzcGVjaWFs aXphdGlvbnMgbmVlZCB0byBiZSAsIG9yIGluIGEgLmNwcCBmaWxlLCBvdGhlcndpc2UgZWFjaCAu byBjcmVhdGVzIGEgZHVwbGljYXRlIHN5bWJvbCB3aGljaCBtYWtlcyB0aGUgbGlua2VyIHZlcnkg c2FkLgotLS0KIFNvdXJjZS9XVEYvQ2hhbmdlTG9nICAgICAgfCAxNSArKysrKysrKysrKysrKysK IFNvdXJjZS9XVEYvd3RmL0V4cGVjdGVkLmggfCAgNCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDE3 IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCBkYmRhMjVhLi4zMDA0NGJmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTExLTE0ICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFw cGxlLmNvbT4KKworICAgICAgICBFeHBlY3RlZDogYWRkIG1pc3NpbmcgYHN0YXRpYyBpbmxpbmVg CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ3MzUK KworICAgICAgICBSZXZpZXdlZCBieSBZdXN1a2UgU3V6dWtpLgorCisgICAgICAgIEZyZWUgZnVu Y3Rpb25zIGFuZCBmdWxsIHRlbXBsYXRlIHNwZWNpYWxpemF0aW9ucyBuZWVkIHRvIGJlCisgICAg ICAgIGBzdGF0aWMgaW5saW5lYCwgb3IgaW4gYSAuY3BwIGZpbGUsIG90aGVyd2lzZSBlYWNoIC5v IGNyZWF0ZXMgYQorICAgICAgICBkdXBsaWNhdGUgc3ltYm9sIHdoaWNoIG1ha2VzIHRoZSBsaW5r ZXIgdmVyeSBzYWQuCisKKyAgICAgICAgKiB3dGYvRXhwZWN0ZWQuaDoKKyAgICAgICAgKFdURjo6 RXhwZWN0ZWREZXRhaWw6OlRocm93KToKKyAgICAgICAgKFdURjo6bWFrZUV4cGVjdGVkKToKKwog MjAxNi0xMS0xMyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IGRlYnVnZ2luZyBmYWNpbGl0eSB0byBsaW1pdCB0aGUgbWF4IHNpbmdsZSBhbGxvY2F0aW9uIHNp emUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9FeHBlY3RlZC5oIGIvU291cmNlL1dURi93 dGYvRXhwZWN0ZWQuaAppbmRleCA2NmUxYTMzLi5jYTE0ZjQ5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V1RGL3d0Zi9FeHBlY3RlZC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0V4cGVjdGVkLmgKQEAgLTcw LDcgKzcwLDcgQEAgY29uc3RleHByIFVuZXhwZWN0VGFnIFVuZXhwZWN0IHsgfTsKIG5hbWVzcGFj ZSBFeHBlY3RlZERldGFpbCB7CiAKIC8vIEludm9rZWQgd2hlcmUgc3RkOjpFeHBlY3RlZCB3b3Vs ZCBpbnN0ZWFkIHRocm93LgotTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIFRocm93KCkgeyBS RUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CitzdGF0aWMgaW5saW5lIE5PX1JFVFVSTl9E VUVfVE9fQ1JBU0ggdm9pZCBUaHJvdygpIHsgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsg fQogCiBzdGF0aWMgY29uc3RleHByIGVudW0gY2xhc3MgVmFsdWVUYWdUeXBlIHsgfSBWYWx1ZVRh ZyB7IH07CiBzdGF0aWMgY29uc3RleHByIGVudW0gY2xhc3MgRXJyb3JUYWdUeXBlIHsgfSBFcnJv clRhZyB7IH07CkBAIC00MTQsNyArNDE0LDcgQEAgdGVtcGxhdGUgPGNsYXNzIFQsIGNsYXNzIEU+ IGNvbnN0ZXhwciBFeHBlY3RlZDxULCBzdGQ6OmRlY2F5X3Q8RT4+IG1ha2VFeHBlY3RlZEYKIHRl bXBsYXRlIDxjbGFzcyBULCBjbGFzcyBFLCBjbGFzcyBVPiBjb25zdGV4cHIgRXhwZWN0ZWQ8VCwg RT4gbWFrZUV4cGVjdGVkRnJvbUVycm9yKFUmJiB1KSB7IHJldHVybiBFeHBlY3RlZDxULCBFPiht YWtlVW5leHBlY3RlZChFIHsgc3RkOjpmb3J3YXJkPFU+KHUpIH0gKSk7IH0KIC8vIHRlbXBsYXRl IDxjbGFzcyBGLCBjbGFzcyBFID0gV1RGOjpOdWxsb3B0VGFnPiBjb25zdGV4cHIgRXhwZWN0ZWQ8 dHlwZW5hbWUgc3RkOjpyZXN1bHRfb2Y8Rj46OnR5cGUsIEU+IG1ha2VFeHBlY3RlZF9mcm9tX2Nh bGwoRiBmKTsKIAotRXhwZWN0ZWQ8dm9pZCwgV1RGOjpOdWxsb3B0VGFnPiBtYWtlRXhwZWN0ZWQo KSB7IHJldHVybiBFeHBlY3RlZDx2b2lkLCBXVEY6Ok51bGxvcHRUYWc+KCk7IH0KK3N0YXRpYyBp bmxpbmUgRXhwZWN0ZWQ8dm9pZCwgV1RGOjpOdWxsb3B0VGFnPiBtYWtlRXhwZWN0ZWQoKSB7IHJl dHVybiBFeHBlY3RlZDx2b2lkLCBXVEY6Ok51bGxvcHRUYWc+KCk7IH0KIAogfSAvLyBuYW1lc3Bh Y2UgV1RGCiAKLS0gCjIuMTAuMQoK 294762 2016-11-14 15:37:14 -0800 2016-11-14 16:13:32 -0800 patch 0001-Expected-add-missing-inline.patch text/plain 2461 jfbastien RnJvbSAyNTlkOTBjOWZjZTk5YmYxNjAzNjZlZWZkMzJjNzhkZWMyYzcyMDU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBNb24sIDE0IE5vdiAyMDE2IDE1OjI3OjExIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gRXhwZWN0 ZWQ6IGFkZCBtaXNzaW5nIGBpbmxpbmVgCgpGcmVlIGZ1bmN0aW9ucyBhbmQgZnVsbCB0ZW1wbGF0 ZSBzcGVjaWFsaXphdGlvbnMgbmVlZCB0byBiZSBgaW5saW5lYCwgb3IgaW4gYQouY3BwIGZpbGUs IG90aGVyd2lzZSBlYWNoIC5vIGNyZWF0ZXMgYSBkdXBsaWNhdGUgc3ltYm9sIHdoaWNoIG1ha2Vz IHRoZSBsaW5rZXIKdmVyeSBzYWQuCi0tLQogU291cmNlL1dURi9DaGFuZ2VMb2cgICAgICB8IDE1 ICsrKysrKysrKysrKysrKwogU291cmNlL1dURi93dGYvRXhwZWN0ZWQuaCB8ICA0ICsrLS0KIDIg ZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRi ZGEyNWEuLjVhNGU3MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTYtMTEtMTQgIEpGIEJhc3Rp ZW4gIDxqZmJhc3RpZW5AYXBwbGUuY29tPgorCisgICAgICAgIEV4cGVjdGVkOiBhZGQgbWlzc2lu ZyBgaW5saW5lYAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTY0NzM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgWXVzdWtlIFN1enVraS4KKworICAgICAg ICBGcmVlIGZ1bmN0aW9ucyBhbmQgZnVsbCB0ZW1wbGF0ZSBzcGVjaWFsaXphdGlvbnMgbmVlZCB0 byBiZQorICAgICAgICBgaW5saW5lYCwgb3IgaW4gYSAuY3BwIGZpbGUsIG90aGVyd2lzZSBlYWNo IC5vIGNyZWF0ZXMgYSBkdXBsaWNhdGUKKyAgICAgICAgc3ltYm9sIHdoaWNoIG1ha2VzIHRoZSBs aW5rZXIgdmVyeSBzYWQuCisKKyAgICAgICAgKiB3dGYvRXhwZWN0ZWQuaDoKKyAgICAgICAgKFdU Rjo6RXhwZWN0ZWREZXRhaWw6OlRocm93KToKKyAgICAgICAgKFdURjo6bWFrZUV4cGVjdGVkKToK KwogMjAxNi0xMS0xMyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAg QWRkIGRlYnVnZ2luZyBmYWNpbGl0eSB0byBsaW1pdCB0aGUgbWF4IHNpbmdsZSBhbGxvY2F0aW9u IHNpemUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9FeHBlY3RlZC5oIGIvU291cmNlL1dU Ri93dGYvRXhwZWN0ZWQuaAppbmRleCA2NmUxYTMzLi5kOGY3NGU3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV1RGL3d0Zi9FeHBlY3RlZC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0V4cGVjdGVkLmgKQEAg LTcwLDcgKzcwLDcgQEAgY29uc3RleHByIFVuZXhwZWN0VGFnIFVuZXhwZWN0IHsgfTsKIG5hbWVz cGFjZSBFeHBlY3RlZERldGFpbCB7CiAKIC8vIEludm9rZWQgd2hlcmUgc3RkOjpFeHBlY3RlZCB3 b3VsZCBpbnN0ZWFkIHRocm93LgotTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIFRocm93KCkg eyBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CitpbmxpbmUgTk9fUkVUVVJOX0RVRV9U T19DUkFTSCB2b2lkIFRocm93KCkgeyBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAK IHN0YXRpYyBjb25zdGV4cHIgZW51bSBjbGFzcyBWYWx1ZVRhZ1R5cGUgeyB9IFZhbHVlVGFnIHsg fTsKIHN0YXRpYyBjb25zdGV4cHIgZW51bSBjbGFzcyBFcnJvclRhZ1R5cGUgeyB9IEVycm9yVGFn IHsgfTsKQEAgLTQxNCw3ICs0MTQsNyBAQCB0ZW1wbGF0ZSA8Y2xhc3MgVCwgY2xhc3MgRT4gY29u c3RleHByIEV4cGVjdGVkPFQsIHN0ZDo6ZGVjYXlfdDxFPj4gbWFrZUV4cGVjdGVkRgogdGVtcGxh dGUgPGNsYXNzIFQsIGNsYXNzIEUsIGNsYXNzIFU+IGNvbnN0ZXhwciBFeHBlY3RlZDxULCBFPiBt YWtlRXhwZWN0ZWRGcm9tRXJyb3IoVSYmIHUpIHsgcmV0dXJuIEV4cGVjdGVkPFQsIEU+KG1ha2VV bmV4cGVjdGVkKEUgeyBzdGQ6OmZvcndhcmQ8VT4odSkgfSApKTsgfQogLy8gdGVtcGxhdGUgPGNs YXNzIEYsIGNsYXNzIEUgPSBXVEY6Ok51bGxvcHRUYWc+IGNvbnN0ZXhwciBFeHBlY3RlZDx0eXBl bmFtZSBzdGQ6OnJlc3VsdF9vZjxGPjo6dHlwZSwgRT4gbWFrZUV4cGVjdGVkX2Zyb21fY2FsbChG IGYpOwogCi1FeHBlY3RlZDx2b2lkLCBXVEY6Ok51bGxvcHRUYWc+IG1ha2VFeHBlY3RlZCgpIHsg cmV0dXJuIEV4cGVjdGVkPHZvaWQsIFdURjo6TnVsbG9wdFRhZz4oKTsgfQoraW5saW5lIEV4cGVj dGVkPHZvaWQsIFdURjo6TnVsbG9wdFRhZz4gbWFrZUV4cGVjdGVkKCkgeyByZXR1cm4gRXhwZWN0 ZWQ8dm9pZCwgV1RGOjpOdWxsb3B0VGFnPigpOyB9CiAKIH0gLy8gbmFtZXNwYWNlIFdURgogCi0t IAoyLjEwLjEKCg==