164734 2016-11-14 14:18:07 -0800 Avoid copying attributes vector when constructing a CustomElement in HTMLTreeBuilder 2016-11-14 14:57:26 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cdumez commit-queue darin esprehn+autocc gyuyoung.kim rniwa oldest_to_newest 1251140 0 cdumez 2016-11-14 14:18:07 -0800 Avoid copying attributes vector when constructing a CustomElement in HTMLTreeBuilder. 1251141 1 294741 cdumez 2016-11-14 14:19:44 -0800 Created attachment 294741 Patch 1251168 2 294741 commit-queue 2016-11-14 14:57:19 -0800 Comment on attachment 294741 Patch Clearing flags on attachment: 294741 Committed r208711: <http://trac.webkit.org/changeset/208711> 1251169 3 commit-queue 2016-11-14 14:57:26 -0800 All reviewed patches have been landed. Closing bug. 294741 2016-11-14 14:19:44 -0800 2016-11-14 14:57:19 -0800 Patch bug-164734-20161114141525.patch text/plain 6740 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4Njg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWUyNDEyOWNlNzhlNGM1 ZTg2YjU2NGIyMWQxYjBiOWE0ZTQxODgyNi4uZGE2MjBkZWY3NTdmMWVjOTJlYTQxNDEwYzAwMWYy ZmNmNDA0MDQzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE2LTExLTE0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgQXZvaWQgY29weWluZyBhdHRy aWJ1dGVzIHZlY3RvciB3aGVuIGNvbnN0cnVjdGluZyBhIEN1c3RvbUVsZW1lbnQgaW4gSFRNTFRy ZWVCdWlsZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjQ3MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBdm9pZCBjb3B5aW5nIGF0dHJpYnV0ZXMgdmVjdG9yIHdoZW4gY29uc3RydWN0aW5nIGEgQ3Vz dG9tRWxlbWVudCBpbiBIVE1MVHJlZUJ1aWxkZXIuCisKKyAgICAgICAgKiBodG1sL3BhcnNlci9I VE1MQ29uc3RydWN0aW9uU2l0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQ29uc3RydWN0 aW9uU2l0ZTo6aW5zZXJ0Q3VzdG9tRWxlbWVudCk6CisgICAgICAgICogaHRtbC9wYXJzZXIvSFRN TENvbnN0cnVjdGlvblNpdGUuaDoKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MU3RhY2tJdGVt Lmg6CisgICAgICAgIChXZWJDb3JlOjpIVE1MU3RhY2tJdGVtOjpIVE1MU3RhY2tJdGVtKToKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxTdGFja0l0ZW06OmNyZWF0ZSk6CisgICAgICAgICogaHRtbC9w YXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUcmVlQnVp bGRlcjo6ZGlkQ3JlYXRlQ3VzdG9tT3JDYWxsYmFja0VsZW1lbnQpOgorCisyMDE2LTExLTE0ICBD aHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgRml4IHRoZSAhRU5BQkxF KEZFVENIX0FQSSkgYnVpbGQgYWZ0ZXIgcjIwODYxMwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0NzEzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmNwcAppbmRleCAyNDQ2NWY3MGEyMDY3 OGM1Yzc1YjJiY2RjZjVlMjYxYTAyNTZjMWRhLi5lMGQyN2UyMzA1MDA3NTY0MDliOGZhNzU2NjE2 ZjNhNjg5OTdkNTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1M Q29uc3RydWN0aW9uU2l0ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRN TENvbnN0cnVjdGlvblNpdGUuY3BwCkBAIC00OTAsMTEgKzQ5MCwxMSBAQCBKU0N1c3RvbUVsZW1l bnRJbnRlcmZhY2UqIEhUTUxDb25zdHJ1Y3Rpb25TaXRlOjppbnNlcnRIVE1MRWxlbWVudE9yRmlu ZEN1c3RvbUVsZQogICAgIHJldHVybiBudWxscHRyOwogfQogCi12b2lkIEhUTUxDb25zdHJ1Y3Rp b25TaXRlOjppbnNlcnRDdXN0b21FbGVtZW50KFJlZjxFbGVtZW50PiYmIGVsZW1lbnQsIGNvbnN0 IEF0b21pY1N0cmluZyYgbG9jYWxOYW1lLCBWZWN0b3I8QXR0cmlidXRlPiYgYXR0cmlidXRlcykK K3ZvaWQgSFRNTENvbnN0cnVjdGlvblNpdGU6Omluc2VydEN1c3RvbUVsZW1lbnQoUmVmPEVsZW1l bnQ+JiYgZWxlbWVudCwgY29uc3QgQXRvbWljU3RyaW5nJiBsb2NhbE5hbWUsIFZlY3RvcjxBdHRy aWJ1dGU+JiYgYXR0cmlidXRlcykKIHsKICAgICBzZXRBdHRyaWJ1dGVzKGVsZW1lbnQsIGF0dHJp YnV0ZXMsIG1fcGFyc2VyQ29udGVudFBvbGljeSk7CiAgICAgYXR0YWNoTGF0ZXIoY3VycmVudE5v ZGUoKSwgZWxlbWVudC5jb3B5UmVmKCkpOwotICAgIG1fb3BlbkVsZW1lbnRzLnB1c2goSFRNTFN0 YWNrSXRlbTo6Y3JlYXRlKFdURk1vdmUoZWxlbWVudCksIGxvY2FsTmFtZSwgYXR0cmlidXRlcykp OworICAgIG1fb3BlbkVsZW1lbnRzLnB1c2goSFRNTFN0YWNrSXRlbTo6Y3JlYXRlKFdURk1vdmUo ZWxlbWVudCksIGxvY2FsTmFtZSwgV1RGTW92ZShhdHRyaWJ1dGVzKSkpOwogfQogCiB2b2lkIEhU TUxDb25zdHJ1Y3Rpb25TaXRlOjppbnNlcnRTZWxmQ2xvc2luZ0hUTUxFbGVtZW50KEF0b21pY0hU TUxUb2tlbiYgdG9rZW4pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9I VE1MQ29uc3RydWN0aW9uU2l0ZS5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTENv bnN0cnVjdGlvblNpdGUuaAppbmRleCA1ZmM0NTYxZGQyNGY2YzYyMjVlMzY3M2U5NzhlNjdjNTAz OThjYTA4Li42MTg5MGVhODJkMjVlMTIyNDU1NzE4OTg5NWJjOWJkNmJiNjI1N2NhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmgKQEAg LTEwMyw3ICsxMDMsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBpbnNlcnRDb21tZW50T25IVE1MSHRt bEVsZW1lbnQoQXRvbWljSFRNTFRva2VuJik7CiAgICAgdm9pZCBpbnNlcnRIVE1MRWxlbWVudChB dG9taWNIVE1MVG9rZW4mKTsKICAgICBKU0N1c3RvbUVsZW1lbnRJbnRlcmZhY2UqIGluc2VydEhU TUxFbGVtZW50T3JGaW5kQ3VzdG9tRWxlbWVudEludGVyZmFjZShBdG9taWNIVE1MVG9rZW4mKTsK LSAgICB2b2lkIGluc2VydEN1c3RvbUVsZW1lbnQoUmVmPEVsZW1lbnQ+JiYsIGNvbnN0IEF0b21p Y1N0cmluZyYgbG9jYWxOYW1lLCBWZWN0b3I8QXR0cmlidXRlPiYpOworICAgIHZvaWQgaW5zZXJ0 Q3VzdG9tRWxlbWVudChSZWY8RWxlbWVudD4mJiwgY29uc3QgQXRvbWljU3RyaW5nJiBsb2NhbE5h bWUsIFZlY3RvcjxBdHRyaWJ1dGU+JiYpOwogICAgIHZvaWQgaW5zZXJ0U2VsZkNsb3NpbmdIVE1M RWxlbWVudChBdG9taWNIVE1MVG9rZW4mKTsKICAgICB2b2lkIGluc2VydEZvcm1hdHRpbmdFbGVt ZW50KEF0b21pY0hUTUxUb2tlbiYpOwogICAgIHZvaWQgaW5zZXJ0SFRNTEhlYWRFbGVtZW50KEF0 b21pY0hUTUxUb2tlbiYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIv SFRNTFN0YWNrSXRlbS5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFN0YWNrSXRl bS5oCmluZGV4IDQ5ZjkxOGQ3Y2IwMmZmMWQ3ZWRjNTU1YjQzM2RmMDEzOTIwNTMyMjAuLmUwNmE2 ZTAxMzVlZjRhMzUxMTMwZmIwYThjMzJhYzUwZTA4YzcxMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxTdGFja0l0ZW0uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9IVE1MU3RhY2tJdGVtLmgKQEAgLTM5LDcgKzM5LDcgQEAgY2xhc3MgSFRNTFN0 YWNrSXRlbSA6IHB1YmxpYyBSZWZDb3VudGVkPEhUTUxTdGFja0l0ZW0+IHsKIHB1YmxpYzoKICAg ICAvLyBOb3JtYWwgSFRNTEVsZW1lbnRTdGFjayBhbmQgSFRNTEZvcm1hdHRpbmdFbGVtZW50TGlz dCBpdGVtcy4KICAgICBzdGF0aWMgUmVmPEhUTUxTdGFja0l0ZW0+IGNyZWF0ZShSZWY8RWxlbWVu dD4mJiwgQXRvbWljSFRNTFRva2VuJiwgY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lc3BhY2VVUkkg PSBIVE1MTmFtZXM6OnhodG1sTmFtZXNwYWNlVVJJKTsKLSAgICBzdGF0aWMgUmVmPEhUTUxTdGFj a0l0ZW0+IGNyZWF0ZShSZWY8RWxlbWVudD4mJiwgY29uc3QgQXRvbWljU3RyaW5nJiwgY29uc3Qg VmVjdG9yPEF0dHJpYnV0ZT4mKTsKKyAgICBzdGF0aWMgUmVmPEhUTUxTdGFja0l0ZW0+IGNyZWF0 ZShSZWY8RWxlbWVudD4mJiwgY29uc3QgQXRvbWljU3RyaW5nJiwgVmVjdG9yPEF0dHJpYnV0ZT4m Jik7CiAKICAgICAvLyBEb2N1bWVudCBmcmFnbWVudCBvciBlbGVtZW50IGZvciBwYXJzaW5nIGNv bnRleHQuCiAgICAgc3RhdGljIFJlZjxIVE1MU3RhY2tJdGVtPiBjcmVhdGUoRWxlbWVudCYpOwpA QCAtNjIsNyArNjIsNyBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgSFRNTFN0YWNrSXRlbShS ZWY8RWxlbWVudD4mJiwgQXRvbWljSFRNTFRva2VuJiwgY29uc3QgQXRvbWljU3RyaW5nJiBuYW1l c3BhY2VVUkkpOwotICAgIEhUTUxTdGFja0l0ZW0oUmVmPEVsZW1lbnQ+JiYsIGNvbnN0IEF0b21p Y1N0cmluZyYgbG9jYWxOYW1lLCBjb25zdCBBdG9taWNTdHJpbmcmIG5hbWVzcGFjZVVSSSwgY29u c3QgVmVjdG9yPEF0dHJpYnV0ZT4mKTsKKyAgICBIVE1MU3RhY2tJdGVtKFJlZjxFbGVtZW50PiYm LCBjb25zdCBBdG9taWNTdHJpbmcmIGxvY2FsTmFtZSwgY29uc3QgQXRvbWljU3RyaW5nJiBuYW1l c3BhY2VVUkksIFZlY3RvcjxBdHRyaWJ1dGU+JiYpOwogICAgIGV4cGxpY2l0IEhUTUxTdGFja0l0 ZW0oRWxlbWVudCYpOwogICAgIGV4cGxpY2l0IEhUTUxTdGFja0l0ZW0oRG9jdW1lbnRGcmFnbWVu dCYpOwogCkBAIC05MCwxOSArOTAsMTggQEAgaW5saW5lIFJlZjxIVE1MU3RhY2tJdGVtPiBIVE1M U3RhY2tJdGVtOjpjcmVhdGUoUmVmPEVsZW1lbnQ+JiYgZWxlbWVudCwgQXRvbWljSFQKICAgICBy ZXR1cm4gYWRvcHRSZWYoKm5ldyBIVE1MU3RhY2tJdGVtKFdURk1vdmUoZWxlbWVudCksIHRva2Vu LCBuYW1lc3BhY2VVUkkpKTsKIH0KIAotaW5saW5lIEhUTUxTdGFja0l0ZW06OkhUTUxTdGFja0l0 ZW0oUmVmPEVsZW1lbnQ+JiYgZWxlbWVudCwgY29uc3QgQXRvbWljU3RyaW5nJiBsb2NhbE5hbWUs IGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZXNwYWNlVVJJLCBjb25zdCBWZWN0b3I8QXR0cmlidXRl PiYgYXR0cmlidXRlcykKK2lubGluZSBIVE1MU3RhY2tJdGVtOjpIVE1MU3RhY2tJdGVtKFJlZjxF bGVtZW50PiYmIGVsZW1lbnQsIGNvbnN0IEF0b21pY1N0cmluZyYgbG9jYWxOYW1lLCBjb25zdCBB dG9taWNTdHJpbmcmIG5hbWVzcGFjZVVSSSwgVmVjdG9yPEF0dHJpYnV0ZT4mJiBhdHRyaWJ1dGVz KQogICAgIDogbV9ub2RlKFdURk1vdmUoZWxlbWVudCkpCiAgICAgLCBtX25hbWVzcGFjZVVSSShu YW1lc3BhY2VVUkkpCiAgICAgLCBtX2xvY2FsTmFtZShsb2NhbE5hbWUpCi0gICAgLCBtX2F0dHJp YnV0ZXMoYXR0cmlidXRlcykKKyAgICAsIG1fYXR0cmlidXRlcyhXVEZNb3ZlKGF0dHJpYnV0ZXMp KQogewotICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgZmluZCBhIHdheSB0byBtb3ZlIHRoZSBhdHRy aWJ1dGVzIHZlY3RvciBpbiB0aGUgbm9ybWFsIGNvZGUgcGF0aCBpbnN0ZWFkIG9mIGNvcHlpbmcg aXQuCiB9CiAKLWlubGluZSBSZWY8SFRNTFN0YWNrSXRlbT4gSFRNTFN0YWNrSXRlbTo6Y3JlYXRl KFJlZjxFbGVtZW50PiYmIGVsZW1lbnQsIGNvbnN0IEF0b21pY1N0cmluZyYgbG9jYWxOYW1lLCBj b25zdCBWZWN0b3I8QXR0cmlidXRlPiYgYXR0cmlidXRlcykKK2lubGluZSBSZWY8SFRNTFN0YWNr SXRlbT4gSFRNTFN0YWNrSXRlbTo6Y3JlYXRlKFJlZjxFbGVtZW50PiYmIGVsZW1lbnQsIGNvbnN0 IEF0b21pY1N0cmluZyYgbG9jYWxOYW1lLCBWZWN0b3I8QXR0cmlidXRlPiYmIGF0dHJpYnV0ZXMp CiB7CiAgICAgYXV0byYgbmFtZXNwYWNlVVJJID0gZWxlbWVudC5nZXQoKS5uYW1lc3BhY2VVUkko KTsKLSAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBIVE1MU3RhY2tJdGVtKFdURk1vdmUoZWxlbWVu dCksIGxvY2FsTmFtZSwgbmFtZXNwYWNlVVJJLCBhdHRyaWJ1dGVzKSk7CisgICAgcmV0dXJuIGFk b3B0UmVmKCpuZXcgSFRNTFN0YWNrSXRlbShXVEZNb3ZlKGVsZW1lbnQpLCBsb2NhbE5hbWUsIG5h bWVzcGFjZVVSSSwgV1RGTW92ZShhdHRyaWJ1dGVzKSkpOwogfQogCiBpbmxpbmUgSFRNTFN0YWNr SXRlbTo6SFRNTFN0YWNrSXRlbShFbGVtZW50JiBlbGVtZW50KQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAKaW5kZXggYWNjYTAzZDcxNTkxMDFlNjYy YmQzZDMxM2Y2ZmQ2OThhMTBlMzU2ZS4uNDM5ZWIwODM1NTJiMmJkNWRlMmE5MzY4OGIxMzBjY2Q0 MGVmNTU3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVC dWlsZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxk ZXIuY3BwCkBAIC04NzIsNyArODcyLDcgQEAgaW5saW5lIHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpp bnNlcnRHZW5lcmljSFRNTEVsZW1lbnQoQXRvbWljSFRNTFRva2VuJiB0b2tlbikKIAogdm9pZCBI VE1MVHJlZUJ1aWxkZXI6OmRpZENyZWF0ZUN1c3RvbU9yQ2FsbGJhY2tFbGVtZW50KFJlZjxFbGVt ZW50PiYmIGVsZW1lbnQsIEN1c3RvbUVsZW1lbnRDb25zdHJ1Y3Rpb25EYXRhJiBkYXRhKQogewot ICAgIG1fdHJlZS5pbnNlcnRDdXN0b21FbGVtZW50KFdURk1vdmUoZWxlbWVudCksIGRhdGEubmFt ZSwgZGF0YS5hdHRyaWJ1dGVzKTsKKyAgICBtX3RyZWUuaW5zZXJ0Q3VzdG9tRWxlbWVudChXVEZN b3ZlKGVsZW1lbnQpLCBkYXRhLm5hbWUsIFdURk1vdmUoZGF0YS5hdHRyaWJ1dGVzKSk7CiB9CiAK IHZvaWQgSFRNTFRyZWVCdWlsZGVyOjpwcm9jZXNzVGVtcGxhdGVTdGFydFRhZyhBdG9taWNIVE1M VG9rZW4mIHRva2VuKQo=