164728 2016-11-14 13:28:05 -0800 [CSS Parser] Support the font-synthesis property 2016-11-14 13:40:33 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt oldest_to_newest 1251112 0 hyatt 2016-11-14 13:28:05 -0800 [CSS Parser] Support the font-synthesis property 1251114 1 294735 hyatt 2016-11-14 13:29:05 -0800 Created attachment 294735 Patch 1251116 2 294735 dino 2016-11-14 13:32:23 -0800 Comment on attachment 294735 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294735&action=review > Source/WebCore/css/parser/CSSPropertyParser.cpp:806 > + do { > + if (range.peek().id() == CSSValueWeight) > + weight = consumeIdent(range); > + else if (range.peek().id() == CSSValueStyle) > + style = consumeIdent(range); > + else > + return nullptr; > + } while (!range.atEnd()); What a weird property. font-synthesis: weight style weight weight weight; is fine. 1251120 3 hyatt 2016-11-14 13:40:33 -0800 Landed in r208706. 294735 2016-11-14 13:29:05 -0800 2016-11-14 13:32:23 -0800 Patch bug-164728-20161114152446.patch text/plain 2380 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODcwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTExLTE0ICBEYXZlIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFtDU1MgUGFyc2VyXSBTdXBwb3J0IHRo ZSBmb250LXN5bnRoZXNpcyBwcm9wZXJ0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY0NzI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBjc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OmNvbnN1bWVGb250U3ludGhlc2lzKToKKyAgICAgICAgKFdlYkNvcmU6 OkNTU1Byb3BlcnR5UGFyc2VyOjpwYXJzZVNpbmdsZVZhbHVlKToKKwogMjAxNi0xMS0xMiAgU2Ft IFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtTVkddIE1vdmluZyBtb3JlIHNw ZWNpYWwgY2FzaW5nIG9mIFNWRyBvdXQgb2YgdGhlIGJpbmRpbmdzIC0gU1ZHTnVtYmVyL1NWR1Bv aW50L1NWR1JlY3QvU1ZHTGVuZ3RoL1NWR1RyYW5zZm9ybS9TVkdNYXRyaXgKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXIuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXIuY3BwCShyZXZpc2lv biAyMDg3MDApCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2Vy LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzg3LDYgKzc4NywzMiBAQCBzdGF0aWMgUmVmUHRyPENT U1ZhbHVlTGlzdD4gY29uc3VtZUZvbnRGCiAgICAgcmV0dXJuIGxpc3Q7CiB9CiAKK3N0YXRpYyBS ZWZQdHI8Q1NTVmFsdWU+IGNvbnN1bWVGb250U3ludGhlc2lzKENTU1BhcnNlclRva2VuUmFuZ2Um IHJhbmdlKQoreworICAgIC8vIG5vbmUgfCBbIHdlaWdodCB8fCBzdHlsZSBdCisgICAgaWYgKHJh bmdlLnBlZWsoKS5pZCgpID09IENTU1ZhbHVlTm9uZSkKKyAgICAgICAgcmV0dXJuIGNvbnN1bWVJ ZGVudChyYW5nZSk7CisgICAgCisgICAgUmVmUHRyPENTU1ZhbHVlPiB3ZWlnaHQ7CisgICAgUmVm UHRyPENTU1ZhbHVlPiBzdHlsZTsKKworICAgIGRvIHsKKyAgICAgICAgaWYgKHJhbmdlLnBlZWso KS5pZCgpID09IENTU1ZhbHVlV2VpZ2h0KQorICAgICAgICAgICAgd2VpZ2h0ID0gY29uc3VtZUlk ZW50KHJhbmdlKTsKKyAgICAgICAgZWxzZSBpZiAocmFuZ2UucGVlaygpLmlkKCkgPT0gQ1NTVmFs dWVTdHlsZSkKKyAgICAgICAgICAgIHN0eWxlID0gY29uc3VtZUlkZW50KHJhbmdlKTsKKyAgICAg ICAgZWxzZQorICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7CisgICAgfSB3aGlsZSAoIXJhbmdl LmF0RW5kKCkpOworICAgIAorICAgIGF1dG8gbGlzdCA9IENTU1ZhbHVlTGlzdDo6Y3JlYXRlU3Bh Y2VTZXBhcmF0ZWQoKTsKKyAgICBpZiAod2VpZ2h0KQorICAgICAgICBsaXN0LT5hcHBlbmQod2Vp Z2h0LnJlbGVhc2VOb25OdWxsKCkpOworICAgIGlmIChzdHlsZSkKKyAgICAgICAgbGlzdC0+YXBw ZW5kKHN0eWxlLnJlbGVhc2VOb25OdWxsKCkpOworICAgIHJldHVybiBXVEZNb3ZlKGxpc3QpOwor fQorCiBzdGF0aWMgUmVmUHRyPENTU1ZhbHVlPiBjb25zdW1lTGV0dGVyU3BhY2luZyhDU1NQYXJz ZXJUb2tlblJhbmdlJiByYW5nZSwgQ1NTUGFyc2VyTW9kZSBjc3NQYXJzZXJNb2RlKQogewogICAg IGlmIChyYW5nZS5wZWVrKCkuaWQoKSA9PSBDU1NWYWx1ZU5vcm1hbCkKQEAgLTMzNDgsNiArMzM3 NCw4IEBAIFJlZlB0cjxDU1NWYWx1ZT4gQ1NTUHJvcGVydHlQYXJzZXI6OnBhcnMKICAgICAgICAg cmV0dXJuIGNvbnN1bWVGb250RmFtaWx5KG1fcmFuZ2UpOwogICAgIGNhc2UgQ1NTUHJvcGVydHlG b250V2VpZ2h0OgogICAgICAgICByZXR1cm4gY29uc3VtZUZvbnRXZWlnaHQobV9yYW5nZSk7Cisg ICAgY2FzZSBDU1NQcm9wZXJ0eUZvbnRTeW50aGVzaXM6CisgICAgICAgIHJldHVybiBjb25zdW1l Rm9udFN5bnRoZXNpcyhtX3JhbmdlKTsKICAgICBjYXNlIENTU1Byb3BlcnR5TGV0dGVyU3BhY2lu ZzoKICAgICAgICAgcmV0dXJuIGNvbnN1bWVMZXR0ZXJTcGFjaW5nKG1fcmFuZ2UsIG1fY29udGV4 dC5tb2RlKTsKICAgICBjYXNlIENTU1Byb3BlcnR5V29yZFNwYWNpbmc6Cg==