164713 2016-11-14 08:21:57 -0800 Fix the !ENABLE(FETCH_API) build after r208613 2016-11-14 10:02:22 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 164644 1 ossy cdumez beidson cdumez commit-queue darin ossy rniwa sam youennf oldest_to_newest 1250978 0 ossy 2016-11-14 08:21:57 -0800 DerivedSources/WebCore/JSWorkerGlobalScope.cpp: In member function 'void WebCore::JSWorkerGlobalScopePrototype::finishCreation(JSC::VM&)': DerivedSources/WebCore/JSWorkerGlobalScope.cpp:544:124: error: 'jsWorkerGlobalScopePrototypeFunctionFetchRequest' was not declared in this scope 1250979 1 ossy 2016-11-14 08:23:39 -0800 ... #if ENABLE(FETCH_API) JSC::EncodedJSValue JSC_HOST_CALL jsWorkerGlobalScopePrototypeFunctionFetchRequest(JSC::ExecState*); #endif ... void JSWorkerGlobalScopePrototype::finishCreation(VM& vm) { Base::finishCreation(vm); reifyStaticProperties(vm, JSWorkerGlobalScopePrototypeTableValues, *this); #if ENABLE(FETCH_API) if (!RuntimeEnabledFeatures::sharedFeatures().fetchAPIEnabled()) { Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("fetch"), strlen("fetch")); VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable); JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName); } #endif #if ENABLE(INDEXED_DATABASE_IN_WORKERS) if (!RuntimeEnabledFeatures::sharedFeatures().indexedDBWorkersEnabled()) { Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("indexedDB"), strlen("indexedDB")); VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable); JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName); } #endif JSVMClientData& clientData = *static_cast<JSVMClientData*>(vm.clientData); putDirect(vm, clientData.builtinNames().fetchRequestPrivateName(), JSFunction::create(vm, globalObject(), 0, String(), jsWorkerGlobalScopePrototypeFunctionFetchRequest), ReadOnly | DontEnum); <-------------------- BANG!!! This line should be guarded. } 1250981 2 ossy 2016-11-14 08:53:02 -0800 I bisected, it is a regression caused by http://trac.webkit.org/changeset/208613 . 1250983 3 cdumez 2016-11-14 08:56:56 -0800 I am investigating, thanks. 1250990 4 294705 cdumez 2016-11-14 09:18:57 -0800 Created attachment 294705 Patch 1251009 5 294705 commit-queue 2016-11-14 10:02:17 -0800 Comment on attachment 294705 Patch Clearing flags on attachment: 294705 Committed r208689: <http://trac.webkit.org/changeset/208689> 1251010 6 commit-queue 2016-11-14 10:02:22 -0800 All reviewed patches have been landed. Closing bug. 294705 2016-11-14 09:18:57 -0800 2016-11-14 10:02:17 -0800 Patch bug-164713-20161114091438.patch text/plain 4089 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4Njg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGUxYTgxMzlkYjc1N2My NDUzMDY5ZGZhYTU1ZGYzM2VkNzljMDNlNS4uYmU3MDZmOTVhNTVhMTg0ODI4MzY1NWEwNjI5MGEy Mjg2MDFmNGMxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTExLTE0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHRoZSAhRU5BQkxFKEZF VENIX0FQSSkgYnVpbGQgYWZ0ZXIgcjIwODYxMworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0NzEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w bToKKyAgICAgICAgKEdlbmVyYXRlSW1wbGVtZW50YXRpb24pOgorCiAyMDE2LTExLTE0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uZkBnbWFpbC5jb20+CiAKICAgICAgICAgUlRDUnRwVHJhbnNjZWl2 ZXIgc2hvdWxkIGhhdmUgUmVmIG9mIHNlbmRlciBhbmQgcmVjZWl2ZXIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggOTQxOTM0 NTc0YzY3OThkMjkzNTYwYjJjZmY2OWMyY2UzMGFhZGIzNy4uNmEyYjI3MGQyNmVkMDk5NTljY2Ez ZGQ3MDE3NGVmZmQ2MTdkZWI4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTI5MzAsMTMgKzI5MzAsMTMgQEAgc3ViIEdl bmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiI2Vu ZGlmXG4iKSBpZiAkY29uZGl0aW9uYWxTdHJpbmc7CiAgICAgICAgIH0KIAotICAgICAgICBteSAk Zmlyc3RQcml2YXRlRnVuY3Rpb24gPSAxOwogICAgICAgICBmb3JlYWNoIG15ICRmdW5jdGlvbiAo QHskaW50ZXJmYWNlLT5mdW5jdGlvbnN9KSB7CiAgICAgICAgICAgICBuZXh0IHVubGVzcyAoJGZ1 bmN0aW9uLT5leHRlbmRlZEF0dHJpYnV0ZXMtPntQcml2YXRlSWRlbnRpZmllcn0pOwogICAgICAg ICAgICAgQWRkVG9JbXBsSW5jbHVkZXMoIldlYkNvcmVKU0NsaWVudERhdGEuaCIpOwotICAgICAg ICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgSlNWTUNsaWVudERhdGEmIGNsaWVudERhdGEg PSAqc3RhdGljX2Nhc3Q8SlNWTUNsaWVudERhdGEqPih2bS5jbGllbnREYXRhKTtcbiIpIGlmICRm aXJzdFByaXZhdGVGdW5jdGlvbjsKLSAgICAgICAgICAgICRmaXJzdFByaXZhdGVGdW5jdGlvbiA9 IDA7Ci0gICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICBwdXREaXJlY3Qodm0sIGNs aWVudERhdGEuYnVpbHRpbk5hbWVzKCkuIiAuICRmdW5jdGlvbi0+bmFtZSAuICJQcml2YXRlTmFt ZSgpLCBKU0Z1bmN0aW9uOjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdCgpLCAwLCBTdHJpbmcoKSwg IiAuIEdldEZ1bmN0aW9uTmFtZSgkaW50ZXJmYWNlLCAkY2xhc3NOYW1lLCAkZnVuY3Rpb24pIC4g IiksIFJlYWRPbmx5IHwgRG9udEVudW0pO1xuIik7CisgICAgICAgICAgICBteSAkY29uZGl0aW9u YWxTdHJpbmcgPSAkY29kZUdlbmVyYXRvci0+R2VuZXJhdGVDb25kaXRpb25hbFN0cmluZygkZnVu Y3Rpb24pOworICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIjaWYgJHtjb25kaXRpb25h bFN0cmluZ31cbiIpIGlmICRjb25kaXRpb25hbFN0cmluZzsKKyAgICAgICAgICAgIHB1c2goQGlt cGxDb250ZW50LCAiICAgIHB1dERpcmVjdCh2bSwgc3RhdGljX2Nhc3Q8SlNWTUNsaWVudERhdGEq Pih2bS5jbGllbnREYXRhKS0+YnVpbHRpbk5hbWVzKCkuIiAuICRmdW5jdGlvbi0+bmFtZSAuICJQ cml2YXRlTmFtZSgpLCBKU0Z1bmN0aW9uOjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdCgpLCAwLCBT dHJpbmcoKSwgIiAuIEdldEZ1bmN0aW9uTmFtZSgkaW50ZXJmYWNlLCAkY2xhc3NOYW1lLCAkZnVu Y3Rpb24pIC4gIiksIFJlYWRPbmx5IHwgRG9udEVudW0pO1xuIik7CisgICAgICAgICAgICBwdXNo KEBpbXBsQ29udGVudCwgIiNlbmRpZlxuIikgaWYgJGNvbmRpdGlvbmFsU3RyaW5nOwogICAgICAg ICB9CiAKICAgICAgICAgaWYgKCRpbnRlcmZhY2UtPml0ZXJhYmxlKSB7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwCmluZGV4 IDRmZjdjMDgzMmQ1YzFhOTA0ZDY3MGExMTMxYmRkNjQ5MDhjZTlmMmYuLmY5YTA3NzkzZmY5Mjli MGY4NjBjMDc1ZDU0N2EyMGY4ZjNlZjE0YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwCkBAIC0xNzM1LDkgKzE3MzUs OCBAQCB2b2lkIEpTVGVzdE9ialByb3RvdHlwZTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtKQogICAg ICAgICBKU09iamVjdDo6ZGVsZXRlUHJvcGVydHkodGhpcywgZ2xvYmFsT2JqZWN0KCktPmdsb2Jh bEV4ZWMoKSwgcHJvcGVydHlOYW1lKTsKICAgICB9CiAjZW5kaWYKLSAgICBKU1ZNQ2xpZW50RGF0 YSYgY2xpZW50RGF0YSA9ICpzdGF0aWNfY2FzdDxKU1ZNQ2xpZW50RGF0YSo+KHZtLmNsaWVudERh dGEpOwotICAgIHB1dERpcmVjdCh2bSwgY2xpZW50RGF0YS5idWlsdGluTmFtZXMoKS5wcml2YXRl TWV0aG9kUHJpdmF0ZU5hbWUoKSwgSlNGdW5jdGlvbjo6Y3JlYXRlKHZtLCBnbG9iYWxPYmplY3Qo KSwgMCwgU3RyaW5nKCksIGpzVGVzdE9ialByb3RvdHlwZUZ1bmN0aW9uUHJpdmF0ZU1ldGhvZCks IFJlYWRPbmx5IHwgRG9udEVudW0pOwotICAgIHB1dERpcmVjdCh2bSwgY2xpZW50RGF0YS5idWls dGluTmFtZXMoKS5wdWJsaWNBbmRQcml2YXRlTWV0aG9kUHJpdmF0ZU5hbWUoKSwgSlNGdW5jdGlv bjo6Y3JlYXRlKHZtLCBnbG9iYWxPYmplY3QoKSwgMCwgU3RyaW5nKCksIGpzVGVzdE9ialByb3Rv dHlwZUZ1bmN0aW9uUHVibGljQW5kUHJpdmF0ZU1ldGhvZCksIFJlYWRPbmx5IHwgRG9udEVudW0p OworICAgIHB1dERpcmVjdCh2bSwgc3RhdGljX2Nhc3Q8SlNWTUNsaWVudERhdGEqPih2bS5jbGll bnREYXRhKS0+YnVpbHRpbk5hbWVzKCkucHJpdmF0ZU1ldGhvZFByaXZhdGVOYW1lKCksIEpTRnVu Y3Rpb246OmNyZWF0ZSh2bSwgZ2xvYmFsT2JqZWN0KCksIDAsIFN0cmluZygpLCBqc1Rlc3RPYmpQ cm90b3R5cGVGdW5jdGlvblByaXZhdGVNZXRob2QpLCBSZWFkT25seSB8IERvbnRFbnVtKTsKKyAg ICBwdXREaXJlY3Qodm0sIHN0YXRpY19jYXN0PEpTVk1DbGllbnREYXRhKj4odm0uY2xpZW50RGF0 YSktPmJ1aWx0aW5OYW1lcygpLnB1YmxpY0FuZFByaXZhdGVNZXRob2RQcml2YXRlTmFtZSgpLCBK U0Z1bmN0aW9uOjpjcmVhdGUodm0sIGdsb2JhbE9iamVjdCgpLCAwLCBTdHJpbmcoKSwganNUZXN0 T2JqUHJvdG90eXBlRnVuY3Rpb25QdWJsaWNBbmRQcml2YXRlTWV0aG9kKSwgUmVhZE9ubHkgfCBE b250RW51bSk7CiAgICAgaWYgKFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVz KCkuZG9tSXRlcmF0b3JFbmFibGVkKCkpCiAgICAgICAgIGFkZFZhbHVlSXRlcmFibGVNZXRob2Rz KCpnbG9iYWxPYmplY3QoKSwgKnRoaXMpOwogICAgIEpTT2JqZWN0JiB1bnNjb3BhYmxlcyA9ICpj b25zdHJ1Y3RFbXB0eU9iamVjdChnbG9iYWxPYmplY3QoKS0+Z2xvYmFsRXhlYygpLCBnbG9iYWxP YmplY3QoKS0+bnVsbFByb3RvdHlwZU9iamVjdFN0cnVjdHVyZSgpKTsK