164693 2016-11-12 16:51:49 -0800 document.currentScript should be null when running a script inside a shadow tree 2016-11-13 00:58:39 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 148695 1 rniwa rniwa cdumez commit-queue dbates esprehn+autocc kangil.han koivisto webkit-bug-importer ysuzuki oldest_to_newest 1250747 0 rniwa 2016-11-12 16:51:49 -0800 document.currentScript should be null when running a script inside a shadow tree instead of being set to the old script element waiting on that script to finish. The following test is failing because of that: imported/w3c/web-platform-tests/shadow-dom/Document-prototype-currentScript.html 1250748 1 294642 rniwa 2016-11-12 16:57:56 -0800 Created attachment 294642 Fixes the bug 1250757 2 294642 ysuzuki 2016-11-12 18:11:37 -0800 Comment on attachment 294642 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=294642&action=review r=me > Source/WebCore/dom/CurrentScriptIncrementer.h:46 > + m_document.pushCurrentScript(scriptElement.isInShadowTree() ? nullptr : &scriptElement); Later, it will be extended to handle module script elements. 1250758 3 294642 ysuzuki 2016-11-12 18:13:02 -0800 Comment on attachment 294642 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=294642&action=review r=me >> Source/WebCore/dom/CurrentScriptIncrementer.h:46 >> + m_document.pushCurrentScript(scriptElement.isInShadowTree() ? nullptr : &scriptElement); > > Later, it will be extended to handle module script elements. Later, it will be extended to handle module script elements. 1250759 4 294642 rniwa 2016-11-12 18:22:36 -0800 Comment on attachment 294642 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=294642&action=review >>> Source/WebCore/dom/CurrentScriptIncrementer.h:46 >>> + m_document.pushCurrentScript(scriptElement.isInShadowTree() ? nullptr : &scriptElement); >> >> Later, it will be extended to handle module script elements. > > Later, it will be extended to handle module script elements. Yup. Thanks for the review! 1250763 5 294642 commit-queue 2016-11-12 18:46:44 -0800 Comment on attachment 294642 Fixes the bug Clearing flags on attachment: 294642 Committed r208660: <http://trac.webkit.org/changeset/208660> 1250764 6 commit-queue 2016-11-12 18:46:50 -0800 All reviewed patches have been landed. Closing bug. 1250809 7 webkit-bug-importer 2016-11-13 00:58:39 -0800 <rdar://problem/29237296> 294642 2016-11-12 16:57:56 -0800 2016-11-12 18:46:44 -0800 Fixes the bug bug-164693-20161112165341.patch text/plain 5651 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE5ZmJjZmI4M2UyOTBi MGQ5OGI1OTFmODZmZWEwODJjYjgwZmQwYS4uYjYyY2IwYTc3MDYzYzFmZTViMGNhZGI1ZTQ5NTMx ZDY0MDhhYzY0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE2LTExLTEyICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIGRvY3VtZW50LmN1cnJlbnRT Y3JpcHQgc2hvdWxkIGJlIG51bGwgd2hlbiBydW5uaW5nIGEgc2NyaXB0IGluc2lkZSBhIHNoYWRv dyB0cmVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjQ2OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXhlZCB0aGUgYnVnIHRoYXQgd2Ugd2VyZSByZXR1cm5pbmcgdGhlIG9sZCBvciBvdXRlciBzY3Jp cHQgZWxlbWVudCBpbiBkb2N1bWVudC5jdXJyZW50U2NyaXB0CisgICAgICAgIHdoaWxlIGV4ZWN1 dGluZyBhIHNjcmlwdCBlbGVtZW50IGluc2lkZSBhIHNoYWRvdyB0cmVlLiBSZXR1cm4gbnVsbCBp bnN0ZWFkLgorCisgICAgICAgIE5ldyBiZWhhdmlvciBtYXRjaGVzIHRoZSBsYXRlc3QgSFRNTDUg c3BlY2lmaWNhdGlvbjoKKyAgICAgICAgaHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9yZy9tdWx0 aXBhZ2Uvc2NyaXB0aW5nLmh0bWwjZXhlY3V0ZS10aGUtc2NyaXB0LWJsb2NrCisgICAgICAgIHdo ZXJlIGl0IHNheXMgZm9yIHRoZSBjbGFzc2ljIHNjcmlwdCB0eXBlLCAiaWYgdGhlIHNjcmlwdCBl bGVtZW50J3Mgcm9vdCBpcyBub3QgYSBzaGFkb3cgcm9vdCwgdGhlbiBzZXQKKyAgICAgICAgdGhl IHNjcmlwdCBlbGVtZW50J3Mgbm9kZSBkb2N1bWVudCdzIGN1cnJlbnRTY3JpcHQgYXR0cmlidXRl IHRvIHRoZSBzY3JpcHQgZWxlbWVudC4gT3RoZXJ3aXNlLCBzZXQgaXQgdG8gbnVsbC4iCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NoYWRv dy1kb20vRG9jdW1lbnQtcHJvdG90eXBlLWN1cnJlbnRTY3JpcHQuaHRtbCBjb3ZlcnMgaXQuCisK KyAgICAgICAgKiBkb20vQ3VycmVudFNjcmlwdEluY3JlbWVudGVyLmg6CisgICAgICAgIChXZWJD b3JlOjpDdXJyZW50U2NyaXB0SW5jcmVtZW50ZXI6OkN1cnJlbnRTY3JpcHRJbmNyZW1lbnRlcik6 IFB1c2ggbnVsbHB0ciB3aGVuIHRoZSBzY3JpcHQgZWxlbWVudAorICAgICAgICBpcyBpbnNpZGUg YSBzaGFkb3cgdHJlZS4KKyAgICAgICAgKFdlYkNvcmU6OkN1cnJlbnRTY3JpcHRJbmNyZW1lbnRl cjo6fkN1cnJlbnRTY3JpcHRJbmNyZW1lbnRlcik6IENoYW5nZWQgdG8gdXNlIGFuIGVhcmx5IGV4 aXQuCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3Vt ZW50OjpwdXNoQ3VycmVudFNjcmlwdCk6IFJlbW92ZWQgdGhlIGFzc2VydGlvbiBzaW5jZSB0aGUg YXJndW1lbnQgY2FuIG5vdyBiZSBudWxscHRyLgorCiAyMDE2LTExLTEwICBFcmljIENhcmxzb24g IDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtNZWRpYVN0cmVhbV0gYXBwbHkg Y29uc3RyYWludHMgcGFzc2VkIHRvIGdldFVzZXJNZWRpYSgpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9kb20vQ3VycmVudFNjcmlwdEluY3JlbWVudGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9k b20vQ3VycmVudFNjcmlwdEluY3JlbWVudGVyLmgKaW5kZXggYTdkNjNkYTgwNjY0ZmFhMDE4NWE0 YjBhODYwZWQzOGI3ZDBhYWQ3OC4uMTUxZWQ2NTA5YTkyZWJmNTAwODVjMGRiNzJhM2UzZTY4Njg1 NWVkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0N1cnJlbnRTY3JpcHRJbmNyZW1l bnRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9DdXJyZW50U2NyaXB0SW5jcmVtZW50ZXIu aApAQCAtMzgsMjEgKzM4LDI0IEBAIGNsYXNzIEN1cnJlbnRTY3JpcHRJbmNyZW1lbnRlciB7CiBw dWJsaWM6CiAgICAgQ3VycmVudFNjcmlwdEluY3JlbWVudGVyKERvY3VtZW50JiBkb2N1bWVudCwg RWxlbWVudCYgZWxlbWVudCkKICAgICAgICAgOiBtX2RvY3VtZW50KGRvY3VtZW50KQotICAgICAg ICAsIG1faXNIVE1MU2NyaXB0RWxlbWVudE91dHNpZGVTaGFkb3dUcmVlKGlzPEhUTUxTY3JpcHRF bGVtZW50PihlbGVtZW50KSAmJiAhZWxlbWVudC5pc0luU2hhZG93VHJlZSgpKQorICAgICAgICAs IG1faXNIVE1MU2NyaXB0RWxlbWVudChpczxIVE1MU2NyaXB0RWxlbWVudD4oZWxlbWVudCkpCiAg ICAgewotICAgICAgICBpZiAobV9pc0hUTUxTY3JpcHRFbGVtZW50T3V0c2lkZVNoYWRvd1RyZWUp Ci0gICAgICAgICAgICBtX2RvY3VtZW50LnB1c2hDdXJyZW50U2NyaXB0KCZkb3duY2FzdDxIVE1M U2NyaXB0RWxlbWVudD4oZWxlbWVudCkpOworICAgICAgICBpZiAoIW1faXNIVE1MU2NyaXB0RWxl bWVudCkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgYXV0byYgc2NyaXB0RWxlbWVudCA9 IGRvd25jYXN0PEhUTUxTY3JpcHRFbGVtZW50PihlbGVtZW50KTsKKyAgICAgICAgbV9kb2N1bWVu dC5wdXNoQ3VycmVudFNjcmlwdChzY3JpcHRFbGVtZW50LmlzSW5TaGFkb3dUcmVlKCkgPyBudWxs cHRyIDogJnNjcmlwdEVsZW1lbnQpOwogICAgIH0KIAogICAgIH5DdXJyZW50U2NyaXB0SW5jcmVt ZW50ZXIoKQogICAgIHsKLSAgICAgICAgaWYgKG1faXNIVE1MU2NyaXB0RWxlbWVudE91dHNpZGVT aGFkb3dUcmVlKQotICAgICAgICAgICAgbV9kb2N1bWVudC5wb3BDdXJyZW50U2NyaXB0KCk7Cisg ICAgICAgIGlmICghbV9pc0hUTUxTY3JpcHRFbGVtZW50KQorICAgICAgICAgICAgcmV0dXJuOwor ICAgICAgICBtX2RvY3VtZW50LnBvcEN1cnJlbnRTY3JpcHQoKTsKICAgICB9CiAKIHByaXZhdGU6 CiAgICAgRG9jdW1lbnQmIG1fZG9jdW1lbnQ7Ci0gICAgYm9vbCBtX2lzSFRNTFNjcmlwdEVsZW1l bnRPdXRzaWRlU2hhZG93VHJlZTsKKyAgICBib29sIG1faXNIVE1MU2NyaXB0RWxlbWVudDsKIH07 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDM3 NWY0MWNjNjMyYzA1MWI3Y2ExODE5MDNhYWZhYzFhN2M4N2U5Y2YuLmZhNDNmYTAyMWViYWIwZGZl NzY2ODgzNTc1M2VmM2Y1ZDNkYjJlYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNDc4 OSw3ICs0Nzg5LDYgQEAgU3RyaW5nIERvY3VtZW50OjpxdWVyeUNvbW1hbmRWYWx1ZShjb25zdCBT dHJpbmcmIGNvbW1hbmROYW1lKQogCiB2b2lkIERvY3VtZW50OjpwdXNoQ3VycmVudFNjcmlwdChI VE1MU2NyaXB0RWxlbWVudCogbmV3Q3VycmVudFNjcmlwdCkKIHsKLSAgICBBU1NFUlQobmV3Q3Vy cmVudFNjcmlwdCk7CiAgICAgbV9jdXJyZW50U2NyaXB0U3RhY2suYXBwZW5kKG5ld0N1cnJlbnRT Y3JpcHQpOwogfQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCBjYjUwNzM0MmM4 Nzg0OGUwOTU1NzU2YmMzZWNmODNiMGZjZjhlNjAzLi45ZTM4MDNmMGMwNmJkNTNmYjBhODU2YWQ4 NGI2MDNmZmZjNDFiNmIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAxNi0xMS0xMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KKwor ICAgICAgICBkb2N1bWVudC5jdXJyZW50U2NyaXB0IHNob3VsZCBiZSBudWxsIHdoZW4gcnVubmlu ZyBhIHNjcmlwdCBpbnNpZGUgYSBzaGFkb3cgdHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0NjkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmViYXNlbGluZWQgdGhlIGltcG9ydGVkIHRlc3Qgbm93 IHRoYXQgdGhlcmUgYXJlIG5vIGVycm9ycy4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0 cy9zaGFkb3ctZG9tL0RvY3VtZW50LXByb3RvdHlwZS1jdXJyZW50U2NyaXB0LWV4cGVjdGVkLnR4 dDoKKwogMjAxNi0xMS0wNSAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFVwZGF0ZSBTdWJ0bGVDcnlwdG86OmltcG9ydEtleSB0byBtYXRjaCB0aGUgbGF0ZXN0 IHNwZWMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvc2hhZG93LWRvbS9Eb2N1bWVudC1wcm90b3R5cGUtY3VycmVudFNjcmlwdC1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NoYWRv dy1kb20vRG9jdW1lbnQtcHJvdG90eXBlLWN1cnJlbnRTY3JpcHQtZXhwZWN0ZWQudHh0CmluZGV4 IDYzNWVjN2UxNmY4OTg2YmI5MTI0ZTA4OTE4YzI0NDMyZThlNWU2YTMuLmYxMGI4YjcyYjE5MzA0 NGFjOGM1M2I4YzZiOWJlMWE4YmI0MmM0NzggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvc2hhZG93LWRvbS9Eb2N1bWVudC1wcm90b3R5cGUt Y3VycmVudFNjcmlwdC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9zaGFkb3ctZG9tL0RvY3VtZW50LXByb3RvdHlwZS1jdXJyZW50 U2NyaXB0LWV4cGVjdGVkLnR4dApAQCAtMSwxMyArMSwzIEBACi1DT05TT0xFIE1FU1NBR0U6IGxp bmUgMjQyMjogRXJyb3I6IGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkIG51bGwgYnV0IGdvdCBFbGVt ZW50IG5vZGUgPHNjcmlwdCBpZD0ib3V0ZXJTY3JpcHRFbGVtZW50Ij4KLQotdmFyIG91dGVyU2Ny aXB0RWxlbWVudCAuLi4KLUNPTlNPTEUgTUVTU0FHRTogbGluZSAyNDIyOiBFcnJvcjogYXNzZXJ0 X2VxdWFsczogZXhwZWN0ZWQgbnVsbCBidXQgZ290IEVsZW1lbnQgbm9kZSA8c2NyaXB0IGlkPSJv dXRlclNjcmlwdEVsZW1lbnQiPgotCi12YXIgb3V0ZXJTY3JpcHRFbGVtZW50IC4uLgotCi1IYXJu ZXNzIEVycm9yIChGQUlMKSwgbWVzc2FnZSA9IEVycm9yOiBhc3NlcnRfZXF1YWxzOiBleHBlY3Rl ZCBudWxsIGJ1dCBnb3QgRWxlbWVudCBub2RlIDxzY3JpcHQgaWQ9Im91dGVyU2NyaXB0RWxlbWVu dCI+Ci0KLXZhciBvdXRlclNjcmlwdEVsZW1lbnQgLi4uCiAKIFBBU1MgZG9jdW1lbnQuY3VycmVu dFNjcmlwdCBtdXN0IG5vdCB0byBiZSBzZXQgdG8gYSBzY3JpcHQgZWxlbWVudCBpbiBhIHNoYWRv dyB0cmVlIGluIG9wZW4gbW9kZSAKIFBBU1MgZG9jdW1lbnQuY3VycmVudFNjcmlwdCBtdXN0IG5v dCB0byBiZSBzZXQgdG8gYSBzY3JpcHQgZWxlbWVudCBpbiBhIHNoYWRvdyB0cmVlIGluIGNsb3Nl ZCBtb2RlIAo=