164689 2016-11-12 14:15:51 -0800 [FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns 2017-03-07 12:36:34 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro webkit-unassigned bugs-noreply mcatanzaro mmaxfield mrobinson oldest_to_newest 1250718 0 mcatanzaro 2016-11-12 14:15:51 -0800 Behdad warned me about this at the Web Engines Hackfest. From the documentation of FcFontSort(): """The returned FcFontSet references FcPattern structures which may be shared by the return value from multiple FcFontSort calls, applications must not modify these patterns. Instead, they should be passed, along with p to FcFontRenderPrepare which combines them into a complete pattern.""" That means each call to FcFontSort() must be followed up by a call to FcFontRenderPrepare(), else the patterns will lack information about how to draw the font properly. 1250750 1 294643 mcatanzaro 2016-11-12 16:59:05 -0800 Created attachment 294643 [FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns 1250752 2 mcatanzaro 2016-11-12 17:00:15 -0800 Same caveat here as in bug #82889: it's surely going to affect layout tests, so has to be landed once we've cleaned up our existing expectations. 1251059 3 mmaxfield 2016-11-14 11:34:23 -0800 I would review this but I don't understand enough about FontConfig. 1284180 4 294643 mcatanzaro 2017-03-06 21:21:42 -0800 Comment on attachment 294643 [FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns Seems like a good time to try landing this. Carlos? 1284220 5 294643 cgarcia 2017-03-06 23:24:25 -0800 Comment on attachment 294643 [FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns View in context: https://bugs.webkit.org/attachment.cgi?id=294643&action=review > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:265 > + for (int i = 0; i < unpreparedFallbacks.get()->nfont; i++) { unsigned > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:267 > + FcPattern* pattern = FcFontRenderPrepare(nullptr, m_pattern.get(), unpreparedFallbacks.get()->fonts[i]); > + FcFontSetAdd(m_fallbacks.get(), pattern); This could probably be just one line 1284491 6 mcatanzaro 2017-03-07 12:35:57 -0800 (In reply to comment #5) > > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:265 > > + for (int i = 0; i < unpreparedFallbacks.get()->nfont; i++) { > > unsigned Nope, because FcFontSet::nfont is an int. > > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:267 > > + FcPattern* pattern = FcFontRenderPrepare(nullptr, m_pattern.get(), unpreparedFallbacks.get()->fonts[i]); > > + FcFontSetAdd(m_fallbacks.get(), pattern); > > This could probably be just one line OK. 1284493 7 mcatanzaro 2017-03-07 12:36:34 -0800 Committed r213532: <http://trac.webkit.org/changeset/213532> 294643 2016-11-12 16:59:05 -0800 2017-03-06 23:24:25 -0800 [FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns bug-164689-20161112185449.patch text/plain 2453 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE2YmIwYmIyZDUyNjAw ZGQ1YzM3ZjViMDJjOTczOTUyYmMzZWNlNi4uMGI1YzZlYWM0MTQ0OWY5YjFhOGI4ZmQyOTNhZmUz ZDk3YTgxYWZkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE2LTExLTEyICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbRnJlZVR5 cGVdIEZvbnRQbGF0Zm9ybURhdGE6OmZhbGxiYWNrcygpIHJldHVybnMgdW5wcmVwYXJlZCBGY1Bh dHRlcm5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjQ2ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG cm9tIHRoZSBkb2N1bWVudGF0aW9uIG9mIEZjRm9udFNvcnQoKToKKworICAgICAgICAiIiJUaGUg cmV0dXJuZWQgRmNGb250U2V0IHJlZmVyZW5jZXMgRmNQYXR0ZXJuIHN0cnVjdHVyZXMgd2hpY2gg bWF5IGJlIHNoYXJlZCBieSB0aGUKKyAgICAgICAgcmV0dXJuIHZhbHVlIGZyb20gbXVsdGlwbGUg RmNGb250U29ydCBjYWxscywgYXBwbGljYXRpb25zIG11c3Qgbm90IG1vZGlmeSB0aGVzZSBwYXR0 ZXJucy4KKyAgICAgICAgSW5zdGVhZCwgdGhleSBzaG91bGQgYmUgcGFzc2VkLCBhbG9uZyB3aXRo IHAgdG8gRmNGb250UmVuZGVyUHJlcGFyZSB3aGljaCBjb21iaW5lcyB0aGVtIGludG8KKyAgICAg ICAgYSBjb21wbGV0ZSBwYXR0ZXJuLiIiIgorCisgICAgICAgIFRoYXQgbWVhbnMgZWFjaCBjYWxs IHRvIEZjRm9udFNvcnQoKSBtdXN0IGJlIGZvbGxvd2VkIHVwIGJ5IGEgY2FsbCB0byBGY0ZvbnRS ZW5kZXJQcmVwYXJlKCksCisgICAgICAgIGVsc2UgdGhlIHBhdHRlcm5zIHdpbGwgbGFjayBpbmZv cm1hdGlvbiBhYm91dCBob3cgdG8gZHJhdyB0aGUgZm9udCBwcm9wZXJseS4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpGb250UGxhdGZvcm1EYXRhOjpmYWxsYmFja3MpOgorCisyMDE2 LTExLTEyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKwogICAg ICAgICBbR1RLXSBIb25vciBHVEsrIGZvbnQgc2V0dGluZ3MKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgyODg5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlw ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250UGxh dGZvcm1EYXRhRnJlZVR5cGUuY3BwCmluZGV4IGEwZTkxNWFhZTlkMmNkNjAxODdmYzI2YWM1ZDI4 ODU4ZjFiYWIxNWUuLmJjMDdkYzMyYjk5NGYwY2I3NjkyNThhZjE4NzQwZjA3MzZiZGY1OTQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQ bGF0Zm9ybURhdGFGcmVlVHlwZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZnJlZXR5cGUvRm9udFBsYXRmb3JtRGF0YUZyZWVUeXBlLmNwcApAQCAtMjYwLDcgKzI2 MCwxMiBAQCBGY0ZvbnRTZXQqIEZvbnRQbGF0Zm9ybURhdGE6OmZhbGxiYWNrcygpIGNvbnN0CiAK ICAgICBpZiAobV9wYXR0ZXJuKSB7CiAgICAgICAgIEZjUmVzdWx0IGZvbnRDb25maWdSZXN1bHQ7 Ci0gICAgICAgIG1fZmFsbGJhY2tzLnJlc2V0KEZjRm9udFNvcnQobnVsbHB0ciwgbV9wYXR0ZXJu LmdldCgpLCBGY1RydWUsIG51bGxwdHIsICZmb250Q29uZmlnUmVzdWx0KSk7CisgICAgICAgIEZj VW5pcXVlUHRyPEZjRm9udFNldD4gdW5wcmVwYXJlZEZhbGxiYWNrcyhGY0ZvbnRTb3J0KG51bGxw dHIsIG1fcGF0dGVybi5nZXQoKSwgRmNUcnVlLCBudWxscHRyLCAmZm9udENvbmZpZ1Jlc3VsdCkp OworICAgICAgICBtX2ZhbGxiYWNrcy5yZXNldChGY0ZvbnRTZXRDcmVhdGUoKSk7CisgICAgICAg IGZvciAoaW50IGkgPSAwOyBpIDwgdW5wcmVwYXJlZEZhbGxiYWNrcy5nZXQoKS0+bmZvbnQ7IGkr KykgeworICAgICAgICAgICAgRmNQYXR0ZXJuKiBwYXR0ZXJuID0gRmNGb250UmVuZGVyUHJlcGFy ZShudWxscHRyLCBtX3BhdHRlcm4uZ2V0KCksIHVucHJlcGFyZWRGYWxsYmFja3MuZ2V0KCktPmZv bnRzW2ldKTsKKyAgICAgICAgICAgIEZjRm9udFNldEFkZChtX2ZhbGxiYWNrcy5nZXQoKSwgcGF0 dGVybik7CisgICAgICAgIH0KICAgICB9CiAgICAgcmV0dXJuIG1fZmFsbGJhY2tzLmdldCgpOwog fQo=