164684 2016-11-12 11:55:27 -0800 USE(APPLE_INTERNAL_SDK) should not be combined with other conditions 2017-11-03 08:08:24 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 mitz webkit-unassigned ap bdakin fred.wang sam oldest_to_newest 1250692 0 mitz 2016-11-12 11:55:27 -0800 There are some instances of #if USE(APPLE_INTERNAL_SDK) && … in the code base, but this is hardly ever the right thing to do. USE(APPLE_INTERNAL_SDK) really only makes sense as the innermost condition, and almost always has an #else clause that should not depend on anything other than the use of the internal SDK (but should just contain declarations that are equivalent to what the SDK provides). 1250700 1 mitz 2016-11-12 12:39:49 -0800 I see that a common pattern is USE(APPLE_INTERNAL_SDK) || PLATFORM(MAC) because several APIs are public in macOS but private in iOS and Windows. 1367921 2 fred.wang 2017-11-03 08:08:24 -0700 (In reply to mitz from comment #0) > There are some instances of > #if USE(APPLE_INTERNAL_SDK) && … > in the code base, but this is hardly ever the right thing to do. > USE(APPLE_INTERNAL_SDK) really only makes sense as the innermost condition, > and almost always has an #else clause that should not depend on anything > other than the use of the internal SDK (but should just contain declarations > that are equivalent to what the SDK provides). Also, we should consider moving such #if #else into separate SPI.h headers. Note: I just rebased and landed the old patch https://trac.webkit.org/changeset/224395 which adds more USE(APPLE_INTERNAL_SDK) to fix here.