164677 2016-11-11 23:29:26 -0800 Follow-up: fix the OpenSource build on Mac after r208642 2016-11-12 11:52:55 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue rniwa oldest_to_newest 1250621 0 wenson_hsieh 2016-11-11 23:29:26 -0800 It seems I forgot to mark a property as assign. 1250622 1 294602 wenson_hsieh 2016-11-11 23:30:53 -0800 Created attachment 294602 Patch 1250635 2 294602 rniwa 2016-11-12 00:07:35 -0800 Comment on attachment 294602 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294602&action=review rs=me. > Source/WebCore/ChangeLog:7 > + > + The playbackControlsController property should also be `assign`. > + Missing Reviewed by. 1250636 3 294606 wenson_hsieh 2016-11-12 00:11:53 -0800 Created attachment 294606 Patch for landing 1250637 4 294602 wenson_hsieh 2016-11-12 00:12:54 -0800 Comment on attachment 294602 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294602&action=review >> Source/WebCore/ChangeLog:7 >> + > > Missing Reviewed by. Fixed. Thanks! 1250647 5 294606 commit-queue 2016-11-12 00:47:06 -0800 Comment on attachment 294606 Patch for landing Clearing flags on attachment: 294606 Committed r208645: <http://trac.webkit.org/changeset/208645> 1250648 6 rniwa 2016-11-12 00:50:41 -0800 Thanks for the build fixes! 294602 2016-11-11 23:30:53 -0800 2016-11-12 00:07:35 -0800 Patch bug-164677-20161111232637.patch text/plain 1482 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NjQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWM2NzY2ZDI1MjdjODk3 ZDM4OTkxZDY3MzA2OWMxNDIzMmQ1NmE2My4uMzIzN2JmYjVjMDc4MGE3YzI5YzY1NjBhMTFlY2Ni N2ZkMjI1OTE1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE2LTExLTExICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCisgICAgICAgIEZvbGxvdy11cDog Zml4IHRoZSBPcGVuU291cmNlIGJ1aWxkIG9uIE1hYyBhZnRlciByMjA4NjQyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ2NzcKKworICAgICAgICBU aGUgcGxheWJhY2tDb250cm9sc0NvbnRyb2xsZXIgcHJvcGVydHkgc2hvdWxkIGFsc28gYmUgYGFz c2lnbmAuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9zcGkvY29jb2EvQVZLaXRTUEkuaDoKKworMjAx Ni0xMS0xMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKwogICAgICAg ICBTUEkgaW1wb3J0cyBpbiBBVktpdFNQSS5oIHNob3VsZCBiZSBndWFyZGVkIGJ5IFVTRShBUFBM RV9JTlRFUk5BTF9TREspCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjQ2NzIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3Bp L2NvY29hL0FWS2l0U1BJLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvY29jb2EvQVZL aXRTUEkuaAppbmRleCA0MzRlNWY2ZDBmZmU0NWU4MWVkOWQ2ZmQ0MGExODhjMTU1ZWZkZWYyLi41 NDg5NWNhOTY3ZDEwNjA1YjMxNDg4OGYzOTJiM2RjZTlhMmQwZGQwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvY29jb2EvQVZLaXRTUEkuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9zcGkvY29jb2EvQVZLaXRTUEkuaApAQCAtMTcyLDcgKzE3Miw3IEBAIE5T X0FTU1VNRV9OT05OVUxMX0JFR0lOCiAKIEBpbnRlcmZhY2UgQVZGdW5jdGlvbkJhclBsYXliYWNr Q29udHJvbHNQcm92aWRlciA6IE5TUmVzcG9uZGVyCiBAcHJvcGVydHkgKHN0cm9uZywgcmVhZG9u bHksIG51bGxhYmxlKSBOU1RvdWNoQmFyICp0b3VjaEJhcjsKLUBwcm9wZXJ0eSAobnVsbGFibGUp IGlkPEFWRnVuY3Rpb25CYXJQbGF5YmFja0NvbnRyb2xzQ29udHJvbGxpbmc+IHBsYXliYWNrQ29u dHJvbHNDb250cm9sbGVyOworQHByb3BlcnR5IChhc3NpZ24sIG51bGxhYmxlKSBpZDxBVkZ1bmN0 aW9uQmFyUGxheWJhY2tDb250cm9sc0NvbnRyb2xsaW5nPiBwbGF5YmFja0NvbnRyb2xzQ29udHJv bGxlcjsKIEBlbmQKIAogQGludGVyZmFjZSBBVkZ1bmN0aW9uQmFyU2NydWJiZXIgOiBOU1ZpZXcK 294606 2016-11-12 00:11:53 -0800 2016-11-12 00:47:06 -0800 Patch for landing bug-164677-20161112000738.patch text/plain 1461 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NjQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWM2NzY2ZDI1MjdjODk3 ZDM4OTkxZDY3MzA2OWMxNDIzMmQ1NmE2My4uYWQ2NTdlZGUwMGUwYjc5NTlhNjhkMjk1ZmI1NDI0 ZmNjZmIyN2ZhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTExLTEyICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEZvbGxvdy11cDog Zml4IHRoZSBPcGVuU291cmNlIGJ1aWxkIG9uIE1hYyBhZnRlciByMjA4NjQyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ2NzcKKworICAgICAgICBS ZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgVGhlIHBsYXliYWNrQ29udHJvbHND b250cm9sbGVyIHByb3BlcnR5IHNob3VsZCBhbHNvIGJlIGBhc3NpZ25gLgorCisgICAgICAgICog cGxhdGZvcm0vc3BpL2NvY29hL0FWS2l0U1BJLmg6CisKIDIwMTYtMTEtMTEgIFdlbnNvbiBIc2ll aCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgU1BJIGltcG9ydHMgaW4gQVZL aXRTUEkuaCBzaG91bGQgYmUgZ3VhcmRlZCBieSBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3BpL2NvY29hL0FWS2l0U1BJLmggYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvY29jb2EvQVZLaXRTUEkuaAppbmRleCA0MzRlNWY2 ZDBmZmU0NWU4MWVkOWQ2ZmQ0MGExODhjMTU1ZWZkZWYyLi41NDg5NWNhOTY3ZDEwNjA1YjMxNDg4 OGYzOTJiM2RjZTlhMmQwZGQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9z cGkvY29jb2EvQVZLaXRTUEkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvY29j b2EvQVZLaXRTUEkuaApAQCAtMTcyLDcgKzE3Miw3IEBAIE5TX0FTU1VNRV9OT05OVUxMX0JFR0lO CiAKIEBpbnRlcmZhY2UgQVZGdW5jdGlvbkJhclBsYXliYWNrQ29udHJvbHNQcm92aWRlciA6IE5T UmVzcG9uZGVyCiBAcHJvcGVydHkgKHN0cm9uZywgcmVhZG9ubHksIG51bGxhYmxlKSBOU1RvdWNo QmFyICp0b3VjaEJhcjsKLUBwcm9wZXJ0eSAobnVsbGFibGUpIGlkPEFWRnVuY3Rpb25CYXJQbGF5 YmFja0NvbnRyb2xzQ29udHJvbGxpbmc+IHBsYXliYWNrQ29udHJvbHNDb250cm9sbGVyOworQHBy b3BlcnR5IChhc3NpZ24sIG51bGxhYmxlKSBpZDxBVkZ1bmN0aW9uQmFyUGxheWJhY2tDb250cm9s c0NvbnRyb2xsaW5nPiBwbGF5YmFja0NvbnRyb2xzQ29udHJvbGxlcjsKIEBlbmQKIAogQGludGVy ZmFjZSBBVkZ1bmN0aW9uQmFyU2NydWJiZXIgOiBOU1ZpZXcK