164674 2016-11-11 19:51:47 -0800 Speed up setting attributes of input elements of type 'text' 2016-11-12 09:57:53 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cdumez commit-queue rniwa oldest_to_newest 1250578 0 cdumez 2016-11-11 19:51:47 -0800 Speed up setting attributes of input elements of type 'text' by calling updateInnerTextValue() only when needed. It was previously called whenever an attribute was set, no matter it could impact its text value or not. 1250579 1 294585 cdumez 2016-11-11 19:53:10 -0800 Created attachment 294585 Patch 1250675 2 294585 commit-queue 2016-11-12 09:57:49 -0800 Comment on attachment 294585 Patch Clearing flags on attachment: 294585 Committed r208653: <http://trac.webkit.org/changeset/208653> 1250676 3 commit-queue 2016-11-12 09:57:53 -0800 All reviewed patches have been landed. Closing bug. 294585 2016-11-11 19:53:10 -0800 2016-11-12 09:57:49 -0800 Patch bug-164674-20161111194856.patch text/plain 4531 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTVmYmQzM2JjZDg3MGY2 ZGJmMzc2ZmY2ZGNiZmE1OTQyMjQxYmZhMi4uMTI5ZmJjN2YyOTMwYzJhMzdjMmYwMjhmNWZhNDI2 YjgzYjQwZmM0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDE2LTExLTExICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgU3BlZWQgdXAgc2V0dGluZyBh dHRyaWJ1dGVzIG9mIGlucHV0IGVsZW1lbnRzIG9mIHR5cGUgJ3RleHQnCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ2NzQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGVlZCB1cCBzZXR0aW5nIGF0dHJp YnV0ZXMgb2YgaW5wdXQgZWxlbWVudHMgb2YgdHlwZSAndGV4dCcgYnkgY2FsbGluZworICAgICAg ICB1cGRhdGVJbm5lclRleHRWYWx1ZSgpIG9ubHkgd2hlbiBuZWVkZWQuIEl0IHdhcyBwcmV2aW91 c2x5IGNhbGxlZAorICAgICAgICB3aGVuZXZlciBhbiBhdHRyaWJ1dGUgd2FzIHNldCwgbm8gbWF0 dGVyIGl0IGNvdWxkIGltcGFjdCBpdHMgdGV4dCB2YWx1ZQorICAgICAgICBvciBub3QuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBubyBXZWItZXhwb3NlZCBiZWhhdmlvciBjaGFuZ2UuCisKKyAg ICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRN TElucHV0RWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUpOgorICAgICAgICAqIGh0bWwvSW5wdXRUeXBl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklucHV0VHlwZTo6YXR0cmlidXRlQ2hhbmdlZCk6Cisg ICAgICAgICogaHRtbC9JbnB1dFR5cGUuaDoKKyAgICAgICAgKiBodG1sL1RleHRGaWVsZElucHV0 VHlwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0RmllbGRJbnB1dFR5cGU6OmF0dHJpYnV0 ZUNoYW5nZWQpOgorICAgICAgICAqIGh0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmg6CisKKzIwMTYt MTEtMTEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAgICBXb3JrZXJH bG9iYWxTY29wZSdzIGluZGV4ZWREQiBwcm9wZXJ0eSBzaG91bGQgYmUgb24gdGhlIHByb3RvdHlw ZSwgbm90IHRoZSBpbnN0YW5jZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY0NjQ0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TElucHV0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQu Y3BwCmluZGV4IDQxMGNiYzg3MTA5MjhkNGNjMDc0NDlkYTYyMDhlYjI5OGNhMDg3ZDkuLmY3YWQ2 NjgyYThhZTA0YjBhZWUyZTViNGJkY2U1NTA4ZjE4NmZkYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtNzgwLDcgKzc4MCw4IEBAIHZvaWQgSFRNTElucHV0 RWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgY29uc3Qg QXRvbWljU3RyCiAjZW5kaWYKICAgICBlbHNlCiAgICAgICAgIEhUTUxUZXh0Rm9ybUNvbnRyb2xF bGVtZW50OjpwYXJzZUF0dHJpYnV0ZShuYW1lLCB2YWx1ZSk7Ci0gICAgbV9pbnB1dFR5cGUtPmF0 dHJpYnV0ZUNoYW5nZWQoKTsKKworICAgIG1faW5wdXRUeXBlLT5hdHRyaWJ1dGVDaGFuZ2VkKG5h bWUpOwogfQogCiB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnBhcnNlckRpZFNldEF0dHJpYnV0ZXMo KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuY3BwCmluZGV4IGZjYTA4YmExMjAxZDlhZWFmMWUzY2Ji OWFkZGEzMzdiMzhhNDRlYjguLjMxMDJkM2RlZjExZGY5MDBkNTJkODc3Y2YyOGRhZWZlMzQyMGFh ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5jcHAKQEAgLTkwNiw3ICs5MDYsNyBAQCB2b2lk IElucHV0VHlwZTo6dXBkYXRlUGxhY2Vob2xkZXJUZXh0KCkKIHsKIH0KIAotdm9pZCBJbnB1dFR5 cGU6OmF0dHJpYnV0ZUNoYW5nZWQoKQordm9pZCBJbnB1dFR5cGU6OmF0dHJpYnV0ZUNoYW5nZWQo Y29uc3QgUXVhbGlmaWVkTmFtZSYpCiB7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSW5wdXRUeXBlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5oCmluZGV4 IDgxYThhNzljMDc1Yzk2OWFiMDFhM2QzZDhiOGRhYzE5ODc4Y2UyOWQuLmVkNzkyYzhmNDAyOWVl YWNiNjE2YzgxYzI3ZWUzY2VlZWNiNzIyZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSW5wdXRUeXBlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaApAQCAt MjU3LDcgKzI1Nyw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNSZWFkT25s eSgpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVJbm5lclRleHRWYWx1ZSgpOwogICAg IHZpcnR1YWwgdm9pZCB1cGRhdGVQbGFjZWhvbGRlclRleHQoKTsKLSAgICB2aXJ0dWFsIHZvaWQg YXR0cmlidXRlQ2hhbmdlZCgpOworICAgIHZpcnR1YWwgdm9pZCBhdHRyaWJ1dGVDaGFuZ2VkKGNv bnN0IFF1YWxpZmllZE5hbWUmKTsKICAgICB2aXJ0dWFsIHZvaWQgbXVsdGlwbGVBdHRyaWJ1dGVD aGFuZ2VkKCk7CiAgICAgdmlydHVhbCB2b2lkIGRpc2FibGVkQXR0cmlidXRlQ2hhbmdlZCgpOwog ICAgIHZpcnR1YWwgdm9pZCByZWFkb25seUF0dHJpYnV0ZUNoYW5nZWQoKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcAppbmRleCBlZTYzMmFiMWYyNTI0N2M1YjZh ZWNiMDhlM2QxMmY4MzhlNTdiMTI2Li5lYjJhM2M1ZmM1Nzc2N2FhMDA1NDYzY2UyY2IyYTBiM2E2 ZTkyYTIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlw ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuY3BwCkBA IC0zNDYsMTEgKzM0NiwxMCBAQCB2b2lkIFRleHRGaWVsZElucHV0VHlwZTo6ZGVzdHJveVNoYWRv d1N1YnRyZWUoKQogICAgIG1fY29udGFpbmVyID0gbnVsbHB0cjsKIH0KIAotdm9pZCBUZXh0Rmll bGRJbnB1dFR5cGU6OmF0dHJpYnV0ZUNoYW5nZWQoKQordm9pZCBUZXh0RmllbGRJbnB1dFR5cGU6 OmF0dHJpYnV0ZUNoYW5nZWQoY29uc3QgUXVhbGlmaWVkTmFtZSYgYXR0cmlidXRlTmFtZSkKIHsK LSAgICAvLyBGSVhNRTogVXBkYXRpbmcgdGhlIGlubmVyIHRleHQgb24gYW55IGF0dHJpYnV0ZSB1 cGRhdGUgc2hvdWxkCi0gICAgLy8gYmUgdW5uZWNlc3NhcnkuIFdlIHNob3VsZCBmaWd1cmUgb3V0 IHdoYXQgYXR0cmlidXRlcyBhZmZlY3QuCi0gICAgdXBkYXRlSW5uZXJUZXh0VmFsdWUoKTsKKyAg ICBpZiAoYXR0cmlidXRlTmFtZSA9PSB2YWx1ZUF0dHIgfHwgYXR0cmlidXRlTmFtZSA9PSBwbGFj ZWhvbGRlckF0dHIpCisgICAgICAgIHVwZGF0ZUlubmVyVGV4dFZhbHVlKCk7CiB9CiAKIHZvaWQg VGV4dEZpZWxkSW5wdXRUeXBlOjpkaXNhYmxlZEF0dHJpYnV0ZUNoYW5nZWQoKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuaCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmgKaW5kZXggMjQxYWJhOTM5MWYzY2M0YTYwNDc3 ZTQzZGRlMGJkZTdlZTZiMGUzNi4uNDI5MzM0NTJjNTUyYjg2NjA3NGUxNzcyM2VlODMxYzM5NWY5 NWFlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5oCkBAIC01OSw3 ICs1OSw3IEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIGJvb2wgbmVlZHNDb250YWluZXIoKSBj b25zdDsKICAgICB2b2lkIGNyZWF0ZVNoYWRvd1N1YnRyZWUoKSBvdmVycmlkZTsKICAgICB2b2lk IGRlc3Ryb3lTaGFkb3dTdWJ0cmVlKCkgb3ZlcnJpZGU7Ci0gICAgdm9pZCBhdHRyaWJ1dGVDaGFu Z2VkKCkgZmluYWw7CisgICAgdm9pZCBhdHRyaWJ1dGVDaGFuZ2VkKGNvbnN0IFF1YWxpZmllZE5h bWUmKSBmaW5hbDsKICAgICB2b2lkIGRpc2FibGVkQXR0cmlidXRlQ2hhbmdlZCgpIGZpbmFsOwog ICAgIHZvaWQgcmVhZG9ubHlBdHRyaWJ1dGVDaGFuZ2VkKCkgZmluYWw7CiAgICAgYm9vbCBzdXBw b3J0c1JlYWRPbmx5KCkgY29uc3QgZmluYWw7Cg==