164667 2016-11-11 17:06:31 -0800 run-safari does not work for open source contributors 2016-11-12 02:35:10 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=149711 InRadar P2 Normal --- 1 joepeck mitz ap beidson dbates ddkilzer hi joepeck lforschler mitz rik timothy webkit-bug-importer oldest_to_newest 1250523 0 joepeck 2016-11-11 17:06:31 -0800 Summary: run-safari does not appear to work for open source contributors. They end up having to use debug-safari. Either we should make run-safari work, or change the instructions <https://webkit.org/running-webkit/> > [16:19:45] Rik`: it seems run-safari is just using system webkit rather than the one I built > [16:20:48] dcrousso: oh yeah Rik` I have that issue too > [16:21:01] dcrousso: I have to use `debug-safari` instead > [16:21:17] dcrousso: followed by `r` or `run` > [16:21:31] dcrousso: ive been doing that for 2 years now > [16:22:34] Rik`: maybe we should update the instructions on https://webkit.org/running-webkit/ ? > [16:26:41] Rik`: I've found this info https://trac.webkit.org/wiki/WebKitNightlyElCapWorkaround but that didn't change things > [16:29:06] dcrousso: yeah ever since ElCapitan it hasnt been working It seems as though run-safari does launch SafariForWebKitDevelopment but is using System WebKit frameworks instead of the built WebKit frameworks. 1250524 1 webkit-bug-importer 2016-11-11 17:09:46 -0800 <rdar://problem/29229894> 1250633 2 mitz 2016-11-12 00:03:33 -0800 I can reproduce this in macOS Sierra 10.12.1. I can see that the “arch” branch is taken in webkitdirs.pm’s runWebKitApp(). If iI force the “system { $appPath }” code path to be taken, the right frameworks are picked up. I think this is due to arch(1) itself being restricted and therefore not carrying over DYLD_FRAMEWORK_PATH from the environment into what it’s executing. I think we have a workaround for that in one of the other scripts. 1250634 3 mitz 2016-11-12 00:05:27 -0800 See <https://trac.webkit.org/r190412>, the fix for bug 149711, which was the same issue with run-api-tests. 1250638 4 294607 mitz 2016-11-12 00:16:31 -0800 Created attachment 294607 Pass DYLD_* environment variables over arch(1) 1250643 5 294607 joepeck 2016-11-12 00:25:34 -0800 Comment on attachment 294607 Pass DYLD_* environment variables over arch(1) r=me! Thanks Dan! 1250644 6 mitz 2016-11-12 00:27:34 -0800 Fixed in <https://trac.webkit.org/r208644>. 1250645 7 294607 joepeck 2016-11-12 00:28:38 -0800 Comment on attachment 294607 Pass DYLD_* environment variables over arch(1) View in context: https://bugs.webkit.org/attachment.cgi?id=294607&action=review > Tools/Scripts/run-api-tests:-391 > -sub archCommandLineArgumentsForRestrictedEnvironmentVariables() You may be able to remove a forward declaration for this at the top of this file. Now that it has moved. 1250655 8 rik 2016-11-12 02:35:10 -0800 Thanks, that fixed it! 294607 2016-11-12 00:16:31 -0800 2016-11-12 00:25:34 -0800 Pass DYLD_* environment variables over arch(1) bug-164667-20161112001216.patch text/plain 2985 mitz SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwODY0MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE2LTExLTEyICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgcnVuLXNhZmFyaSBkb2VzIG5vdCB3b3JrIGZvciBvcGVuIHNvdXJjZSBjb250cmli dXRvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 NDY2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjkyMjk4OTQ+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1hcGktdGVzdHM6 CisgICAgICAgIChhcmNoQ29tbWFuZExpbmVBcmd1bWVudHNGb3JSZXN0cmljdGVkRW52aXJvbm1l bnRWYXJpYWJsZXMpOiBNb3ZlZCBmcm9tIGhlcmXigKYKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dGRpcnMucG06CisgICAgICAgIChhcmNoQ29tbWFuZExpbmVBcmd1bWVudHNGb3JSZXN0cmljdGVk RW52aXJvbm1lbnRWYXJpYWJsZXMpOiDigKZ0byBoZXJlCisgICAgICAgIChydW5NYWNXZWJLaXRB cHApOiBIYXZlIGFyY2goMSkgY2FycnkgdGhlIERZTERfKiB2YXJpYWJsZXMgd2Ugc2V0IGluIG91 ciBlbnZpcm9ubWV0IG92ZXIKKyAgICAgICAgICB0byB0aGUgZW52aXJvbm1lbnQgb2YgdGhlIGFw cCBiZWluZyBydW4uCisKIDIwMTYtMTEtMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW1vdmVkIHVudXNlZCBJTkNMVURFX09QVElPTlNfRk9SX0RF QlVHR0lORwpJbmRleDogVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvcnVuLWFwaS10ZXN0cwkocmV2aXNpb24gMjA4NjQyKQorKysgVG9vbHMv U2NyaXB0cy9ydW4tYXBpLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0zODgsMTcgKzM4OCw2IEBA IHN1YiBwcmVwYXJlRW52aXJvbm1lbnRGb3JSdW5uaW5nVGVzdFRvb2wKICAgICBzZXR1cE1hY1dl YktpdEVudmlyb25tZW50KHByb2R1Y3REaXIoKSk7CiB9CiAKLXN1YiBhcmNoQ29tbWFuZExpbmVB cmd1bWVudHNGb3JSZXN0cmljdGVkRW52aXJvbm1lbnRWYXJpYWJsZXMoKQotewotICAgIG15IEBh cmd1bWVudHMgPSAoKTsKLSAgICBmb3JlYWNoIG15ICRrZXkgKGtleXMoJUVOVikpIHsKLSAgICAg ICAgaWYgKCRrZXkgPX4gL15EWUxEXy8pIHsKLSAgICAgICAgICAgIHB1c2ggQGFyZ3VtZW50cywg Ii1lIiwgIiRrZXk9JEVOVnska2V5fSI7Ci0gICAgICAgIH0KLSAgICB9Ci0gICAgcmV0dXJuIEBh cmd1bWVudHM7Ci19Ci0KIHN1YiB0ZXN0VG9vbFBhdGhzKCkKIHsKICAgICBpZiAoIWlzQXBwbGVX aW5XZWJLaXQoKSkgewpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gMjA4NjQyKQorKysg VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC01OSw2ICs1OSw3 IEBAIEJFR0lOIHsKICAgICAgICAmWGNvZGVTdGF0aWNBbmFseXplck9wdGlvbgogICAgICAgICZh cHBEaXNwbGF5TmFtZUZyb21CdW5kbGUKICAgICAgICAmYXBwZW5kVG9FbnZpcm9ubWVudFZhcmlh YmxlTGlzdAorICAgICAgICZhcmNoQ29tbWFuZExpbmVBcmd1bWVudHNGb3JSZXN0cmljdGVkRW52 aXJvbm1lbnRWYXJpYWJsZXMKICAgICAgICAmYmFzZVByb2R1Y3REaXIKICAgICAgICAmY2hkaXJX ZWJLaXQKICAgICAgICAmY2hlY2tGcmFtZXdvcmtzCkBAIC0yNDM3LDYgKzI0MzgsMTcgQEAgc3Vi IHJ1bklPU1dlYktpdEFwcCgkKQogICAgIGRpZSAiTm90IHVzaW5nIGFuIGlPUyBTREsuIgogfQog CitzdWIgYXJjaENvbW1hbmRMaW5lQXJndW1lbnRzRm9yUmVzdHJpY3RlZEVudmlyb25tZW50VmFy aWFibGVzKCkKK3sKKyAgICBteSBAYXJndW1lbnRzID0gKCk7CisgICAgZm9yZWFjaCBteSAka2V5 IChrZXlzKCVFTlYpKSB7CisgICAgICAgIGlmICgka2V5ID1+IC9eRFlMRF8vKSB7CisgICAgICAg ICAgICBwdXNoIEBhcmd1bWVudHMsICItZSIsICIka2V5PSRFTlZ7JGtleX0iOworICAgICAgICB9 CisgICAgfQorICAgIHJldHVybiBAYXJndW1lbnRzOworfQorCiBzdWIgcnVuTWFjV2ViS2l0QXBw KCQ7JCkKIHsKICAgICBteSAoJGFwcFBhdGgsICR1c2VPcGVuQ29tbWFuZCkgPSBAXzsKQEAgLTI0 NTAsNyArMjQ2Miw3IEBAIHN1YiBydW5NYWNXZWJLaXRBcHAoJDskKQogICAgICAgICByZXR1cm4g c3lzdGVtKCJvcGVuIiwgIi1XIiwgIi1hIiwgJGFwcFBhdGgsICItLWFyZ3MiLCBhcmd1bWVudHNG b3JSdW5BbmREZWJ1Z01hY1dlYktpdEFwcCgpKTsKICAgICB9CiAgICAgaWYgKGFyY2hpdGVjdHVy ZSgpKSB7Ci0gICAgICAgIHJldHVybiBzeXN0ZW0gImFyY2giLCAiLSIgLiBhcmNoaXRlY3R1cmUo KSwgJGFwcFBhdGgsIGFyZ3VtZW50c0ZvclJ1bkFuZERlYnVnTWFjV2ViS2l0QXBwKCk7CisgICAg ICAgIHJldHVybiBzeXN0ZW0gImFyY2giLCAiLSIgLiBhcmNoaXRlY3R1cmUoKSwgYXJjaENvbW1h bmRMaW5lQXJndW1lbnRzRm9yUmVzdHJpY3RlZEVudmlyb25tZW50VmFyaWFibGVzKCksICRhcHBQ YXRoLCBhcmd1bWVudHNGb3JSdW5BbmREZWJ1Z01hY1dlYktpdEFwcCgpOwogICAgIH0KICAgICBy ZXR1cm4gc3lzdGVtIHsgJGFwcFBhdGggfSAkYXBwUGF0aCwgYXJndW1lbnRzRm9yUnVuQW5kRGVi dWdNYWNXZWJLaXRBcHAoKTsKIH0K