164626 2016-11-10 17:22:46 -0800 Fix broken have-a-bad-time-with-arguments.js test. 2016-11-10 17:31:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam oldest_to_newest 1250076 0 mark.lam 2016-11-10 17:22:46 -0800 But also save a copy of the broken one as broken-have-a-bad-time-with-arguments-for-gc-testing.js because coincidentally, it stresses the GC in ways that help reveal bugs. 1250078 1 294448 mark.lam 2016-11-10 17:28:08 -0800 Created attachment 294448 proposed patch. 1250079 2 mark.lam 2016-11-10 17:31:28 -0800 Thanks for the review. Landed in r208574: <http://trac.webkit.org/r208574>. 294448 2016-11-10 17:28:08 -0800 2016-11-10 17:28:42 -0800 proposed patch. bug-164626.patch text/plain 8078 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDg1NzMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE5IEBACisyMDE2LTExLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggYnJva2VuIGhhdmUtYS1iYWQtdGltZS13aXRoLWFyZ3VtZW50cy5q cyB0ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY0NjI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QnV0IGFsc28gc2F2ZWQgYSBjb3B5IG9mIHRoZSBicm9rZW4gb25lIGFzIGJyb2tlbi1oYXZlLWEt YmFkLXRpbWUtd2l0aC1hcmd1bWVudHMtZm9yLWdjLXRlc3RpbmcuanMKKyAgICAgICAgYmVjYXVz ZSBjb2luY2lkZW50YWxseSwgaXQgc3RyZXNzZXMgdGhlIEdDIGluIHdheXMgdGhhdCBoZWxwIHJl dmVhbCBidWdzLgorCisgICAgICAgICogc3RyZXNzL2Jyb2tlbi1oYXZlLWEtYmFkLXRpbWUtd2l0 aC1hcmd1bWVudHMtZm9yLWdjLXRlc3RpbmcuanM6IEFkZGVkLgorICAgICAgICAodGVzdEZ1bmN0 aW9uKToKKyAgICAgICAgKHdhcm11cEZ1bmN0aW9uKToKKyAgICAgICAgKGxldC5hcmdzRGVjbElu ZGV4LmluLmFyZ3VtZW50c0RlY2xzLmxldC5pbmRleFRvUmV0dXJuSW5kZXguaW4uaW5kaWNlc1Rv UmV0dXJuLmxldC5pbnNlcnRFbGVtZW50QWN0aW9uSW5kZXguaW4uaW5zZXJ0RWxlbWVudEFjdGlv bnMubGV0LnRpZXJXYXJtdXBDb3VudEluZGV4LmluLnRpZXJXYXJtdXBDb3VudHMubGV0LnRlc3RB cmdzSW5kZXguaW4udGVzdEFyZ3NMaXN0LmNhdGNoKToKKyAgICAgICAgKiBzdHJlc3MvaGF2ZS1h LWJhZC10aW1lLXdpdGgtYXJndW1lbnRzLmpzOgorCiAyMDE2LTExLTEwICBKRiBCYXN0aWVuICA8 amZiYXN0aWVuQGFwcGxlLmNvbT4KIAogICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiBsZW5ndGgg PiBvZmZzZXQgZW5jb3VudGVyZWQgd2l0aCB3YXNtLnlhbWwvd2FzbS9qcy1hcGkvdGVzdF9Nb2R1 bGUuanMuZGVmYXVsdC13YXNtCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9icm9rZW4taGF2ZS1hLWJh ZC10aW1lLXdpdGgtYXJndW1lbnRzLWZvci1nYy10ZXN0aW5nLmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpT VGVzdHMvc3RyZXNzL2Jyb2tlbi1oYXZlLWEtYmFkLXRpbWUtd2l0aC1hcmd1bWVudHMtZm9yLWdj LXRlc3RpbmcuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvYnJva2VuLWhhdmUt YS1iYWQtdGltZS13aXRoLWFyZ3VtZW50cy1mb3ItZ2MtdGVzdGluZy5qcwkod29ya2luZyBjb3B5 KQpAQCAtMCwwICsxLDE0MCBAQAorLy9AIHJ1bkZUTE5vQ0pJVAorCisvLyBUZXN0cyBhY2Nlc3Np bmcgYW4gZWxlbWVudCBpbiBhcmd1bWVudHMgYmVmb3JlIGFuZCBhZnRlciBoYXZpbmcgYSBiYWQg dGltZS4KKy8vIFRoaXMgdGVzdCBzaG91bGQgbm90IGNyYXNoLgorCitsZXQgdmVyYm9zZSA9IGZh bHNlOworCit2YXIgdXRpbGl0aWVzID0gICAgICAgICAgICAgICAgICdmdW5jdGlvbiBzaG91bGRF cXVhbCh0ZXN0SWQsIGFjdHVhbCwgZXhwZWN0ZWQpIHsnICsgJ1xuJyArCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICcgICAgaWYgKGFjdHVhbCAhPSBleHBlY3RlZCknICsgJ1xuJyAr CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAgIHRocm93IHRlc3RJZCAr ICI6IEVSUk9SOiBleHBlY3QgIiArIGV4cGVjdGVkICsgIiwgYWN0dWFsICIgKyBhY3R1YWw7JyAr ICdcbicgKworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnfScgKyAnXG4nOworCit2 YXIgaGF2ZUFCYWRUaW1lID0gICAgICAgICAgICAgICdPYmplY3QuZGVmaW5lUHJvcGVydHkoT2Jq ZWN0LnByb3RvdHlwZSwgMjAsIHsgZ2V0KCkgeyByZXR1cm4gMjA7IH0gfSk7JyArICdcbic7CisK K3ZhciBkaXJlY3RBcmd1bWVudHNEZWNsID0gICAgICAgJyAgICB2YXIgYXJncyA9IGFyZ3VtZW50 czsnICsgJ1xuJzsKKwordmFyIHNjb3BlZEFyZ3VtZW50c0RlY2wgPSAgICAgICAnICAgIHZhciBh cmdzID0gYXJndW1lbnRzOycgKyAnXG4nICsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgJyAgICBmdW5jdGlvbiBjbG9zdXJlKCkgeyByZXR1cm4geDsgfScgKyAnXG4nOworCit2YXIg Y2xvbmVkQXJndW1lbnRzRGVjbCA9ICAgICAgICcgICAgInVzZSBzdHJpY3QiOycgKyAnXG4nICsK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICB2YXIgYXJncyA9IGFyZ3VtZW50 czsnICsgJ1xuJzsKKworZnVuY3Rpb24gdGVzdEZ1bmN0aW9uKGFyZ3NEZWNsLCBpbnNlcnRFbGVt ZW50QWN0aW9uLCBpbmRleFRvUmV0dXJuKSB7CisgICAgdmFyIHNjcmlwdCA9ICAgICAgICAgICAg ICAgICdmdW5jdGlvbiB0ZXN0KHgpIHsnICsgJ1xuJyArCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYXJnc0RlY2wgKworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGluc2VydEVsZW1lbnRBY3Rpb24gKworICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAnICAgIHJldHVybiBhcmdzWycgKyBpbmRleFRvUmV0dXJuICsgJ107JyArICdcbicgKwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnfScgKyAnXG4nICsKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJ25vSW5saW5lKHRlc3QpOycgKyAnXG4nOworICAgIHJldHVy biBzY3JpcHQ7Cit9CisKK2Z1bmN0aW9uIHdhcm11cEZ1bmN0aW9uKHRpZXJXYXJtdXBDb3VudCwg dGVzdEFyZ3MpIHsKKyAgICB2YXIgc2NyaXB0ID0gICAgICAgICAgICAgICAgJ2Z1bmN0aW9uIHdh cm11cCgpIHsnICsgJ1xuJyArCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAg Zm9yICh2YXIgaSA9IDA7IGkgPCAnICsgdGllcldhcm11cENvdW50ICsgJzsgaSsrKSB7JyArICdc bicgKworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnICAgICAgICB0ZXN0KCcgKyB0 ZXN0QXJncyArICcpOycgKyAnXG4nICsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg JyAgICB9JyArICdcbicgKworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnfScgKyAn XG4nOworICAgIHJldHVybiBzY3JpcHQ7Cit9CisKK2xldCBhcmd1bWVudHNEZWNscyA9IHsKKyAg ICBkaXJlY3Q6IGRpcmVjdEFyZ3VtZW50c0RlY2wsCisgICAgc2NvcGVkOiBzY29wZWRBcmd1bWVu dHNEZWNsLAorICAgIGNsb25lZDogY2xvbmVkQXJndW1lbnRzRGVjbAorfTsKKworbGV0IGluZGlj ZXNUb1JldHVybiA9IHsKKyAgICBpbkJvdW5kczogMCwKKyAgICBvdXRPZkJvdW5kc0luc2VydGVk RWxlbWVudDogMTAsCisgICAgb3V0T2ZCb3VuZHNJblByb3RvdHlwZTogMjAKK307CisKK2xldCB0 aWVyV2FybXVwQ291bnRzID0geworICAgIGxsaW50OiAxLAorICAgIGJhc2VsaW5lOiA1MCwKKyAg ICBkZmc6IDEwMDAsCisgICAgZnRsOiAxMDAwMAorfTsKKworbGV0IHRlc3RBcmdzTGlzdCA9IHsK KyAgICBub0FyZ3M6ICAgeworICAgICAgICBhcmdzOiAnJywKKyAgICAgICAgcmVzdWx0OiB7Cisg ICAgICAgICAgICBpbkJvdW5kczogeyBiZWZvcmVCYWRUaW1lOiAndW5kZWZpbmVkJywgYWZ0ZXJC YWRUaW1lOiAndW5kZWZpbmVkJywgfSwKKyAgICAgICAgICAgIG91dE9mQm91bmRzSW5zZXJ0ZWRF bGVtZW50OiB7IGJlZm9yZUJhZFRpbWU6ICcxMCcsIGFmdGVyQmFkVGltZTogJzEwJywgfSwKKyAg ICAgICAgICAgIG91dE9mQm91bmRzSW5Qcm90b3R5cGU6IHsgYmVmb3JlQmFkVGltZTogJ3VuZGVm aW5lZCcsIGFmdGVyQmFkVGltZTogJzIwJywgfSwKKyAgICAgICAgfQorICAgIH0sCisgICAgc29t ZUFyZ3M6IHsKKyAgICAgICAgYXJnczogJzEsIDIsIDMnLAorICAgICAgICByZXN1bHQ6IHsKKyAg ICAgICAgICAgIGluQm91bmRzOiB7IGJlZm9yZUJhZFRpbWU6ICcxJywgYWZ0ZXJCYWRUaW1lOiAn MScsIH0sCisgICAgICAgICAgICBvdXRPZkJvdW5kc0luc2VydGVkRWxlbWVudDogeyBiZWZvcmVC YWRUaW1lOiAnMTAnLCBhZnRlckJhZFRpbWU6ICcxMCcsIH0sCisgICAgICAgICAgICBvdXRPZkJv dW5kc0luUHJvdG90eXBlOiB7IGJlZm9yZUJhZFRpbWU6ICd1bmRlZmluZWQnLCBhZnRlckJhZFRp bWU6ICcyMCcsIH0sCisgICAgICAgIH0KKyAgICB9Cit9OworCitsZXQgaW5zZXJ0RWxlbWVudEFj dGlvbnMgPSB7CisgICAgaW5zZXJ0RWxlbWVudDogICAgICAnICAgIGFyZ3NbMTBdID0gMTA7JyAr ICdcbicsCisgICAgZG9udEluc2VydEVsZW1lbnQ6ICAnJworfTsKKworZm9yIChsZXQgYXJnc0Rl Y2xJbmRleCBpbiBhcmd1bWVudHNEZWNscykgeworICAgIGxldCBhcmdzRGVjbCA9IGFyZ3VtZW50 c0RlY2xzW2FyZ3NEZWNsSW5kZXhdOworCisgICAgZm9yIChsZXQgaW5kZXhUb1JldHVybkluZGV4 IGluIGluZGljZXNUb1JldHVybikgeworICAgICAgICBsZXQgaW5kZXhUb1JldHVybiA9IGluZGlj ZXNUb1JldHVybltpbmRleFRvUmV0dXJuSW5kZXhdOworCisgICAgICAgIGZvciAobGV0IGluc2Vy dEVsZW1lbnRBY3Rpb25JbmRleCBpbiBpbnNlcnRFbGVtZW50QWN0aW9ucykgeworICAgICAgICAg ICAgbGV0IGluc2VydEVsZW1lbnRBY3Rpb24gPSBpbnNlcnRFbGVtZW50QWN0aW9uc1tpbnNlcnRF bGVtZW50QWN0aW9uSW5kZXhdOworCisgICAgICAgICAgICBmb3IgKGxldCB0aWVyV2FybXVwQ291 bnRJbmRleCBpbiB0aWVyV2FybXVwQ291bnRzKSB7CisgICAgICAgICAgICAgICAgbGV0IHRpZXJX YXJtdXBDb3VudCA9IHRpZXJXYXJtdXBDb3VudHNbdGllcldhcm11cENvdW50SW5kZXhdOworCisg ICAgICAgICAgICAgICAgZm9yIChsZXQgdGVzdEFyZ3NJbmRleCBpbiB0ZXN0QXJnc0xpc3QpIHsK KyAgICAgICAgICAgICAgICAgICAgbGV0IHRlc3RBcmdzID0gdGVzdEFyZ3NMaXN0W3Rlc3RBcmdz SW5kZXhdLmFyZ3M7CisgICAgICAgICAgICAgICAgICAgIGxldCBleHBlY3RlZFJlc3VsdCA9IHRl c3RBcmdzTGlzdFt0ZXN0QXJnc0luZGV4XS5yZXN1bHRbaW5kZXhUb1JldHVybkluZGV4XTsKKwor ICAgICAgICAgICAgICAgICAgICBpZiAoaW5kZXhUb1JldHVybkluZGV4ID09ICdvdXRPZkJvdW5k c0luc2VydGVkRWxlbWVudCcKKyAgICAgICAgICAgICAgICAgICAgICAgICYmIGluc2VydEVsZW1l bnRBY3Rpb25JbmRleCA9PSAnZG9udEluc2VydEVsZW1lbnQnKQorICAgICAgICAgICAgICAgICAg ICAgICAgZXhwZWN0ZWRSZXN1bHQgPSAndW5kZWZpbmVkJzsKKworICAgICAgICAgICAgICAgICAg ICBsZXQgdGVzdE5hbWUgPQorICAgICAgICAgICAgICAgICAgICAgICAgYXJnc0RlY2xJbmRleCAr ICctJyArCisgICAgICAgICAgICAgICAgICAgICAgICBpbmRleFRvUmV0dXJuSW5kZXggKyAnLScg KworICAgICAgICAgICAgICAgICAgICAgICAgaW5zZXJ0RWxlbWVudEFjdGlvbkluZGV4ICsgJy0n ICsKKyAgICAgICAgICAgICAgICAgICAgICAgIHRpZXJXYXJtdXBDb3VudEluZGV4ICsgJy0nICsK KyAgICAgICAgICAgICAgICAgICAgICAgIHRlc3RBcmdzSW5kZXg7CisKKworICAgICAgICAgICAg ICAgICAgICBsZXQgc2NyaXB0ID0gdXRpbGl0aWVzICsKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHRlc3RGdW5jdGlvbihhcmdzRGVjbCwgaW5zZXJ0RWxlbWVudEFjdGlvbiwgaW5k ZXhUb1JldHVybikgKworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgd2FybXVwRnVu Y3Rpb24odGllcldhcm11cENvdW50LCB0ZXN0QXJncykgKworICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJ3dhcm11cCgpJyArICdcbicgKworICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgJ3Nob3VsZEVxdWFsKDEwMDAwLCB0ZXN0KCcgKyB0ZXN0QXJncyArICcpLCAnICsg ZXhwZWN0ZWRSZXN1bHRbJ2JlZm9yZUJhZFRpbWUnXSArICcpOycgKyAnXG4nOworICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaGF2ZUFCYWRUaW1lICsKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICdzaG91bGRFcXVhbCgyMDAwMCwgdGVzdCgnICsgdGVzdEFyZ3MgKyAn KSwgJyArIGV4cGVjdGVkUmVzdWx0WydhZnRlckJhZFRpbWUnXSArICcpOycgKyAnXG4nOworCisg ICAgICAgICAgICAgICAgICAgIGlmICh2ZXJib3NlKSB7CisgICAgICAgICAgICAgICAgICAgICAg ICBwcmludCgnUnVubmluZyB0ZXN0IGNvbmZpZ3VyYXRpb246ICcgKyB0ZXN0TmFtZSk7CisgICAg ICAgICAgICAgICAgICAgICAgICBwcmludCgKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAn VGVzdCBzY3JpcHQ6ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT1cbicgKworICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNjcmlwdCArCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgJz09PSBFTkQgc2NyaXB0ID09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Jyk7CisgICAgICAgICAgICAgICAgICAg IH0KKworICAgICAgICAgICAgICAgICAgICB0cnkgeworICAgICAgICAgICAgICAgICAgICAgICAg cnVuU3RyaW5nKHNjcmlwdCk7CisgICAgICAgICAgICAgICAgICAgIH0gY2F0Y2ggKGUpIHsKKyAg ICAgICAgICAgICAgICAgICAgICAgIHByaW50KCdGQUlMRUQgdGVzdCBjb25maWd1cmF0aW9uOiAn ICsgdGVzdE5hbWUpOworICAgICAgICAgICAgICAgICAgICAgICAgcHJpbnQoJ0ZBSUxFRCB0ZXN0 IHNjcmlwdDpcbicgKyBzY3JpcHQpOworICAgICAgICAgICAgICAgICAgICAgICAgdGhyb3cgZTsK KyAgICAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0K KyAgICAgICAgfQorICAgIH0KK30KSW5kZXg6IEpTVGVzdHMvc3RyZXNzL2hhdmUtYS1iYWQtdGlt ZS13aXRoLWFyZ3VtZW50cy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9oYXZlLWEt YmFkLXRpbWUtd2l0aC1hcmd1bWVudHMuanMJKHJldmlzaW9uIDIwODU3MykKKysrIEpTVGVzdHMv c3RyZXNzL2hhdmUtYS1iYWQtdGltZS13aXRoLWFyZ3VtZW50cy5qcwkod29ya2luZyBjb3B5KQpA QCAtMTE0LDcgKzExNCw3IEBAIGZvciAobGV0IGFyZ3NEZWNsSW5kZXggaW4gYXJndW1lbnRzRGVj bHMKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRlc3RGdW5jdGlvbihhcmdzRGVj bCwgaW5zZXJ0RWxlbWVudEFjdGlvbiwgaW5kZXhUb1JldHVybikgKwogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgd2FybXVwRnVuY3Rpb24odGllcldhcm11cENvdW50LCB0ZXN0QXJn cykgKwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3dhcm11cCgpJyArICdcbicg KwotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3Nob3VsZEVxdWFsKDEwMDAwLCB0 ZXN0KCcgKyB0ZXN0QXJncyArICcpLCAnICsgZXhwZWN0ZWRSZXN1bHRbJ2JlZm9yZUJhZFRpbWUn XSArICcpOycgKyAnXG4nOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3Nob3Vs ZEVxdWFsKDEwMDAwLCB0ZXN0KCcgKyB0ZXN0QXJncyArICcpLCAnICsgZXhwZWN0ZWRSZXN1bHRb J2JlZm9yZUJhZFRpbWUnXSArICcpOycgKyAnXG4nICsKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGhhdmVBQmFkVGltZSArCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAnc2hvdWxkRXF1YWwoMjAwMDAsIHRlc3QoJyArIHRlc3RBcmdzICsgJyksICcgKyBleHBlY3Rl ZFJlc3VsdFsnYWZ0ZXJCYWRUaW1lJ10gKyAnKTsnICsgJ1xuJzsKIAo=