164621 2016-11-10 15:32:03 -0800 After r207459 ASSERT in CachedResourceLoader under InspectorPageAgent::cachedResource 2016-11-10 16:04:23 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer youennf oldest_to_newest 1250008 0 joepeck 2016-11-10 15:32:03 -0800 Summary: After r207459 ASSERT in CachedResourceLoader under InspectorPageAgent::cachedResource Browsing in debug build with Web Inspector open, or opening inspector on some pages produces this ASSERT: ASSERTION FAILED: !MemoryCache::shouldRemoveFragmentIdentifier(url) Source/WebCore/loader/cache/CachedResourceLoader.cpp(160) : WebCore::CachedResource *WebCore::CachedResourceLoader::cachedResource(const WebCore::URL &) const 1 0x10fa2573d WTFCrash 2 0x1121f6ac2 WebCore::CachedResourceLoader::cachedResource(WebCore::URL const&) const 3 0x112fc7c73 WebCore::InspectorPageAgent::cachedResource(WebCore::Frame*, WebCore::URL const&) 4 0x113df30ab WebCore::PageDebuggerAgent::sourceMapURLForScript(Inspector::ScriptDebugListener::Script const&) 5 0x10f2e293e Inspector::InspectorDebuggerAgent::didParseSource(unsigned long, Inspector::ScriptDebugListener::Script const&) 6 0x10f2e3544 non-virtual thunk to Inspector::InspectorDebuggerAgent::didParseSource(unsigned long, Inspector::ScriptDebugListener::Script const&) 7 0x10f7fecdb Inspector::ScriptDebugServer::dispatchDidParseSource(WTF::HashSet<Inspector::ScriptDebugListener*, WTF::PtrHash<Inspector::ScriptDebugListener*>, WTF::HashTraits<Inspector::ScriptDebugListener*> > const&, JSC::SourceProvider*, bool) 8 0x10f7feff5 Inspector::ScriptDebugServer::sourceParsed(JSC::ExecState*, JSC::SourceProvider*, int, WTF::String const&) 9 0x10ec4b32c JSC::Debugger::attach(JSC::JSGlobalObject*) 10 0x114351f14 WebCore::ScriptController::attachDebugger(WebCore::JSDOMWindowShell*, JSC::Debugger*) 11 0x1143522ff WebCore::ScriptController::attachDebugger(JSC::Debugger*) 12 0x113dd66f7 WebCore::Page::setDebugger(JSC::Debugger*) 13 0x113e08fc7 WebCore::PageScriptDebugServer::attachDebugger() 14 0x10f7ff60e Inspector::ScriptDebugServer::addListener(Inspector::ScriptDebugListener*) 15 0x10f2dcaea Inspector::InspectorDebuggerAgent::enable() 16 0x1149cc6ff WebCore::WebDebuggerAgent::enable() 17 0x113df2f3f WebCore::PageDebuggerAgent::enable() 18 0x10f2dcd48 Inspector::InspectorDebuggerAgent::enable(WTF::String&) 19 0x10f2dcd7c non-virtual thunk to Inspector::InspectorDebuggerAgent::enable(WTF::String&) 20 0x10f2a254a Inspector::DebuggerBackendDispatcher::enable(long, WTF::RefPtr<Inspector::InspectorObject>&&) 21 0x10f2a23e3 Inspector::DebuggerBackendDispatcher::dispatch(long, WTF::String const&, WTF::Ref<Inspector::InspectorObject>&&) 22 0x10f2823bf Inspector::BackendDispatcher::dispatch(WTF::String const&) 23 0x112f0d88c WebCore::InspectorController::dispatchMessageFromFrontend(WTF::String const&) 24 0x10bebb561 WebKit::WebInspector::sendMessageToBackend(WTF::String const&) 1250009 1 294423 joepeck 2016-11-10 15:33:08 -0800 Created attachment 294423 [PATCH] Proposed Fix 1250032 2 294423 commit-queue 2016-11-10 16:04:19 -0800 Comment on attachment 294423 [PATCH] Proposed Fix Clearing flags on attachment: 294423 Committed r208570: <http://trac.webkit.org/changeset/208570> 1250033 3 commit-queue 2016-11-10 16:04:23 -0800 All reviewed patches have been landed. Closing bug. 294423 2016-11-10 15:33:08 -0800 2016-11-10 16:04:19 -0800 [PATCH] Proposed Fix assert-1.patch text/plain 1445 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MTlmYmNmLi4xZmI4NGRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTYtMTEtMTAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBBZnRlciByMjA3NDU5IEFTU0VSVCBpbiBDYWNoZWRSZXNvdXJjZUxvYWRlciB1bmRl ciBJbnNwZWN0b3JQYWdlQWdlbnQ6OmNhY2hlZFJlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ2MjEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JQYWdlQWdl bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yUGFnZUFnZW50OjpjYWNoZWRSZXNv dXJjZSk6CisgICAgICAgIENhY2hlZFJlc291cmNlTG9hZGVyIGV4cGVjdHMgYSBzYW5pdGl6ZWQg VVJMLgorCiAyMDE2LTExLTEwICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29t PgogCiAgICAgICAgIFtNZWRpYVN0cmVhbV0gYXBwbHkgY29uc3RyYWludHMgcGFzc2VkIHRvIGdl dFVzZXJNZWRpYSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yUGFnZUFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQYWdl QWdlbnQuY3BwCmluZGV4IDI2MjkzOTcuLmEwYTVlYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwCkBAIC0yNzIsNyArMjcyLDcgQEAgQ2Fj aGVkUmVzb3VyY2UqIEluc3BlY3RvclBhZ2VBZ2VudDo6Y2FjaGVkUmVzb3VyY2UoRnJhbWUqIGZy YW1lLCBjb25zdCBVUkwmIHVybCkKICAgICBpZiAodXJsLmlzTnVsbCgpKQogICAgICAgICByZXR1 cm4gbnVsbHB0cjsKIAotICAgIENhY2hlZFJlc291cmNlKiBjYWNoZWRSZXNvdXJjZSA9IGZyYW1l LT5kb2N1bWVudCgpLT5jYWNoZWRSZXNvdXJjZUxvYWRlcigpLmNhY2hlZFJlc291cmNlKHVybCk7 CisgICAgQ2FjaGVkUmVzb3VyY2UqIGNhY2hlZFJlc291cmNlID0gZnJhbWUtPmRvY3VtZW50KCkt PmNhY2hlZFJlc291cmNlTG9hZGVyKCkuY2FjaGVkUmVzb3VyY2UoTWVtb3J5Q2FjaGU6OnJlbW92 ZUZyYWdtZW50SWRlbnRpZmllcklmTmVlZGVkKHVybCkpOwogICAgIGlmICghY2FjaGVkUmVzb3Vy Y2UpIHsKICAgICAgICAgUmVzb3VyY2VSZXF1ZXN0IHJlcXVlc3QodXJsKTsKICNpZiBFTkFCTEUo Q0FDSEVfUEFSVElUSU9OSU5HKQo=