164607 2016-11-10 12:20:06 -0800 Web Inspector: TestSuite should pass the test case to setup/teardown 2016-11-10 15:53:51 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED WONTFIX InRadar P2 Normal --- 163230 1 mattbaker mattbaker bburg joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1249905 0 mattbaker 2016-11-10 12:20:06 -0800 Summary: TestSuite should pass the test case to setup/teardown. This allows setup to associate state with the test case itself, instead of with the `window` object or within the scope of the `test()` function. This should be done for both AsyncTestSuite and SyncTestSuite. 1249909 1 webkit-bug-importer 2016-11-10 12:22:39 -0800 <rdar://problem/29204593> 1250011 2 mattbaker 2016-11-10 15:36:38 -0800 Setup/teardown could just use `this` to access test case state. There are only two issues with this approach, and they both seem pretty far fetched: 1) Using `this` in arrow function for setup/teardown will bind to something other than the test case. Setup/teardown are usually inline, and if they need to be defined elsewhere (for reuse in multiple tests), a regular named function will work. 2) However unlikely, the test case itself could trample state that was created during setup.