164605 2016-11-10 11:51:31 -0800 Incorrect release log message emitted when waiting/not waiting for the WebProcess continue a load 2016-11-12 21:53:44 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates achristensen beidson cdumez commit-queue koivisto krollin sam oldest_to_newest 1249892 0 dbates 2016-11-10 11:51:31 -0800 Currently the release log messages emitted in NetworkResourceLoader::didReceiveResponse() are inverted with respect to whether we are waiting for the WebProcess to send message NetworkResourceLoader::ContinueDidReceiveResponse. We emit a release log message of the form "didReceiveResponse: Should wait for message from WebContent process ..." when we are not waiting for the WebProcess and emit a message of the form "didReceiveResponse: Should not wait for message from WebContent process" when we are waiting on the WebProcess. We should invert these messages. 1249893 1 294393 dbates 2016-11-10 11:52:45 -0800 Created attachment 294393 Patch 1250785 2 294393 commit-queue 2016-11-12 21:53:40 -0800 Comment on attachment 294393 Patch Clearing flags on attachment: 294393 Committed r208665: <http://trac.webkit.org/changeset/208665> 1250786 3 commit-queue 2016-11-12 21:53:44 -0800 All reviewed patches have been landed. Closing bug. 294393 2016-11-10 11:52:45 -0800 2016-11-12 21:53:40 -0800 Patch bug-164605-20161110114833.patch text/plain 3453 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTljYzgxMjNjYTQyNTI5 ZGZlYzM5NWIwZGYxNTI5MjNhZTE3NjU0OS4uNDM3MWIxZDQ0MTA4MTJmMTY5NmM5ZmI0N2ZiNThm NDEyOGFiN2VjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTExLTEwICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBJbmNvcnJlY3QgcmVsZWFz ZSBsb2cgbWVzc2FnZSBlbWl0dGVkIHdoZW4gd2FpdGluZy9ub3Qgd2FpdGluZyBmb3IgdGhlIFdl YlByb2Nlc3MgY29udGludWUgYSBsb2FkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjQ2MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDdXJyZW50bHkgd2UgZW1pdCBhIHJlbGVhc2UgbG9nIG1lc3NhZ2Ug b2YgdGhlIGZvcm0gImRpZFJlY2VpdmVSZXNwb25zZTogU2hvdWxkIHdhaXQgZm9yCisgICAgICAg IG1lc3NhZ2UgZnJvbSBXZWJDb250ZW50IHByb2Nlc3MgLi4uIiB3aGVuIHdlIGFyZSBub3Qgd2Fp dGluZyBmb3IgdGhlIFdlYlByb2Nlc3MgYW5kIGVtaXQKKyAgICAgICAgYSBtZXNzYWdlIG9mIHRo ZSBmb3JtICJkaWRSZWNlaXZlUmVzcG9uc2U6IFNob3VsZCBub3Qgd2FpdCBmb3IgbWVzc2FnZSBm cm9tIFdlYkNvbnRlbnQKKyAgICAgICAgcHJvY2VzcyIgd2hlbiB3ZSBhcmUgd2FpdGluZyBvbiB0 aGUgV2ViUHJvY2Vzcy4gSW52ZXJ0IHRoZXNlIG1lc3NhZ2VzIHRvIHJlZmxlY3Qgd2hldGhlcgor ICAgICAgICB3ZSBhcmUgd2FpdGluZyBmb3IgdGhlIFdlYlByb2Nlc3MgdG8gc2VuZCBtZXNzYWdl IE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6Q29udGludWVEaWRSZWNlaXZlUmVzcG9uc2V3aGV0aGVy LgorCisgICAgICAgIEZvciB0aGUgbWFpbiByZXNvdXJjZSBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6 OmRpZFJlY2VpdmVSZXNwb25zZSgpIHJldHVybnMgU2hvdWxkQ29udGludWVEaWRSZWNlaXZlUmVz cG9uc2U6Ok5vCisgICAgICAgIGJlY2F1c2Ugd2UgYXJlIHdhaXRpbmcgZm9yIHRoZSBXZWJQcm9j ZXNzIHRvIHNlbmQgbWVzc2FnZSBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OkNvbnRpbnVlRGlkUmVj ZWl2ZVJlc3BvbnNlCisgICAgICAgIHRvIGNvbnRpbnVlIHRoZSBsb2FkLiBGb3IgYSBzdWJyZXNv dXJjZSB3ZSBkbyBub3QgbmVlZCB0byB3YWl0IGZvciB0aGUgV2ViUHJvY2VzcyB0byBhbGxvdyB0 aGUgbG9hZCB0byBjb250aW51ZQorICAgICAgICBhbmQgaGVuY2UgTmV0d29ya1Jlc291cmNlTG9h ZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UoKSByZXR1cm5zIFNob3VsZENvbnRpbnVlRGlkUmVjZWl2 ZVJlc3BvbnNlOjpZZXMuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3Vy Y2VMb2FkZXIuY3BwOgorCiAyMDE2LTExLTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj aWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbTGludXhdIE1lbW9yeSBwcm9jZXNzIHZhbHVlcyBz aG93biBieSB0aGUgV2ViTWVtb3J5U2FtcGxlciBpbiBsaW51eCBhcmUgd3JvbmcKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIu Y3BwCmluZGV4IGE2MzJjMjY3ODgzMDUyYzgzODMyNjYzZGY3MThkNjY1MGJkOTVhNzguLmQyZDQ3 MDBiYjRiYTdjNTg1MzczZTU0MTYzNDEwNDc2NjQyNWMyYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcApAQCAt MzUwLDExICszNTAsMTEgQEAgYXV0byBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVS ZXNwb25zZShSZXNvdXJjZVJlc3BvbnNlJiYgcmVjZWl2ZWRSZXNwb24KICNlbmRpZgogCiAgICAg aWYgKHNob3VsZENvbnRpbnVlRGlkUmVjZWl2ZVJlc3BvbnNlKSB7Ci0gICAgICAgIFJFTEVBU0Vf TE9HX0lGX0FMTE9XRUQoImRpZFJlY2VpdmVSZXNwb25zZTogU2hvdWxkIHdhaXQgZm9yIG1lc3Nh Z2UgZnJvbSBXZWJDb250ZW50IHByb2Nlc3MgYmVmb3JlIGNvbnRpbnVpbmcgcmVzb3VyY2UgbG9h ZCAocGFnZUlEID0gJSIgUFJJdTY0ICIsIGZyYW1lSUQgPSAlIiBQUkl1NjQgIiwgcmVzb3VyY2VJ RCA9ICUiIFBSSXU2NCAiKSIsIG1fcGFyYW1ldGVycy53ZWJQYWdlSUQsIG1fcGFyYW1ldGVycy53 ZWJGcmFtZUlELCBtX3BhcmFtZXRlcnMuaWRlbnRpZmllcik7CisgICAgICAgIFJFTEVBU0VfTE9H X0lGX0FMTE9XRUQoImRpZFJlY2VpdmVSZXNwb25zZTogU2hvdWxkIG5vdCB3YWl0IGZvciBtZXNz YWdlIGZyb20gV2ViQ29udGVudCBwcm9jZXNzIGJlZm9yZSBjb250aW51aW5nIHJlc291cmNlIGxv YWQgKHBhZ2VJRCA9ICUiIFBSSXU2NCAiLCBmcmFtZUlEID0gJSIgUFJJdTY0ICIsIHJlc291cmNl SUQgPSAlIiBQUkl1NjQgIikiLCBtX3BhcmFtZXRlcnMud2ViUGFnZUlELCBtX3BhcmFtZXRlcnMu d2ViRnJhbWVJRCwgbV9wYXJhbWV0ZXJzLmlkZW50aWZpZXIpOwogICAgICAgICByZXR1cm4gU2hv dWxkQ29udGludWVEaWRSZWNlaXZlUmVzcG9uc2U6OlllczsKICAgICB9CiAKLSAgICBSRUxFQVNF X0xPR19JRl9BTExPV0VEKCJkaWRSZWNlaXZlUmVzcG9uc2U6IFNob3VsZCBub3Qgd2FpdCBmb3Ig bWVzc2FnZSBmcm9tIFdlYkNvbnRlbnQgcHJvY2VzcyBiZWZvcmUgY29udGludWluZyByZXNvdXJj ZSBsb2FkIChwYWdlSUQgPSAlIiBQUkl1NjQgIiwgZnJhbWVJRCA9ICUiIFBSSXU2NCAiLCByZXNv dXJjZUlEID0gJSIgUFJJdTY0ICIpIiwgbV9wYXJhbWV0ZXJzLndlYlBhZ2VJRCwgbV9wYXJhbWV0 ZXJzLndlYkZyYW1lSUQsIG1fcGFyYW1ldGVycy5pZGVudGlmaWVyKTsKKyAgICBSRUxFQVNFX0xP R19JRl9BTExPV0VEKCJkaWRSZWNlaXZlUmVzcG9uc2U6IFNob3VsZCB3YWl0IGZvciBtZXNzYWdl IGZyb20gV2ViQ29udGVudCBwcm9jZXNzIGJlZm9yZSBjb250aW51aW5nIHJlc291cmNlIGxvYWQg KHBhZ2VJRCA9ICUiIFBSSXU2NCAiLCBmcmFtZUlEID0gJSIgUFJJdTY0ICIsIHJlc291cmNlSUQg PSAlIiBQUkl1NjQgIikiLCBtX3BhcmFtZXRlcnMud2ViUGFnZUlELCBtX3BhcmFtZXRlcnMud2Vi RnJhbWVJRCwgbV9wYXJhbWV0ZXJzLmlkZW50aWZpZXIpOwogICAgIHJldHVybiBTaG91bGRDb250 aW51ZURpZFJlY2VpdmVSZXNwb25zZTo6Tm87CiB9CiAK