164587 2016-11-10 04:12:24 -0800 [WebRTC][OpenWebRTC] parse turns urls 2016-11-21 01:41:56 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 164817 1 pnormand webkit-unassigned adam.bergkvist alex commit-queue pnormand oldest_to_newest 1249754 0 pnormand 2016-11-10 04:12:24 -0800 Since bug 164506 was fixed the end-point should now parse turns urls and pass them on to openwebrtc. 1251861 1 pnormand 2016-11-16 07:39:34 -0800 Depends on https://github.com/EricssonResearch/openwebrtc/pull/658 1251862 2 294938 pnormand 2016-11-16 07:41:41 -0800 Created attachment 294938 patch 1251863 3 commit-queue 2016-11-16 07:42:58 -0800 Attachment 294938 did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:586: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:587: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1251867 4 294940 pnormand 2016-11-16 07:54:31 -0800 Created attachment 294940 patch 1252273 5 294940 alex 2016-11-17 04:20:40 -0800 Comment on attachment 294940 patch Why do we have the style issues? 1252275 6 pnormand 2016-11-17 05:10:35 -0800 Which style issues? :) They've been fixed in the patch you reviewed. 1253207 7 pnormand 2016-11-21 01:41:56 -0800 Committed r208944: <http://trac.webkit.org/changeset/208944> 294938 2016-11-16 07:41:41 -0800 2016-11-16 07:54:31 -0800 patch patch.patch text/plain 2940 pnormand RnJvbSAwNmVkNDVhYWMxN2U3OTE2OGI2MTFiNTRlNDk4ZTk1ZDczOGJjYjIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDE2IE5vdiAyMDE2IDE2OjQxOjE2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgMTIgKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbWVkaWFzdHJl YW0vb3BlbndlYnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmNwcCAgICAgfCAgNiArKysrKy0KIDIgZmls ZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBmZGY0MzdhYS4uZTUyYWY0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTEx LTE2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAorICAgICAgICBb V2ViUlRDXVtPcGVuV2ViUlRDXSBwYXJzZSB0dXJucyB1cmxzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ1ODcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL29wZW53 ZWJydGMvTWVkaWFFbmRwb2ludE93ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUVuZHBv aW50T3dyOjplbnN1cmVUcmFuc3BvcnRBZ2VudEFuZFRyYW5zY2VpdmVycyk6CisgICAgICAgIEhv b2sgdHVybnMgc2VydmVycyBiZXR3ZWVuIHRoZSBSVENDb25maWd1cmF0aW9uIGFuZCB0aGUgdW5k ZXJseWluZworICAgICAgICBPcGVuV2ViUlRDIGxheWVyLgorCisyMDE2LTExLTE2ICBQaGlsaXBw ZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1N0cmVhbWVyXVtH TF0gYnVpbGQgYnJva2VuIHdoZW4gdXNpbmcgZ3N0LXBsdWdpbnMtYmFkIGZyb20gZ2l0CiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ3NzYKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vb3BlbndlYnJ0Yy9N ZWRpYUVuZHBvaW50T3dyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFt L29wZW53ZWJydGMvTWVkaWFFbmRwb2ludE93ci5jcHAKaW5kZXggYTcyNTM5OC4uNjkxYzgyNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vb3BlbndlYnJ0 Yy9NZWRpYUVuZHBvaW50T3dyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRp YXN0cmVhbS9vcGVud2VicnRjL01lZGlhRW5kcG9pbnRPd3IuY3BwCkBAIC01OCw3ICs1OCw3IEBA IHN0YXRpYyBjb25zdCBWZWN0b3I8U3RyaW5nPiBjYW5kaWRhdGVUeXBlcyA9IHsgImhvc3QiLCAi c3JmbHgiLCAicHJmbHgiLCAicmVsYXkiCiBzdGF0aWMgY29uc3QgVmVjdG9yPFN0cmluZz4gY2Fu ZGlkYXRlVGNwVHlwZXMgPSB7ICIiLCAiYWN0aXZlIiwgInBhc3NpdmUiLCAic28iIH07CiBzdGF0 aWMgY29uc3QgVmVjdG9yPFN0cmluZz4gY29kZWNUeXBlcyA9IHsgIk5PTkUiLCAiUENNVSIsICJQ Q01BIiwgIk9QVVMiLCAiSDI2NCIsICJWUDgiIH07CiAKLXN0YXRpYyBjb25zdCBjaGFyKiBoZWxw ZXJTZXJ2ZXJSZWdFeCA9ICIodHVybnxzdHVuKTooW1xcd1xcLlxcLV0rfFxcW1tcXHdcXDpdK1xc XSkoOlxcZCspPyhcXD8uKyk/IjsKK3N0YXRpYyBjb25zdCBjaGFyKiBoZWxwZXJTZXJ2ZXJSZWdF eCA9ICIodHVybnN8dHVybnxzdHVuKTooW1xcd1xcLlxcLV0rfFxcW1tcXHdcXDpdK1xcXSkoOlxc ZCspPyhcXD8uKyk/IjsKIAogc3RhdGljIGNvbnN0IHVuc2lnbmVkIHNob3J0IGhlbHBlclNlcnZl ckRlZmF1bHRQb3J0ID0gMzQ3ODsKIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBzaG9ydCBjYW5kaWRh dGVEZWZhdWx0UG9ydCA9IDk7CkBAIC01ODEsNiArNTgxLDEwIEBAIHZvaWQgTWVkaWFFbmRwb2lu dE93cjo6ZW5zdXJlVHJhbnNwb3J0QWdlbnRBbmRUcmFuc2NlaXZlcnMoYm9vbCBpc0luaXRpYXRv ciwgY29uCiAgICAgICAgICAgICAgICAgICAgIG93cl90cmFuc3BvcnRfYWdlbnRfYWRkX2hlbHBl cl9zZXJ2ZXIobV90cmFuc3BvcnRBZ2VudCwgc2VydmVyVHlwZSwKICAgICAgICAgICAgICAgICAg ICAgICAgIHVybC5ob3N0LmFzY2lpKCkuZGF0YSgpLCBwb3J0LAogICAgICAgICAgICAgICAgICAg ICAgICAgc2VydmVyLnVzZXJuYW1lLmFzY2lpKCkuZGF0YSgpLCBzZXJ2ZXIuY3JlZGVudGlhbC5h c2NpaSgpLmRhdGEoKSk7CisgICAgICAgICAgICAgICAgfSBlbHNlIGlmICh1cmwucHJvdG9jb2wg PT0gInR1cm5zIikgeworICAgICAgICAgICAgICAgICAgICBvd3JfdHJhbnNwb3J0X2FnZW50X2Fk ZF9oZWxwZXJfc2VydmVyKG1fdHJhbnNwb3J0QWdlbnQsIE9XUl9IRUxQRVJfU0VSVkVSX1RZUEVf VFVSTl9UTFMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdXJsLmhvc3QuYXNjaWkoKS5kYXRhKCksIHBvcnQsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VydmVyLnVzZXJu YW1lLmFzY2lpKCkuZGF0YSgpLCBzZXJ2ZXIuY3JlZGVudGlhbC5hc2NpaSgpLmRhdGEoKSk7CiAg ICAgICAgICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVB Q0hFRCgpOwogICAgICAgICAgICAgfQotLSAKMi4xMC4y 294940 2016-11-16 07:54:31 -0800 2016-11-17 04:20:40 -0800 patch patch.patch text/plain 2872 pnormand RnJvbSAxNjM2NjA0MzE0OGI1YWRmYzE4YWE2NDUwNWJlZDk4ZWZhMTQ5NWUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDE2IE5vdiAyMDE2IDE2OjQxOjE2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgMTIgKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbWVkaWFzdHJl YW0vb3BlbndlYnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmNwcCAgICAgfCAgNiArKysrKy0KIDIgZmls ZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBmZGY0MzdhYS4uZTUyYWY0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTEx LTE2ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAorICAgICAgICBb V2ViUlRDXVtPcGVuV2ViUlRDXSBwYXJzZSB0dXJucyB1cmxzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ1ODcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL29wZW53 ZWJydGMvTWVkaWFFbmRwb2ludE93ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUVuZHBv aW50T3dyOjplbnN1cmVUcmFuc3BvcnRBZ2VudEFuZFRyYW5zY2VpdmVycyk6CisgICAgICAgIEhv b2sgdHVybnMgc2VydmVycyBiZXR3ZWVuIHRoZSBSVENDb25maWd1cmF0aW9uIGFuZCB0aGUgdW5k ZXJseWluZworICAgICAgICBPcGVuV2ViUlRDIGxheWVyLgorCisyMDE2LTExLTE2ICBQaGlsaXBw ZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1N0cmVhbWVyXVtH TF0gYnVpbGQgYnJva2VuIHdoZW4gdXNpbmcgZ3N0LXBsdWdpbnMtYmFkIGZyb20gZ2l0CiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ3NzYKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vb3BlbndlYnJ0Yy9N ZWRpYUVuZHBvaW50T3dyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFt L29wZW53ZWJydGMvTWVkaWFFbmRwb2ludE93ci5jcHAKaW5kZXggYTcyNTM5OC4uZWU3ZDdhZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vb3BlbndlYnJ0 Yy9NZWRpYUVuZHBvaW50T3dyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRp YXN0cmVhbS9vcGVud2VicnRjL01lZGlhRW5kcG9pbnRPd3IuY3BwCkBAIC01OCw3ICs1OCw3IEBA IHN0YXRpYyBjb25zdCBWZWN0b3I8U3RyaW5nPiBjYW5kaWRhdGVUeXBlcyA9IHsgImhvc3QiLCAi c3JmbHgiLCAicHJmbHgiLCAicmVsYXkiCiBzdGF0aWMgY29uc3QgVmVjdG9yPFN0cmluZz4gY2Fu ZGlkYXRlVGNwVHlwZXMgPSB7ICIiLCAiYWN0aXZlIiwgInBhc3NpdmUiLCAic28iIH07CiBzdGF0 aWMgY29uc3QgVmVjdG9yPFN0cmluZz4gY29kZWNUeXBlcyA9IHsgIk5PTkUiLCAiUENNVSIsICJQ Q01BIiwgIk9QVVMiLCAiSDI2NCIsICJWUDgiIH07CiAKLXN0YXRpYyBjb25zdCBjaGFyKiBoZWxw ZXJTZXJ2ZXJSZWdFeCA9ICIodHVybnxzdHVuKTooW1xcd1xcLlxcLV0rfFxcW1tcXHdcXDpdK1xc XSkoOlxcZCspPyhcXD8uKyk/IjsKK3N0YXRpYyBjb25zdCBjaGFyKiBoZWxwZXJTZXJ2ZXJSZWdF eCA9ICIodHVybnN8dHVybnxzdHVuKTooW1xcd1xcLlxcLV0rfFxcW1tcXHdcXDpdK1xcXSkoOlxc ZCspPyhcXD8uKyk/IjsKIAogc3RhdGljIGNvbnN0IHVuc2lnbmVkIHNob3J0IGhlbHBlclNlcnZl ckRlZmF1bHRQb3J0ID0gMzQ3ODsKIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBzaG9ydCBjYW5kaWRh dGVEZWZhdWx0UG9ydCA9IDk7CkBAIC01ODEsNiArNTgxLDEwIEBAIHZvaWQgTWVkaWFFbmRwb2lu dE93cjo6ZW5zdXJlVHJhbnNwb3J0QWdlbnRBbmRUcmFuc2NlaXZlcnMoYm9vbCBpc0luaXRpYXRv ciwgY29uCiAgICAgICAgICAgICAgICAgICAgIG93cl90cmFuc3BvcnRfYWdlbnRfYWRkX2hlbHBl cl9zZXJ2ZXIobV90cmFuc3BvcnRBZ2VudCwgc2VydmVyVHlwZSwKICAgICAgICAgICAgICAgICAg ICAgICAgIHVybC5ob3N0LmFzY2lpKCkuZGF0YSgpLCBwb3J0LAogICAgICAgICAgICAgICAgICAg ICAgICAgc2VydmVyLnVzZXJuYW1lLmFzY2lpKCkuZGF0YSgpLCBzZXJ2ZXIuY3JlZGVudGlhbC5h c2NpaSgpLmRhdGEoKSk7CisgICAgICAgICAgICAgICAgfSBlbHNlIGlmICh1cmwucHJvdG9jb2wg PT0gInR1cm5zIikgeworICAgICAgICAgICAgICAgICAgICBvd3JfdHJhbnNwb3J0X2FnZW50X2Fk ZF9oZWxwZXJfc2VydmVyKG1fdHJhbnNwb3J0QWdlbnQsIE9XUl9IRUxQRVJfU0VSVkVSX1RZUEVf VFVSTl9UTFMsCisgICAgICAgICAgICAgICAgICAgICAgICB1cmwuaG9zdC5hc2NpaSgpLmRhdGEo KSwgcG9ydCwKKyAgICAgICAgICAgICAgICAgICAgICAgIHNlcnZlci51c2VybmFtZS5hc2NpaSgp LmRhdGEoKSwgc2VydmVyLmNyZWRlbnRpYWwuYXNjaWkoKS5kYXRhKCkpOwogICAgICAgICAgICAg ICAgIH0gZWxzZQogICAgICAgICAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAg ICAgICAgICAgIH0KLS0gCjIuMTAuMg==