164572 2016-11-09 17:05:53 -0800 REGRESSION (r208455): LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing 2016-11-16 18:40:26 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=164494 P2 Normal --- 1 ryanhaddad ap ap cdumez commit-queue thorton oldest_to_newest 1249588 0 ryanhaddad 2016-11-09 17:05:53 -0800 LayoutTests swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html are failing https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r208501%20(10931)/results.html --- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/swipe/main-frame-pinning-requirement-expected.txt +++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/swipe/main-frame-pinning-requirement-actual.txt @@ -16,9 +16,9 @@ scroll event (delta 10 0, phase 'changed') didBeginSwipe swipe event (delta 1 0, phase 'changed') +willEndSwipe swipe event (delta 256 0, phase 'changed') swipe event (delta 0 0, phase 'ended') -willEndSwipe -didEndSwipe didRemoveSwipeSnapshot +Failure. The swipe should have navigated back to the first page. (expected: true, actual: false) 1249589 1 ryanhaddad 2016-11-09 17:06:33 -0800 Seeing this on El Capitan Release WK2 1249994 2 ryanhaddad 2016-11-10 15:06:53 -0800 Marked as failing on El Capitan in http://trac.webkit.org/projects/webkit/changeset/208566 1252019 3 ap 2016-11-16 14:27:19 -0800 Test history suggests that this started with http://trac.webkit.org/r208455 The tests sometimes passes on retry, and sometimes fails again. 1252044 4 ap 2016-11-16 15:11:55 -0800 Reproduces locally with this command: run-webkit-tests swipe/basic-cached-back-swipe.html swipe/pushState-cached-back-swipe.html 1252093 5 294997 ap 2016-11-16 16:21:22 -0800 Created attachment 294997 proposed fix 1252118 6 294997 commit-queue 2016-11-16 17:14:41 -0800 Comment on attachment 294997 proposed fix Clearing flags on attachment: 294997 Committed r208831: <http://trac.webkit.org/changeset/208831> 1252119 7 commit-queue 2016-11-16 17:14:45 -0800 All reviewed patches have been landed. Closing bug. 1252161 8 294997 cdumez 2016-11-16 18:40:26 -0800 Comment on attachment 294997 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=294997&action=review > Tools/WebKitTestRunner/mac/TestControllerMac.mm:107 > + while ([NSApp nextEventMatchingMask:NSEventMaskGesture | NSEventMaskScrollWheel untilDate:nil inMode:NSDefaultRunLoopMode dequeue:YES]) { Oops. Sorry about that! 294997 2016-11-16 16:21:22 -0800 2016-11-16 17:14:41 -0800 proposed fix EventMask.txt text/plain 2901 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwODgyMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE2LTExLTE2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMDg0NTUpOiBMYXlvdXRUZXN0cyBzd2lwZS9wdXNo U3RhdGUtY2FjaGVkLWJhY2stc3dpcGUuaHRtbCBhbmQgc3dpcGUvbWFpbi1mcmFtZS1waW5uaW5n LXJlcXVpcmVtZW50Lmh0bWwgYXJlIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDU3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9tYWMvVGVzdENvbnRyb2xs ZXJNYWMubW06IChXVFI6OlRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybVJlc2V0U3RhdGVUb0NvbnNp c3RlbnRWYWx1ZXMpOgorICAgICAgICBVc2UgdGhlIGNvcnJlY3QgY29uc3RhbnQuCisKIDIwMTYt MTEtMTYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg SGFyZCB0byB3cml0ZSByZWxpYWJsZSBVSVNjcmlwdENvbnRyb2xsZXIgc2Nyb2xsaW5nVHJlZUFz VGV4dCB0ZXN0cwpJbmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvVGVzdENvbnRyb2xs ZXJNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvVGVzdENv bnRyb2xsZXJNYWMubW0JKHJldmlzaW9uIDIwODQ1NSkKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5u ZXIvbWFjL1Rlc3RDb250cm9sbGVyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMDQsNyArMTA0 LDcgQEAgdm9pZCBUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1SZXNldFN0YXRlVAogewogICAgIGNv Y29hUmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcygpOwogCi0gICAgd2hpbGUgKFtOU0FwcCBu ZXh0RXZlbnRNYXRjaGluZ01hc2s6TlNFdmVudE1hc2tHZXN0dXJlIHwgTlNFdmVudFR5cGVTY3Jv bGxXaGVlbCB1bnRpbERhdGU6bmlsIGluTW9kZTpOU0RlZmF1bHRSdW5Mb29wTW9kZSBkZXF1ZXVl OllFU10pIHsKKyAgICB3aGlsZSAoW05TQXBwIG5leHRFdmVudE1hdGNoaW5nTWFzazpOU0V2ZW50 TWFza0dlc3R1cmUgfCBOU0V2ZW50TWFza1Njcm9sbFdoZWVsIHVudGlsRGF0ZTpuaWwgaW5Nb2Rl Ok5TRGVmYXVsdFJ1bkxvb3BNb2RlIGRlcXVldWU6WUVTXSkgewogICAgICAgICAvLyBDbGVhciBv dXQgKGFuZCBpZ25vcmUpIGFueSBwZW5kaW5nIGdlc3R1cmUgYW5kIHNjcm9sbCB3aGVlbCBldmVu dHMuCiAgICAgfQogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjA4ODIyKQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTYtMTEtMTYgIEFs ZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjIwODQ1NSk6IExheW91dFRlc3RzIHN3aXBlL3B1c2hTdGF0ZS1jYWNoZWQtYmFjay1zd2lwZS5o dG1sIGFuZCBzd2lwZS9tYWluLWZyYW1lLXBpbm5pbmctcmVxdWlyZW1lbnQuaHRtbCBhcmUgZmFp bGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0 NTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnM6IFJlbW92ZSBmbGFraW5lc3MgZXhwZWN0 YXRpb25zLgorCiAyMDE2LTExLTE2ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29t PgogCiAgICAgICAgIE1hcmtpbmcgaW5zcGVjdG9yL3dvcmtlci9kZWJ1Z2dlci1wYXVzZS5odG1s IGFzIGZsYWt5LgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0 YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4 cGVjdGF0aW9ucwkocmV2aXNpb24gMjA4ODIyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj LXdrMi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC01OTksNiArNTk5LDMgQEAg d2Via2l0Lm9yZy9iLzE2MTY1MyBbIERlYnVnIF0gc3RvcmFnZS9pbgogd2Via2l0Lm9yZy9iLzE2 MzQ1MyBbIFNpZXJyYSBSZWxlYXNlIF0gaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJp dHlQb2xpY3kvdXBncmFkZS1pbnNlY3VyZS1yZXF1ZXN0cy9iYXNpYy11cGdyYWRlLWNvcnMuaHR0 cHMuaHRtbCBbIFBhc3MgVGltZW91dCBdCiAKIHdlYmtpdC5vcmcvYi8xNjM3MDIgcGxhdGZvcm0v bWFjLXdrMi9wbHVnaW5zL211dGVkLXN0YXRlLmh0bWwgWyBGYWlsdXJlIF0KLQotd2Via2l0Lm9y Zy9iLzE2NDU3MiBbIEVsQ2FwaXRhbiBdIHN3aXBlL21haW4tZnJhbWUtcGlubmluZy1yZXF1aXJl bWVudC5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTY0NTcyIFsgRWxDYXBpdGFuIF0g c3dpcGUvcHVzaFN0YXRlLWNhY2hlZC1iYWNrLXN3aXBlLmh0bWwgWyBGYWlsdXJlIF0K