164570 2016-11-09 17:00:17 -0800 REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure 2016-11-10 16:02:49 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 164458 1 ryanhaddad cdumez achristensen cdumez darin rniwa oldest_to_newest 1249584 0 ryanhaddad 2016-11-09 17:00:17 -0800 LayoutTest fast/loader/reload-zero-byte-plugin.html is failing https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r208504%20(1288)/results.html --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/fast/loader/reload-zero-byte-plugin-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/fast/loader/reload-zero-byte-plugin-actual.txt @@ -1 +1,4 @@ +Download started. +Downloading URL with suggested filename "Unknown" +Download completed. This test passes if it doesn't crash. To run manually, please disable your popup blocker. 1249884 1 ryanhaddad 2016-11-10 11:42:20 -0800 Marked as flaky in http://trac.webkit.org/projects/webkit/changeset/208553 1249938 2 ryanhaddad 2016-11-10 13:16:13 -0800 Hmm, a similar diff with imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-video.html https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r208550%20(19346)/results.html 1249942 3 ryanhaddad 2016-11-10 13:18:08 -0800 I think this may be somehow related to http://trac.webkit.org/changeset/208522 The test fast/dom/HTMLAnchorElement/anchor-file-blob-download.html expects some of the text seen in the diffs above. https://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-download-expected.txt?rev=208522 1250020 4 ryanhaddad 2016-11-10 15:45:34 -0800 Similar failure here with http/tests/loading/text-content-type-with-binary-extension.html https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r208562%20(19351)/results.html 1250023 5 cdumez 2016-11-10 15:51:56 -0800 (In reply to comment #3) > I think this may be somehow related to > http://trac.webkit.org/changeset/208522 > > The test fast/dom/HTMLAnchorElement/anchor-file-blob-download.html expects > some of the text seen in the diffs above. > > https://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLAnchorElement/ > anchor-file-blob-download-expected.txt?rev=208522 Actually, since the filename is "Unknown", this is unlikely to be https://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLAnchorElement/ > anchor-file-blob-download-expected.txt. $ git grep "Downloading URL with suggested filename" LayoutTests/ | grep nknown LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-expected.txt:Downloading URL with suggested filename "unknown" LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click-expected.txt:Downloading URL with suggested filename "unknown" LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download-expected.txt:Downloading URL with suggested filename "unknown" LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload-set-expected.txt:Downloading URL with suggested filename "unknown" Interestingly though, they all expect "unknown" with a lowercase "u" but the flaky test has "Unknown" with a capital "U". 1250025 6 cdumez 2016-11-10 15:53:51 -0800 (In reply to comment #5) > (In reply to comment #3) > > I think this may be somehow related to > > http://trac.webkit.org/changeset/208522 > > > > The test fast/dom/HTMLAnchorElement/anchor-file-blob-download.html expects > > some of the text seen in the diffs above. > > > > https://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLAnchorElement/ > > anchor-file-blob-download-expected.txt?rev=208522 > > Actually, since the filename is "Unknown", this is unlikely to be > https://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLAnchorElement/ > > anchor-file-blob-download-expected.txt. > > $ git grep "Downloading URL with suggested filename" LayoutTests/ | grep > nknown > LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-expected.txt: > Downloading URL with suggested filename "unknown" > LayoutTests/fast/dom/HTMLAnchorElement/anchor-download-user-triggered- > synthetic-click-expected.txt:Downloading URL with suggested filename > "unknown" > LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download- > expected.txt:Downloading URL with suggested filename "unknown" > LayoutTests/fast/dom/HTMLAnchorElement/anchor-nodownload-set-expected.txt: > Downloading URL with suggested filename "unknown" > > Interestingly though, they all expect "unknown" with a lowercase "u" but the > flaky test has "Unknown" with a capital "U". LayoutTests/fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html uses: testRunner.setShouldDownloadUndisplayableMIMETypes(true); Maybe this does not get reset properly between tests and it causes the next test to download. 1250027 7 294429 cdumez 2016-11-10 15:58:28 -0800 Created attachment 294429 Patch 1250030 8 cdumez 2016-11-10 16:02:49 -0800 Committed r208569: <http://trac.webkit.org/changeset/208569> 294429 2016-11-10 15:58:28 -0800 2016-11-10 16:01:05 -0800 Patch bug-164570-20161110155415.patch text/plain 2739 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NTY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDU1YzhkMDY5MjE1MGNiZTAxZWJlNWJiZmZiMTk4NWM4 NjczNTU3YS4uM2U1Mjg5MWYzMjgwYzdmNWY3ODcyYWY4OTFlZTNlMDgxNjg3MGIyMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE2LTExLTEwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTiAocjIwODUyMj8pOiBMYXlvdXRUZXN0IGZhc3QvbG9hZGVyL3JlbG9hZC16 ZXJvLWJ5dGUtcGx1Z2luLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ1NzAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm9wZXJseSByZXNldCBUZXN0Q29udHJv bGxlcjo6bV9zaG91bGREb3dubG9hZFVuZGlzcGxheWFibGVNSU1FVHlwZXMgYmV0d2VlbiB0ZXN0 cyB0bworICAgICAgICBhdm9pZCBmbGFraW5lc3MuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVu bmVyL1Rlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdENvbnRyb2xsZXI6OnJl c2V0U3RhdGVUb0NvbnNpc3RlbnRWYWx1ZXMpOgorCiAyMDE2LTExLTEwICBNaWd1ZWwgR29tZXog IDxtYWdvbWV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQWRkZWQgbXlzZWxm IHRvIHRoZSBsaXN0IG9mIGNvbW1pdHRlcnMuCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENv bnRyb2xsZXIuY3BwCmluZGV4IDI4MmU5MDkwOGUzZWM5MDVlNTBhYzI3M2QxYjE0NTU2ZDdhMTU5 NTUuLjlmMjcxM2E3NjlmOWM5MzAwZWUzY2VmOTczODdmMjc1YmZjN2QyZjIgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCkBAIC03NzEsNiArNzcxLDggQEAgYm9v bCBUZXN0Q29udHJvbGxlcjo6cmVzZXRTdGF0ZVRvQ29uc2lzdGVudFZhbHVlcyhjb25zdCBUZXN0 T3B0aW9ucyYgb3B0aW9ucykKICAgICAvLyBSZXNldCBDdXN0b20gUG9saWN5IERlbGVnYXRlLgog ICAgIHNldEN1c3RvbVBvbGljeURlbGVnYXRlKGZhbHNlLCBmYWxzZSk7CiAKKyAgICBtX3Nob3Vs ZERvd25sb2FkVW5kaXNwbGF5YWJsZU1JTUVUeXBlcyA9IGZhbHNlOworCiAgICAgbV93b3JrUXVl dWVNYW5hZ2VyLmNsZWFyV29ya1F1ZXVlKCk7CiAKICAgICBtX3JlamVjdHNQcm90ZWN0aW9uU3Bh Y2VBbmRDb250aW51ZUZvckF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlcyA9IGZhbHNlOwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IDc4NGIxMDg3YTc4MzA5NTMyMWJjNzYzMDAyMGFmYWMyYzRkZGIzMzguLmU1OGNmM2E5NzQ5NjBk ZTA3OGE4Y2JkYTc4ODQ4OGY4MzVlZjY2NmQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNi0x MS0xMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04gKHIyMDg1MjI/KTogTGF5b3V0VGVzdCBmYXN0L2xvYWRlci9yZWxvYWQtemVyby1ieXRlLXBs dWdpbi5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0NTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVW5za2lwIHRlc3Qgd2hpY2ggc2hvdWxkIG5vIGxvbmdlciBi ZSBmbGFreS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAy MDE2LTExLTEwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAg ICAgdGVzdDI2MjogRGF0YVZpZXcgLyBUeXBlZEFycmF5IG1ldGhvZHMgc2hvdWxkIHRocm93IFJh bmdlRXJyb3JzIGZvciBuZWdhdGl2ZSBudW1iZXJzIChUb0luZGV4KQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA2MDVkYzVhMGFhMGU1NDg3Y2NmYzQzNThj YzNmODI2OTcyNzQ0MDE1Li5jOTk0MzJmZjNiNjY2ODlhMDM5M2ZlODYxMGMyY2VjZTZiNDVhZGM0 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTQ2OSw0 ICsxNDY5LDMgQEAgd2Via2l0Lm9yZy9iLzE2NDI3NyBmYXN0L3ByZWxvYWRlci9pbWFnZS1zcmNz ZXQuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xNjQzODggaW5zcGVjdG9y L3NhbXBsaW5nLXByb2ZpbGVyIFsgUGFzcyBUaW1lb3V0IF0KIAotd2Via2l0Lm9yZy9iLzE2NDU3 MCBmYXN0L2xvYWRlci9yZWxvYWQtemVyby1ieXRlLXBsdWdpbi5odG1sIFsgUGFzcyBGYWlsdXJl IF0K