164569 2016-11-09 16:53:41 -0800 jsc CLI should work with the remote inspector 2016-11-09 17:25:19 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam oldest_to_newest 1249582 0 keith_miller 2016-11-09 16:53:41 -0800 jsc CLI should work with the remote inspector 1249593 1 294309 keith_miller 2016-11-09 17:14:11 -0800 Created attachment 294309 Patch 1249596 2 294309 msaboff 2016-11-09 17:15:41 -0800 Comment on attachment 294309 Patch r=me 1249597 3 294310 keith_miller 2016-11-09 17:15:46 -0800 Created attachment 294310 Patch 1249600 4 294310 joepeck 2016-11-09 17:20:15 -0800 Comment on attachment 294310 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294310&action=review r=me > Source/JavaScriptCore/inspector/InjectedScriptBase.cpp:-88 > - ASSERT(!hadException); We shouldn't check this in. We hate the assert, but it does catch real exceptions that we (Inspector folks) should investigate. > Source/JavaScriptCore/jsc.cpp:2785 > + if (!strcmp(arg, "--remote-debug")) { Might want to add this to the --help usage. 1249606 5 keith_miller 2016-11-09 17:25:19 -0800 Committed r208514: <http://trac.webkit.org/changeset/208514> 294309 2016-11-09 17:14:11 -0800 2016-11-09 17:15:44 -0800 Patch bug-164569-20161109171000.patch text/plain 3400 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MmU5NTJhM2QyMmY0YWNmZGYxNjgwNmYwODk4YjY2YjNhMzcyYTU2Li4yOGU3MmUyNzA5YzIxNDdj YTg0MTk3MjA1ZTI5NTIwM2E5ZGYyMWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNi0xMS0wOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBqc2MgQ0xJIHNob3VsZCB3b3JrIHdpdGggdGhlIHJlbW90ZSBpbnNw ZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 NDU2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgcGF0Y2ggZW5hYmxlcyB1c2luZyB0aGUgcmVtb3RlIGluc3BlY3RvciBvbiB0aGUganNjIENM SS4KKyAgICAgICAgaW4gb3JkZXIgdG8gdXNlIHRoZSByZW1vdGUgaW5zcGVjdG9yIGpzYyB1c2Vy cyBuZWVkIHRvIHBhc3MgYW4gb3B0aW9uLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWxzbyByZW1v dmVzIGFuIGludmFsaWQgYXNzZXJ0aW9uIGluIHRoZSBpbnNwZWN0b3IuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRCYXNlLmNwcDoKKyAgICAgICAgKEluc3BlY3Rvcjo6SW5q ZWN0ZWRTY3JpcHRCYXNlOjptYWtlQ2FsbCk6CisgICAgICAgICoganNjLmNwcDoKKyAgICAgICAg KENvbW1hbmRMaW5lOjpwYXJzZUFyZ3VtZW50cyk6CisgICAgICAgIChydW5KU0MpOgorCiAyMDE2 LTEwLTIwICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAg IEludmFsaWQgYXNzZXJ0aW9uIGluIGFyZ3VtZW50cyBlbGltaW5hdGlvbgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEJhc2UuY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEJhc2UuY3BwCmlu ZGV4IDljYWE0ZWI5M2ZlN2Y5ZTMyOGRkMzI5OTAyMTM5NWNjMzJhNDlhZDQuLjliZDA4NzA1NzY4 YzhmMjI3NzMyM2U1ZmY4YzMzMTliYmIyMmNmMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRCYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFzZS5jcHAKQEAgLTg1LDcgKzg1 LDYgQEAgdm9pZCBJbmplY3RlZFNjcmlwdEJhc2U6Om1ha2VDYWxsKERlcHJlY2F0ZWQ6OlNjcmlw dEZ1bmN0aW9uQ2FsbCYgZnVuY3Rpb24sIFJlZlAKICAgICBib29sIGhhZEV4Y2VwdGlvbiA9IGZh bHNlOwogICAgIGF1dG8gcmVzdWx0VmFsdWUgPSBjYWxsRnVuY3Rpb25XaXRoRXZhbEVuYWJsZWQo ZnVuY3Rpb24sIGhhZEV4Y2VwdGlvbik7CiAKLSAgICBBU1NFUlQoIWhhZEV4Y2VwdGlvbik7CiAg ICAgaWYgKCFoYWRFeGNlcHRpb24pIHsKICAgICAgICAgKnJlc3VsdCA9IHRvSW5zcGVjdG9yVmFs dWUoKm1faW5qZWN0ZWRTY3JpcHRPYmplY3Quc2NyaXB0U3RhdGUoKSwgcmVzdWx0VmFsdWUpOwog ICAgICAgICBpZiAoISpyZXN1bHQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv anNjLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCmluZGV4IGIxN2MyNWZiMjEx NzQ3OGJhNDljZWI2MDljNGIzMmUwMmI4ZjgwM2QuLjkwZWI3NmYzZGM4ZDJhMDllYjhmNmQxMzQ3 Y2E5NWM0ZGE4MWEwMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCkBAIC05NjYsNiArOTY2LDcgQEAg cHVibGljOgogICAgIFN0cmluZyBtX3VuY2F1Z2h0RXhjZXB0aW9uTmFtZTsKICAgICBib29sIG1f YWx3YXlzRHVtcFVuY2F1Z2h0RXhjZXB0aW9uIHsgZmFsc2UgfTsKICAgICBib29sIG1fZHVtcFNh bXBsaW5nUHJvZmlsZXJEYXRhIHsgZmFsc2UgfTsKKyAgICBib29sIG1fZW5hYmxlUmVtb3RlRGVi dWdnaW5nIHsgZmFsc2UgfTsKIAogICAgIHZvaWQgcGFyc2VBcmd1bWVudHMoaW50LCBjaGFyKiop OwogfTsKQEAgLTI3ODEsNiArMjc4MiwxMSBAQCB2b2lkIENvbW1hbmRMaW5lOjpwYXJzZUFyZ3Vt ZW50cyhpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAg ICAgfQogCisgICAgICAgIGlmICghc3RyY21wKGFyZywgIi0tcmVtb3RlLWRlYnVnIikpIHsKKyAg ICAgICAgICAgIG1fZW5hYmxlUmVtb3RlRGVidWdnaW5nID0gdHJ1ZTsKKyAgICAgICAgICAgIGNv bnRpbnVlOworICAgICAgICB9CisKICAgICAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIHN0cmlj dEZpbGVTdHJMZW5ndGggPSBzdHJsZW4oIi0tc3RyaWN0LWZpbGU9Iik7CiAgICAgICAgIGlmICgh c3RybmNtcChhcmcsICItLXN0cmljdC1maWxlPSIsIHN0cmljdEZpbGVTdHJMZW5ndGgpKSB7CiAg ICAgICAgICAgICBtX3NjcmlwdHMuYXBwZW5kKFNjcmlwdChTY3JpcHQ6OlN0cmljdE1vZGU6OlN0 cmljdCwgU2NyaXB0OjpDb2RlU291cmNlOjpGaWxlLCBTY3JpcHQ6OlNjcmlwdFR5cGU6OlNjcmlw dCwgYXJndltpXSArIHN0cmljdEZpbGVTdHJMZW5ndGgpKTsKQEAgLTI4NDgsNiArMjg1NCw3IEBA IHN0YXRpYyBpbnQgTkVWRVJfSU5MSU5FIHJ1bkpTQyhWTSogdm0sIENvbW1hbmRMaW5lIG9wdGlv bnMpCiAgICAgICAgIHZtLT5tX3BlckJ5dGVjb2RlUHJvZmlsZXIgPSBzdGQ6Om1ha2VfdW5pcXVl PFByb2ZpbGVyOjpEYXRhYmFzZT4oKnZtKTsKIAogICAgIEdsb2JhbE9iamVjdCogZ2xvYmFsT2Jq ZWN0ID0gR2xvYmFsT2JqZWN0OjpjcmVhdGUoKnZtLCBHbG9iYWxPYmplY3Q6OmNyZWF0ZVN0cnVj dHVyZSgqdm0sIGpzTnVsbCgpKSwgb3B0aW9ucy5tX2FyZ3VtZW50cyk7CisgICAgZ2xvYmFsT2Jq ZWN0LT5zZXRSZW1vdGVEZWJ1Z2dpbmdFbmFibGVkKG9wdGlvbnMubV9lbmFibGVSZW1vdGVEZWJ1 Z2dpbmcpOwogICAgIGJvb2wgc3VjY2VzcyA9IHJ1bldpdGhTY3JpcHRzKGdsb2JhbE9iamVjdCwg b3B0aW9ucy5tX3NjcmlwdHMsIG9wdGlvbnMubV91bmNhdWdodEV4Y2VwdGlvbk5hbWUsIG9wdGlv bnMubV9hbHdheXNEdW1wVW5jYXVnaHRFeGNlcHRpb24sIG9wdGlvbnMubV9kdW1wLCBvcHRpb25z Lm1fbW9kdWxlKTsKICAgICBpZiAob3B0aW9ucy5tX2ludGVyYWN0aXZlICYmIHN1Y2Nlc3MpCiAg ICAgICAgIHJ1bkludGVyYWN0aXZlKGdsb2JhbE9iamVjdCk7Cg== 294310 2016-11-09 17:15:46 -0800 2016-11-09 17:20:15 -0800 Patch bug-164569-20161109171135.patch text/plain 3401 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MmU5NTJhM2QyMmY0YWNmZGYxNjgwNmYwODk4YjY2YjNhMzcyYTU2Li5lNWRkYWJlNmM1ZGJlZjky N2YxOGQ1MTUzZDE2MzRkMmMzMTlmNjk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNi0xMS0wOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBqc2MgQ0xJIHNob3VsZCB3b3JrIHdpdGggdGhlIHJlbW90ZSBpbnNw ZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 NDU2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgcGF0Y2ggZW5hYmxlcyB1c2luZyB0aGUgcmVtb3RlIGluc3BlY3RvciBvbiB0aGUganNjIENM SS4KKyAgICAgICAgSW4gb3JkZXIgdG8gdXNlIHRoZSByZW1vdGUgaW5zcGVjdG9yLCBqc2MgdXNl cnMgbmVlZCB0byBwYXNzIGFuIG9wdGlvbi4KKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gcmVt b3ZlcyBhbiBpbnZhbGlkIGFzc2VydGlvbiBpbiB0aGUgaW5zcGVjdG9yLgorCisgICAgICAgICog aW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFzZS5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6Oklu amVjdGVkU2NyaXB0QmFzZTo6bWFrZUNhbGwpOgorICAgICAgICAqIGpzYy5jcHA6CisgICAgICAg IChDb21tYW5kTGluZTo6cGFyc2VBcmd1bWVudHMpOgorICAgICAgICAocnVuSlNDKToKKwogMjAx Ni0xMC0yMCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAg ICBJbnZhbGlkIGFzc2VydGlvbiBpbiBhcmd1bWVudHMgZWxpbWluYXRpb24KZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRCYXNlLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRCYXNlLmNwcApp bmRleCA5Y2FhNGViOTNmZTdmOWUzMjhkZDMyOTkwMjEzOTVjYzMyYTQ5YWQ0Li45YmQwODcwNTc2 OGM4ZjIyNzczMjNlNWZmOGMzMzE5YmJiMjJjZjFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0QmFzZS5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEJhc2UuY3BwCkBAIC04NSw3ICs4 NSw2IEBAIHZvaWQgSW5qZWN0ZWRTY3JpcHRCYXNlOjptYWtlQ2FsbChEZXByZWNhdGVkOjpTY3Jp cHRGdW5jdGlvbkNhbGwmIGZ1bmN0aW9uLCBSZWZQCiAgICAgYm9vbCBoYWRFeGNlcHRpb24gPSBm YWxzZTsKICAgICBhdXRvIHJlc3VsdFZhbHVlID0gY2FsbEZ1bmN0aW9uV2l0aEV2YWxFbmFibGVk KGZ1bmN0aW9uLCBoYWRFeGNlcHRpb24pOwogCi0gICAgQVNTRVJUKCFoYWRFeGNlcHRpb24pOwog ICAgIGlmICghaGFkRXhjZXB0aW9uKSB7CiAgICAgICAgICpyZXN1bHQgPSB0b0luc3BlY3RvclZh bHVlKCptX2luamVjdGVkU2NyaXB0T2JqZWN0LnNjcmlwdFN0YXRlKCksIHJlc3VsdFZhbHVlKTsK ICAgICAgICAgaWYgKCEqcmVzdWx0KQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2pzYy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAppbmRleCBiMTdjMjVmYjIx MTc0NzhiYTQ5Y2ViNjA5YzRiMzJlMDJiOGY4MDNkLi45MGViNzZmM2RjOGQyYTA5ZWI4ZjZkMTM0 N2NhOTVjNGRhODFhMDBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcApAQCAtOTY2LDYgKzk2Niw3IEBA IHB1YmxpYzoKICAgICBTdHJpbmcgbV91bmNhdWdodEV4Y2VwdGlvbk5hbWU7CiAgICAgYm9vbCBt X2Fsd2F5c0R1bXBVbmNhdWdodEV4Y2VwdGlvbiB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2R1bXBT YW1wbGluZ1Byb2ZpbGVyRGF0YSB7IGZhbHNlIH07CisgICAgYm9vbCBtX2VuYWJsZVJlbW90ZURl YnVnZ2luZyB7IGZhbHNlIH07CiAKICAgICB2b2lkIHBhcnNlQXJndW1lbnRzKGludCwgY2hhcioq KTsKIH07CkBAIC0yNzgxLDYgKzI3ODIsMTEgQEAgdm9pZCBDb21tYW5kTGluZTo6cGFyc2VBcmd1 bWVudHMoaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogICAgICAgICAgICAgY29udGludWU7CiAgICAg ICAgIH0KIAorICAgICAgICBpZiAoIXN0cmNtcChhcmcsICItLXJlbW90ZS1kZWJ1ZyIpKSB7Cisg ICAgICAgICAgICBtX2VuYWJsZVJlbW90ZURlYnVnZ2luZyA9IHRydWU7CisgICAgICAgICAgICBj b250aW51ZTsKKyAgICAgICAgfQorCiAgICAgICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBzdHJp Y3RGaWxlU3RyTGVuZ3RoID0gc3RybGVuKCItLXN0cmljdC1maWxlPSIpOwogICAgICAgICBpZiAo IXN0cm5jbXAoYXJnLCAiLS1zdHJpY3QtZmlsZT0iLCBzdHJpY3RGaWxlU3RyTGVuZ3RoKSkgewog ICAgICAgICAgICAgbV9zY3JpcHRzLmFwcGVuZChTY3JpcHQoU2NyaXB0OjpTdHJpY3RNb2RlOjpT dHJpY3QsIFNjcmlwdDo6Q29kZVNvdXJjZTo6RmlsZSwgU2NyaXB0OjpTY3JpcHRUeXBlOjpTY3Jp cHQsIGFyZ3ZbaV0gKyBzdHJpY3RGaWxlU3RyTGVuZ3RoKSk7CkBAIC0yODQ4LDYgKzI4NTQsNyBA QCBzdGF0aWMgaW50IE5FVkVSX0lOTElORSBydW5KU0MoVk0qIHZtLCBDb21tYW5kTGluZSBvcHRp b25zKQogICAgICAgICB2bS0+bV9wZXJCeXRlY29kZVByb2ZpbGVyID0gc3RkOjptYWtlX3VuaXF1 ZTxQcm9maWxlcjo6RGF0YWJhc2U+KCp2bSk7CiAKICAgICBHbG9iYWxPYmplY3QqIGdsb2JhbE9i amVjdCA9IEdsb2JhbE9iamVjdDo6Y3JlYXRlKCp2bSwgR2xvYmFsT2JqZWN0OjpjcmVhdGVTdHJ1 Y3R1cmUoKnZtLCBqc051bGwoKSksIG9wdGlvbnMubV9hcmd1bWVudHMpOworICAgIGdsb2JhbE9i amVjdC0+c2V0UmVtb3RlRGVidWdnaW5nRW5hYmxlZChvcHRpb25zLm1fZW5hYmxlUmVtb3RlRGVi dWdnaW5nKTsKICAgICBib29sIHN1Y2Nlc3MgPSBydW5XaXRoU2NyaXB0cyhnbG9iYWxPYmplY3Qs IG9wdGlvbnMubV9zY3JpcHRzLCBvcHRpb25zLm1fdW5jYXVnaHRFeGNlcHRpb25OYW1lLCBvcHRp b25zLm1fYWx3YXlzRHVtcFVuY2F1Z2h0RXhjZXB0aW9uLCBvcHRpb25zLm1fZHVtcCwgb3B0aW9u cy5tX21vZHVsZSk7CiAgICAgaWYgKG9wdGlvbnMubV9pbnRlcmFjdGl2ZSAmJiBzdWNjZXNzKQog ICAgICAgICBydW5JbnRlcmFjdGl2ZShnbG9iYWxPYmplY3QpOwo=