16454 2007-12-15 12:35:11 -0800 [GTK] Text input doesn't work consistently on PPC 2007-12-16 05:21:27 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Mac (PowerPC) All RESOLVED FIXED Gtk P2 Normal --- 14120 1 alp webkit-unassigned ap oldest_to_newest 64317 0 alp 2007-12-15 12:35:11 -0800 Big endian systems have trouble with keyboard entry in forms etc. 64321 1 17916 alp 2007-12-15 12:52:09 -0800 Created attachment 17916 Fix 64323 2 17916 alp 2007-12-15 13:09:04 -0800 Comment on attachment 17916 Fix Given the implementation does this: memcpy(m_data, str, len * sizeof(UChar)); This patch doesn't look right. Needs further investigation. 64334 3 17918 xan.lopez 2007-12-15 16:22:19 -0800 Created attachment 17918 0001-Fix-keyval-text-translation-for-key-events-on-big-e.patch Subject: [PATCH] Fix keyval->text translation for key events on big endian systems. UChar is UTF-16, not UCS-4, so transform accordingly. --- WebCore/ChangeLog | 15 +++++++++++++++ WebCore/platform/gtk/KeyEventGtk.cpp | 15 +++++++++++++-- 2 files changed, 28 insertions(+), 2 deletions(-) 64357 4 17918 ap 2007-12-16 00:58:09 -0800 Comment on attachment 17918 0001-Fix-keyval-text-translation-for-key-events-on-big-e.patch Per gnome documentation, g_ucs4_to_utf16 signals error by returning NULL - theoretically, nwc may remain uninitialized in this case, so you shouldn't compare it to 1. More importantly, I do not see any reason to truncate the input to "single character" - probably, the function should be renamed, and then you can just handle any length (where any is 1 or 2 :) ). Or you can keep the name, and say that two UTF-16 surrogates are still a single Unicode character. This is a good fix as is, so r=me, but please consider making it even better! 64363 5 17929 xan.lopez 2007-12-16 04:10:37 -0800 Created attachment 17929 0001-Fix-keyval-text-translation-for-key-events-on-big-e.patch Very good points, thanks! I'm checking for uchar16 != NULL and passing nwc to the String constructor now. 64364 6 xan.lopez 2007-12-16 04:13:14 -0800 Oh btw, one more thing. Does it still make sense to keep the function inline? 64365 7 17929 ap 2007-12-16 04:27:51 -0800 Comment on attachment 17929 0001-Fix-keyval-text-translation-for-key-events-on-big-e.patch r=me > Does it still make sense to keep the function inline? Probably not :) 64367 8 alp 2007-12-16 05:21:27 -0800 Landed in r28769 (with tab removed from the ChangeLog and function de-inlined). 17916 2007-12-15 12:52:09 -0800 2007-12-15 16:22:19 -0800 Fix bigendian.patch text/plain 1383 alp SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODc1NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDctMTItMTUgIEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDU0CisgICAgICAgIFtHVEtdIFRleHQg aW5wdXQgZG9lc24ndCB3b3JrIGNvbnNpc3RlbnRseSBvbiBQUEMKKworICAgICAgICBQYXNzIHRo ZSByZWFsIHNpemUgb2YgdGhlIFVuaWNvZGUgY2hhcmFjdGVyIHdoZW4gaW5pdGlhbGl6aW5nIHRo ZQorICAgICAgICBTdHJpbmcgZm9yIGEga2V5IGV2ZW50IHJhdGhlciB0aGFuIDEgYnl0ZS4gVGhp cyBvZnRlbiB3b3JrZWQgb24KKyAgICAgICAgbGl0dGxlLWVuZGlhbiBzeXN0ZW1zIGJlY2F1c2Ug dGhlIHNpZ25pZmljYW50IGRhdGEgd2FzIGF0IHRoZSBzdGFydCwKKyAgICAgICAgd2hlcmVhcyBv biBiaWctZW5kaWFuIHN5c3RlbXMgdGhpcyBieXRlIGlzIHR5cGljYWxseSBudWxsLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNp bmdsZUNoYXJhY3RlclN0cmluZyk6CisKIDIwMDctMTItMTUgIEVyaWMgU2VpZGVsICA8ZXJpY0B3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlci4KSW5kZXg6IFdlYkNvcmUv cGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRm b3JtL2d0ay9LZXlFdmVudEd0ay5jcHAJKHJldmlzaW9uIDI4NzU1KQorKysgV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzAsNyArNDcwLDcg QEAgc3RhdGljIGludCB3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KHVucwogc3RhdGljIGlubGlu ZSBTdHJpbmcgc2luZ2xlQ2hhcmFjdGVyU3RyaW5nKGd1aW50IHZhbCkKIHsKICAgICB2YWwgPSBn ZGtfa2V5dmFsX3RvX3VuaWNvZGUodmFsKTsKLSAgICByZXR1cm4gU3RyaW5nKChVQ2hhciopJnZh bCwgMSk7CisgICAgcmV0dXJuIFN0cmluZygoVUNoYXIqKSZ2YWwsIHNpemVvZihndWludDMyKSk7 CiB9CiAKIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6UGxhdGZvcm1LZXlib2FyZEV2ZW50KEdka0V2 ZW50S2V5KiBldmVudCkK 17918 2007-12-15 16:22:19 -0800 2007-12-16 04:10:37 -0800 0001-Fix-keyval-text-translation-for-key-events-on-big-e.patch 0001-Fix-keyval-text-translation-for-key-events-on-big-e.patch text/plain 1925 xan.lopez RnJvbSAyMGVmNDM0NzJkYzdkN2Y0YTk4MjEyZWJjZGYzNGE0ZWY0Y2FmMWFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IFN1biwg MTYgRGVjIDIwMDcgMDI6MTk6MzQgKzAyMDAKU3ViamVjdDogW1BBVENIXSBGaXgga2V5dmFsLT50 ZXh0IHRyYW5zbGF0aW9uIGZvciBrZXkgZXZlbnRzIG9uIGJpZyBlbmRpYW4gc3lzdGVtcy4KClVD aGFyIGlzIFVURi0xNiwgbm90IFVDUy00LCBzbyB0cmFuc2Zvcm0gYWNjb3JkaW5nbHkuCi0tLQog V2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysr KysKIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcCB8ICAgMTUgKysrKysrKysr KysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBlNTYyZTYwLi45ZDE2YmMxIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDA3LTEyLTE1ICBYYW4gTG9wZXog IDx4YW5AZ25vbWUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdBUk5JTkc6IE5PIFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisJaHR0 cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0NTQKKwlbR1RLXSBUZXh0IGlu cHV0IGRvZXNuJ3Qgd29yayBjb25zaXN0ZW50bHkgb24gUFBDCisJCisgICAgICAgICogcGxhdGZv cm0vZ3RrL0tleUV2ZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNpbmdsZUNoYXJhY3Rl clN0cmluZyk6CisKKwlVQ2hhciBpcyAyIGJ5dGVzIChVVEYtMTYpLCBzbyB0cmFuc2Zvcm0gYWNj b3JkaW5nbHkgZnJvbQorCWd1bmljaGFyIChVQ1MtNCkuIEZpeGVzIGZvcm0gaW5wdXQgb24gYmln IGVuZGlhbiBzeXN0ZW1zLgorCiAyMDA3LTEyLTE1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3Rr L0tleUV2ZW50R3RrLmNwcAppbmRleCAwMDFkYTU1Li4xYjIyNmMzIDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvS2V5RXZlbnRHdGsuY3BwCkBAIC00NjksOCArNDY5LDE5IEBAIHN0YXRpYyBpbnQgd2luZG93 c0tleUNvZGVGb3JLZXlFdmVudCh1bnNpZ25lZCBpbnQga2V5Y29kZSkKIAogc3RhdGljIGlubGlu ZSBTdHJpbmcgc2luZ2xlQ2hhcmFjdGVyU3RyaW5nKGd1aW50IHZhbCkKIHsKLSAgICB2YWwgPSBn ZGtfa2V5dmFsX3RvX3VuaWNvZGUodmFsKTsKLSAgICByZXR1cm4gU3RyaW5nKChVQ2hhciopJnZh bCwgMSk7CisgICAgZ2xvbmcgbndjOworICAgIFN0cmluZyByZXRWYWw7CisgICAgZ3VuaWNoYXIg YyA9IGdka19rZXl2YWxfdG9fdW5pY29kZSh2YWwpOworICAgIGd1bmljaGFyMiAqdWNoYXIxNiA9 IGdfdWNzNF90b191dGYxNigmYywgMSwgMCwgJm53YywgMCk7CisKKyAgICBpZiAobndjID09IDEp CisgICAgICAgIHJldFZhbCA9IFN0cmluZygoVUNoYXIqKXVjaGFyMTYsIDEpOworICAgIGVsc2UK KyAgICAgICAgcmV0VmFsID0gU3RyaW5nKCk7CisKKyAgICBnX2ZyZWUodWNoYXIxNik7CisKKyAg ICByZXR1cm4gcmV0VmFsOwogfQogCiBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OlBsYXRmb3JtS2V5 Ym9hcmRFdmVudChHZGtFdmVudEtleSogZXZlbnQpCi0tIAoxLjUuMy40Cgo= 17929 2007-12-16 04:10:37 -0800 2007-12-16 04:27:51 -0800 0001-Fix-keyval-text-translation-for-key-events-on-big-e.patch 0001-Fix-keyval-text-translation-for-key-events-on-big-e.patch text/plain 1952 xan.lopez RnJvbSA0ODI4MWY4NzRmM2YwMTI3ZGRhZTBkZjEwYzkwZDMxNmE1NTYyM2ViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IFN1biwg MTYgRGVjIDIwMDcgMTQ6MDg6NDkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBGaXgga2V5dmFsLT50 ZXh0IHRyYW5zbGF0aW9uIGZvciBrZXkgZXZlbnRzIG9uIGJpZyBlbmRpYW4gc3lzdGVtcy4KClVD aGFyIGlzIFVURi0xNiwgbm90IFVDUy00LCBzbyB0cmFuc2Zvcm0gYWNjb3JkaW5nbHkuCi0tLQog V2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysr KysKIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcCB8ICAgMTUgKysrKysrKysr KysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCA2MjE3MTdjLi4xODk3N2NiIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDA3LTEyLTE2ICBYYW4gTG9wZXog IDx4YW5AZ25vbWUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdBUk5JTkc6IE5PIFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisgICAg ICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDU0CisgICAgICAg IFtHVEtdIFRleHQgaW5wdXQgZG9lc24ndCB3b3JrIGNvbnNpc3RlbnRseSBvbiBQUEMKKwkKKyAg ICAgICAgKiBwbGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 c2luZ2xlQ2hhcmFjdGVyU3RyaW5nKToKKworICAgICAgICBVQ2hhciBpcyAyIGJ5dGVzIChVVEYt MTYpLCBzbyB0cmFuc2Zvcm0gYWNjb3JkaW5nbHkgZnJvbQorICAgICAgICBndW5pY2hhciAoVUNT LTQpLiBGaXhlcyBmb3JtIGlucHV0IG9uIGJpZyBlbmRpYW4gc3lzdGVtcy4KKwogMjAwNy0xMi0x NSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg TWFyayBSb3dlLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsu Y3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwCmluZGV4IDAwMWRhNTUu LmMyNWQyMDggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHAKQEAgLTQ2OSw4ICs0 NjksMTkgQEAgc3RhdGljIGludCB3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KHVuc2lnbmVkIGlu dCBrZXljb2RlKQogCiBzdGF0aWMgaW5saW5lIFN0cmluZyBzaW5nbGVDaGFyYWN0ZXJTdHJpbmco Z3VpbnQgdmFsKQogewotICAgIHZhbCA9IGdka19rZXl2YWxfdG9fdW5pY29kZSh2YWwpOwotICAg IHJldHVybiBTdHJpbmcoKFVDaGFyKikmdmFsLCAxKTsKKyAgICBnbG9uZyBud2M7CisgICAgU3Ry aW5nIHJldFZhbDsKKyAgICBndW5pY2hhciBjID0gZ2RrX2tleXZhbF90b191bmljb2RlKHZhbCk7 CisgICAgZ3VuaWNoYXIyICp1Y2hhcjE2ID0gZ191Y3M0X3RvX3V0ZjE2KCZjLCAxLCAwLCAmbndj LCAwKTsKKworICAgIGlmICh1Y2hhcjE2KQorICAgICAgICByZXRWYWwgPSBTdHJpbmcoKFVDaGFy Kil1Y2hhcjE2LCBud2MpOworICAgIGVsc2UKKyAgICAgICAgcmV0VmFsID0gU3RyaW5nKCk7CisK KyAgICBnX2ZyZWUodWNoYXIxNik7CisKKyAgICByZXR1cm4gcmV0VmFsOwogfQogCiBQbGF0Zm9y bUtleWJvYXJkRXZlbnQ6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudChHZGtFdmVudEtleSogZXZlbnQp Ci0tIAoxLjUuMy40Cgo=