164514 2016-11-08 08:44:52 -0800 REGRESSION (r208149): Media scrubber is not displayed in media controls 2016-11-09 12:21:50 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue darin webkit-bug-importer oldest_to_newest 1249042 0 jer.noble 2016-11-08 08:44:52 -0800 REGRESSION (r208149): Media scrubber is not displayed in media controls 1249043 1 jer.noble 2016-11-08 08:48:16 -0800 rdar://problem/29098431 1249047 2 294162 jer.noble 2016-11-08 08:58:32 -0800 Created attachment 294162 Patch 1249053 3 294162 darin 2016-11-08 09:10:01 -0800 Comment on attachment 294162 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294162&action=review > Source/WebCore/html/MediaElementSession.h:174 > -static bool isType(const WebCore::PlatformMediaSession& session) { return session.mediaType() == WebCore::PlatformMediaSession::Video || session.mediaType() == WebCore::PlatformMediaSession::Audio; } > +static bool isType(const WebCore::PlatformMediaSession& session) > +{ > + return session.mediaType() == WebCore::PlatformMediaSession::Video > + || session.mediaType() == WebCore::PlatformMediaSession::Audio > + || session.mediaType() == WebCore::PlatformMediaSession::VideoAudio; > +} Normally we’d like these isType functions to stay as tiny one-liners. Maybe we can make an inline helper for this to call? I think it might be nicer to use switch for this rather than a return statement. 1249054 4 darin 2016-11-08 09:10:27 -0800 Why no regression test? 1249087 5 jer.noble 2016-11-08 11:29:09 -0800 (In reply to comment #4) > Why no regression test? The patch should have mentioned that this fixes a number of broken TestWebKitAPI tests. 1249088 6 jer.noble 2016-11-08 11:41:32 -0800 (In reply to comment #3) > Comment on attachment 294162 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=294162&action=review > > > Source/WebCore/html/MediaElementSession.h:174 > > -static bool isType(const WebCore::PlatformMediaSession& session) { return session.mediaType() == WebCore::PlatformMediaSession::Video || session.mediaType() == WebCore::PlatformMediaSession::Audio; } > > +static bool isType(const WebCore::PlatformMediaSession& session) > > +{ > > + return session.mediaType() == WebCore::PlatformMediaSession::Video > > + || session.mediaType() == WebCore::PlatformMediaSession::Audio > > + || session.mediaType() == WebCore::PlatformMediaSession::VideoAudio; > > +} > > Normally we’d like these isType functions to stay as tiny one-liners. Maybe > we can make an inline helper for this to call? > > I think it might be nicer to use switch for this rather than a return > statement. I'm imagining some template method like: template<typename T> bool isIn(T value, initializer_list<T> candidates) { for (auto& candidate : candidates) { if (value == candidate) return true; } return false; } Then, the isType() implementation looks like: return isIn(session.mediaType(), { WebCore::PlatformMediaSession::Video, WebCore::PlatformMediaSession::Audio, WebCore::PlatformMediaSession::VideoAudio}); 1249117 7 294179 jer.noble 2016-11-08 13:25:51 -0800 Created attachment 294179 Patch for landing 1249419 8 294179 commit-queue 2016-11-09 12:21:50 -0800 Comment on attachment 294179 Patch for landing Clearing flags on attachment: 294179 Committed r208464: <http://trac.webkit.org/changeset/208464> 294162 2016-11-08 08:58:32 -0800 2016-11-08 09:10:01 -0800 Patch bug-164514-20161108085423.patch text/plain 1777 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTJhN2U1ZThiYmVkYWNh NDVmMmZjOGMwYzJkZjJkNTc5M2NiZDhiNC4uNTM1M2Q1ZjY2YWNhZjQ2NTZjNTFhNWM4YTgwNzNh ODhlODUxZmI1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTExLTA4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMDgx NDkpOiBNZWRpYSBzY3J1YmJlciBpcyBub3QgZGlzcGxheWVkIGluIG1lZGlhIGNvbnRyb2xzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ1MTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIG5l dyBQbGF0Zm9ybU1lZGlhU2Vzc2lvblR5cGU7IG5lZWQgdG8gYWRkIHRoYXQgc2FtZSB0eXBlIHRv IHRoZSBUWVBFX1RSQUlUUyBzZWN0aW9uIG9mIAorICAgICAgICBNZWRpYUVsZW1lbnRTZXNzaW9u Lmggc28gdGhhdCBpczw+IGFuZCBkb3duY2FzdDw+IHdvcmsgY29ycmVjdGx5LgorCisgICAgICAg ICogaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmg6CisgICAgICAgIChpc1R5cGUpOgorCiAyMDE2 LTEwLTI4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIE9wdC1v dXQgb2YgQVZQbGF5ZXIgYXV0b21hdGljIHNsZWVwIGRpc2FibGluZwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9NZWRpYUVsZW1lbnRTZXNzaW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL01lZGlhRWxlbWVudFNlc3Npb24uaAppbmRleCAzMGUwY2ZhMzM3NjExZmQ2YmY2OTg4ODFi YWE4YmI5NGE2NDNmZTdhLi4xMWI2MzcxN2QxMmI2YzUxZDRjYzYwNGY5ODI0OWI0YWU5ZWE2OWRl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uaApAQCAtMTY2LDcg KzE2NiwxMiBAQCBwcml2YXRlOgogfQogCiBTUEVDSUFMSVpFX1RZUEVfVFJBSVRTX0JFR0lOKFdl YkNvcmU6Ok1lZGlhRWxlbWVudFNlc3Npb24pCi1zdGF0aWMgYm9vbCBpc1R5cGUoY29uc3QgV2Vi Q29yZTo6UGxhdGZvcm1NZWRpYVNlc3Npb24mIHNlc3Npb24pIHsgcmV0dXJuIHNlc3Npb24ubWVk aWFUeXBlKCkgPT0gV2ViQ29yZTo6UGxhdGZvcm1NZWRpYVNlc3Npb246OlZpZGVvIHx8IHNlc3Np b24ubWVkaWFUeXBlKCkgPT0gV2ViQ29yZTo6UGxhdGZvcm1NZWRpYVNlc3Npb246OkF1ZGlvOyB9 CitzdGF0aWMgYm9vbCBpc1R5cGUoY29uc3QgV2ViQ29yZTo6UGxhdGZvcm1NZWRpYVNlc3Npb24m IHNlc3Npb24pCit7CisgICAgcmV0dXJuIHNlc3Npb24ubWVkaWFUeXBlKCkgPT0gV2ViQ29yZTo6 UGxhdGZvcm1NZWRpYVNlc3Npb246OlZpZGVvCisgICAgICAgIHx8IHNlc3Npb24ubWVkaWFUeXBl KCkgPT0gV2ViQ29yZTo6UGxhdGZvcm1NZWRpYVNlc3Npb246OkF1ZGlvCisgICAgICAgIHx8IHNl c3Npb24ubWVkaWFUeXBlKCkgPT0gV2ViQ29yZTo6UGxhdGZvcm1NZWRpYVNlc3Npb246OlZpZGVv QXVkaW87Cit9CiBTUEVDSUFMSVpFX1RZUEVfVFJBSVRTX0VORCgpCiAKICNlbmRpZiAvLyBFTkFC TEUoVklERU8pCg== 294179 2016-11-08 13:25:51 -0800 2016-11-09 12:21:50 -0800 Patch for landing bug-164514-20161108132141.patch text/plain 2070 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTJhN2U1ZThiYmVkYWNh NDVmMmZjOGMwYzJkZjJkNTc5M2NiZDhiNC4uMWQwYzI1MTY5NGJhMGYwYTA0YmRhNjhlNTYyNTI2 Y2FmOThhMWJmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTExLTA4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMDgx NDkpOiBNZWRpYSBzY3J1YmJlciBpcyBub3QgZGlzcGxheWVkIGluIG1lZGlhIGNvbnRyb2xzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ1MTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBGaXhlcyBicm9rZW4g TWVkaWEgQ29udHJvbHMgQVBJIHRlc3RzLgorCisgICAgICAgIEFkZGVkIGEgbmV3IFBsYXRmb3Jt TWVkaWFTZXNzaW9uVHlwZTsgbmVlZCB0byBhZGQgdGhhdCBzYW1lIHR5cGUgdG8gdGhlIFRZUEVf VFJBSVRTIHNlY3Rpb24gb2YgCisgICAgICAgIE1lZGlhRWxlbWVudFNlc3Npb24uaCBzbyB0aGF0 IGlzPD4gYW5kIGRvd25jYXN0PD4gd29yayBjb3JyZWN0bHkuCisKKyAgICAgICAgKiBodG1sL01l ZGlhRWxlbWVudFNlc3Npb24uaDoKKyAgICAgICAgKGlzVHlwZSk6CisKIDIwMTYtMTAtMjggIEpl ciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgT3B0LW91dCBvZiBBVlBs YXllciBhdXRvbWF0aWMgc2xlZXAgZGlzYWJsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFF bGVtZW50U2Vzc2lvbi5oCmluZGV4IDMwZTBjZmEzMzc2MTFmZDZiZjY5ODg4MWJhYThiYjk0YTY0 M2ZlN2EuLmE1MzI3MGY5ODdiYmU0MmM1NzE3MzczZDE1OWVjY2ZhODQ4YmEyOGQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5oCkBAIC0xMjgsNiArMTI4LDEzIEBA IHB1YmxpYzoKICAgICBib29sIGFsbG93c1BsYXliYWNrQ29udHJvbHNGb3JBdXRvcGxheWluZ0F1 ZGlvKCkgY29uc3Q7CiAgICAgYm9vbCBhbGxvd3NOb3dQbGF5aW5nQ29udHJvbHNWaXNpYmlsaXR5 KCkgY29uc3Qgb3ZlcnJpZGU7CiAKKyAgICBzdGF0aWMgYm9vbCBpc01lZGlhRWxlbWVudFNlc3Np b25NZWRpYVR5cGUoTWVkaWFUeXBlIHR5cGUpCisgICAgeworICAgICAgICByZXR1cm4gdHlwZSA9 PSBWaWRlbworICAgICAgICAgICAgfHwgdHlwZSA9PSBBdWRpbworICAgICAgICAgICAgfHwgdHlw ZSA9PSBWaWRlb0F1ZGlvOworICAgIH0KKwogcHJpdmF0ZToKIAogI2lmIEVOQUJMRShXSVJFTEVT U19QTEFZQkFDS19UQVJHRVQpCkBAIC0xNjYsNyArMTczLDcgQEAgcHJpdmF0ZToKIH0KIAogU1BF Q0lBTElaRV9UWVBFX1RSQUlUU19CRUdJTihXZWJDb3JlOjpNZWRpYUVsZW1lbnRTZXNzaW9uKQot c3RhdGljIGJvb2wgaXNUeXBlKGNvbnN0IFdlYkNvcmU6OlBsYXRmb3JtTWVkaWFTZXNzaW9uJiBz ZXNzaW9uKSB7IHJldHVybiBzZXNzaW9uLm1lZGlhVHlwZSgpID09IFdlYkNvcmU6OlBsYXRmb3Jt TWVkaWFTZXNzaW9uOjpWaWRlbyB8fCBzZXNzaW9uLm1lZGlhVHlwZSgpID09IFdlYkNvcmU6OlBs YXRmb3JtTWVkaWFTZXNzaW9uOjpBdWRpbzsgfQorc3RhdGljIGJvb2wgaXNUeXBlKGNvbnN0IFdl YkNvcmU6OlBsYXRmb3JtTWVkaWFTZXNzaW9uJiBzZXNzaW9uKSB7IHJldHVybiBXZWJDb3JlOjpN ZWRpYUVsZW1lbnRTZXNzaW9uOjppc01lZGlhRWxlbWVudFNlc3Npb25NZWRpYVR5cGUoc2Vzc2lv bi5tZWRpYVR5cGUoKSk7IH0KIFNQRUNJQUxJWkVfVFlQRV9UUkFJVFNfRU5EKCkKIAogI2VuZGlm IC8vIEVOQUJMRShWSURFTykK