<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>164510</bug_id>
          
          <creation_ts>2016-11-08 02:43:12 -0800</creation_ts>
          <short_desc>text-combine-upright should ignore forced line breaks</short_desc>
          <delta_ts>2023-05-22 09:10:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>Safari 10</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>FromImplementor, InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>150821</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Koji Ishii">kojii</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ahmad.saleem792</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>ntim</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1249016</commentid>
    <comment_count>0</comment_count>
    <who name="Koji Ishii">kojii</who>
    <bug_when>2016-11-08 02:43:12 -0800</bug_when>
    <thetext>The spec 9.1.2. Layout Rules defines &quot;ignoring ... any forced line breaks&quot;.
https://drafts.csswg.org/css-writing-modes-3/#text-combine-layout

STEPS:
1. Open http://test.csswg.org/harness/test/css-writing-modes-3_dev/single/text-combine-upright-break-inside-001a/format/html5/

EXPECTED:
Test should render the same as &quot;Reference Page&quot; tab.

Note that since the test does not have prefix, you will need to add one, or use bookmarklets &lt;http://kojiishi.github.io/tweak-css-tests/&gt; to reproduce.

chrome bug: http://crbug.com/663308</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1249327</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2016-11-09 10:34:44 -0800</bug_when>
    <thetext>&lt;rdar://problem/29181797&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1907619</commentid>
    <comment_count>2</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2022-10-23 00:41:01 -0700</bug_when>
    <thetext>*** Bug 234761 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1907620</commentid>
    <comment_count>3</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2022-10-23 00:42:00 -0700</bug_when>
    <thetext>imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-break-inside-001.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-break-inside-001a.html [ ImageOnlyFailure ]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1956951</commentid>
    <comment_count>4</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-05-22 08:15:33 -0700</bug_when>
    <thetext>(In reply to Tim Nguyen (:ntim) from comment #3)
&gt; imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-
&gt; break-inside-001.html [ ImageOnlyFailure ]
&gt; imported/w3c/web-platform-tests/css/css-writing-modes/text-combine-upright-
&gt; break-inside-001a.html [ ImageOnlyFailure ]

We are passing these tests on STP170.

https://wpt.fyi/results/css/css-writing-modes?label=master&amp;label=experimental&amp;aligned&amp;q=text-combine-upright-break-inside

^ Do we need to do anything else? I think we can mark this as fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1956957</commentid>
    <comment_count>5</comment_count>
    <who name="Tim Nguyen (:ntim)">ntim</who>
    <bug_when>2023-05-22 08:44:39 -0700</bug_when>
    <thetext>Looks like this was fixed by some IFC change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1956967</commentid>
    <comment_count>6</comment_count>
    <who name="alan">zalan</who>
    <bug_when>2023-05-22 09:10:45 -0700</bug_when>
    <thetext>(In reply to Tim Nguyen (:ntim) from comment #5)
&gt; Looks like this was fixed by some IFC change.
Correct, these have progressed at 257036@main when text-combine content got enabled for IFC (tagging with IFC progression).</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>