164484 2016-11-07 09:46:48 -0800 preprocessor.pm: Use shellwords() instead of splitting preprocessor command by space 2016-11-08 02:43:33 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 annulen annulen cdumez commit-queue fujii lforschler oldest_to_newest 1248769 0 annulen 2016-11-07 09:46:48 -0800 Now any quoted or escaped command line arguments can be passed in --preprocessor value independently of OS. 1248771 1 annulen 2016-11-07 09:48:37 -0800 In particular, this is needed to compile with MinGW, because preprocessor.pm does not apply split() on Windows. 1248772 2 294066 annulen 2016-11-07 09:49:52 -0800 Created attachment 294066 Patch 1248785 3 294069 annulen 2016-11-07 10:41:08 -0800 Created attachment 294069 Patch 1248803 4 annulen 2016-11-07 11:57:16 -0800 MinGW works fine after r207412 without this patch, and it doesn't build in EWS 1249017 5 annulen 2016-11-08 02:43:33 -0800 It would be great if we used shellwords everywhere instead of splitting by space for parsing command line tokens, but not this time. 294066 2016-11-07 09:49:52 -0800 2016-11-07 10:41:01 -0800 Patch bug-164484-20161107204544.patch text/plain 2131 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGNlZWRjNmEwNmNhMjAx ZGM2MTZkZGU3OTczZTExNTcxODNhYWY2Ni4uZWNkZjQ1ZTM0NmQ0NWI0MWYyOWQwNTg3NjcyNWVm MmMxOWU4MGYzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTExLTA3ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBwcmVwcm9jZXNz b3IucG06IFVzZSBzaGVsbHdvcmRzKCkgaW5zdGVhZCBvZiBzcGxpdHRpbmcgcHJlcHJvY2Vzc29y IGNvbW1hbmQgYnkgc3BhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2NDQ4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vdyBhbnkgcXVvdGVkIG9yIGVzY2FwZWQgY29tbWFuZCBsaW5lIGFyZ3VtZW50 cyBtYXkgYmUgcGFzc2VkIGluCisgICAgICAgIC0tcHJlcHJvY2Vzc29yIHZhbHVlIGluZGVwZW5k ZW50bHkgb2YgT1MuCisKKyAgICAgICAgSW4gcGFydGljdWxhciwgdGhpcyBpcyBuZWVkZWQgdG8g Y29tcGlsZSB3aXRoIE1pbkdXLCBiZWNhdXNlCisgICAgICAgIHByZXByb2Nlc3Nvci5wbSBkb2Vz IG5vdCBhcHBseSBzcGxpdCgpIG9uIFdpbmRvd3MuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5l ZWRlZC4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzc29yLnBtOgorICAg ICAgICAoYXBwbHlQcmVwcm9jZXNzb3IpOgorCiAyMDE2LTExLTA3ICBSeWFuIEhhZGRhZCAgPHJ5 YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIy MDgzODIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3ByZXBy b2Nlc3Nvci5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzc29y LnBtCmluZGV4IDIzMjFkNTE5MWEwYTdiYTE4NzY0MzU5NGE0NDlhYzRjZThhMjlhYjMuLjVkOTM3 NmQ2NWNjNjg0MmEyMGIzNThhNGIyN2U3MTg4YThjODE5NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzc29yLnBtCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzc29yLnBtCkBAIC0yNCw2ICsyNCw3IEBAIHVz ZSB3YXJuaW5nczsKIHVzZSBDb25maWc7CiB1c2UgSVBDOjpPcGVuMjsKIHVzZSBJUEM6Ok9wZW4z OwordXNlIFRleHQ6OlBhcnNlV29yZHM7CiAKIEJFR0lOIHsKICAgIHVzZSBFeHBvcnRlciAgICgp OwpAQCAtNTksNiArNjAsOSBAQCBzdWIgYXBwbHlQcmVwcm9jZXNzb3IKICAgICAgICAgfSBlbHNl IHsKICAgICAgICAgICAgIHB1c2goQGFyZ3MsIHF3KC1FIC1QIC14IGMrKykpOwogICAgICAgICB9 CisgICAgfSBlbHNlIHsKKyAgICAgICAgQGFyZ3MgPSBzaGVsbHdvcmRzKCRwcmVwcm9jZXNzb3Ip OworICAgICAgICAkcHJlcHJvY2Vzc29yID0gc2hpZnQgQGFyZ3M7CiAgICAgfQogCiAgICAgaWYg KCRDb25maWc6OkNvbmZpZ3sib3NuYW1lIn0gZXEgImRhcndpbiIpIHsKQEAgLTEwNCw3ICsxMDgs NyBAQCBzdWIgYXBwbHlQcmVwcm9jZXNzb3IKICAgICAgICAgdXNlIFN5bWJvbCAnZ2Vuc3ltJzsg bXkgJGVyciA9IGdlbnN5bTsKICAgICAgICAgJHBpZCA9IG9wZW4zKFwqUFBfSU4sIFwqUFBfT1VU LCAkZXJyLCAkcHJlcHJvY2Vzc29yLCBAYXJncywgQG1hY3JvcywgJGZpbGVOYW1lKTsKICAgICB9 IGVsc2UgewotICAgICAgICAkcGlkID0gb3BlbjIoXCpQUF9PVVQsIFwqUFBfSU4sIHNwbGl0KCcg JywgJHByZXByb2Nlc3NvciksIEBhcmdzLCBAbWFjcm9zLCAkZmlsZU5hbWUpOworICAgICAgICAk cGlkID0gb3BlbjIoXCpQUF9PVVQsIFwqUFBfSU4sICRwcmVwcm9jZXNzb3IsIEBhcmdzLCBAbWFj cm9zLCAkZmlsZU5hbWUpOwogICAgIH0KICAgICBjbG9zZSBQUF9JTjsKICAgICBteSBAZG9jdW1l bnRDb250ZW50ID0gPFBQX09VVD47Cg== 294069 2016-11-07 10:41:08 -0800 2016-11-07 10:41:08 -0800 Patch bug-164484-20161107213700.patch text/plain 2270 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGNlZWRjNmEwNmNhMjAx ZGM2MTZkZGU3OTczZTExNTcxODNhYWY2Ni4uZWNkZjQ1ZTM0NmQ0NWI0MWYyOWQwNTg3NjcyNWVm MmMxOWU4MGYzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTExLTA3ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBwcmVwcm9jZXNz b3IucG06IFVzZSBzaGVsbHdvcmRzKCkgaW5zdGVhZCBvZiBzcGxpdHRpbmcgcHJlcHJvY2Vzc29y IGNvbW1hbmQgYnkgc3BhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2NDQ4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5vdyBhbnkgcXVvdGVkIG9yIGVzY2FwZWQgY29tbWFuZCBsaW5lIGFyZ3VtZW50 cyBtYXkgYmUgcGFzc2VkIGluCisgICAgICAgIC0tcHJlcHJvY2Vzc29yIHZhbHVlIGluZGVwZW5k ZW50bHkgb2YgT1MuCisKKyAgICAgICAgSW4gcGFydGljdWxhciwgdGhpcyBpcyBuZWVkZWQgdG8g Y29tcGlsZSB3aXRoIE1pbkdXLCBiZWNhdXNlCisgICAgICAgIHByZXByb2Nlc3Nvci5wbSBkb2Vz IG5vdCBhcHBseSBzcGxpdCgpIG9uIFdpbmRvd3MuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5l ZWRlZC4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzc29yLnBtOgorICAg ICAgICAoYXBwbHlQcmVwcm9jZXNzb3IpOgorCiAyMDE2LTExLTA3ICBSeWFuIEhhZGRhZCAgPHJ5 YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIy MDgzODIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3ByZXBy b2Nlc3Nvci5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzc29y LnBtCmluZGV4IDIzMjFkNTE5MWEwYTdiYTE4NzY0MzU5NGE0NDlhYzRjZThhMjlhYjMuLmRmZTdi ZjQzZjNhOWExZTNjZjlmYTIxOGQyOTZmMjc5ODBhODAwNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzc29yLnBtCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzc29yLnBtCkBAIC0yNCw2ICsyNCw3IEBAIHVz ZSB3YXJuaW5nczsKIHVzZSBDb25maWc7CiB1c2UgSVBDOjpPcGVuMjsKIHVzZSBJUEM6Ok9wZW4z OwordXNlIFRleHQ6OlBhcnNlV29yZHM7CiAKIEJFR0lOIHsKICAgIHVzZSBFeHBvcnRlciAgICgp OwpAQCAtNTksNiArNjAsMTEgQEAgc3ViIGFwcGx5UHJlcHJvY2Vzc29yCiAgICAgICAgIH0gZWxz ZSB7CiAgICAgICAgICAgICBwdXNoKEBhcmdzLCBxdygtRSAtUCAteCBjKyspKTsKICAgICAgICAg fQorICAgIH0gZWxzZSB7CisgICAgICAgIHByaW50IFNUREVSUiAicHJlcHJvY2Vzc29yPSckcHJl cHJvY2Vzc29yJyBhcmdzPSdAYXJncydcbiI7CisgICAgICAgIEBhcmdzID0gc2hlbGx3b3Jkcygk cHJlcHJvY2Vzc29yKTsKKyAgICAgICAgJHByZXByb2Nlc3NvciA9IHNoaWZ0IEBhcmdzOworICAg ICAgICBwcmludCBTVERFUlIgInByZXByb2Nlc3Nvcj0nJHByZXByb2Nlc3NvcicgYXJncz0nQGFy Z3MnXG4iOwogICAgIH0KIAogICAgIGlmICgkQ29uZmlnOjpDb25maWd7Im9zbmFtZSJ9IGVxICJk YXJ3aW4iKSB7CkBAIC0xMDQsNyArMTEwLDcgQEAgc3ViIGFwcGx5UHJlcHJvY2Vzc29yCiAgICAg ICAgIHVzZSBTeW1ib2wgJ2dlbnN5bSc7IG15ICRlcnIgPSBnZW5zeW07CiAgICAgICAgICRwaWQg PSBvcGVuMyhcKlBQX0lOLCBcKlBQX09VVCwgJGVyciwgJHByZXByb2Nlc3NvciwgQGFyZ3MsIEBt YWNyb3MsICRmaWxlTmFtZSk7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgJHBpZCA9IG9wZW4yKFwq UFBfT1VULCBcKlBQX0lOLCBzcGxpdCgnICcsICRwcmVwcm9jZXNzb3IpLCBAYXJncywgQG1hY3Jv cywgJGZpbGVOYW1lKTsKKyAgICAgICAgJHBpZCA9IG9wZW4yKFwqUFBfT1VULCBcKlBQX0lOLCAk cHJlcHJvY2Vzc29yLCBAYXJncywgQG1hY3JvcywgJGZpbGVOYW1lKTsKICAgICB9CiAgICAgY2xv c2UgUFBfSU47CiAgICAgbXkgQGRvY3VtZW50Q29udGVudCA9IDxQUF9PVVQ+Owo=